| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CL being reverted:
This patch lets the browser window punch a hole in the DesktopBackgroundView,
thus eliminating overdraw.
To do this, the hole punching logic was changed to look at the entire tree.
Drawing the screen is a preorder traversal through all the layers. Thus, to
compute the hole, we have to look at all of the layers after a particular layer
in the preorder traversal.
This is not an efficient algorithm, but it is simplest I could come up with.
Plus we will be moving to the WebKit compositor soon.
Hopefully this will improve the frame rate for the Aura demos
Note: I will put the changes to Transform into another patch.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107360
Review URL: http://codereview.chromium.org/8368013
TBR=pkotwicz@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8372048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8362006/
BUG=101595
TEST=None
Review URL: http://codereview.chromium.org/8395046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce dependencies amongst DCLM, ShowStateC, WorkspaceC and such.
I changed my mind and kept "WorkspaceController owns WorkspaceManager" as this seems to be better in long run. I decoupled DCLM from ShowStateC and WorkspaceC. I moved a layout_in_progress flag to WorkspaceManager as it really belongs there, and can reduce dependency.
BUG=84070
TEST=new test conditions for workspace observer are added to workspace_manager_unittests
Review URL: http://codereview.chromium.org/8430024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.
TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.
Review URL: http://codereview.chromium.org/8439015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, window is now correctly maximized/fullscreen'ed on aura desktop.
* Added OnPropertyChanged to WindowObserver
* Added Get/Set IntProperty to simplify handling int value properties.
* Remove IsOrContainsFullscreen. Added Workspace::ContainsFullscreen instead. We need this to autohide launcher.
BUG=97257,97259
TEST=new test for property change notification. existing tests are updated, except maximized/fullscreen drag test. I'll add it to new set of tests that verifies window dragging within workspace.
Review URL: http://codereview.chromium.org/8400063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8440018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is needed for bubbles.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8351042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8440008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Should allow us to fully convert all bubbles (bookmark, etc.)
Use separate border and contents widgets (like old bubble).
Supports transparency/opacity with fading, etc.
Remove BubbleView remnants; update tests.
BUG=98312
TEST=No views_examples bubble problems.
Review URL: http://codereview.chromium.org/8368006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97411
TEST=interactive_ui_tests --gtest_filter=ConstrainedWindowViewTest.FocusTest
Review URL: http://codereview.chromium.org/8052019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
control.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8351036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8429014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
better matches expectations.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8432001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes aura::DesktopHostLinux avoid generating Char
events when not appropriate, which avoids a problem that I
observed where arrow keys were moving <select> selections two
spaces instead of one.
There still appears to be an issue with the Enter key getting
double-counted in <select> popups, though (but if we avoid
sending a Char event for it, things like <textarea> break),
and fullscreen Flash windows aren't getting updated.
BUG=99757,101899,101848
TEST=manual
Review URL: http://codereview.chromium.org/8417008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parents. This is needed otherwise the worskpace code tries to place
and position bubbles and other transient type windows.
BUG=none
TEST=none
R=ben@chromium.org,oshima@chromium.org
Review URL: http://codereview.chromium.org/8414035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8430011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45605
TEST=Tested it with Google Japanese Input method on Win7
Review URL: http://codereview.chromium.org/8294026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors and improves a bunch of views accessibility
code on Windows and has the result of enabling NVDA to
announce the text selection in the omnibox.
The AutocompleteAccessibility class is removed; its
functionality is rolled into NativeViewAccessibilityWin.
NativeViewAccessibilityWin adds IAccessible2 and
IAccessibleText interfaces, allowing it to directly expose
the caret and selection to compatible assistive technology.
In addition, this gives each accessible object an unique id.
Finally, the reference from a View to its
NativeViewAccessibilityWin is changed from a scoped_refptr
to a ScopedComPtr, because another process may still have a
reference to the accessible COM object when the View is
deleted.
BUG=53380
TEST=Manually test the omnibox with NVDA on Windows. It should announce text that's selected, including autocompletions.
Review URL: http://codereview.chromium.org/8391010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8405002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98322
TEST=None
Review URL: http://codereview.chromium.org/8319008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, each widget's tooltip-manager listens to every single X event in the system, all the time. This can get expensive as the number of windows increase. Instead of doing this, the change here makes a TooltipManagerViews only listen to the mouse-events on the corresponding Widget. It starts its timer when the mouse enters the widget, and stops the timer when the mouse leaves the widget. So at a single time, only one TooltipManagerViews will be activated, and looking to update the its tooltip.
BUG=97249
TEST=none
Review URL: http://codereview.chromium.org/8417025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also revert the previous attempt to fix this issue:
Revert "Aura build fix: Make TooltipManagerViews an observer of parent Widget and"
This reverts commit 6749813691870c8311c81c030bee9e1d4ad305ff.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100232
TEST=Manual
Review URL: http://codereview.chromium.org/8341050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107715
Review URL: http://codereview.chromium.org/8362006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also wires up GetRestoredBounds().
BUG=99729
TEST=manual: less spam
Review URL: http://codereview.chromium.org/8417014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8362006
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8400059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8362006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stop updating tooltips after the widget is destroyed.
BUG=none
TEST=views_unittests pass
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8414012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most consumers on all platforms (including windows!) were converting the font family/GetFontName() result to UTF8. (Windows was still having to convert for the SkTypeface calls.) On Linux, we're performing a UTF16ToUTF8 on each string print (and this is showing up in pprof output.)
BUG=100803
TEST=none
Review URL: http://codereview.chromium.org/8392017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
omnibox_view_win.cc.
BUG=101938
TEST=none
Review URL: http://codereview.chromium.org/8343036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97249
TEST=none
Review URL: http://codereview.chromium.org/8371024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor
Rationale:
a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized
b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update
BUG=101477
TEST=bots stay green
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107563
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=107564
Review URL: http://codereview.chromium.org/8395043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the --keep-mouse-cursor flag, and moves the --touch-devices flag
from touchui-only to linux-views (i.e. chromeos, aura on linux, touchui).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8371022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor
Rationale:
a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized
b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update
BUG=101477
TEST=bots stay green
Review URL: http://codereview.chromium.org/8395043
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/8404041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor
Rationale:
a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized
b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update
BUG=101477
TEST=bots stay green
Review URL: http://codereview.chromium.org/8395043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8363036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8395016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8390037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tbw
Review URL: http://codereview.chromium.org/8395039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thus eliminating overdraw.
To do this, the hole punching logic was changed to look at the entire tree.
Drawing the screen is a preorder traversal through all the layers. Thus, to
compute the hole, we have to look at all of the layers after a particular layer
in the preorder traversal.
This is not an efficient algorithm, but it is simplest I could come up with.
Plus we will be moving to the WebKit compositor soon.
Hopefully this will improve the frame rate for the Aura demos
Note: I will put the changes to Transform into another patch.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107360
Review URL: http://codereview.chromium.org/8368013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make NativeViewHostAura detach the native view when notified OnWindowDestroyed.
BUG=101526
TEST=Verify closing a window with DOMView inside (e.g. AppList window) does not crash per 101526.
Review URL: http://codereview.chromium.org/8390052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
some accessors which in turn prompted me to make some uses of these accessors be a bit more const-correct.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8393024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for up arrow, down arrow, and tabbing.
BUG=75782
TEST=
Review URL: http://codereview.chromium.org/8363014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wired it up to Widget by way of new field in Widget::InitParam.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8392005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't clear to transparent when we fills bounds opaquely given that we are not drawing the parent layer.
This makes the code a bit less confusing and will probably bring a slight speed benefit.
BUG= None
TEST= None
Review URL: http://codereview.chromium.org/8318008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transient parent and is forced to always be on top of transient
parent (assuming they have the same parent).
BUG=100088
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8391027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use NativeViewHostAura in NativeViewHost.
Using TYPE_WINDOW_FRAMELESS instead of TYPE_CONTROL since latter has issues with keyboard/focus (both not working). In a result, launcher is seen on login screen even though its container is below LockScreen container.
Tested with http://codereview.chromium.org/8373004/ and
temporary workaround with old WM present (http://gerrit.chromium.org/gerrit/#change,10552).
This CL is a take-over for http://codereview.chromium.org/8361001/
BUG=100874
TEST=Manual: Navigated through user pods, signed in with new/existing users, launched guest mode, shutdown, create account flow, removed user. Tested with non-Aura build that there were no regressions.
Review URL: http://codereview.chromium.org/8382004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107332 0039d316-1c4b-4281-b951-d872f2087c98
|