| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/255075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GLEW's bootstrapping sequence on both X11 and Windows platforms to
avoid linking against libGL.so.1 directly due to
http://crbug.com/16800 . Made GLEW's inclusion of glu.h optional.
Tested on Linux, Mac and Windows.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/258024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249057/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore has a static FontCache that holds handles to platform-specific font data. It exposes a few knobs that might be useful to track or minimize memory usage. This patch exposes an API to experiment with.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/251081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build flag for chromium build of webkit. Doesn't expose the feature to any websites yet.
BUG=none
TEST=none (This is part 1 of 3 for this feature; tests will follow).
Review URL: http://codereview.chromium.org/194079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch
er_host.cc
TBR=darin
TEST=Manually inspected that storage events fired. Will turn on more layout tests in a
subsequent patch.
BUG=19972
Original review URL: http://codereview.chromium.org/223013
Review URL: http://codereview.chromium.org/258010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a 5mb quota to DOM Storage. Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ).
BUG=16876
TEST=I added a layout test upstream and it works.
Review URL: http://codereview.chromium.org/255050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves a bunch of methods from glue to the WebKit API.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/246079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16876
TEST=It compiles.
Review URL: http://codereview.chromium.org/255065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used the GPU to vertically flip the framebuffer. Updated GLEW to use
standard dlopen / dlsym rather than deprecated mach-o/dyld functions;
updated README.chromium.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/256037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Handle name change (setExperimentalWebGLEnabled() => setWebGLEnabled())
Review URL: http://codereview.chromium.org/259014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out this is reached through a very awkward code path. We send an IPC
to the renderer so that it can call WebFrame::executeCommand passing it the
"ToggleSpellingPanel" command. That is intercepted in our code--in
WebFrameImpl--and results in calling a method on Editor that just turns around
and calls EditorClient. EditorClient is again our code, which just pokes the
embedder via WebViewClient to get it to send an IPC back to the browser so that
it can show the spelling panel.
I would have just short-circuited all of this plumbing if it weren't for the
side-effect that this code has of triggering an update to the spelling panel.
That way it can show the correct word. I think that could be done a simpler
way, but for now, I'm content to just restore the way things were.
R=pinkerton
BUG=23543
TEST=manual test: right click on a misspelled word and select the option on
Mac Chrome to show the spelling panel. you should see it appear :)
Review URL: http://codereview.chromium.org/246071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Avoid including windows.h
2. Rename FileType to FileHandle
3. Fix consumers to use FileHandle
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix obsolete references to FrameLoader::XXXXScheduleXXXX APIs.
Review URL: http://codereview.chromium.org/259011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/256010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll re-order the methods in webview_impl.cc in a follow-up CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Originally reviewed here: http://codereview.chromium.org/251051
Review URL: http://codereview.chromium.org/255042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/249058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
found here: https://bugs.webkit.org/show_bug.cgi?id=29655
TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch.
BUG=19972
Review URL: http://codereview.chromium.org/223013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
** browser_tests started failing at this revision. See:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio
**
I'll reorder the methods in webview_impl.cc in a followup CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/251051
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/246060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll re-order the methods in webview_impl.cc in a follow-up CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/251051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This parameter is used to support _self and other names that
need to be evaluated relative to a subframe.
R=jam
BUG=23009
TEST=none
Review URL: http://codereview.chromium.org/257005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ENABLE_3D_CANVAS in development builds. Currently this argument also
requires disabling the sandbox.
BUG=http://crbug.com/21852
TEST=none (runs preexisting WebGL layout tests; more coming)
Review URL: http://codereview.chromium.org/246042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not completely eliminate webkit/glue/webview.h. Instead,
the old WebView extends from the new WebView temporarily as we complete
the transition.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/257001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split so it's not a 2 sided patch.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/242056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make valgrind happy, this CL changes WebKeyboardEvent::isSystemKey and WebMouseWheelEvent::scrollByPage to int type to make sure the size of WebKeyboardEvent and WebMouseWheelEvent align to a factor of 4 bytes strictly.
BUG=22857: Uninitialized memory sent via IPC from RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent()
TEST=Run chrome with valgrind and input something or scroll the mouse wheel in a web page, valgrind should not complain uninitialized memory anymore.
Review URL: http://codereview.chromium.org/235038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
complete the WebKit bug fix https://bugs.webkit.org/show_bug.cgi?id=29109.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled in the build. Change ENABLE_3D_CANVAS to 1 in
src/third_party/WebKit/WebKit/chromium/features.gypi and regenerate
project files to compile. Current code is Windows-specific and
requires the sandbox to be disabled. Follow-on work will add ports to
other platforms and eventually work with the sandbox enabled.
This CL follows https://bugs.webkit.org/show_bug.cgi?id=29664 .
BUG=http://code.google.com/p/chromium/issues/detail?id=21852
TEST=none (runs preexisting WebGL layout tests; more coming)
Review URL: http://codereview.chromium.org/219001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is kinda like yelling, right?
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/241002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
plaintext onto a clipboard in Chromium. The method is declared upstream, in a patch associated with
https://bugs.webkit.org/show_bug.cgi?id=29634
Review URL: http://codereview.chromium.org/211052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Match the new interfaces used for StorageNamespace in WebKit.
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accommodate upstream changes, introduced by:
* http://trac.webkit.org/changeset/48720 (V8 fix)
* http://trac.webkit.org/changeset/48701 (original)
R=vitalyr
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/224018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/224010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also removes two unnecessary methods on WebViewDelegate:
UserMetricsRecordAction and ShowSpellingUI were both never called.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/227006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux fails in opt build due to strict aliasing in WebCore.
BUG=21140
Review URL: http://codereview.chromium.org/215040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12306
TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests.
Review URL: http://codereview.chromium.org/201111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes some initialization order, removes unused varibles,
and fixes a couple signed/unsigned comparison errors. Please
check the signed/unsigned cases.
We can't enable it for windows yet because MSVC complains
about headers pulled in from WebCore. We'll have to wait
until the API is upstreamed.
BUG=21140
Review URL: http://codereview.chromium.org/214024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/211032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore::SecurityOrigin.
This provides us a little wiggle room in the future in
case we ever want to provide more details about a
security origin beyond just its stringified value.
This was done on recommendation from Adam Barth.
R=jorlow
BUG=21967
TEST=none
Review URL: http://codereview.chromium.org/211013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/194126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes WebViewDelegate extend from WebViewClient as
a temporary means to start having consumers implement and use
WebViewClient.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/196128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/204031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r26234.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We crash if we try to report geometry for a plugin that has been
removed from the DOM.
This CL makes changes to main.cpp to support the layout test,
which corresponds to http://trac.webkit.org/changeset/48361.
R=jam
BUG=21841
TEST=covered by layout test
Review URL: http://codereview.chromium.org/196126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarView.
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.
Known issues:
Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).
- When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change).
BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/204022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the compile error on the toolkit builder.
TBR:finnur
Review URL: http://codereview.chromium.org/203064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarView.
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added.
Added an interface that both BookmarkBarView and ExtensionShelf implement.
This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not.
Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions).
Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process.
Toolstrip text color values are no longer hard-coded but use the color specified in the theme.
Decreased the timeouts for showing and hiding the toolstrip handle.
Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses.
Known issues:
Some themes expose the fact that:
- The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though.
- Didn't spend much time theming the shelf handle (just used the solid color from the theme).
BUG=18452, 21272, 21273
TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed.
Review URL: http://codereview.chromium.org/203034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell, so that we can render controls in a platform-verion-independent
manner, allowing us to use (almost) a single set of baselines for all
versions of Windows.
test_shell is modified to accept three new switches: --ux-theme (for the
default or "new" XP/Vista theming engine), --classic-theme (for the older
"Classic" theming engine), and --generic-theme (for the new Skia-based
test theme). Specifying --layout-tests will default to --classic-theme,
otherwise --ux-theme is the default (this is compatible with existing
test_shell behavior). Once the new version-independent baselines are
checked in, we will flip this behavior so --layout-tests defaults to
--generic-theme as well.
This change adds test_shell_webtheme{engine,control}.{cc,h} as Windows-only
build files, and adds documentation to webkit/api/public/win/WebThemeEngine.
It also adds a chromium-win-xp platform baseline directory (currently empty)
and modifies the layout_test/layout_package/platform_utils_win.py baseline
search path to confirm to WebKit's directory search logic (vista and win7
look just in chromium-win, but XP looks in chromium-win-xp first, followed by
chromium-win).
BUG=none
R=darin,pkasting
TEST=none
Review URL: http://codereview.chromium.org/192021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make test shell ignore certificate errors.
2. Extend WebFrameClient for new notifications and printf these.
R=abarth
BUG=21644
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/200110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore/config.h.
I cleaned up the config target in webkit.gyp so it doesn't copy config.h
around. This way wtf/pcre and webcore each use the appropriate config file.
Tested on mac/linux/win platforms.
Patch by Yaar Schnitman <yaar@chromium.org>
Code review URL: http://codereview.chromium.org/196098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the webview.
Also use SkColor isntead of a triplet of colors in RenderPreferences.
BUG=21521
Review URL: http://codereview.chromium.org/195059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
|