| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace build targets 'blob' and 'fileapi' with newly introduced 'webkit_storage'
Introduce a new directory webkit/storage to host webkit_storage.gypi and webkit_storage_export.h
Replace BLOB_EXPORT and FILEAPI_EXPORT with WEBKIT_STORAGE_EXPORT
BUG=155242
TEST=build
TBR=darin@chromium.org, piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11103031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also factor out MockBlobURLRequestContext class so that we can easily
test writing with blob urls.
BUG=148897
TEST=LocalFileChangeTrackerTest.*
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11146015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=141835
TEST=content_unittests --gtest_filter="FileSystemURLRequestJobTest.*"
Review URL: https://chromiumcodereview.appspot.com/11087048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BlobURLReqeustJob
BUG=141835
TEST=content_unittests --gtest_filter="BlobURLRequestJobTest.*"
Review URL: https://chromiumcodereview.appspot.com/11017053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext::CreateRequest
This patch is by departed intern shalev@chromium.org, but it failed to pass the CQ for reasons unrelated to the patch.
Original review at http://codereview.chromium.org/10870060/ .
TBR=mmenke@chromium.org,michaeln@chromium.org,brettw@chromium.org,ben@chromium.org,zelidrag@chromium.org,phajdan.jr@chromium.org,pfeldman@chromium.org
BUG=142945
Review URL: https://chromiumcodereview.appspot.com/10910044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110119
TEST=existing tests (more will be added when we add more implementation)
Review URL: https://chromiumcodereview.appspot.com/10828252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkDelegate as argument
This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext.
TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org
BUG=crbug.com/142945
Review URL: https://chromiumcodereview.appspot.com/10855209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110119
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10827414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introducing webkit_glue::ResourceRequestBody as a content-level abstraction corresponding to WebHTTPBody and as an alternative of net::UploadData in ResourceRequest.
This interface can contain content-level objects like Blob (or FileSystem URL in later patches) while net::UploadData should NOT.
This patch also removes Blob support in net::UploadData.
BUG=110119
TEST=existing tests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152528
Review URL: https://chromiumcodereview.appspot.com/10834289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for upload handling
Introducing webkit_glue::ResourceRequestBody as a content-level abstraction corresponding to WebHTTPBody and as an alternative of net::UploadData in ResourceRequest.
This interface can contain content-level objects like Blob (or FileSystem URL in later patches) while net::UploadData should NOT.
This patch also removes Blob support in net::UploadData.
BUG=110119
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10834289
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introducing webkit_glue::ResourceRequestBody as a content-level abstraction corresponding to WebHTTPBody and as an alternative of net::UploadData in ResourceRequest.
This interface can contain content-level objects like Blob (or FileSystem URL in later patches) while net::UploadData should NOT.
This patch also removes Blob support in net::UploadData.
BUG=110119
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10834289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removing BlobData::BlobData(const WebBlobData&), and instead
adding new NewBlobData(const WebBlobData&) method only for test_shell.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10834386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of the ongoing refactoring of net::UploadData.
UploadData::Element is renamed to UploadElement and is moved from upload_data.cc/h to upload_element.cc/h.
BUG=None
TEST=net_unittests
TBR=kinuko@chromium.org,darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=140508
Review URL: https://chromiumcodereview.appspot.com/10852017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These const accessors are needed in my other CL 10694055.
The accessors are very simple, so I duplicated the code rather than
const-casting the const accessor to implement the non-const.
BUG=N/A
TEST=N/A (no fix & no new feature)
TBR=jianli@chromium.org,darin@chromium.org,joaodasilva@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10825069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136494
Review URL: https://chromiumcodereview.appspot.com/10808043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and URLRequestResourceBundleJob.
To achieve that URLRequestSimpleJob::GetData() signature changed
to allow async operation finishing. All places implementing GetData()
are updated.
Patch from Pavel Ivanov <paivanof@gmail.com>
BUG=59849,90207
Review URL: https://chromiumcodereview.appspot.com/10696135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contructor parameter.
Note: this depends on
http://codereview.chromium.org/10559036/
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10534100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the context was set using the member function set_context.
Note that the context for a URLRequest is not allowed to be null.
BUG=81979
TEST=None
TBR=ajwong,brettw,vitalybuka,sky
Review URL: https://chromiumcodereview.appspot.com/10559036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131295
TEST=manual; successfully copied 3GB file in Chromeos filebrowser
Review URL: https://chromiumcodereview.appspot.com/10536062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes appcache, blob, database, dom_storage, and quota.
Many tests needed MessageLoops, which I've added as appropriate.
Review URL: https://chromiumcodereview.appspot.com/10540042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name was confusion: it does not directly correspond to FileReader in File API, (which is implemented by WebCore::FileReader).
BUG=128483
TEST=Existing file/blob tests.
Review URL: https://chromiumcodereview.appspot.com/10447083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change fileapi is a static library. As it has static data, this causes problems when used from multiple components like chrome and content.
BUG=129885
TEST=Existing tests
Review URL: https://chromiumcodereview.appspot.com/10447055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appended to a blob.
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10444010
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10442013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
support."
Cleaning up git-svn mess with drover.
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Screwed up git branches in that change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10444010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138554
Review URL: https://chromiumcodereview.appspot.com/10386183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current setup, if you have a header file my_class.h
class BASE_EXPORT MyClass {
public:
void MyInlineMethod() { /* do stuff, inline */ }
};
then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.
With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).
Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.
BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan
Review URL: https://chromiumcodereview.appspot.com/10386108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123559
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123302
TEST=LocalFileReaderTest.*
Review URL: https://chromiumcodereview.appspot.com/10260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10066044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any time and add unittests.
Added one-line change (to force running pending cleanup tasks) for leak fix in the test.
Original review URL: https://chromiumcodereview.appspot.com/10234006
BUG=123570
TEST=unit_tests:LocalFileReaderTest.*
TBR=michaeln
Review URL: https://chromiumcodereview.appspot.com/10170031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the internal Open() logic not to deal with raw PlatformFile handle but instead to rely on net::FileStream's destructor to close the file.
Also adding more specific comment to FileReader interface.
BUG=123570
TEST=unit_tests:LocalFileReader.*
Review URL: https://chromiumcodereview.appspot.com/10234006
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10209025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the internal Open() logic not to deal with raw PlatformFile handle but instead to rely on net::FileStream's destructor to close the file.
Also adding more specific comment to FileReader interface.
BUG=123570
TEST=unit_tests:LocalFileReader.*
Review URL: https://chromiumcodereview.appspot.com/10234006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Split LocalFileReader into FileReader interface and LocalFileReader implementation
- Adding FileSystemFileReader as a default implementation for FileSystem files
The FileSystemFileReader implementation uses CreateSnapshotFile which may force downloading the entire file (as the initial generic version). This would need to be changed in remote filesystem implementation.
BUG=114999
TEST=FileSystemURLRequestJobTest, BlobURLRequestJobTest
Review URL: https://chromiumcodereview.appspot.com/10038019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalFileReader change https://chromiumcodereview.appspot.com/10065011
with memory fix http://codereview.chromium.org/10067031/
BUG=113300, 114999, 123302
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10080001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=114179
Review URL: https://chromiumcodereview.appspot.com/10067026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: multiple leak reports on the Memory FYI waterfall (Valgrind, Heapcheck).
- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring
BUG=113300,114999,123302
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10065011
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10066043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring
BUG=113300,114999
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10065011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original change I had tried to submit was:
http://codereview.chromium.org/9651032
The change was reverted because FileStream cannot be created on other
threads than on IO thread on Windows, and therefore broke
the ExtensionPageCaptureApiTest.SaveAsMHTML browser test.
BUG=114999
TEST=test_shell_tests:BlobURLRequestJobTest.*, browser_tests:ExtensionPageCaptureApiTest.SaveAsMHTML
Review URL: http://codereview.chromium.org/10029008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75548,113300
TEST=existing tests should pass
Review URL: https://chromiumcodereview.appspot.com/9949011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10009017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionPageCaptureApiTest.SaveAsMHTML times out consistently after this change.
It also fails in the try job / commit queue runs of this CL.
-------
This patch separates FileStream related code out of BlobURLRequestJob to:
- make BlobURLRequesetJob's responsibility simpler and clearer by moving file-related details out of the class
- remove blocking file operation on IO thread
Long-term goal includes using the same reader class/interface to FileSystemURLRequestJob and other fileapi streaming related code.
(Simplified the patch from the previous version: was: "Add FileStreamInterface for fileapi/blob stream related operations")
BUG=114999,75548
TEST=blob tests
Review URL: https://chromiumcodereview.appspot.com/9651032
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9704010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch separates FileStream related code out of BlobURLRequestJob to:
- make BlobURLRequesetJob's responsibility simpler and clearer by moving file-related details out of the class
- remove blocking file operation on IO thread
Long-term goal includes using the same reader class/interface to FileSystemURLRequestJob and other fileapi streaming related code.
(Simplified the patch from the previous version: was: "Add FileStreamInterface for fileapi/blob stream related operations")
BUG=114999,75548
TEST=blob tests
Review URL: https://chromiumcodereview.appspot.com/9651032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126623 0039d316-1c4b-4281-b951-d872f2087c98
|