| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10825069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136494
Review URL: https://chromiumcodereview.appspot.com/10808043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and URLRequestResourceBundleJob.
To achieve that URLRequestSimpleJob::GetData() signature changed
to allow async operation finishing. All places implementing GetData()
are updated.
Patch from Pavel Ivanov <paivanof@gmail.com>
BUG=59849,90207
Review URL: https://chromiumcodereview.appspot.com/10696135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contructor parameter.
Note: this depends on
http://codereview.chromium.org/10559036/
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10534100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the context was set using the member function set_context.
Note that the context for a URLRequest is not allowed to be null.
BUG=81979
TEST=None
TBR=ajwong,brettw,vitalybuka,sky
Review URL: https://chromiumcodereview.appspot.com/10559036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131295
TEST=manual; successfully copied 3GB file in Chromeos filebrowser
Review URL: https://chromiumcodereview.appspot.com/10536062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes appcache, blob, database, dom_storage, and quota.
Many tests needed MessageLoops, which I've added as appropriate.
Review URL: https://chromiumcodereview.appspot.com/10540042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name was confusion: it does not directly correspond to FileReader in File API, (which is implemented by WebCore::FileReader).
BUG=128483
TEST=Existing file/blob tests.
Review URL: https://chromiumcodereview.appspot.com/10447083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change fileapi is a static library. As it has static data, this causes problems when used from multiple components like chrome and content.
BUG=129885
TEST=Existing tests
Review URL: https://chromiumcodereview.appspot.com/10447055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appended to a blob.
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10444010
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10442013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
support."
Cleaning up git-svn mess with drover.
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Screwed up git branches in that change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10444010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138554
Review URL: https://chromiumcodereview.appspot.com/10386183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
TBR=ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=128266
TEST=as in the bug
Review URL: https://chromiumcodereview.appspot.com/10386183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current setup, if you have a header file my_class.h
class BASE_EXPORT MyClass {
public:
void MyInlineMethod() { /* do stuff, inline */ }
};
then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.
With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).
Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.
BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan
Review URL: https://chromiumcodereview.appspot.com/10386108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123559
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123302
TEST=LocalFileReaderTest.*
Review URL: https://chromiumcodereview.appspot.com/10260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10066044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any time and add unittests.
Added one-line change (to force running pending cleanup tasks) for leak fix in the test.
Original review URL: https://chromiumcodereview.appspot.com/10234006
BUG=123570
TEST=unit_tests:LocalFileReaderTest.*
TBR=michaeln
Review URL: https://chromiumcodereview.appspot.com/10170031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the internal Open() logic not to deal with raw PlatformFile handle but instead to rely on net::FileStream's destructor to close the file.
Also adding more specific comment to FileReader interface.
BUG=123570
TEST=unit_tests:LocalFileReader.*
Review URL: https://chromiumcodereview.appspot.com/10234006
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10209025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the internal Open() logic not to deal with raw PlatformFile handle but instead to rely on net::FileStream's destructor to close the file.
Also adding more specific comment to FileReader interface.
BUG=123570
TEST=unit_tests:LocalFileReader.*
Review URL: https://chromiumcodereview.appspot.com/10234006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Split LocalFileReader into FileReader interface and LocalFileReader implementation
- Adding FileSystemFileReader as a default implementation for FileSystem files
The FileSystemFileReader implementation uses CreateSnapshotFile which may force downloading the entire file (as the initial generic version). This would need to be changed in remote filesystem implementation.
BUG=114999
TEST=FileSystemURLRequestJobTest, BlobURLRequestJobTest
Review URL: https://chromiumcodereview.appspot.com/10038019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalFileReader change https://chromiumcodereview.appspot.com/10065011
with memory fix http://codereview.chromium.org/10067031/
BUG=113300, 114999, 123302
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10080001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=114179
Review URL: https://chromiumcodereview.appspot.com/10067026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: multiple leak reports on the Memory FYI waterfall (Valgrind, Heapcheck).
- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring
BUG=113300,114999,123302
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10065011
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10066043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- to avoid file access on IO thread
- to remove duplicated code
- for further FileSystem stream related refactoring
BUG=113300,114999
TEST=FileSystemURLRequestJobTest.*
Review URL: https://chromiumcodereview.appspot.com/10065011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original change I had tried to submit was:
http://codereview.chromium.org/9651032
The change was reverted because FileStream cannot be created on other
threads than on IO thread on Windows, and therefore broke
the ExtensionPageCaptureApiTest.SaveAsMHTML browser test.
BUG=114999
TEST=test_shell_tests:BlobURLRequestJobTest.*, browser_tests:ExtensionPageCaptureApiTest.SaveAsMHTML
Review URL: http://codereview.chromium.org/10029008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75548,113300
TEST=existing tests should pass
Review URL: https://chromiumcodereview.appspot.com/9949011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10009017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionPageCaptureApiTest.SaveAsMHTML times out consistently after this change.
It also fails in the try job / commit queue runs of this CL.
-------
This patch separates FileStream related code out of BlobURLRequestJob to:
- make BlobURLRequesetJob's responsibility simpler and clearer by moving file-related details out of the class
- remove blocking file operation on IO thread
Long-term goal includes using the same reader class/interface to FileSystemURLRequestJob and other fileapi streaming related code.
(Simplified the patch from the previous version: was: "Add FileStreamInterface for fileapi/blob stream related operations")
BUG=114999,75548
TEST=blob tests
Review URL: https://chromiumcodereview.appspot.com/9651032
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9704010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch separates FileStream related code out of BlobURLRequestJob to:
- make BlobURLRequesetJob's responsibility simpler and clearer by moving file-related details out of the class
- remove blocking file operation on IO thread
Long-term goal includes using the same reader class/interface to FileSystemURLRequestJob and other fileapi streaming related code.
(Simplified the patch from the previous version: was: "Add FileStreamInterface for fileapi/blob stream related operations")
BUG=114999,75548
TEST=blob tests
Review URL: https://chromiumcodereview.appspot.com/9651032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Makes the class less stateful, trying to make the code flow easier to follow.
- The new code posts multiple GetFileInfo tasks at once while if error occurs rest of the tasks wouldn't run. (If it could cause any problem I can change the behavior back)
- This patch also makes a few related minor cleanups.
BUG=114999
TEST=none
Review URL: http://codereview.chromium.org/9550010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ReadBytes -> ReadBytesItem
- DispatchReadFile -> ReadFileItem
- DidOpen -> DidOpenFile
- ReadFile -> ReadFileStream
- DidRead -> DidReadFileStream
- CloseStream -> CloseFileStream
- ReadCompleted -> BytesReadCompleted
BUG=114999
TEST=existing tests should pass
Review URL: https://chromiumcodereview.appspot.com/9600032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also did some reordering to group related methods together.
BUG=114999
TEST=existing tests should pass
Review URL: https://chromiumcodereview.appspot.com/9602019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=115603
Review URL: https://chromiumcodereview.appspot.com/9569035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the class to ShareableFileReference and fixed up the current callers with the new name and gypi files.
BUG=115603
Review URL: https://chromiumcodereview.appspot.com/9466025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove lots of duplicated ifdefs, replacing them with syntax that works
on all platforms (including VS2010).
BUG=106215
Review URL: https://chromiumcodereview.appspot.com/8735002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to use these functions.
BUG=72001
TEST=try bots
Review URL: http://codereview.chromium.org/9402014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for implementing async versions of Open()
and Close().
The existing clients are changed to use OpenSync/CloseSync.
No logic is changed.
The original patch was reverted as it broke linux_chromeos build.
This patch includes fixes for the build.
TEST=git try -r 121075 --bot=win,linux,mac,linux_chromeos,linux_chromeos_gtk,win_aura to confirm everything is built as before.
BUG=72001
Review URL: https://chromiumcodereview.appspot.com/9373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/16/steps/compile/logs/stdio
net: Rename FileStream::Open/Close with OpenSync/CloseSync.
This is in preparation for implementing async versions of Open()
and Close().
The existing clients are changed to use OpenSync/CloseSync.
No logic is changed.
TEST=try bots to confirm everythign is built as before.
BUG=72001
Review URL: http://codereview.chromium.org/9349005
TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9363036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for implementing async versions of Open()
and Close().
The existing clients are changed to use OpenSync/CloseSync.
No logic is changed.
TEST=try bots to confirm everythign is built as before.
BUG=72001
Review URL: http://codereview.chromium.org/9349005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
close/CloseHandle().
TBR=mkwst@chromium.org,satorux@chromium.org
Reverting my revert: this commit wasn't the culprit.
Review URL: https://chromiumcodereview.appspot.com/9320060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9315062
TBR=satorux@chromium.org
We're guessing that this is causing timeouts on the Windows browser tests,
see http://build.chromium.org/p/chromium/builders/Win7%20Tests%20%28dbg%29%286%29/builds/2695/steps/browser_tests/logs/stdio
for example. :(
Review URL: https://chromiumcodereview.appspot.com/9307081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClosePlatformFile() is guarded with ThreadRestrictions::AssertIOAllowed()
that will catch bad pieces of code performing file IO on wrong threads.
The original patch was reverted as it broke tests in debug builds.
This version contains workarounds for the bad pieces of code.
BUG=59849,72001,75548,112474,112512
TEST=try bots both release and debug
Review URL: http://codereview.chromium.org/9315062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The net logging doesn't currently do anything, but is ready if some system wants to pass it in.
This is the first of 4 CLs that will enable net logging for downloads.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9288084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=tony@chromium.org
BUG=105823
TEST=everything stays green
Review URL: https://chromiumcodereview.appspot.com/9254040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118774 0039d316-1c4b-4281-b951-d872f2087c98
|