| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of crrev.com/127030
The original patch was reverted as it broke
ExtensionFileBrowserPrivateApiTest.FileBrowserMount
This version fixed the test expectation.
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9699107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke ExtensionFileBrowserPrivateApiTest.FileBrowserMount.
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9700077
TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9693067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9700077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this implemented, snapshot files are created on-the-fly
when files on gdata are accessed via File API.
The files on gdata are downloaded if not cached locally.
BUG=chromium-os:23516
TEST=click on large jpg files on gdata from the file manager, and they are displayed, with the following line in metadata_provider.js commented out, per kaznacheev's suggestion:
contentURL: (result.contentUrl || '').replace(/\?.*$/gi, ''),
Review URL: https://chromiumcodereview.appspot.com/9692026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the following changes:
1. Implement copy and move operations in RemoteFileSystemOperation,
DocumentsService, and GDataFileSystem. Copying of regular files and
directories is yet to be implemented.
2. Add corresponding unit tests in GDataFileSystemTest.
BUG=chromium-os:26962
TEST=Tested the following:
1. Run "unit_tests --gtest_filter='*GData*'"
2. Manually test copy, move, and rename operations in file manager.
Review URL: http://codereview.chromium.org/9662041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:26961
TEST=GDataFileSystemTest.CreateDirectory, GDataFileSystemTest.FindFirstMissingParentDirectory
Review URL: http://codereview.chromium.org/9561009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
filesystem files.
BUG=chromium-os:26673
TEST=*FileBrowser*
Review URL: http://codereview.chromium.org/9465001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:26963
TEST=GDataFileSystemTest.RemoveFiles, GDataFileSystemTest.FilePathTest
Review URL: https://chromiumcodereview.appspot.com/9514002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added RemoteFileSystemOperation impl (with NOTIMPLEMENTED()) to
http://codereview.chromium.org/9462005/
BUG=115603
TEST=FileSystemOperationTest.TestCreateSnapshotFile
TBR=michaeln
Review URL: https://chromiumcodereview.appspot.com/9474037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added GDataFileSystemProxy object which routes RemoteFileSystem operation requests to GDataFileSystem. Each remote mount point in CrosMountPointProvider will have its own specialization of RemoteFileSystemProxyInterface which will be responsible to execute RemoteFileSystemOperations.
BUG=chromium-os:26110
TEST=still working on them, comming soon.
Review URL: http://codereview.chromium.org/9368038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reland of r121620, which was reverted because it broke chromeos-clang compilation and LayoutTests/fast/filesystem/file-writer-*)
This patch is the first step for supporting cross-filesystem copy/move on
the Filesystem API implementation. To accomplish it, I'm planning to
crack FileSystemOperation::{Move,Copy} to a series of other FSO operations.
For it, per-method callback is more handy.
BUG=110121
TEST=*File*
TEST=LayoutTest fast/filesystem
Review URL: http://codereview.chromium.org/9372044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is the first step for supporting cross-filesystem copy/move on
the Filesystem API implementation. To accomplish it, I'm planning to
crack FileSystemOperation::{Move,Copy} to a series of other FSO operations.
For it, per-method callback is more handy.
BUG=110121
TEST=*File*
Review URL: http://codereview.chromium.org/9372044
TBR=kinaba@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9380040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is the first step for supporting cross-filesystem copy/move on
the Filesystem API implementation. To accomplish it, I'm planning to
crack FileSystemOperation::{Move,Copy} to a series of other FSO operations.
For it, per-method callback is more handy.
BUG=110121
TEST=*File*
Review URL: http://codereview.chromium.org/9372044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
file manager should call this method to ensure that gdata provider is fully accessible and authenticated.
BUG=chromium-os:26030
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9317045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
slash (as expected by clients).
BUG=chromium-os:24641
TEST=See bug.
Review URL: http://codereview.chromium.org/9251010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=satorux
Review URL: http://codereview.chromium.org/9228003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no functional changes
Review URL: http://codereview.chromium.org/8999017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move OpenFileSystem() to FileSystemContext
2. Change Cancel() not to take another FileSystemOperation
These two changes are made so that all the operations that require FileSystemOperation take target path URL.
3. Did some related code cleanups in FileSystemMountPointProvider:
- Renamed ValidateFileSystemRootAndGetURL() to ValidateFileSystemRoot() as we no longer need to return RootURL
- Renamed ValidateFileSystemRootAndGetPathOnFileThread() to GetFileSystemRootPathOnFileThread() for the sake of simplicity
- Reimplemented SandboxMPP::GetRootPathTask using PostTaskAndReply
Patch from http://codereview.chromium.org/9004019/
BUG=none
TEST=existing tests should pass
Review URL: http://codereview.chromium.org/9016020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Deprecating FileSystemPathManager, which I believe no longer has a lot of reasons to exist
* Changed GetFileSystemTypeString to a regular function in file_system_util
* Added GetFileUtil(FileSystemType), GetMountPointProvider(FileSystemType), external_provider() to FileSystemContext
* Moved all the tests in file_system_path_manager_unittest to file_system_mount_point_provider_unittest
- Also replaced two boolean values in FileSystemContext with a thin FileSystemOptions interface
BUG=none
TEST=no functional changes
Review URL: http://codereview.chromium.org/9004019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby
Review URL: http://codereview.chromium.org/9032010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108015
TEST=test_shell_tests:MemoryFileUtil\* with heapcheck/valgrind
TBR=satorux
Review URL: http://codereview.chromium.org/9007006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108015
TEST=test_shell_tests:MemoryFileUtil\* with heapcheck/valgrind
Review URL: http://codereview.chromium.org/8953027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testing purposes.
patch from issue 8574007
BUG=chromium-os:23316
TEST=out/Debug/test_shell_tests --gtest_filter='MemoryFileUtilTest.*'
Review URL: http://codereview.chromium.org/8907014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23809
TEST=SelectFileDialogExtensionBrowserTest.*
Review URL: http://codereview.chromium.org/8819025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/8787003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8662021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=OWNERS
Review URL: http://codereview.chromium.org/8539001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106139
Review URL: http://codereview.chromium.org/8342008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97879
TEST=FileSystemPathManagerTest.*
Review URL: http://codereview.chromium.org/8028023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splits FileSystemFileUtil into two classes.
1. FileSystemFileUtil (pure virtual and non-virtual functions + functions to forward to an underlying file_util.)
2. NativeFileUtil (FileUtil for OS-native operations)
Renames *FileSystemFileUtil into *FileUtil except for FileSystemFileUtil.
Renames *_file_system_file_util.{cc,h} into *_file_util.{cc,h}.
Renames variable *_file_system_file_util into *_file_util.
BUG=none
TEST=All FileAPI-related tests
Review URL: http://codereview.chromium.org/7470037
Patch from Dai Mikurube <dmikurube@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17412
TEST=None
Review URL: http://codereview.chromium.org/7497037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileUtils.
Based on the discussion at http://codereview.chromium.org/7174002/diff/26001/webkit/fileapi/local_file_system_file_util.h#newcode38, this change
* also reduces dependency between FileUtils,
* enables more flexible stacking of -FileUtils, such as QuotaFileUtil over other -FileUtils, and
* makes -FileUtils symmetry so owner handling for these objects gets unified.
BUG=none
TEST=FileSystemFileUtilTest.*,FileSystemOperationTest.*,FileSystemOperationWriteTest.*,FileSystemQuotaTest.*,FileWriterDelegateTest.*,LocalFileSystemFileUtilTest.*,ObfuscatedFileSystemFileUtil.*,QuotaFileUtil.*,SandboxMountPointProviderTest.*
Review URL: http://codereview.chromium.org/7312023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
Review URL: http://codereview.chromium.org/7502010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file browser:
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/7495024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
underlying *FileUtil.
This change :
* reduces dependency between FileUtils, and
* enables more flexible stacking of FileSystemFileUtil, such as {Obfuscated|Local}FSFU without any quota operation.
BUG=none
TEST=*FileUtilTest.*,FileSystemPathManagerTest.*,SandboxMountPointProvider.*,FileSystem*OperationTest.*,FileWriterDelegateTest.*,FileSystemQuotaTest.*
Review URL: http://codereview.chromium.org/7174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also add missing WebString include to cros_mount_point_provider.cc.
Review URL: http://codereview.chromium.org/7170017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not change.
BUG=chromium-os:14880
TEST=Click "play" button on an audion file in the file browser. Check that the mediaplayer panel has popped up. Click on another file. Check that the mediaplayer playlist panel has popped up and contains 2 items.
Review URL: http://codereview.chromium.org/7067020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Per Eric's request, refactored FileSystemDirURLRequestJob and FileSystemURLRequestJob classes to resolve local file system through a new operation.
BUG=chromium-os:14225
TEST=added new test cases to FileSystemPathManagerTest.*, added FileSystemOperationTest.TestGetLocalFilePathSuccess
Review URL: http://codereview.chromium.org/6864040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the file browser component extension to a 3rd party extension.
BUG=chromium-os:11996
TEST=FileAccessPermissionsTest.FileAccessChecks
Review URL: http://codereview.chromium.org/6810037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
currently exists for ChromeOS builds only.
This CL exposes new extension permission 'fileSystem' that controls access to individual local file system elements from 3rd party extensions. Another new permission 'fileBrowserPrivate' controls access to following API call that retrieves root DOMFileSystem instance for locally exposed folders:
chrome.fileBrowserPrivate.requestLocalFileSystem(callback)
BUG=chromium-os:11983
TEST=ExtensionApiTest.LocalFileSystem
Review URL: http://codereview.chromium.org/6519040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79451 0039d316-1c4b-4281-b951-d872f2087c98
|