| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace build targets 'blob' and 'fileapi' with newly introduced 'webkit_storage'
Introduce a new directory webkit/storage to host webkit_storage.gypi and webkit_storage_export.h
Replace BLOB_EXPORT and FILEAPI_EXPORT with WEBKIT_STORAGE_EXPORT
BUG=155242
TEST=build
TBR=darin@chromium.org, piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11103031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The check is added since BlobData has expected_modification_time field.
Add tests (mostly copied from LocalFileStreamReaderTest).
BUG=141835
TEST=content_unittests --gtest_filter="FileSystemFileStreamReaderTest.*"
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11098067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new mount point will be accessible will be accessible by file manager
extension, but it won't be shown in the UI.
The mount point will contain Timescapes-ChromeOS video which will be playable in
the media player.
BUG=152216
TEST=manual (tried playing video on oem mount point using media player)
Review URL: https://chromiumcodereview.appspot.com/10993066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL ensures the written content is flushed physically before
fileWriter.write() invokes the "onwriteend" event, for native local files.
Remote files (Google Drive files in Chrome OS) nor FileSystem API
files (in PERSISTENT or TEMPORARY storage) aren't affected.
The summary of the changes:
* Call Flush() before the final callback.
(webkit/fileapi/file_writer_delegate.cc)
* Delegate Flush() to net::FileStream::Flush
(webkit/fileapi/local_file_stream_writer.cc)
* No-op implementation for Flush().
(webkit/fileapi/sanbox_file_stream_writer.cc)
(webkit/chromeos/fileapi/remote_file_stream_writer.cc)
* Implementation of asynchronous Flush.
(net/base/file_stream_{posix,win}.cc)
* Other files are just for reflecting the rename Flush -> FlushSync.
BUG=144790
R=willchan@chromium.org,kinuko@chromium.org,benjhayden@chromium.org
TBR=marja@chromium.org
TEST=out/Debug/browser_tests --gtest_filter='*FileSystemApi*'
TEST=./webkit/tools/layout_tests/run_webkit_tests.sh fast/filesystem
TEST=Manual steps reported in the issue.
Review URL: https://codereview.chromium.org/10986045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fails but something was written. e.g. partial write before failure.
BUG=150060
Review URL: https://chromiumcodereview.appspot.com/10956064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystemMountPointProvider::CreateFileSystemOperation function.
BUG=141617
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10914188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext::CreateRequest
This patch is by departed intern shalev@chromium.org, but it failed to pass the CQ for reasons unrelated to the patch.
Original review at http://codereview.chromium.org/10870060/ .
TBR=mmenke@chromium.org,michaeln@chromium.org,brettw@chromium.org,ben@chromium.org,zelidrag@chromium.org,phajdan.jr@chromium.org,pfeldman@chromium.org
BUG=142945
Review URL: https://chromiumcodereview.appspot.com/10910044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Full implementation will be made possible once we start using the new Drive API
(see the issue tracker for details). For the old WAPI, the operation calls back
an 'invalid' error.
BUG=144369
Review URL: https://chromiumcodereview.appspot.com/10875028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added verbose description in file_system_types.h.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10879002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystemURL instead of a triplet.
BUG=142267
Contributed by calvinlo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10873055
Patch from Calvin Lo <calvinlo@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=144388
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10870040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this CL,
* gdata_file_system_interface.h has been renamed to drive_file_system_interface.{h,cc}
* gdata_file_system.{h,cc} have been renamed to drive_file_system.{h,cc}
* same for gdata_file_system_unittest.cc, gdata_file_system_proxy.{h,cc}, mock_gdata_file_system.{h,cc}
* class GDataFileSystemInterface has been renamed to DriveFileSystemInterface.
* class DriveFileSystem has been renamed to DriveFileSystem.
This change applies on top of
https://chromiumcodereview.appspot.com/10878023/
BUG=137151
TEST=pass all existing tests.
TBR=satorux@chromium.org, ben@chromium.org, estade@chromium.org, rginda@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10874028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The implementation is almost the exact clone of that in LocalFileSystemOperation.
BUG=132403
Review URL: https://chromiumcodereview.appspot.com/10827412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* To support MTP/Media filesystems in CrOS's FileBrowser
* To eventually support external, persistent mount points in sans-CrOS chrome (currently ifdef'ed only for cros since we need http://crbug.com/142289 to do the same in chrome)
* To introduce more finer-grained filesystem types
* To reduce duplicated code
What this patch actually does:
- Add external mount point support in IsolatedContext
- Introduce new filesystem types, NativeLocal and GData, to represent file systems supported by CrOS
- Replace CrOSMountPointProvider's internal mount map with IsolatedContext
BUG=139223
TEST=manually tested
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10823273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139611
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10843041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139366
TEST="Will be tested from WebKit inspector test"
Review URL: https://chromiumcodereview.appspot.com/10828043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
declarations.
BUG=none.
Review URL: https://chromiumcodereview.appspot.com/10821127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=existing test
Review URL: https://chromiumcodereview.appspot.com/10834021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* cracks isolated path in FileSystemURL ctor
* FileUtils no longer need to crack the isolated path by themselves
* Make IsolatedFileUtil inherit from LocalFileUtil
* Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil
BUG=134078,138022
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10810053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136494
Review URL: https://chromiumcodereview.appspot.com/10808043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=138020
TEST=content_unittests
Review URL: https://chromiumcodereview.appspot.com/10790096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RemoteFileSystemOperation::OpenFile() method.
BUG=133879
TEST=coming...
Review URL: https://chromiumcodereview.appspot.com/10600013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remote filesystems need to know when a plugin finished
updating a local cache file in order to commit the change.
This CL is to wire the notification of file close between
the two components.
Since writable OpenFile is not yet implemented for remote filesystem,
the CL itself should not cause behavior change.
BUG=132236
TEST=browser_tests --gtest_filter='*FileIO*'
Review URL: https://chromiumcodereview.appspot.com/10541113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is the last piece for implementing the File API
getFile(..., {create: true}, ...) for GDataFileSytem.
Currently the file creation is implemented as uploading of
an empty file to the server. The Drive server assigns the
resource_id, and further read or write operation just
treats it as a non-pinned file (e.g., when it is read or
written it is downloaded to GCache/v1/tmp/<resource_id>.<md5>).
BUG=132968
TEST=Manual test.
1) Be sure prerequisites patches (10636053, 10656043, and 10556003) are applied.
2) Edit image files on Google Drive folder by photo editor, and with "overwrite original" unchecked)
3) Verify a new file is created on the Drive.
Review URL: https://chromiumcodereview.appspot.com/10568012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- crack the filesystem URL as soon as we get it in FileAPIMessageFilter
- introduce a new class FileSystemURL for cracked URL information and use it everywhere
- deprecate FileSystemPath (this used to serve the similar role for *FileUtil classes)
Mechanical changes only except for fileapi_message_filter.cc and file_system_operation.cc.
This change reduces the # of CrackFileSystemURL roughly from 3~4 to 1 for each FileSystem operation.
BUG=none
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10566002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10386206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the context was set using the member function set_context.
Note that the context for a URLRequest is not allowed to be null.
BUG=81979
TEST=None
TBR=ajwong,brettw,vitalybuka,sky
Review URL: https://chromiumcodereview.appspot.com/10559036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExternalMountPointProvider.
BUG=none
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10540177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127097
TEST=browser_test --gest_filter='*RemoteFileSystem*'
TEST=unit_tests --gtest_filter='*GData*'
Review URL: https://chromiumcodereview.appspot.com/10441015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a browser test for remote file writing.
* Fix a confusion of remote and local path in CloseWritableSnapshotFile.
* Fix a wrong ownership relation between FileWriterDelegate and RemoteFileStreamWriter.
* Made CommitDirtyInCache update entry metadata.
BUG=132051, 127097
TEST=browser_tests --gtest_filter='*RemoteFileSystem*'
TEST=unit_tests --gtest_filter='*GData*'
First Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=142373
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=142380
The first commit broke GDataFileSystemTest::OpenAndCloseFile. Changing
the behavior of CloseFile began to require some more IO operations.
Review URL: https://chromiumcodereview.appspot.com/10562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
several revealed bugs.
* Add a browser test for remote file writing.
* Fix a confusion of remote and local path in CloseWritableSnapshotFile.
* Fix a calling thread for automatic invocation of CreateWritableSnapshotFile.
* Fix a wrong ownership relation between FileWriterDelegate and RemoteFileStreamWriter.
* Made CommitDirtyInCache update entry metadata.
BUG=132051, 127097
TEST=browser_tests --gtest_filter='*RemoteFileSystem*'
Review URL: https://chromiumcodereview.appspot.com/10537174
TBR=kinaba@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a browser test for remote file writing.
* Fix a confusion of remote and local path in CloseWritableSnapshotFile.
* Fix a calling thread for automatic invocation of CreateWritableSnapshotFile.
* Fix a wrong ownership relation between FileWriterDelegate and RemoteFileStreamWriter.
* Made CommitDirtyInCache update entry metadata.
BUG=132051, 127097
TEST=browser_tests --gtest_filter='*RemoteFileSystem*'
Review URL: https://chromiumcodereview.appspot.com/10537174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127754
TEST=none. the code is to be used for future cross-fs operations.
Review URL: https://chromiumcodereview.appspot.com/10539154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132236
TEST=make sure we can open files from Drive with QuickOffice viewer
Review URL: https://chromiumcodereview.appspot.com/10543132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=127097
TEST=unit_tests --gtest_filter='*GData*'
Review URL: https://chromiumcodereview.appspot.com/10477026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- CreateFileStreamWriter wiring in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)
BUG=none
TEST=existing tests should pass
Original review URL: https://chromiumcodereview.appspot.com/10540070
Review URL: https://chromiumcodereview.appspot.com/10532085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For several reasons the name of the class was confusing:
- It does not directly correspond to FileWriter in File API (which is implemented by WebCore::FileWriter), and
- FileWriterDelegate is NOT a delegate of the class.
hence the change. FileReader renaming is to come in a separate CL.
BUG=128483
TEST=unit_tests --gtest_filter='*File*Write*'
Review URL: https://chromiumcodereview.appspot.com/10456024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name was confusion: it does not directly correspond to FileReader in File API, (which is implemented by WebCore::FileReader).
BUG=128483
TEST=Existing file/blob tests.
Review URL: https://chromiumcodereview.appspot.com/10447083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None. Just changing comments and spaces.
Review URL: https://chromiumcodereview.appspot.com/10441086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this CL:
- Stop layering under FileSystemFileUtil, and make it pure virtual class.
- Introduce LayeringFileUtil class, instead.
- Change NativeFileUtil to pure 'static' class.
- Change {Obfuscated,Local,Isolated}FileUtil to call NativeFileUtil directory.
BUG=114732
TEST='*File*'
Review URL: https://chromiumcodereview.appspot.com/10391102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removing the obsolete derivation from RefCountedThreadSafe. There's no bug here
yet, but it would be very easy to add one later if we don't clean this up.
BUG=http://code.google.com/p/chromium/issues/detail?id=128942
TEST=none; there's no actual bug there yet.
Review URL: https://chromiumcodereview.appspot.com/10332283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this patch, just adding an interface. Concrete implementations that return
appropriate FileWriter subclass instances are on the way.
BUG=123993
TEST=check it compiles.
Review URL: https://chromiumcodereview.appspot.com/10332164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none, I'll convert some tests to use it once it's submitted
Review URL: https://chromiumcodereview.appspot.com/10386069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123559
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/10197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instance by cracking a given filesystem URL.
In a short term a returned reader is to be used by FileSystemURLRequestJob and generalized cross-filesystem operation implementation.
For now in most cases it just returns a default FileSystemFileReader which internally calls CreateSnapshotFile (i.e. downloads everything first).
(diff to http://codereview.chromium.org/10038019/)
BUG=114999
TEST=FileSystemURLRequestJobTest.*
Review URL: http://codereview.chromium.org/10082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And remove the copied code.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9965033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of crrev.com/127030
The original patch was reverted as it broke
ExtensionFileBrowserPrivateApiTest.FileBrowserMount
This version fixed the test expectation.
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9699107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke ExtensionFileBrowserPrivateApiTest.FileBrowserMount.
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9700077
TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9693067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use $HOME/Downloads if running on Linux desktop.
Note that gspencer@ tried to solve this problem in a cleaner way:
http://codereview.chromium.org/9455073/
However his patch didn't work. I patched it locally, but mount
points like /media/removable didn't show up in the file manager,
and the renderer crashed when I clicked on the "Open downloads folder"
in chrome://downloads, as he warned me beforehand. Hence I decided to
go with a simpler approach in this patch.
BUG=chromium-os:27859
TEST=confirm that contents in ~/Downloads are shown in the file browser on Linux desktop
Review URL: https://chromiumcodereview.appspot.com/9700077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127030 0039d316-1c4b-4281-b951-d872f2087c98
|