| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
from is_directory_operation_enabled checks.
BUG=162811
Review URL: https://chromiumcodereview.appspot.com/11496005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DriveFileSyncService::ResolveConflictToLocal.
- Drop metadata of the resolved file to prevent repeated conflit.
- Allow ClearChangesForURL for non-changed URL, to prevent DCHECK hit.
BUG=164335
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/11464024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Step to repro:
- make a local change
- finish the browser before or right after the local change is uploaded
(to leave the dirty flag in the local tracker DB)
- restart the browser
Expected behavior:
- the file is marked as 'pending' initially but it's to be uploaded
Actual behavior:
- the file is marked as 'pending' but will never be uploaded (unless the user makes a new change on the file)
BUG=164362
TEST=manual
Review URL: https://codereview.chromium.org/11439009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we decided not to resolve conflicts automatically I think
we still want to have a notification type to let the apps know when
a file has a conflict.
BUG=162358
TEST=manual, auto tests are to be added
Review URL: https://codereview.chromium.org/11434102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resolution
BUG=164335
TEST=LocalFileSyncServiceTest.RecordFakeChange
Review URL: https://codereview.chromium.org/11437007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Stop clearing sync flag locally in ProcessLocalChange for local sync
- *Always* clear sync flag after a local or remote sync
BUG=155505
TEST=LocalFileSyncServiceTest.*
Review URL: https://codereview.chromium.org/11411352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- The method takes FileSystemURL and returns a new enum: fileapi::SyncFileStatus, which takes one of either: UNKNOWN, SYNCED, HAS_PENDING_CHANGES or CONFLICTING
BUG=163860
TEST=SyncFileSystemService.GetFileSyncStatus
Review URL: https://codereview.chromium.org/11421197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=153757
TEST=n/a
Review URL: https://chromiumcodereview.appspot.com/11275147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=162830
TEST=manual (see the bug comment 1)
Review URL: https://codereview.chromium.org/11421094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=161436
TEST=SyncFileSystemServiceTest.SimpleSyncFlowWithFileBusy
Review URL: https://codereview.chromium.org/11280157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: https://chromiumcodereview.appspot.com/11418085/
Change from the original review: diff from patch 1 to patch 2
(Added empty tasks to wait for remaining shutdown tasks to finish before we terminate the test)
BUG=155505
TEST=SyncFileSystemServiceTest.Simple{Local,Remote}SyncFlow
TBR=tzik
Review URL: https://codereview.chromium.org/11418152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we need the file size for uploading the newly created/updated file
to the remote service.
BUG=162215
TEST=LocalFileSyncServiceTest.*
Review URL: https://codereview.chromium.org/11414111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Separates out SyncOperation type enum from sync_event_observer.h into its own file (webkit/fileapi/syncable/sync_operation_type.h)
- Changes RemoteFileSyncService::ProcessRemoteChange to return SyncOperationType in its callback (no change in the local side for now as the ProcessLocalChange may make multiple changes in the current implementation)
- Fixes SyncEventObserver::OnFileSynced signature as well
BUG=162358
TEST=to be added
Review URL: https://codereview.chromium.org/11419129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved MockLocalChangeProcessor local implementation from
local_file_sync_service_unittest.cc into its own file
and added default implementation of
MockRemoteFileSyncService::GetLocalChangeProcessor using the mock class.
Similarly separating out MockSyncStatusObserver class into its own class.
BUG=161436
TEST=LocalFileSyncServiceTest.*
Review URL: https://codereview.chromium.org/11414108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adding temporary --enable-sync-directory-operation command line switch
so that we could start testing the directory operations manually.
- In testing code that uses CannedSyncableFileSystem I also enabled it
by default (with noisy TODOs) to save some changes
BUG=161442
TEST=content_unittests:SyncableFileSystemTest.DisableDirectoryOperations
Review URL: https://chromiumcodereview.appspot.com/11416069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157815
TEST=unit_tests --gtest_filter=\*DriveFileSyncClient\*
Review URL: https://codereview.chromium.org/11362201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also add to base namespace.
BUG=
Review URL: https://codereview.chromium.org/11359217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160951
TEST=unit_tests:LocalFileSyncService\*
Review URL: https://codereview.chromium.org/11410088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change PrepareForSync to fail with FILE_BUSY if the target file is already in sync
- Call EndSinging() at the end of ApplyRemoteChange() (this is a bug fix) and made some more related fixes in the tests
- Added LocalFileSyncStatus::IsSyncable() utility method
BUG=155505
TEST=content_unittests:LocalFileSyncStatusTest.*, unit_tests:LocalFileSyncServiceTest.*
Review URL: https://chromiumcodereview.appspot.com/11365217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fill in implementation for:
- SyncFileSystemService::GetConflictFiles which internally calls GetRemoteFileMetadata and GetLocalFileMetadata
- SyncFileSystemService::GetConflictFileInfo which calls RemoteFileSyncService::GetConflictFiles
- Adding mock method for: RemoteFileSyncService::{GetConflictFiles, GetRemoteFileMetadata}
BUG=155505, 157795
TEST=SyncFileSystemServiceTest.GetConflictFiles*
Review URL: https://codereview.chromium.org/11364172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160210
TEST=unit_test:LocalFileSyncServiceTest.GetLocalMetadata
Review URL: https://codereview.chromium.org/11360186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change LocalFileSyncInfo struct to have SyncFileMetadata and move its
definition to sync_file_metadata.h
- Change PrepareForSync to return file metadata
BUG=160210
TEST=content_unittests:LocalFileSyncContextTest.*
TEST=unit_tests:LocalFileSyncServiceTest.*
Review URL: https://chromiumcodereview.appspot.com/11360166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, added GDataErrorCodeToSyncStatusCode() to translate them.
TBR=thestig@chromium.org
BUG=156041
Review URL: https://chromiumcodereview.appspot.com/11293196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tests using the method are to be added
Review URL: https://chromiumcodereview.appspot.com/11363161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No implementation yet.
BUG=155505
TEST=n/a
Review URL: https://chromiumcodereview.appspot.com/11275192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=156599
TEST=LocalFileSyncServiceTest.ProcessLocalChange*
Review URL: https://codereview.chromium.org/11367098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1st review: http://codereview.chromium.org/11365032/
2nd review: https://codereview.chromium.org/11362080/
Change from 2nd submit: Removed failing tests.
BUG=156599
TEST=LocalFileSyncServiceTest.LocalChangeObserver*
TBR=tzik@chromium.org
Review URL: https://codereview.chromium.org/11363097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a bit awkward as the sync/change status is kept on IO thread while changes are recorded on FILE thread, but should work.
BUG=156599
TEST=LocalFileSyncServiceTest.LocalChangeObserver\*
TBR=tzik@chromium.org
Original review: http://codereview.chromium.org/11365032/
Review URL: https://codereview.chromium.org/11362080
TBR=kinuko@chromium.org
Review URL: https://codereview.chromium.org/11275151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a bit awkward as the sync/change status is kept on IO thread while changes are recorded on FILE thread, but should work.
BUG=156599
TEST=LocalFileSyncServiceTest.LocalChangeObserver\*
TBR=tzik@chromium.org
Original review: http://codereview.chromium.org/11365032/
Review URL: https://codereview.chromium.org/11362080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a bit awkward as the sync/change status is kept on IO thread while changes are recorded on FILE thread, but should work.
BUG=156599
TEST=LocalFileSyncServiceTest.LocalChangeObserver\*
Review URL: https://codereview.chromium.org/11365032
TBR=kinuko@chromium.org
Review URL: https://codereview.chromium.org/11312060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a bit awkward as the sync/change status is kept on IO thread while changes are recorded on FILE thread, but should work.
BUG=156599
TEST=LocalFileSyncServiceTest.LocalChangeObserver\*
Review URL: https://codereview.chromium.org/11365032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change includes:
- record changes with time-based sequence numbers (as well as changestamps) so that we can mildly prioritize older changes for local sync
- add GetNextChangedURLs() which returns changes in last-modified-time order
- cleanup some existing methods in LocalFileChangeTracker
- fix destruction order
BUG=156599
TEST=LocalFileChangeTrackerTest.Changes, LocalFileChangeTrackerTest.NextChangedURLs*
Review URL: https://codereview.chromium.org/11362026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=156599
TEST=LocalFileSyncServiceTest.*
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11339045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158732
TEST=none
Review URL: https://codereview.chromium.org/11275071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158490
TEST=SyncableFileSystemUtilTest.SerializeBeforeOpenFileSystem
Review URL: https://codereview.chromium.org/11342036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add necessary std includes
- TODO: -> TODO(user):
- fix indentation / spacing / empty lines
- avoid unnamed parameters
- avoid non-recommended functions
BUG=none
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/11343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=158026,157867
TEST=LocalFileSyncContextTest.*
TEST=tests for LocalFileSyncService should also come later
Review URL: https://codereview.chromium.org/11305003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a preparation to fix issue 157867 (return file type from
PrepareForProcessRemoteChange)
BUG=158026
TEST=existing tests
Review URL: https://codereview.chromium.org/11304002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=156599
TEST=LocalFileSyncContext.ApplyRemoteChangeForAddOrUpdate
Review URL: https://codereview.chromium.org/11264038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=156599
TEST=LocalFileSyncContextTest.ApplyRemoteChangeForDeletion
Review URL: https://chromiumcodereview.appspot.com/11263012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding LocalFileSyncContext::PrepareForSync method which disables writing on the given URL (the design is roughly based on the skeleton http://codereview.chromium.org/11234025/)
BUG=148897,154234
TEST=LocalFileSyncContextTest.*
Review URL: https://codereview.chromium.org/11235027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157789
TEST=SyncableFileSystemTest.SyncableLocalSandboxCombined
Review URL: https://codereview.chromium.org/11266031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157788
TEST=none
Review URL: https://codereview.chromium.org/11264030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runner
Original review: https://chromiumcodereview.appspot.com/11238054
1st submit (http://crrev.com/163584) got reverted because it broke win_aura/win7 bots.
* Slightly changing ownership relationship: now LocalFileSyncContext owns both SyncableFileOperationRunner and LocalFileSyncStatus (previously SyncContext used to own OperationRunner that owns SyncStatus)
* Adding OnSyncEnabled, OnWriteEnabled notifications to the LocalFileSyncStatus
* Let SyncableFileOperation listen to OnWriteEnabled notification so that it can automatically start write operations (as far as the # of operations is less than the given max)
BUG=148897, 154234
TEST=SyncableFileOperationRunnerTest.*
Review URL: https://codereview.chromium.org/11271003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=156041
Review URL: https://codereview.chromium.org/11187021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=156599,156041
TEST=to be added when we add implementation
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11234025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=157529, 157530
Review URL: https://codereview.chromium.org/11265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operation runner
* Slightly changing ownership relationship: now LocalFileSyncContext owns both SyncableFileOperationRunner and LocalFileSyncStatus (previously SyncContext used to own OperationRunner that owns SyncStatus)
* Adding OnSyncEnabled, OnWriteEnabled notifications to the LocalFileSyncStatus
* Let SyncableFileOperation listen to OnWriteEnabled notification so that it can automatically start write operations (as far as the # of operations is less than the given max)
BUG=148897, 154234
TEST=SyncableFileOperationRunnerTest.*
Review URL: https://chromiumcodereview.appspot.com/11238054
TBR=kinuko@chromium.org
Review URL: https://codereview.chromium.org/11236076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Slightly changing ownership relationship: now LocalFileSyncContext owns both SyncableFileOperationRunner and LocalFileSyncStatus (previously SyncContext used to own OperationRunner that owns SyncStatus)
* Adding OnSyncEnabled, OnWriteEnabled notifications to the LocalFileSyncStatus
* Let SyncableFileOperation listen to OnWriteEnabled notification so that it can automatically start write operations (as far as the # of operations is less than the given max)
BUG=148897, 154234
TEST=SyncableFileOperationRunnerTest.*
Review URL: https://chromiumcodereview.appspot.com/11238054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BlobURLRequestJob's ctor takes FileSystemContext to create FileSystemFileStreamReader.
BUG=141835
TEST=content_unittests --gtest_filter="BlobURLRequestJobTest.*"
TBR=jam@chromium.org for content change
Review URL: https://chromiumcodereview.appspot.com/11103027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163245 0039d316-1c4b-4281-b951-d872f2087c98
|