| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Fix its test to enforce that, and add a test for FileSystemOperation::TouchFile.
BUG=none
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/7685039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
variables in the FileSystemOperation.
BUG=none
TEST=FSO unit tests
Review URL: http://codereview.chromium.org/7685037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=91793
TEST='QuotaFileUtilTest.*'
Review URL: http://codereview.chromium.org/7659010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing test_shell_tests plus a new OFSFU test.
Review URL: http://codereview.chromium.org/7608011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SpecialStoragePolicy.
BUG=NONE
TEST=Existing tests pass: FileSystemDirURLRequestJobTest.*, FileSystemURLRequestJobTest.*, FileSystemContextTest.*, DatabaseTrackerTest.*, QuotaFileUtilTest.*, FileSystemPathManagerTest.*, SandboxMountPointProviderMigrationTest.*
Review URL: http://codereview.chromium.org/7633016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stages:
1. Remove chromium files from leveldb repo. [Done]
2. Put chromium leveldb files in third_party/leveldatabase and leveldb in third_party/leveldatabase/src. Update leveldb references in chrome to use third_party/leveldatabase/src instead of third_party/leveldb. Leave third_party/leveldb so it can be referred to by WebCore.gyp.
3. Change third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp to use third_party/leveldatabase.
4. Delete third_party/leveldb
Eventually: 5. Rename third_party/leveldatabase back to third_party/leveldb
We can't avoid the leveldb-checkout duplication by just changing third_party/leveldb from an unversioned to a versioned directory. Doing so would break everyone's gclient sync update.
BUG=89378
TEST=indexeddb layout and browser tests
Review URL: http://codereview.chromium.org/7522008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7583053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enum types should be named using CamelCase as class and function names,
not using MACRO_STYLE.
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7618037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
quota change
BUG=86556
TEST=no functional change
Review URL: http://codereview.chromium.org/7639011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ObfuscatedFileSystemFileUtil
BUG=91328
TEST='ObfuscatedFileSystemFileUtilTest.*'
Review URL: http://codereview.chromium.org/7540022
TBR=tzik@chromium.org
Review URL: http://codereview.chromium.org/7600022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91328
TEST='ObfuscatedFileSystemFileUtilTest.*'
Review URL: http://codereview.chromium.org/7540022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90996
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/7533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A tiny fallout from issue 7489038
BUG=none
TEST=green bots
Review URL: http://codereview.chromium.org/7511008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some of the test case are moved for pr_time_unittests to time_unittests.
BUG=77962
TEST=base_unittests:TimeTest.*
Review URL: http://codereview.chromium.org/7492063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some of the test case are moved for pr_time_unittests to time_unitests.
BUG=77962
TEST=base_unittests:TimeTest.*
Review URL: http://codereview.chromium.org/7470038
TBR=shinyak@google.com
Review URL: http://codereview.chromium.org/7520021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some of the test case are moved for pr_time_unittests to time_unitests.
BUG=77962
TEST=base_unittests:TimeTest.*
Review URL: http://codereview.chromium.org/7470038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FileSystemQuotaClientTest.*
Review URL: http://codereview.chromium.org/7517008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileUtils.
Based on the discussion at http://codereview.chromium.org/7174002/diff/26001/webkit/fileapi/local_file_system_file_util.h#newcode38, this change
* also reduces dependency between FileUtils,
* enables more flexible stacking of -FileUtils, such as QuotaFileUtil over other -FileUtils, and
* makes -FileUtils symmetry so owner handling for these objects gets unified.
BUG=none
TEST=FileSystemFileUtilTest.*,FileSystemOperationTest.*,FileSystemOperationWriteTest.*,FileSystemQuotaTest.*,FileWriterDelegateTest.*,LocalFileSystemFileUtilTest.*,ObfuscatedFileSystemFileUtil.*,QuotaFileUtil.*,SandboxMountPointProviderTest.*
Review URL: http://codereview.chromium.org/7312023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89841
TEST=FileSystemQuotaClientTest.*,FileSystemQuotaTest.*,FileSystemObfuscatedQuotaTest.*,QuotaFileUtilTest.*
Review URL: http://codereview.chromium.org/7347003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89134
TEST=None
Review URL: http://codereview.chromium.org/7353012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't try to remove FileManagerDialog pointers from the pending list inside the FileMangerDialog destructor. This isn't needed, because dialogs are only "pending" when they are shown, and they are cleaned up in the Close* methods. Doing it results in std::map::erase() releasing a smart-pointer which calls erase() again and tries to release the object again. Memory management hilarity ensues. Also fix a compiler warning that only shows up when I use tcmalloc-related build options.
BUG=chromium-os:17728
TEST=manual, browser_tests FileManagerDialogTest.*
Review URL: http://codereview.chromium.org/7445004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mark those APIs as private and friend existing uses.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7397008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and FileEnumerator::{GetFilesize,GetLastModifiedTime}.
BUG=89134
TEST=None
Review URL: http://codereview.chromium.org/7355013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AsyncOpenFileCallback: fix the issue that file handle is leaked if the file handle arrives after the requester has died.
This change also fixes test_file_system.
BUG=79820
TEST=FileIO/FileRef/FileSystem tests in ppapi_tests: Reload the test page, the test still passes. The output files can be deleted when any of these tests finishes running, no matter the test page is still open or not.
Review URL: http://codereview.chromium.org/7327025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/7384009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/7386004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used
A tiny cleanup.
BUG=none
TEST=green bots
Review URL: http://codereview.chromium.org/7372001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URLRequestContext is basically a collection of pointers to other data structures. This CL makes sure that these pointers are not easily modified after the construction of the URLRequestContext.
BUG=67597
TEST=no
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92511
Review URL: http://codereview.chromium.org/7322010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URLRequestContext is basically a collection of pointers to other data structures. This CL makes sure that these pointers are not easily modified after the construction of the URLRequestContext.
BUG=67597
TEST=no
Review URL: http://codereview.chromium.org/7322010
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/7366005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The URLRequestContext is basically a collection of pointers to other data structures. This CL makes sure that these pointers are not easily modified after the construction of the URLRequestContext.
BUG=67597
TEST=no
Review URL: http://codereview.chromium.org/7322010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that we only do this if a filesystem for a particular origin/type
pair is deleted via QuotaClient::DeleteOriginData
BUG=86087
TEST=manually tested
Review URL: http://codereview.chromium.org/7324053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89147
TEST=QuotaFileUtilTest.*
Review URL: http://codereview.chromium.org/7354016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
usage cache itself.
BUG=86114
TEST=FileSystemQuotaClientTest.*, BrowsingDataFileSystemHelperTest.*
Review URL: http://codereview.chromium.org/7278016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88454
TEST=manually tested
Review URL: http://codereview.chromium.org/7307013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7232040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
underlying *FileUtil.
This change :
* reduces dependency between FileUtils, and
* enables more flexible stacking of FileSystemFileUtil, such as {Obfuscated|Local}FSFU without any quota operation.
BUG=none
TEST=*FileUtilTest.*,FileSystemPathManagerTest.*,SandboxMountPointProvider.*,FileSystem*OperationTest.*,FileWriterDelegateTest.*,FileSystemQuotaTest.*
Review URL: http://codereview.chromium.org/7174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/7256004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7294007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85176,86108
TEST=FileSystemURLRequestJobTest.GetMimeType
Review URL: http://codereview.chromium.org/7031071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=16857,16921
BUG=none
TEST=none
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/7218020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=9299,13805,14203,14284,14459,15435,15897,16023,16614,16773,16819,16820,
16908,16916
BUG=none
TEST=none
R=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7215027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86497
TEST=manual
Review URL: http://codereview.chromium.org/7155031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=62811, we'll suddenly need it. For now
this won't have any effect, as we don't do any escaping of control characters.
BUG=78860
TEST=none; this code can't be triggered yet
Review URL: http://codereview.chromium.org/7193017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86016
TEST=FileSystemQuotaTest.*,FileWriterDelegateTest.*
Review URL: http://codereview.chromium.org/7144013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7149008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28727
Review URL: http://codereview.chromium.org/7146001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=86016
TEST=FileSystemQuotaTest.*
Review URL: http://codereview.chromium.org/6905095
TBR=dmikurube@chromium.org
Review URL: http://codereview.chromium.org/7145024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86016
TEST=FileSystemQuotaTest.*
Review URL: http://codereview.chromium.org/6905095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|