summaryrefslogtreecommitdiffstats
path: root/webkit/glue/chrome_client_impl.h
Commit message (Collapse)AuthorAgeFilesLines
* Appcache related WebKit API additions. With this patch the compile-time flag ↵michaeln@google.com2009-08-121-0/+5
| | | | | | | | | | | | | | | | | | | | | is enabled, but the run-time flag is disabled. 1) Added a new class WebApplicationCacheHost and a factory method on WebKitClient. 2) Provide an implementation of WebCore's ApplicationCachHost class that calls out to chrome thru the new WebKit API. 3) Added new files to gyp and turned on the compile-time ENABLE(OFFLINE_WEB_APPLICATIONS) flag. 4) Turned on the compile-time flag for v8 bindings in build-generated-files.sh 4) Disabled the run-time appliation_cache_enabled settings in the test shell for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/165222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23217 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 5996: Tooltip gets direction from Chrome langauge, not ↵xji@chromium.org2009-07-221-1/+2
| | | | | | | | | | | | | | | | | | | element (or even page) The related webkit bug is https://bugs.webkit.org/show_bug.cgi?id=24187 After webkit passes both the title string and its directionality to its client, Chrome will force the title to be displayed in correct directionality using Unicode Control characters. BUG=http://crbug.com/5996 TEST=In both English Chrome and Hebrew Chrome 1. open the test case in http://crbug.com/5996 comment #1 2. hover over the red span, tooltip should be displayed as RTL in both English Chrome and Hebrew Chrome. 3. hover over the blue span, tooltip should be displayed as LTR in both English Chrome and Hebrew Chrome. Review URL: http://codereview.chromium.org/147240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21266 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo. Also,darin@chromium.org2009-07-141-4/+5
| | | | | | | | | | | | | | | | | | make use of WebPopupMenuInfo from the WebKit API. WebMenuItem remains in webkit/glue for convenience with IPC marshalling and related usage in Chrome. This work is precursor to switching over to using WebWidget from the WebKit API. BUG=16234 TEST=html select drop downs should still work on the mac. try switching languages on news.google.com. R=paul Review URL: http://codereview.chromium.org/155378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20624 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS from 45738 to 45840.dimich@google.com2009-07-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/149575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20589 0039d316-1c4b-4281-b951-d872f2087c98
* Start using WebCursorInfo from the WebKit API. WebCursorInfo is adarin@google.com2009-07-081-3/+6
| | | | | | | | | | | | | | | | lightweight struct containing a description of a cursor that the embedder should render. WebCursor still exists. Instead of WebCursor initializing from a PlatformCursor, it now initializes from a WebCursorInfo. TEST=none BUG=10039 R=jam Review URL: http://codereview.chromium.org/155172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20194 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit to r44123darin@chromium.org2009-05-251-1/+1
| | | | | | | | | | | | | | | | | This required dealing with a few changes in WebKit: 1- ImageBuffer::create() now returns a PassOwnPtr instead of an auto_ptr. 2- ChromeClient::createHTMLParserQuirks() now returns a PassOwnPtr instead of a raw pointer. 3- HTMLFormControlElement::onChange was renamed dispatchFormControlChangeEvent. 4- dom/SelectElement.{h,cpp} were added to the tree. TEST=none R=ukai BUG=none Review URL: http://codereview.chromium.org/115751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the webkit.org build of chromium.levin@chromium.org2009-05-201-0/+4
| | | | | | | | | | | | http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20%28webkit.org%29 This is the same code that was there upstream before these methods became pure virtual. TBR=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16492 0039d316-1c4b-4281-b951-d872f2087c98
* Adds propagation and handling of render-side focus events, for the benefit ↵klink@chromium.org2009-05-201-2/+3
| | | | | | | | of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager. Review URL: http://codereview.chromium.org/115374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
* Revert bug fix because interactive_ui_tests are failing.mbelshe@google.com2009-05-041-10/+0
| | | | | | Review URL: http://codereview.chromium.org/99358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15227 0039d316-1c4b-4281-b951-d872f2087c98
* Defer window.close(), window.resizeTo(), and window.moveTo()mbelshe@google.com2009-05-041-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | actions by posting a task back to the message loop before notifying the RenderWidgetHost to perform these operations. Otherwise, the JS code races with the browser to use the modified window. BUG=http://crbug.com/6377 BUG=http://crbug.com/6192 Also, because window resizing is asynchronous between the renderer and browser, added a renderer-side cache of "pending window rect" to ChromeClientImpl. Before the change, calling setWindowRect() would schedule a call to the RenderViewHost to do the work, but a subsequent call to windowRect() would return the current size, as through the call to setWindowRect() had never happened. We cache a pending size and then schedule a task on the message loop to clear the cached size. This allows javascript which writes and reads the WindowRect sizes to work, and once we come out of JS and return to the message loop, we'll go back to asking the RenderViewHost for the true values. This pending_window_size is my only concern about this patch. It does pass all layout tests, and the ChromeClientImpl code is executed in the test_shell.exe code path. BUG=http://crbug.com/835 TEST=LayoutTests have tests which cover all of these actions. The problem is that we run layout tests using the test_shell, not Chrome. Review URL: http://codereview.chromium.org/101019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15214 0039d316-1c4b-4281-b951-d872f2087c98
* Add empty createHTMLParserQuirks implementation in anticipation of ↵dglazkov@google.com2009-04-301-0/+3
| | | | | | | | | | | | http://trac.webkit.org/changeset/43092. R=levin BUG=10898 TEST=0 Review URL: http://codereview.chromium.org/100227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15000 0039d316-1c4b-4281-b951-d872f2087c98
* Merge WebKit console and load deferrer changes.pfeldman@chromium.org2009-04-281-1/+2
| | | | | | Review URL: http://codereview.chromium.org/99121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-251-3/+0
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of the WebKit popup changes.paulg@google.com2009-04-101-8/+6
| | | | | | | | | | | Implements HTML select popups on Mac OS X as native Cocoa controls. BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/67018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13495 0039d316-1c4b-4281-b951-d872f2087c98
* Callbacks through ChromeClient->RenderView->RenderViewHost for ↵rafaelw@chromium.org2009-04-041-1/+2
| | | | | | | | ContentsDidChangeSize so that extensions can change their toolbar size when the contained contents changes size. Review URL: http://codereview.chromium.org/56122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13130 0039d316-1c4b-4281-b951-d872f2087c98
* First stage of implementing HTML select popup menus forpaulg@google.com2009-03-241-0/+7
| | | | | | | | | | | | | | | | the Mac test_shell. Once the changes to WebKit/WebCore/platform/chromium/PopupMenuChromium* have been upstreamed (then landed in our tree), we can enable them in test_shell. The WebKit part is contained in this bug: https://bugs.webkit.org/show_bug.cgi?id=24692 BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/48149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12382 0039d316-1c4b-4281-b951-d872f2087c98
* Retrying previous changelist. I can't get this to fail finnur@google.com2009-02-091-7/+6
| | | | | | | | | | | locally so I am checking this in again and debugging live. TBR=nsylvain (already reviewed by mbelshe) Review URL: http://codereview.chromium.org/21175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9398 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9366.finnur@google.com2009-02-071-6/+7
| | | | | | | Reverting due to failures in layout tests Review URL: http://codereview.chromium.org/21159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9374 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing that callback required to passfinnur@google.com2009-02-071-7/+6
| | | | | | | | | | | | | LayoutTest/fast/dom/assign-to-window-status.html which is testing whether we can assign values to window.status. BUG=1143492 Review URL: http://codereview.chromium.org/21147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9366 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in webkit/glue/phajdan.jr@chromium.org2009-02-031-1/+1
| | | | | | | | | | | - make more methods const - remove unneeded #includes BUG=7210 Review URL: http://codereview.chromium.org/19535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9080 0039d316-1c4b-4281-b951-d872f2087c98
* The popup for autofill is now never activated, even when clicked.jcampan@chromium.org2009-01-091-1/+1
| | | | | | | | | | | | | This allows us to hide it when the page loses focus. (doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer). Most of the file changes are just renaming focus_on_show to activatable. TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well. BUG=3844,5830 Review URL: http://codereview.chromium.org/17455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for custom cursors set by windowless plugins. Windowless plugins ↵ananta@chromium.org2009-01-091-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | typically set the cursor in NPP_HandleEvent for WM_MOUSEMOVE.The current implementation looks for the cursor type and if the typedoes not match predefinedcursor types defaults to the pointer cursor. The fixes are as below:- 1. Marshal the HCURSOR after copying it to ensure that it remains valid. This works as a HCURSOR is a user object and can be used across processes. Ideally we would like to convert it to a skia bitmap but there are issues with converting monochrome cursors. 2. Added support for marshaling platform specific data in the webcursor Serialize/Deserialize functions. This is in the form of functions like InitPlatformData, SerializePlatformData, DeserializePlatformData, etc. which are stubbed out for the other platforms. 3. Mimic webkit windowless plugin behavior where it sets a flag to ignore the next setCursor after HandleEvent of WM_MOUSEMOVE. If we don't do this the cursor keeps changing between a pointerCursor and the cursor set by the plugin which also causes flicker. 4. Fixed the WebCursor::IsEqual function to ensure that it checks all fields for equality. 5. The browser(RenderWidgetHostViewWin) now maintains a WebCursor instance representing the current cursor. Any cursor updates received from the renderer update the current cursor member maintained by the browser. 6. We intercept the SetCursor API for windowless plugins like Flash and Silverlight and remember the cursor being set. We don't invoke the original API as the browser UI thread would do it anyways. This fixes the annoying cursor flicker caused by the windowless flash plugin instance constantly setting the cursor even when the tab is not visible. This fixes bug http://code.google.com/p/chromium/issues/detail?id=3800. Review URL: http://codereview.chromium.org/15088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7798 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 39606:39660dimich@google.com2009-01-071-0/+1
| | | | | | Review URL: http://codereview.chromium.org/17239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7684 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the render widget unittest so it can be reused to create a render viewbrettw@chromium.org2009-01-051-2/+1
| | | | | | | | | | | | | | | | | unit test. Change the mock render thread to save all IPC messages it is asked to send so that tests can verify that the correct ones were sent. There are some new functions that support this checking. Plumb the form state change notification through the render view so that we will correctly update the form state to the browser. Write two RenderView unit tests. One arbitrarily tests OnLoadAlternateHTMLText which I used as a testcase for my testing framework. The other tests the above form state change notification. I had to expose the timeout of this message through the RenderView API so that the test can change it. Review URL: http://codereview.chromium.org/16482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7549 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 39143:39309, Part 8 (port side)dglazkov@google.com2008-12-161-0/+3
| | | | | | Review URL: http://codereview.chromium.org/14140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7040 0039d316-1c4b-4281-b951-d872f2087c98
* Change old code from "unloadListnerChanged" model to new WebKit ↵erikkay@google.com2008-11-101-0/+3
| | | | | | | | | | | EnableSuddenTermination, unforking a bunch of code. BUG=http://crbug.com/4064 Review URL: http://codereview.chromium.org/9746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 37604:38097 mergedglazkov@google.com2008-11-101-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5110 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this again as I cannot reproduce the perf regression locally.jcampan@chromium.org2008-11-071-1/+2
| | | | | | | | | | | Will investigate on the bot. TBR=nsylvain Review URL: http://codereview.chromium.org/9700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the autofill popu CL as it creates perf regression.jcampan@chromium.org2008-11-061-6/+5
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/9460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate CursorChromium's dependency on webkit/glue.darin@chromium.org2008-11-061-3/+8
| | | | | | | | | | | Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge. The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner. R=iyengar,eseidel Review URL: http://codereview.chromium.org/9072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds the autofill UI in forms.jcampan@chromium.org2008-11-051-1/+2
| | | | | | | | | | | | When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup. Listeners are set on the form text field in a similar fashion than for password save. The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows. The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown. Review URL: http://codereview.chromium.org/8885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 36102:37604 merge on trunkdglazkov@google.com2008-10-301-10/+22
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4222 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MSVC pragmas with the macro. Also adds two filestc@google.com2008-10-161-2/+4
| | | | | | | | | | | | from webkit/glue to the build rule. Patch from icefox (TorchMobile) http://codereview.chromium.org/7418 Review URL: http://codereview.chromium.org/7454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
* Move many files that were suffixed Win.cpp to Chromium.cpp, and place them ↵darin@chromium.org2008-10-151-2/+2
| | | | | | | | | | | in chromium/ subdirectories. We still build these files with PLATFORM(WIN) defined. In this change, I also killed off LogWin.{h,cpp} since we don't use it. So, you will see some changes related to that. R=dglazkov,tony Review URL: http://codereview.chromium.org/7419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3427 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit to the repository.initial.commit2008-07-271-0/+137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 19:19:53 +0000