| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 8d410ce0aae7acbbcd816425ba49e79d8d7b9a1d.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 24e3962db61243eea4976bead441c6206cd4f21e.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required moving some code from webkit/glue to
chrome/common/web_apps.cc so that it could rely on
chrome/common/json_schema_validator.h.
BUG=49233
TEST=Convered by unit tests.
Review URL: http://codereview.chromium.org/4979003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/5004002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=All tests should pass. Autocomplete/autofill should still work.
Review URL: http://codereview.chromium.org/4231001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles everywhere
Review URL: http://codereview.chromium.org/3748004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes input element |setValue()| call sites to respect the input element's maxlength attribute.
BUG=56378, 45831
TEST=Manual test as per bug 45831, and PasswordManagerAutocompleteTests.TestValidValueConditions
Review URL: http://codereview.chromium.org/3615008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 27ea47d65cf8767f350113d5ad9e25170efde811 (r61237).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebInputElement::inputType is deprecated because
HTMLInputElement::inputType is deprecated. We should stop using it
and use is<Type>() functions.
BUG=webkit.org/b/45872
TEST=none; no functional changes.
Review URL: http://codereview.chromium.org/3421023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3366011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also IsPageTranslatable was moved to TranslateHelper as it is where it belongs.
BUG=51454
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/3236008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, anyone who included tab_contents.h would bring in a bunch of
implementation details of the password manager from webkit_glue. This breaks
the delegate interface out of the rest of password manager system and makes
FillData not an inner-class so anyone can forward declare FillData instead of
having to include the header to meet a delegate interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2877022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
using the magic Google meta-tag.
BUG=48606
TEST=See bug.
Review URL: http://codereview.chromium.org/2960001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also some clean-up of the PasswordManagerAutocompleteTests.
Original review: http://codereview.chromium.org/2711010
BUG=46231
TEST=See bug.
Review URL: http://codereview.chromium.org/2812001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
STLDeleteElements function is already in base/stl_util-inl.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2752001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
longer called by WebKit.
R=jhawkins
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1995002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26416
TEST=PasswordManagerAutocompleteTests::OnBlur
Review URL: http://codereview.chromium.org/1856004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
store field data in FormData instead of storing the field data separately in the struct.
BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/847002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
|submit|, so this is essentially dead code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not used anymore.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/657059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Accept "link" element of both "icon" and "shortcut icon" type.
see also:
http://en.wikipedia.org/wiki/Favicon
http://dev.w3.org/html5/spec/Overview.html#rel-icon
- Get complete url from icon link's href;
BUG=none
TEST=Create web app shortcut to "Google Reader" and expect to see crispy clear icon rather than the blur favicon.
Review URL: http://codereview.chromium.org/611008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for deleting that file.
R=dglazkov
BUG=24607
TEST=none
Review URL: http://codereview.chromium.org/551012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch completes http://codereview.chromium.org/503082/show and corresponds with https://bugs.webkit.org/show_bug.cgi?id=32870.
Review URL: http://codereview.chromium.org/505070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Animation operations will be done in a subsequent patch.
Corresponds with upstream changes: https://bugs.webkit.org/show_bug.cgi?id=32866
Review URL: http://codereview.chromium.org/503082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See corresponding changes in webkit here: https://bugs.webkit.org/show_bug.cgi?id=31737
Review URL: http://codereview.chromium.org/434087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mega patch contains a few simple but tightly dependent changes:
1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org.
2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion.
3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp.
4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch.
Review URL: http://codereview.chromium.org/387020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Copy of: http://codereview.chromium.org/360013/show
Head to create as new patch due to messy merge.
Review URL: http://codereview.chromium.org/376017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/api/src.
R=yaar
BUG=25896,25897,25902
TEST=none
Review URL: http://codereview.chromium.org/341030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes accommodate fixing up HTMLAllCollection refactoring
upstream: http://trac.webkit.org/changeset/49998
TBR=tony
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/330011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the password form fill data structures and related classes.
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/304013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch scoped_ptr to OwnPtr.
Switch base::RefCounted to WTF::RefCounted.
Switch string16/wstring to WebCore::String
Switch DCHECK to ASSERT.
Switch from Chromium #ifdefs to WebKit #ifdefs for ports.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
src/DOMUtilities
Review URL: http://codereview.chromium.org/287010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
No live code path uses it.
Review URL: http://codereview.chromium.org/273068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/293001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome-extension URLs. In the absence of any API for doing file I/O this adds
very useful functionality to chrome extensions. This patch is needed to allow
APU to save its instrumentation data to disk without the need for a plugin.
patch by: Jaime Yap (jaimeyap@google.com)
BUG=none
TEST=Bundle a page "foo.html" with an extension. Usings the tabs API or
window.open, open "foo.html" in the extensions process. Try to save it
using CTRL+S. (You can test with any of the existing samples that bundle
a page).
Review URL: http://codereview.chromium.org/266051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll re-order the methods in webview_impl.cc in a follow-up CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Originally reviewed here: http://codereview.chromium.org/251051
Review URL: http://codereview.chromium.org/255042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not completely eliminate webkit/glue/webview.h. Instead,
the old WebView extends from the new WebView temporarily as we complete
the transition.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/257001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47907 where KURL no longer has
a single argument constructor.
TBR=brettw@chromium.org,michaeln@chromium.org
TEST=try server
BUG=none
Review URL: http://codereview.chromium.org/180049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and instead accesses the attributes directly.
BUG=none
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/172053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tried to avoid unnecessary changes in this CL to help make it easier to
review.
As part of this CL, glue/webtextinput* are folded into WebFrame / WebFrameImpl.
R=dglazkov
BUG=10034
TEST=none
Review URL: http://codereview.chromium.org/164225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required dealing with a few changes in WebKit:
1- ImageBuffer::create() now returns a PassOwnPtr instead of an auto_ptr.
2- ChromeClient::createHTMLParserQuirks() now returns a PassOwnPtr instead of a raw pointer.
3- HTMLFormControlElement::onChange was renamed dispatchFormControlChangeEvent.
4- dom/SelectElement.{h,cpp} were added to the tree.
TEST=none
R=ukai
BUG=none
Review URL: http://codereview.chromium.org/115751
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the code triggering this was just checking that the focused element before and after processing the event was the same.
We need to do a hit test to ensure the click is really on the text field, otherwise in cases where clicking somewhere in the page does not change the focus, we would bogusly bring up the autofill popup.
BUG=8627
TEST=Ensure autocomplete popup still works as expected: when entering text, when using up/down arrows, when clicking selected text field. Also ensures the scenario from the bug does not trigger the popup.
Review URL: http://codereview.chromium.org/50038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- created dom_operations_private.h for things that mention WebCore types
that are only needed within webkit/glue.
- moved contents of webkit_glue.h to the right locations.
- moved FilePath::StringType <-> WebString conversion out of glue_util
into webkit_glue since it is part of the public API.
- minimized includes in webkit_glue.h
R=dglazkov
Review URL: http://codereview.chromium.org/27351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10664 0039d316-1c4b-4281-b951-d872f2087c98
|