summaryrefslogtreecommitdiffstats
path: root/webkit/glue/editor_client_impl.h
Commit message (Collapse)AuthorAgeFilesLines
* Move glue/EditorClientImpl.h/cpp to webkit/api/srcyaar@chromium.org2009-10-271-187/+0
| | | | | | Review URL: http://codereview.chromium.org/330021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30270 0039d316-1c4b-4281-b951-d872f2087c98
* Fold WebEditingClient into WebViewClient.darin@chromium.org2009-09-181-7/+2
| | | | | | | | | | R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/211032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup to various WebCore client implementations.darin@chromium.org2009-09-051-26/+28
| | | | | | | | | | | | | | Replaced usage of MessageLoop in EditorClientImpl with WebCore::Timer. Changed the clients to be instance variables of WebViewImpl instead of being separately heap allocated. This cleaned up some of the lifetime issues. R=dglazkov Review URL: http://codereview.chromium.org/198030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25573 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebEditingClient.darin@chromium.org2009-09-041-17/+9
| | | | | | | | | | | | | | | | | | | | Moves the WebViewDelegate parameter back to WebView::Create and adds a second parameter for WebEditingClient. I had hoped to make the WebEditingClient NULL for RenderView on Windows and Mac, but that turned out to not be an option. I need a few methods on all platforms. The Describe* functions from EditorClientImpl are moved into the TestWebViewDelegate since they are only applicable to layout tests. R=dglazkov BUG= TEST=none Review URL: http://codereview.chromium.org/195008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25432 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill dropdown support for password forms.tim@chromium.org2009-07-141-1/+8
| | | | | | | | BUG=5406 Review URL: http://codereview.chromium.org/155399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20585 0039d316-1c4b-4281-b951-d872f2087c98
* The autofilling of passwords when the URL for visited page and the page the ↵jcampan@chromium.org2009-05-261-1/+1
| | | | | | | | | | | | | password was stored are different was broken. This happened as part as some refactoring done for the form autofill last year. BUG=12675 TEST=See bug. Review URL: http://codereview.chromium.org/113853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16950 0039d316-1c4b-4281-b951-d872f2087c98
* Add Automatic spell correction support in Chrome.sidchat@google.com2009-05-121-0/+2
| | | | | | | Issue=7624 Review URL: http://codereview.chromium.org/42608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15888 0039d316-1c4b-4281-b951-d872f2087c98
* One of my recent CL added triggering form autofill when clicking an already ↵jcampan@chromium.org2009-04-091-5/+10
| | | | | | | | | | | | focused text-field. It was triggering form autofill or password autofill indiscriminately, causing a regression: double clicking a login text-field would trigger password autofill preventing the expected behavior of selecting the text in the text-field. Only form autofill is expected to be triggered in that case. BUG=9544 TEST=Open a page with a login form for which you have saved a password. Double-click the login text-field, this should select all the text. Ensure the form autocomplete still works as expected. Review URL: http://codereview.chromium.org/62143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13408 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the behavior of the form autofill popup.jcampan@chromium.org2009-03-271-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are 3 ways to bring up the form autofill: 1 - start typing some text in a form text field 2 - press key down/up when the focus is on a form text field 3 - click an already focused form text field In all these cases, our current behavior is to show the form autofill only if the caret is at the end of the text field. Other browsers' behavior: IE shows the autofill popup in all 3 cases regardless of the caret position FF shows the autofill popup regardless of the caret position for case 2 and 3 but not 1. Safari never shows an autofill popup for cases 2 and 3, it shows the autofill popup for case 1 only if the caret is at the end. This CL changes our behavior to be like FF. Also this CL now lets the default processing of key up/down events happen in the case where we are showing an autofill. We were preventing default handling as it moves the caret. Since were showing the autofill in a posted task and we would check that the caret was at the end, this would prevent the autofill from showing. Now that we don't enforce the caret at the end condition with key up/down presses, we can let the default handling move the caret. BUG=6437 TEST=See description of 3 scenarios above. Make sure our behavior matches FF's. Also test that password autocomplete still works. Review URL: http://codereview.chromium.org/45067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12681 0039d316-1c4b-4281-b951-d872f2087c98
* When in a form text field, pressing the up/down arrow keys should bring up ↵jcampan@chromium.org2009-03-251-2/+6
| | | | | | | | | | | | | | | | | | | | the autofill popup. Pressing up would not trigger that behavior. This happened because the default processing of the up arrow key is to move the caret to the beginning of the text input. Showing the autofill is done as a posted task. Because the caret was not at the end of the text-field by the time that task got executed, the popup would not show. The fix is to not default process the up/down arrow key messages when an autofill popup will be shown. Also fixed the WebViewImpl::HideAutoCompletePopup (harmless bug, calling it twice would cause it to hide the already hidden popup). BUG=6437 TEST=Make sure up/down arrow keys trigger the autofill menu correctly (especially when there is already text in the text-field). Make sure autofill still works as expected. Review URL: http://codereview.chromium.org/53017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12428 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side of moving webkit/glue/cache_manager.{h,cc} to the WebKit API layer.darin@chromium.org2009-03-191-7/+3
| | | | | | | | | | | | | | This also includes a change to not have third_party/WebKit/WebKit/chromium/public in the global include path. Most of the code changes pertain to this. I also took this opportunity to do some renaming: browser/cache_manager_host -> browser/renderer_host/web_cache_manager R=brettw Review URL: http://codereview.chromium.org/42194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12085 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-111-1/+0
| | | | | | | | | Normalize end of file newlines in webkit/. All files end in a single newline. Review URL: http://codereview.chromium.org/42070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11443 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-051-7/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* We now show the form autofill when the user does any of these on a focused ↵jcampan@chromium.org2008-12-181-1/+18
| | | | | | | | | | | | | | | empty text-field: - presses the up/down arrow key - left-clicks it The other browsers have that feature. BUG=5130 TEST=See bug. Review URL: http://codereview.chromium.org/14852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7269 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Enable spell check for this field" menu option in sub context menu for ↵sidchat@google.com2008-12-151-0/+18
| | | | | | | | context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields. Review URL: http://codereview.chromium.org/13731 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7000 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webkit merge 38729:38760ojan@google.com2008-12-011-0/+1
| | | | | | Review URL: http://codereview.chromium.org/13028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6183 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the new autofill.jcampan@chromium.org2008-11-201-10/+11
| | | | | | | | | I rolled it back yesterday, it broke the Linux and Mac builds. TBR=tim Review URL: http://codereview.chromium.org/11543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5796 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/11306jcampan@chromium.org2008-11-201-11/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5747 0039d316-1c4b-4281-b951-d872f2087c98
* A new implementation of the autofill using the editor client API.jcampan@chromium.org2008-11-201-10/+11
| | | | | | | | | | | | | | This simplifies code as we don't need to listen for events on input elements, the editor client API is only triggered when the text changes. The only quirk we have to work around is that when the editor client API notifies us that the text has changed, the selection is not set properly, preventing us from reliably finding out if the caret is at the end of the text. To work around that issue, we post a task that does the autofill after the text change callback. BUG=None TEST=Trigger the autofill behavior with form and passwords. Review URL: http://codereview.chromium.org/11479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5742 0039d316-1c4b-4281-b951-d872f2087c98
* Take PLATFORM_MAC stuff out of editor_client_implmark@chromium.org2008-10-221-8/+0
| | | | | | Review URL: http://codereview.chromium.org/8084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3795 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MSVC pragmas with the macro. Also adds two filestc@google.com2008-10-161-2/+4
| | | | | | | | | | | | from webkit/glue to the build rule. Patch from icefox (TorchMobile) http://codereview.chromium.org/7418 Review URL: http://codereview.chromium.org/7454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the chrome_webkit_merge_branch back on to trunk. This brings ustc@google.com2008-10-011-1/+1
| | | | | | | up to webkit@36102. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2778 0039d316-1c4b-4281-b951-d872f2087c98
* fix platform differences in editor client, make compile on non-windowspinkerton@google.com2008-09-091-0/+10
| | | | | | Review URL: http://codereview.chromium.org/1852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1916 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit to the repository.initial.commit2008-07-271-0/+164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 14:33:31 +0000