summaryrefslogtreecommitdiffstats
path: root/webkit/glue/form_field.h
Commit message (Collapse)AuthorAgeFilesLines
* Make FormField be a struct rather than a class per c++ standards.tsepez@chromium.org2011-03-081-35/+8
| | | | | | | | | | | This makes automatic generation of IPC messages much easier. Convert autofill messsage to automatic generation in the process. Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001 for original CL. Review URL: http://codereview.chromium.org/6625087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77296 - zea@chromium.org2011-03-081-8/+35
| | | | | | | | | | | | | | | Convert autofill messages to use the new IPC macros. This requires changing the FormField class to a struct with publically-visible members, which was what should have been done in the first place, instead of the trivial setters/getters which are accessed in various combinations independently of each other throughout the code. Review URL: http://codereview.chromium.org/6633001 TBR=tsepez@chromium.org Review URL: http://codereview.chromium.org/6623086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77298 0039d316-1c4b-4281-b951-d872f2087c98
* Convert autofill messages to use the new IPC macros. This requirestsepez@chromium.org2011-03-081-35/+8
| | | | | | | | | | | changing the FormField class to a struct with publically-visible members, which was what should have been done in the first place, instead of the trivial setters/getters which are accessed in various combinations independently of each other throughout the code. Review URL: http://codereview.chromium.org/6633001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77296 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-171-1/+1
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
* Once a form has been partially autofilled, autofill should only update ↵isherman@chromium.org2010-11-291-1/+6
| | | | | | | | | | | fields one at a time. BUG=63437, 62638 TEST=unit_tests --gtest_filter=AutoFillManagerTest.* Review URL: http://codereview.chromium.org/5334005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67599 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill: Prefer maxLength to size attribute for form filling heuristics.isherman@chromium.org2010-11-201-4/+4
| | | | | | | | | BUG=63440 TEST=browser_tests --gtest_filter=FormManagerTest.* Review URL: http://codereview.chromium.org/5137004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66850 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill - "Clear form" failed to clear the select popup valuesdhollowa@chromium.org2010-10-111-1/+1
| | | | | | | | | | | Enhances Autofill "Clear form" functionality to reset select-one input elements to their original values. The initial values are captured during form load and saved in the FormManager cache. BUG=50412 TEST=FormManagerTest.ClearFormWithNodeContainingSelectOne Review URL: http://codereview.chromium.org/3707001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62133 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-051-1/+1
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move code from headers into cc files.erg@google.com2010-08-271-0/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57732 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for: State in small letters should be auto-filled from the profile.jhawkins@chromium.org2010-07-211-0/+11
| | | | | | | | | | | BUG=38222 TEST=in the bug Patch by George Yakovleg <georgey@chromium.org> Review URL: http://codereview.chromium.org/2832064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53234 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill fill billing address when credit card settings specify a billing ↵dhollowa@chromium.org2010-05-191-0/+8
| | | | | | | | | | | | | | | | | | | address. Fixes address type matching in |AddressField::AddressTypeFromText| method. Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences. Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others. BUG=44227 TEST=AddressFieldTest.ParseOneLineAddress, \ AddressFieldTest.ParseOneLineAddressBilling, \ AddressFieldTest.ParseOneLineAddressShipping, \ AutoFillManagerTest.FillCreditCardForm, \ AutoFillManagerTest.FillCreditCardFormWithBilling, \ FormStructureTest.HeuristicsSample8, \ and manual test with everything2.html bug file. Review URL: http://codereview.chromium.org/2078016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47731 0039d316-1c4b-4281-b951-d872f2087c98
* Form AutoFill Phone number should be displayed as xxx-xxx-xxxxdhollowa@chromium.org2010-05-141-1/+5
| | | | | | | | | | | | | | | | | Modifies the AutoFill label inferencing logic to skip over <img> tags when deriving labels. It is common to use small images as spacers between elements. Also, extends the phone number heuristics to recognize numbers that are split into three fields of the form [xxx]-[yyy]-[zzzz] where xxx is the area code, yyy is the phone number prefix and zzz is the phone number suffix. Note: This change has a dependency on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=38825. Will need to wait for that to land before committing this change. BUG=38218 TEST=FormManagerTest.LabelsInferredWithImageTags:FormStructureTest.ThreePartPhoneNumber:PhoneFieldTest.ThreePartPhoneNumber Review URL: http://codereview.chromium.org/1979008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47297 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Handle filling select controls.jhawkins@chromium.org2010-03-271-13/+7
| | | | | | | | | BUG=38222 TEST=none Review URL: http://codereview.chromium.org/1309003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42891 0039d316-1c4b-4281-b951-d872f2087c98
* FormFieldValues -> FormData consolidation: Use webkit_glue::FormField to ↵jhawkins@chromium.org2010-03-151-2/+6
| | | | | | | | | | store field data in FormData instead of storing the field data separately in the struct. BUG=33032 TEST=none Review URL: http://codereview.chromium.org/847002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41658 0039d316-1c4b-4281-b951-d872f2087c98
* Send suggestions from the AutoFillManager to the AutoFillSuggestionsPopup in ↵jhawkins@chromium.org2010-02-181-0/+10
| | | | | | | | | | WebKit. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/627005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39310 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r38570. The underlying bug has been fix.jhawkins@chromium.org2010-02-111-4/+9
| | | | | | | | | | | Move conditions of FormField creation to FormFieldHistoryManager; AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. TBR=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38711 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move conditions of FormFields creation to FormFieldHistoryManager;tony@chromium.org2010-02-101-9/+4
| | | | | | | | | | | | | AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data." This reverts commit r38570. TBR=jhawkins Review URL: http://codereview.chromium.org/602014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38573 0039d316-1c4b-4281-b951-d872f2087c98
* Move conditions of FormFields creation to FormFieldHistoryManager; AutoFill ↵jhawkins@chromium.org2010-02-101-4/+9
| | | | | | | | | | does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. BUG=none TEST=none Review URL: http://codereview.chromium.org/602008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38570 0039d316-1c4b-4281-b951-d872f2087c98
* Add a label member to the FormField class. This member will hold the value ↵jhawkins@chromium.org2009-11-231-1/+4
| | | | | | | | | | of the field's label once we parse this value from the DOM. BUG=none TEST=none Review URL: http://codereview.chromium.org/418032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32834 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormStructure and an initial method, EncodeUploadRequest. This ↵jhawkins@chromium.org2009-11-041-0/+3
| | | | | | | | | | also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/355003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the element_ member of FormField, as we don't use it and shouldn't be ↵jhawkins@chromium.org2009-10-291-11/+1
| | | | | | | | | | using WebCore internals in glue anyway. BUG=none TEST=none Review URL: http://codereview.chromium.org/342032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98
* Break out FormFieldValues::Element into FormField, which will eventually ↵jhawkins@chromium.org2009-10-231-0/+41
hold more autofill data about each form field. BUG=none TEST=none Review URL: http://codereview.chromium.org/306061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29913 0039d316-1c4b-4281-b951-d872f2087c98