summaryrefslogtreecommitdiffstats
path: root/webkit/glue/inspector_client_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move a bunch of files into webkit/api/srcdarin@chromium.org2009-10-271-231/+0
| | | | | | | | | | R=yaar BUG=25898,25899,25900,25901, TEST=none Review URL: http://codereview.chromium.org/338041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30232 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in webkit/glue to remove some dependencies.darin@chromium.org2009-10-221-18/+9
| | | | | | | | | | | | | | | | Switch scoped_ptr to OwnPtr. Switch base::RefCounted to WTF::RefCounted. Switch string16/wstring to WebCore::String Switch DCHECK to ASSERT. Switch from Chromium #ifdefs to WebKit #ifdefs for ports. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/292042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29779 0039d316-1c4b-4281-b951-d872f2087c98
* Delete glue/webview{_delegate}.hdarin@chromium.org2009-10-191-0/+1
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/293001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup. Use WebViewClient instead of WebViewDelegatedarin@chromium.org2009-10-121-2/+2
| | | | | | | | | | | | at some callsites. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/269052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28717 0039d316-1c4b-4281-b951-d872f2087c98
* More WebView / WebViewDelegate cleanup.darin@chromium.org2009-10-031-4/+6
| | | | | | | | | | | | Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient, replacing many WebViewDelegate methods.darin@chromium.org2009-09-101-2/+2
| | | | | | | | | | | | | | | | | | | Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none Review URL: http://codereview.chromium.org/200054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup to various WebCore client implementations.darin@chromium.org2009-09-051-23/+23
| | | | | | | | | | | | | | Replaced usage of MessageLoop in EditorClientImpl with WebCore::Timer. Changed the clients to be instance variables of WebViewImpl instead of being separately heap allocated. This cleaned up some of the lifetime issues. R=dglazkov Review URL: http://codereview.chromium.org/198030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25573 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove an assertion in InspectorControllerClient that fails on ↵yurys@google.com2009-09-011-1/+0
| | | | | | | | test_shell close. Review URL: http://codereview.chromium.org/175049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25052 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: call InspectorController.close on detach to remove DOM listeners ↵yurys@google.com2009-08-281-74/+10
| | | | | | | | | set by the DOM agent. BUG=20482 Review URL: http://codereview.chromium.org/182009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24728 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webview's dependency on webpreferences.jorlow@chromium.org2009-08-171-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/165513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23589 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to WebFrame from the WebKit API.darin@chromium.org2009-08-101-1/+1
| | | | | | | | | | | | | | | I tried to avoid unnecessary changes in this CL to help make it easier to review. As part of this CL, glue/webtextinput* are folded into WebFrame / WebFrameImpl. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/164225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22896 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 46536:46570ukai@chromium.org2009-07-301-0/+4
| | | | | | | | | | | | | | | | | | | | | webkit 46548 adds new layout tests LayoutTests/http/tests/loadig/redirect-methods.html webkit 46558 adds new pure virtual method InspectorClient::inspectorWindowObjectCleared() Added it as NOTIMPLEMENTED() in WebInspectorClient. webkit 46561 adds new layout tests LayoutTests/fast/lists/ol-start-parting.html webkit 46567 fixed /editing/style/remove-underline-{from-stylesheet,in-bold}. TBR=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/159624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22039 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20855.darin@chromium.org2009-07-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20859 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20854.darin@chromium.org2009-07-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWidget from the WebKit API. This change also makesdarin@chromium.org2009-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of WebKitClient (replacing WebWidgetDelegate from glue). The ripple effects of this change are rather large, but most of the impact is mechanical. The more interesting changes include: 1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't matter at all to RenderWidget or RenderView, but it did cause some changes to be made to TestWebViewDelegate. Now, it is not possible to share a delegate implementation for both the WebView and a popup menu, so I have a second instance of the delegate owned by TestShell for use with popup menus. 2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting to be a pretty large change, so I stopped short of deleting WindowOpenDisposition. That way the Chrome side can remain mostly unmodified. I then added a mapping function to convert from WebNavigationPolicy to WindowOpenDisposition. 3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and there is now an enum to specify the composition command (WebCompositionCommand). 4- I added IPC serialization for WebCompositionCommand and WebTextDirection, which cleaned up some code that was just using ints in IPC messages. R=jam BUG=16234 TEST=none Review URL: http://codereview.chromium.org/149620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Nuke legacy debugger.pfeldman@chromium.org2009-06-241-1/+0
| | | | | | Review URL: http://codereview.chromium.org/146027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from webkit/glue that have been made obsolete by correspondingdarin@chromium.org2009-06-181-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | files in webkit/api. Here's the mapping: webkit/glue/webdatasource.h -> webkit/api/public/WebDataSource.h webkit/glue/weberror.h -> webkit/api/public/WebURLError.h webkit/glue/weburlrequest.h -> webkit/api/public/WebURLRequest.h webkit/glue/webresponse.h -> webkit/api/public/WebURLResponse.h I kept the implementation of WebDataSource in webkit/glue for now because it helps to have it close to WebFrameImpl and WebFrameLoaderClient. To facilitate this change, I needed to make use of WrappedResourceRequest and WrappedResourceResponse from webkit/api/src within the implementation files of webkit/glue. This is only a temporary usage of webkit/api/src from the outside. It will go away when WebFrame, etc. get moved into webkit/api. I modified these wrapper classes to expose the 'bind' function so that I can re-bind a wrapper. This is used in WebDataSourceImpl::request() and related methods to allow the interface to return a const reference to a WebURLRequest and WebURLResponse. The changes here are fairly mechanical. I'm not too happy about the way WebDataSource::redirectChain now works. I would prefer a solution that didn't involve so much copying, but I'm not going to worry about optimizing that now. R=brettw BUG=10041 TEST=none Review URL: http://codereview.chromium.org/126286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18747 0039d316-1c4b-4281-b951-d872f2087c98
* InspectorController::Setting::integerValue() returns a long. Fix format ↵craig.schlenter@chromium.org2009-06-161-1/+1
| | | | | | | | string to match. Review URL: http://codereview.chromium.org/126202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18489 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect parens around a format string call.deanm@chromium.org2009-06-041-1/+1
| | | | | | | | | | I noticed this from a GCC warning: webkit/glue/inspector_client_impl.cc:267: warning: cannot pass objects of non-POD type `class WebCore::String' through `...'; call will abort at runtime Review URL: http://codereview.chromium.org/119166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17625 0039d316-1c4b-4281-b951-d872f2087c98
* Implement InspectorClient's Settings API.pfeldman@chromium.org2009-06-031-5/+101
| | | | | | | | | | | | | | | This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done: - inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC. - There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update. Two things I don't like: 1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option. 2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one? Review URL: http://codereview.chromium.org/119041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17473 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Migrate to InspectorController for network and console events.pfeldman@chromium.org2009-05-271-0/+12
| | | | | | | | | | | | | | - introduced bound object on the agent side; - established remote dispatch of WebInspector calls - using fake InspectorFrontend for serializing events and sending them over the ipc - removed net agents from both sides - moved GetResource stuff to tools agent Assumes following is landed: https://bugs.webkit.org/show_bug.cgi?id=26010 Review URL: http://codereview.chromium.org/113836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16980 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebKit API to src/webkit/api.darin@chromium.org2009-05-101-1/+1
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/113186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15739 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the creator URL for popups up to the browser. We don't yet use this ↵pkasting@chromium.org2009-05-051-1/+1
| | | | | | | | | for anything; it will be used for whitelisting popups by hostname. BUG=11440 Review URL: http://codereview.chromium.org/105004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork Inspector, Chromium side.dglazkov@google.com2009-04-171-1/+2
| | | | | | | | R=darin Review URL: http://codereview.chromium.org/67052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13975 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebPoint, WebRect, and WebSize in more of the gluedarin@chromium.org2009-04-091-2/+6
| | | | | | | | | | | | | | | | | layer interface. This will help when we move those interfaces into the WebKit API. This is a second attempt at r13381, which was already reviewed here: http://codereview.chromium.org/63126 The only change between that CL and this one is in render_view.h, where I needed to change a parameter type from gfx::Rect to WebRect. TBR=dglazkov Review URL: http://codereview.chromium.org/64005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13424 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting dfisher changes 133386 and 13381cpu@google.com2009-04-081-6/+2
| | | | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/58018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13387 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebPoint, WebRect, and WebSize in more of the gluedarin@chromium.org2009-04-081-2/+6
| | | | | | | | | | | layer interface. This will help when we move those interfaces into the WebKit API. R=dglazkov Review URL: http://codereview.chromium.org/63126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13381 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork WebInspector frontend take 2: New DEPS and webkit/...pfeldman@chromium.org2009-03-181-2/+2
| | | | | | Review URL: http://codereview.chromium.org/48132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11967 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the src/webkit part of r11958 since it broke the build.maruel@chromium.org2009-03-181-2/+2
| | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/42332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11960 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork WebInspector frontend.pfeldman@chromium.org2009-03-181-2/+2
| | | | | | Review URL: http://codereview.chromium.org/48063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11958 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code that will not be necessary after ↵ojan@google.com2009-03-031-8/+6
| | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=24307 is fixed. Review URL: http://codereview.chromium.org/27373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10815 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in webkit/glue:darin@chromium.org2009-03-021-0/+1
| | | | | | | | | | | | | | | - created dom_operations_private.h for things that mention WebCore types that are only needed within webkit/glue. - moved contents of webkit_glue.h to the right locations. - moved FilePath::StringType <-> WebString conversion out of glue_util into webkit_glue since it is part of the public API. - minimized includes in webkit_glue.h R=dglazkov Review URL: http://codereview.chromium.org/27351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10747 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused variable that came from r10497 which breaks compile on Linux.jhawkins@chromium.org2009-02-261-1/+0
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/31012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10501 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up inspector highlighting again. This time we useojan@google.com2009-02-261-8/+4
| | | | | | | | | upstream's drawNodeHighlight methods. BUG=5178 Review URL: http://codereview.chromium.org/31010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10497 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of included header files. Vast change like in "Oh God! ↵maruel@chromium.org2009-02-181-0/+1
| | | | | | | | This revision changes half of the source files!". Review URL: http://codereview.chromium.org/20378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9958 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 40847-40875 Chrome side.brettw@chromium.org2009-02-131-0/+5
| | | | | | Review URL: http://codereview.chromium.org/21351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9767 0039d316-1c4b-4281-b951-d872f2087c98
* The WebFrame interface currently supports reference counting, but no one uses.darin@chromium.org2009-02-131-21/+16
| | | | | | | | | | | | | | | | Internally, WebFrameImpl needs reference counting, so we still define it there. Same goes for WebView and WebWidget. While making this change, I noticed that WebInspectorClient was casting WebView pointers to WebViewImpl pointers too much. By just starting with WebViewImpl pointers, things could be cleaned up considerably. R=brettw Review URL: http://codereview.chromium.org/21342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9745 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED() that is obvious and cluttering our debug output.evanm@google.com2008-12-151-1/+0
| | | | | | | Review URL: http://codereview.chromium.org/14109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7009 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 37604:38097 mergedglazkov@google.com2008-11-101-1/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5110 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 36102:37604 merge on trunkdglazkov@google.com2008-10-301-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4222 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MSVC pragmas with the macro. Also adds two filestc@google.com2008-10-161-2/+4
| | | | | | | | | | | | from webkit/glue to the build rule. Patch from icefox (TorchMobile) http://codereview.chromium.org/7418 Review URL: http://codereview.chromium.org/7454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the chrome_webkit_merge_branch back on to trunk. This brings ustc@google.com2008-10-011-0/+4
| | | | | | | up to webkit@36102. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2778 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit to the repository.initial.commit2008-07-271-0/+192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 05:53:46 +0000