summaryrefslogtreecommitdiffstats
path: root/webkit/glue/plugins
Commit message (Collapse)AuthorAgeFilesLines
* Fix FORWARD_NULL errors in plugin test helpers.mattm@chromium.org2009-09-222-9/+27
| | | | | | | | | CID=468,469,470,471,472,473,474 BUG=none Review URL: http://codereview.chromium.org/212041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26796 0039d316-1c4b-4281-b951-d872f2087c98
* Update renderer plugin cache when we load/unload extensions with plugins.mpcomplete@chromium.org2009-09-212-2/+12
| | | | | | | | | BUG=12306 TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests. Review URL: http://codereview.chromium.org/201111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26748 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26724. Caused a couple layout tests to hang.amanda@chromium.org2009-09-216-203/+42
| | | | | | Review URL: http://codereview.chromium.org/214042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26734 0039d316-1c4b-4281-b951-d872f2087c98
* Enable compiler -Werror and -Wall on our webkit code for mac and linux.tony@chromium.org2009-09-212-6/+10
| | | | | | | | | | | | | | | | | This fixes some initialization order, removes unused varibles, and fixes a couple signed/unsigned comparison errors. Please check the signed/unsigned cases. We can't enable it for windows yet because MSVC complains about headers pulled in from WebCore. We'll have to wait until the API is upstreamed. BUG=21140 Review URL: http://codereview.chromium.org/214024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26728 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary Mac plugin whitelist.amanda@chromium.org2009-09-216-42/+203
| | | | | | | | | | | | | Support Mac NPAPI drawing and event model negotiation. Implement a fallback Quickdraw drawing model implementation so that old plugins don't crash. This change does not address keyboard input issues (see issue 19194), just display issues. BUG=12030 TEST=Quickdraw based plugins (such as the QuickTime plugin) should not crash when invoked, and may even display properly. Review URL: http://codereview.chromium.org/211031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26724 0039d316-1c4b-4281-b951-d872f2087c98
* Fix registration of internal plugins broken by rev 23501jam@chromium.org2009-09-181-0/+12
| | | | | | | | | | Due to the plugin_list changes in rev 23501 internal plugins registered via a call to PluginList::RegisterInternalPlugin() are no longer being added to the plugin list when LoadPlugins() is called. Fix the problem by adding the internal plugins in LoadPlugins(). Original change by Marshall Greenblatt <magreenblatt@gmail.com> at http://codereview.chromium.org/173107. Review URL: http://codereview.chromium.org/208026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26595 0039d316-1c4b-4281-b951-d872f2087c98
* Look for the WMP plugin in the directory that it's left in if Firefox isn't ↵jam@chromium.org2009-09-181-0/+22
| | | | | | | | | | installed. BUG=22077 TEST=on a machine without Firefox, install the WMP NPAPI plugin and ensure that Chrome finds it Review URL: http://codereview.chromium.org/214018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26594 0039d316-1c4b-4281-b951-d872f2087c98
* Update NPAPI header file to v24, apply Google modificationsamanda@chromium.org2009-09-181-6/+8
| | | | | | Review URL: http://codereview.chromium.org/208007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26579 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-188-99/+31
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-188-31/+99
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the deadlock when Flash tries to make WMP full screen. This is a ↵jam@chromium.org2009-09-173-13/+19
| | | | | | | | | one-off solution that detects this case and returns the reply to the sync message before calling WMP. I don't think this is a generic problem, since we haven't seen it before, and the generic solutions have too many side-effects. BUG=15985 Review URL: http://codereview.chromium.org/210004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26521 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove a dcheck that is hit with old pluginsevan@chromium.org2009-09-151-3/+2
| | | | | | Review URL: http://codereview.chromium.org/195095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26268 0039d316-1c4b-4281-b951-d872f2087c98
* linux: defend against "netscape" within plugin pathevan@chromium.org2009-09-151-0/+16
| | | | | | | | | | | Flash misbehaves if you load it from a path containing "netscape", so we try to avoid and warn the user if necessary. BUG=20758,21900 Review URL: http://codereview.chromium.org/206009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26265 0039d316-1c4b-4281-b951-d872f2087c98
* linux: raise logging level since INFO doesn't show in Release (?)evan@chromium.org2009-09-151-6/+6
| | | | | | | | Trying to track something down for a user. Review URL: http://codereview.chromium.org/195084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26191 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash in the plugin process specifically in the ↵ananta@chromium.org2009-09-114-4/+28
| | | | | | | | | | | | | | | | | | | | PluginStreamUrl::DidReceiveData function. This crash occurs if the PluginStreamUrl instance is deleted in the context of PluginStream::Write which occurs if the underlying NPP_Write call to the plugin returns a negative value, indicating that the plugin did not accept data. We close the stream in this case which releases existing references to the PluginStream which results in the object being deleted. Added a UI test for this case. Fixes bug http://code.google.com/p/chromium/issues/detail?id=19393 Bug=19393 Review URL: http://codereview.chromium.org/199093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26011 0039d316-1c4b-4281-b951-d872f2087c98
* linux: search Chrome-specific plugin directories before Mozillaevan@chromium.org2009-09-091-8/+14
| | | | | | | | | As discussed in http://groups.google.com/group/chromium-dev/browse_thread/thread/7a70e5fcbac786a9 Review URL: http://codereview.chromium.org/195044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25783 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Mac plugin whitelist to accommodate a new name foramanda@chromium.org2009-09-091-1/+3
| | | | | | | | | the Google Talk voice & video plugin. BUG=none TEST=video chats should work with recent versions of the Google Talk voice and video chat plugin. Review URL: http://codereview.chromium.org/199061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25764 0039d316-1c4b-4281-b951-d872f2087c98
* linux: split MOZ_PLUGIN_PATH on colonsevan@chromium.org2009-09-091-2/+6
| | | | | | | | BUG=20882 Review URL: http://codereview.chromium.org/199053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25698 0039d316-1c4b-4281-b951-d872f2087c98
* linux: rewrite mime parserevan@chromium.org2009-09-093-55/+91
| | | | | | | | | | | This is based on the logic in the Firefox code. It passes existing tests and one new test. TEST=covered by new unit test Review URL: http://codereview.chromium.org/200052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25697 0039d316-1c4b-4281-b951-d872f2087c98
* linux: write a unit test for plugin mime parsingevan@chromium.org2009-09-083-22/+119
| | | | | | | | | | | | | | No significant code change, just preparing to redo the parsing code and thinking I needed test coverage. (Since the parse can fail now, made the parse error out rather than continuing when it's unable to parse some fields. This will have more failure cases in the next version of this code.) Review URL: http://codereview.chromium.org/193046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25678 0039d316-1c4b-4281-b951-d872f2087c98
* Take out the activex control.BUG=20259jam@chromium.org2009-09-086-114/+23
| | | | | | Review URL: http://codereview.chromium.org/200031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25650 0039d316-1c4b-4281-b951-d872f2087c98
* Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set butbenl@chromium.org2009-09-074-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not OS_WIN. Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set. Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX, OS_LINUX or OS_FREEBSD. Added USE_NSS for ... nss (for crypto). Windows and MacOS use platform-specific libraries. All of the above cause slightly odd formulations like: #if defined(OS_WIN) ... #elif defined(USE_BASE_DATA_PACK) ... #endif Possibly should also define USE_DLL_FOR_DATA, etc? Or something? Wrapped various references to struct stat64 and stat64() to use struct stat and stat() for FreeBSD - but a "man stat64" on Linux suggests that we could do the same thing for at least Linux, too, and perhaps eliminate the wrapper? git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
* In prepartion for switching off the activex control, make WMP always use the ↵jam@chromium.org2009-09-052-20/+133
| | | | | | | | | | new UI on XP even if we couldn't update the ShimInclusionList key because of non-admin install. This change patches RegEnumKey, if needed, so that WMP thinks the key contains chrome.exe BUG=20259 Review URL: http://codereview.chromium.org/193024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25566 0039d316-1c4b-4281-b951-d872f2087c98
* This changelist fixes some issues with the NPAPI WMP plugin work in Chrome. ↵jam@chromium.org2009-09-044-17/+67
| | | | | | | | | | | | The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox). The second is to make UpdateGeometry message synchronous for WMP. The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing. While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate. BUG=20259 TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235 Review URL: http://codereview.chromium.org/196012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25433 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 25262. Worked OK in the browser, but blew up TestShell.amanda@chromium.org2009-09-022-20/+147
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/194001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25274 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork shared parts of webplugin_delegate_impl_mac.mm.amanda@chromium.org2009-09-022-147/+20
| | | | | | | | | | | | (Mac side of http://codereview.chromium.org/174479) evan/darin: review, whoever sees it first jam: FYI BUG=none TEST=pages with plugins that worked before this patch should still work after it. Review URL: http://codereview.chromium.org/172116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25262 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate remaining WebCore dependencies from webplugin_impl.ccdarin@chromium.org2009-09-0211-38/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduces WebPluginPageDelegate to hold the methods that only existed on WebViewDelegate to allow WebPluginImpl to talk to the RenderView. This enables us to eliminate those methods from WebViewDelegate, which eliminates the last dependency on gfx/ native_widget_types.h in our WebKit interface! WebViewDelegate grows a CreatePlugin method that returns a WebKit::WebPlugin. It loses its CreatePluginDelegate method, which now lives on WebPluginPageDelegate. This change makes RenderView use WeakPtr when it hands itself to each WebPluginDelegateProxy and WebPluginImpl instance. This makes the memory management simpler. This change also moves various WebPlugin* interfaces defined in webkit/glue into the webkit_glue namespace. This was to help reduce confusion with similarly named types in the WebKit namespace. WebKit::WebPluginParams is added to contain the set of parameters used to construct a plugin. WebPluginContainer gets a couple more methods to allow us to avoid WebCore dependencies in WebPluginImpl. R=jam BUG=10036 TEST=none Review URL: http://codereview.chromium.org/181014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25184 0039d316-1c4b-4281-b951-d872f2087c98
* Linux gcc4.4 fix: stop crashing when loading flash.willchan@chromium.org2009-09-011-3/+4
| | | | | | | | | sizeof(bool) is 1 byte in opt mode. We pass a pointer to a bool to a function expecting a void*. It writes 4 bytes of data to the pointer, rather than 1 byte. This corrupts the stack bordering the bool stack variable, thereby manifesting itself as a crash. In particular, we were overwriting a spilled register (which stored an object pointer) with 3 bytes worth of zeros. After returning from the function, we called into the object, which now had the wrong pointer. BUG=http://crbug.com/20045 Review URL: http://codereview.chromium.org/178046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25003 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix some plugin colormap leaksevan@chromium.org2009-09-011-7/+5
| | | | | | | | | | | | This code was wrong from the start; I know better now. TEST=windowless plugins still draw (I tried in in test_shell) BUG=19238 Review URL: http://codereview.chromium.org/180051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24983 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add a temporary flag for debugging plugin loadingevan@chromium.org2009-08-311-1/+29
| | | | | | | | | We can use this to get more info from users about which plugins we're loading and using. Review URL: http://codereview.chromium.org/178040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24961 0039d316-1c4b-4281-b951-d872f2087c98
* linux: prefer non-nspluginwrapper/crossover pluginsevan@chromium.org2009-08-311-2/+24
| | | | | | | | BUG=18947, various nspluginwrapper-related bugs perhaps Review URL: http://codereview.chromium.org/173617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24910 0039d316-1c4b-4281-b951-d872f2087c98
* linux: scan more plugin directories, fix bugsevan@chromium.org2009-08-271-11/+65
| | | | | | | | | | | | | | | | | | | | | We now scan more directories, sort file entries by mtime, use realpath() before loading plugins (fixes a Java bug), and de-duplicate multiple instances of the same plugin. This matches the Mozilla plugin loading code more closely. We also ignore xpcom-related errors while loading plugins, as that breaks layout tests. I encountered this while attempting to fix QuickTime (need to load the Totem plugins) but the fix overlaps with the Java one. I believe neither quite work yet, though. BUG=16787,19712 TEST=about:plugins should show more plugins Review URL: http://codereview.chromium.org/173550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24691 0039d316-1c4b-4281-b951-d872f2087c98
* More refactoring for WebPlugin.darin@chromium.org2009-08-278-75/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason from WebFrameLoaderClient. This CL also moves WebDataSourceImpl into webkit/api/src. That change was needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it, which WebFrameLoaderClient uses to communicate back to the WebPlugin upon completion of the frame load. WebViewDelegate::DidFinishLoadWithReason is modified to include url and notify_data parameters, eliminating the URLRequestRouted method. This is done so that we can support overlapping NPN_GetURLNotify targetting different frames. WebPluginContainer grows an executeScriptURL method to deal with javascript: URLs. NOTE: I'm working on some UI tests to better cover the case of overlapping NPN_GetURLNotify calls. R=jam BUG=10036 TEST=none yet Review URL: http://codereview.chromium.org/174514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: scan more plugin directories, fix bugs"evan@chromium.org2009-08-271-61/+11
| | | | | | This reverts commit r173550, due to WebKit failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24618 0039d316-1c4b-4281-b951-d872f2087c98
* linux: scan more plugin directories, fix bugsevan@chromium.org2009-08-271-11/+61
| | | | | | | | | | | | | | | | | | We now scan more directories, sort file entries by mtime, use realpath() before loading plugins (fixes a Java bug), and de-duplicate multiple instances of the same plugin. This matches the Mozilla plugin loading code more closely. I encountered this while attempting to fix QuickTime (need to load the Totem plugins) but the fix overlaps with the Java one. I believe neither quite work yet, though. BUG=16787,19712 TEST=about:plugins should show more plugins Review URL: http://codereview.chromium.org/173550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24611 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash caused due to a call to NPP_DestroyStream occuring in the ↵ananta@chromium.org2009-08-275-5/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | context of NPP_NewStream. The plugin would invoke NPN_Evaluate to display an alert in the context of NewStream. This would cause the didFail IPC to be dispatched which would cause the plugin to invoke another call to NPP_NewStream which would repeat these steps and crash. The didFail call from the renderer did not honor the deferred load flag which we set in WebPluginImpl prior to dispatching stream IPCs to the plugin. Fix is to dispatch the didFail call when we receive an ack from the plugin indicating that it is ready to accept stream data. This fixes bug http://code.google.com/p/chromium/issues/detail?id=20063 The other change is in WebPluginImpl::TearDownPluginInstance, where we run through the list of resource clients and cancel them. We call didFail on these clients here, which occurs anyway through the PluginDestroyed code path. Bug=20063 Test=Convered by interactive UI test. Review URL: http://codereview.chromium.org/174383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24593 0039d316-1c4b-4281-b951-d872f2087c98
* Uses FilePath instead of std::wstring in webkit_glue::GetApplicationDirectory.avi@google.com2009-08-271-8/+6
| | | | | | | | | | | | Patch by tfarina. BUG=None TEST=None Review URL: http://codereview.chromium.org/173304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24565 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: unfork WebPluginDelegateImpl between linux/winevan@chromium.org2009-08-265-1508/+45
| | | | | | | | | | | | | | | | | | | | | | Algorithm: - copy win to shared - for each diff between shared and lin, delete/refactor shared - for each diff between shared and lin, delete in lin - for each diff between shared and win, delete in win The change should be mostly deletes. Please verify that I didn't change any behavior on Windows or GTK. Note: coincidentally, this change also fixes a bug that we've seen on Linux that was fixed in the Windows version of the file. I only noticed it because the Windows/Linux files differed, but after this unforking the change is now in the shared code. Mac shouldn't be too hard to do too. Review URL: http://codereview.chromium.org/174479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24404 0039d316-1c4b-4281-b951-d872f2087c98
* Fork webplugin_delegate_impl.cc in anticipation of remerging.evan@chromium.org2009-08-261-0/+1337
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24400 0039d316-1c4b-4281-b951-d872f2087c98
* linux: test plugin for appropriate architecture before loadingevan@chromium.org2009-08-261-0/+44
| | | | | | | | | | | | We'd like to print any dlopen() errors, but opening a 32-bit plugin on a 64-bit system is an avoidable one. This also filters out any Firefox-specific .xpis that may happen to be in the plugin directory. TEST=about:plugins shows same plugins as before, but with less console spew Review URL: http://codereview.chromium.org/174487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24397 0039d316-1c4b-4281-b951-d872f2087c98
* linux: new socket/plug code for windowed pluginspiman@chromium.org2009-08-255-68/+102
| | | | | | | | | | | | | | | | | | | | | | | | This CL reworks the GtkSocket/GtkPlug code for windowed plugins on linux. Instead of having the plugin ask the browser to create a socket to plug into, it simply creates a plug and sends it to the browser. The browser creates a socket and attaches the plug when the socket becomes realized This fixes 2 main issues: - we can create windowed plugins in background tabs (Issue 16125) - we can detach tabs with windowed plugins and reattach them (Issue 17110) I reworked the IPCs, so it removes some amount of linux-specific things. We also need less synchronous IPCs to create/destroy plugins, so that should be a bit faster. In particular, I removed the plugin pid map, and instead made sure the renderer always destroys the plugin containers if the plugin process crashes - they will be destroyed if the renderer process crashes. Let me know if you have an issue with that. Also, the intermediate plug/socket creation now happens in webplugin_delegate_impl_gtk. That means test_shell uses it as well. It made the code a lot simpler, and means we're testing it as well, albeit with a bit of extra overhead. Bonus: I found a big bad bug in the GtkPluginContainer that made its width/height alias with some internal gtk structures. That was certainly causing some amounts of bugs. Bonus 2: scrolling now looks more in sync with the rest of the page, though I'm not exactly sure which part caused that. BUG=16125,17110 TEST=a lot of manual testing involving YouTube videos Review URL: http://codereview.chromium.org/174295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 24266 - This CL ensures that plugins always peek in the context of ↵ananta@chromium.org2009-08-252-10/+2
| | | | | | | | | | | | | | | | | | | | | outgoing sync calls. I will be watching the reliability test runs closely for any crashes which creep in due to reentrancies into plugins caused by this CL. This fixes bug http://code.google.com/p/chromium/issues/detail?id=15985 It is a touch tricky to implement a test case for this. Will add one hopefully in a subsequent CL Bug=15985 Test=Covered by UI test Review URL: http://codereview.chromium.org/173211 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/173384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24296 0039d316-1c4b-4281-b951-d872f2087c98
* This CL ensures that plugins always peek in the context of outgoing sync calls. ananta@chromium.org2009-08-252-2/+10
| | | | | | | | | | | | | | | I will be watching the reliability test runs closely for any crashes which creep in due to reentrancies into plugins caused by this CL. This fixes bug http://code.google.com/p/chromium/issues/detail?id=15985 It is a touch tricky to implement a test case for this. Will add one hopefully in a subsequent CL Bug=15985 Test=Covered by UI test Review URL: http://codereview.chromium.org/173211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24266 0039d316-1c4b-4281-b951-d872f2087c98
* linux/mac: implement NPN_ThreadAsyncCallpiman@chromium.org2009-08-241-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/174296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24136 0039d316-1c4b-4281-b951-d872f2087c98
* More removal of WebCore usage from webplugin_impl.ccdarin@chromium.org2009-08-216-29/+23
| | | | | | | | | | | | Adds a few helper methods on WebFrame. R=jam BUG=10036 TEST=none Review URL: http://codereview.chromium.org/173152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23956 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Plugin descriptions can be UTF-8.evan@chromium.org2009-08-201-1/+1
| | | | | | | | | | | Tested with a Japanese locale, I saw Japanese plugin descriptions when I assumed UTF-8. BUG=18866 Review URL: http://codereview.chromium.org/174078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23815 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a line that was accidently deleted in my plugin change.jam@chromium.org2009-08-201-1/+1
| | | | | | | TBR=ananta Review URL: http://codereview.chromium.org/173108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23794 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the Google Talk Video plugin, which seems pretty well behaved.amanda@chromium.org2009-08-191-3/+4
| | | | | | Review URL: http://codereview.chromium.org/173064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23720 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-181-1/+1
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-156-120/+120
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23501 0039d316-1c4b-4281-b951-d872f2087c98