summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webframe_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-pagefinnur@google.com2008-12-041-11/+27
| | | | | | | | | | | | | | | I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden). Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it. I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious). Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test. Review URL: http://codereview.chromium.org/13130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the URL and title from the state getting functions and IPC messages.brettw@google.com2008-12-021-11/+3
| | | | | | | If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted. Review URL: http://codereview.chromium.org/12859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the X selection clipboard for copying html and text out of a linux ↵tc@google.com2008-12-011-0/+10
| | | | | | | | | | | | | | test shell. I implemented it in the webview delegate, so when we switch to the multiprocess architecture, we will need to find out if the clipboard callback can be async (the current method would require a sync call from browser to renderer to get the selected text). Review URL: http://codereview.chromium.org/12700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix printing. With a webkit merge, the paint() command started to be ↵maruel@chromium.org2008-12-011-1/+2
| | | | | | | | | | delegated to ScrollView instead of FrameView, printing scrollbars on the paper. TEST=print a long page, no scrollbar should appear and it should print on multiple pages correctly. BUG=3670 Review URL: http://codereview.chromium.org/13012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6139 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webKit merge 38653:38729ojan@google.com2008-11-271-4/+7
| | | | | | Review URL: http://codereview.chromium.org/12708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6081 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webKit merge 38600:38625.ojan@google.com2008-11-261-4/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6023 0039d316-1c4b-4281-b951-d872f2087c98
* Find now uses WebKit's TextMatch highlighting for Find-in-page.finnur@google.com2008-11-241-270/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to discard a bunch of code and plumbing related to maintaining and passing around the tickmark vector. WebKit now owns the drawing of the highlights for inactive matches and we use the selection controller to draw the active highlight. I also simplified the code by eliminating the separate FindNext function, which has been merged into Find. This change also requires minor changes to WebKit upstream (sold seperately, void where prohibited). It simply consists of adding one empty virtual paint function to ScrollbarThemeComposite.h (paintTickmarks) and in ScrollbarThemeComposite::paint call paintTickmarks(). This fixes/makes obsolete a slew of bugs: BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599 ... and a couple of external ones as well. Full list: 1326399 Find highlighting disappears on ThinkPad x60s 1241554 Find doesn't highlight word inside blinky tag 1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode 1070190 Find should begin searching from caret/selection 1023019 Find not highlighting correctly 984786 Find highlight drawing code causes ClearType text to look bad 893737 Find in page should search textareas 868599 Find in page tick marks incorrectly appear on nested scrollbars 298 Find-In-page should highlight elided entries 4389 Find-in-box is not highlighting all the instances of the search word 3908 Find in page highlighting and tickmarks are broken Review URL: http://codereview.chromium.org/11364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-221-2/+2
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-221-3/+4
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback "Remove use of wide characters in stats table identifiers."evanm@google.com2008-11-211-4/+3
| | | | | | | This reverts commit r5847. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-211-3/+4
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the new autofill.jcampan@chromium.org2008-11-201-10/+20
| | | | | | | | | I rolled it back yesterday, it broke the Linux and Mac builds. TBR=tim Review URL: http://codereview.chromium.org/11543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5796 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/11306jcampan@chromium.org2008-11-201-20/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5747 0039d316-1c4b-4281-b951-d872f2087c98
* A new implementation of the autofill using the editor client API.jcampan@chromium.org2008-11-201-10/+20
| | | | | | | | | | | | | | This simplifies code as we don't need to listen for events on input elements, the editor client API is only triggered when the text changes. The only quirk we have to work around is that when the editor client API notifies us that the text has changed, the selection is not set properly, preventing us from reliably finding out if the caret is at the end of the text. To work around that issue, we post a task that does the autofill after the text change callback. BUG=None TEST=Trigger the autofill behavior with form and passwords. Review URL: http://codereview.chromium.org/11479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5742 0039d316-1c4b-4281-b951-d872f2087c98
* The password manager and the form autofill feature were listening for events ↵jcampan@chromium.org2008-11-171-1/+14
| | | | | | | | | | | | on text input elements by registering a listener on each element. This is slowing down the page load. This CL changes that to only 1 listener on the body of the page, that forwards the events to element specific listeners. BUG=None TEST=Run the test shell unit tests Review URL: http://codereview.chromium.org/10844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from SkiaUtils, fix namespaces and includes.brettw@google.com2008-11-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/10918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5444 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix on Finnur's behalf to make find useful until bigger fix issky@google.com2008-11-131-2/+4
| | | | | | | | done. Review URL: http://codereview.chromium.org/10881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5357 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crash due to DIB allocation failure joshia@google.com2008-11-121-3/+14
| | | | | | | | | | | | | Change the way we capture tab thumbnail images so that the capturing code can deal with failure. BUG=3795 Review URL: http://codereview.chromium.org/9717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5244 0039d316-1c4b-4281-b951-d872f2087c98
* Change old code from "unloadListnerChanged" model to new WebKit ↵erikkay@google.com2008-11-101-8/+0
| | | | | | | | | | | EnableSuddenTermination, unforking a bunch of code. BUG=http://crbug.com/4064 Review URL: http://codereview.chromium.org/9746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 37604:38097 mergedglazkov@google.com2008-11-101-87/+56
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5110 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled WebFrameTest, refactored some test shell functions.estade@chromium.org2008-11-061-2/+5
| | | | | | Review URL: http://codereview.chromium.org/9652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4916 0039d316-1c4b-4281-b951-d872f2087c98
* Port some test_shell_tests, and platform cleanup for more of them.tc@google.com2008-11-061-4/+3
| | | | | | | | | | | | | | Many of these files that I don't added to the build would even compile and link, but don't yet pass with current test_shell on Linux. They just hang. Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> on http://codereview.chromium.org/9417 Review URL: http://codereview.chromium.org/9641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4892 0039d316-1c4b-4281-b951-d872f2087c98
* revert 9391estade@chromium.org2008-11-051-5/+2
| | | | | | Review URL: http://codereview.chromium.org/9607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4837 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled WebFrameTest, refactored some test shell functions.estade@chromium.org2008-11-051-2/+5
| | | | | | Review URL: http://codereview.chromium.org/9391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4834 0039d316-1c4b-4281-b951-d872f2087c98
* Mac changes for r4070 et seq. Make jsbindings, webcore, port, and glue sharemark@chromium.org2008-10-311-0/+6
| | | | | | | | the same HEADER_SEARCH_PATHS. For the couple of cases where we want to use headers from third_party/WebKit, redirect the #includes in the port headers. Review URL: http://codereview.chromium.org/8964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4288 0039d316-1c4b-4281-b951-d872f2087c98
* Make ImageBuffer creation and handling conform to proper WebKit form rather ↵brettw@google.com2008-10-311-5/+4
| | | | | | | | | | than using tacked-on functions on GraphicsContext. Clean up the associated GraphicsContext objects. Merge SkGraphicsContext, SkPaintContext, and PlatformContextSkia into one class, PlatformContextSkia. This tries to change no code related to this, the code in PlatformContextSkia is just a concatenation of those existing files, and hopefully doesn't need much review. This file is in the wrong style and is a terrible mess, I will clean it up in successive passes so it can be reviewed reasonably. Review URL: http://codereview.chromium.org/8754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the JSC build.darin@chromium.org2008-10-311-7/+7
| | | | | | | | | | | | This involved fixing up vcproj files and making some KJS -> JSC changes. I also had to fix some issues related to ScriptCallContext. I had to create a ScriptControllerChromium.cpp for the JSC build to provide an implementation of createScriptInstanceForWidget that knows how to talk to our plugin implementation. This file belongs in bindings/js alongside files like ScriptControllerWin.cpp, so I created webkit/port/bindings/js to house it. R=dglazkov,ojan Review URL: http://codereview.chromium.org/8947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4269 0039d316-1c4b-4281-b951-d872f2087c98
* Landing 36102:37604 merge on trunkdglazkov@google.com2008-10-301-66/+50
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4222 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix renderer crash on startup.darin@chromium.org2008-10-211-1/+1
| | | | | | | | TBR=mbelshe Review URL: http://codereview.chromium.org/8021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixup some JSC compile errors for glue.mbelshe@google.com2008-10-201-0/+24
| | | | | | | | Implement BindToWindowObject for JSC. Review URL: http://codereview.chromium.org/7673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3628 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix LayoutTests/http/tests/navigation/reloadsubframe-*frame.html on Windows.mmoss@google.com2008-10-201-1/+0
| | | | | | | | | | | | WebFrameImpl::CreateChildFrame is based on third_party/WebKit/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp, which is based on WebKit/mac/WebView/WebFrame.mm:_loadURL. WebKit change 31264 (http://trac.webkit.org/changeset/31264/trunk/WebKit/mac/WebView/WebFrame.mm), fixed this bug on Mac, but was never ported to Windows, so webframe_impl.cc didn't get that fix. (FYI, WebFrame.mm:_loadURL has since moved to WebCore/loader/FrameLoader.cpp, with the appropriate changes.) Note that these layout tests also fail for WebKit on Windows (disabled in LayoutTests/platform/win/Skipped). This same change still needs to be made upstream to WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp. Review URL: http://codereview.chromium.org/7503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3619 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PLATFORM(WIN) !!darin@chromium.org2008-10-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | port/platform/chromium/PlatformKeyboardEventChromium.cpp - this is KeyEventWin.cpp renamed and mostly deleted. we just needed to define two static methods. - the big switch case goes to event_conversion.cc. port/platform/chromium/DragDataChromium.cpp - yay, no more dropData wrapper! port/platform/chromium/TemporaryLinkStubs.cpp - just stubbing scheduleDispatchFunctionsOnMainThread() for now since i think we should really use an implementation based on MessageLoop, and we don't use background threads in webkit yet. port/platform/chromium/DragImageChromium.cpp - PLATFORM(WIN) to PLATFORM(WIN_OS) port/platform/chromium/PopupMenuChromium.cpp - lots of nice cleanup. no more dummy HWNDs! port/platform/chromium/PlatformScrollBarChromium.cpp port/platform/chromium/ScrollViewChromium.cpp - GraphicsContext::getWindowsContext is gone. just use the skia canvas directly. port/platform/network/chromium/NetworkStateNotifierChromium.cpp - delete the PLATFORM(WIN) stubs port/platform/win/KeyEventWin.cpp port/platform/win/PlatformMouseEventWin.cpp port/platform/graphics/IntPointWin.cpp port/platform/graphics/IntSizeWin.cpp port/platform/graphics/IntRectWin.cpp - deleted :) port/platform/win/ScreenWin.cpp - compensate for no longer having implicit conversion between RECT and IntRect port/platform/UniscribeStateTextRun.cpp - scriptCache and scriptFontProperties now live on FontPlatformData as discussed with brett and hyatt. port/platform/graphics/FontCacheWin.cpp - getFontLinkInterface() function doesn't exist outside of PLATFORM(WIN) port/platform/graphics/FontPlatformData.h port/platform/graphics/FontPlatformDataWin.cpp - support storing script{Cache,FontProperties} on FontPlatformData. need to implement assignment operator and copy constructor. the script{Cache,FontProperties} objects are not copied per discussion with hyatt. - i moved m_isMLangFont into RefCountedHFONT so that we would know how to "destroy" the HFONT. port/platform/graphics/SimpleFontDataWin.cpp port/platform/graphics/GlyphPageTreeNodeWin.cpp - modified to support changes to FontPlatformData port/platform/graphics/ImageSkia.cpp - getHBITMAP, etc. were never used and are not needed port/platform/graphics/IconWin.cpp - modifications corresponding to my changes to Icon.h. m_icon is of type PlatformIcon. port/platform/graphics/GraphicsContextSkia.cpp - {get,release}WindowsContext are no longer defined port/platform/Cursor.h pending/NetworkStateNotifier.h pending/PlatformKeyboardEvent.h - we no longer need to fork these files. port/page/chromium/EventHandlerChromium.cpp - add #include "Clipboard.h" to support non-WIN_OS port/page/chromium/AccessibilityObjectWrapper.h - changed to no longer be a COM interface port/page/AccessibilityObjectWrapperWin.h - moved to port/page/chromium/AccessibilityObjectWrapper.h pending/AccessibleBase.cpp pending/AccessibleBase.h - modified to support changes to a11y wrapper class - by the way, these files should not be in pending! will fix that later. glue/glue_util.cc glue/glue_util.h - add conversion functions for rect structures. glue/webframe_impl.cc glue/webplugin_impl.cc - use new webkit_glue rect conversion functions. glue/glue_accessibility.cc - add header that is needed to build this file on windows glue/webview_impl.cc - no longer supports auto-conversion between IntPoint and POINT glue/event_conversion.cc - initialize by modifying member variables of the base class directly. - moved a static function from KeyEventWin.cpp R=tony,brettw BUG=3488 Review URL: http://codereview.chromium.org/7495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3587 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey ↵aa@google.com2008-10-161-0/+7
| | | | | | | | | | | | | flag. Implementation follows the pattern of the visited links system. Things still to be done: - stop using a hardcoded script directory - watch script directory and update shared memory when necessary - move file io to background thread - support for @include patterns -- now, all scripts are applied to all pages Review URL: http://codereview.chromium.org/7254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MSVC pragmas with the macro. Also adds two filestc@google.com2008-10-161-2/+3
| | | | | | | | | | | | from webkit/glue to the build rule. Patch from icefox (TorchMobile) http://codereview.chromium.org/7418 Review URL: http://codereview.chromium.org/7454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3490 0039d316-1c4b-4281-b951-d872f2087c98
* Kill bogus leftover include.darin@chromium.org2008-10-151-1/+0
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3429 0039d316-1c4b-4281-b951-d872f2087c98
* Move many files that were suffixed Win.cpp to Chromium.cpp, and place them ↵darin@chromium.org2008-10-151-14/+12
| | | | | | | | | | | in chromium/ subdirectories. We still build these files with PLATFORM(WIN) defined. In this change, I also killed off LogWin.{h,cpp} since we don't use it. So, you will see some changes related to that. R=dglazkov,tony Review URL: http://codereview.chromium.org/7419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3427 0039d316-1c4b-4281-b951-d872f2087c98
* Convert CaptureImage to a single method with lots of ifdefs.tc@google.com2008-10-141-36/+9
| | | | | | | | | | Original patch from icefox (Torchmobile) in http://codereview.chromium.org/7244 . Review URL: http://codereview.chromium.org/7150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3376 0039d316-1c4b-4281-b951-d872f2087c98
* get webframe_impl.cc to compile on linuxtc@google.com2008-10-141-8/+25
| | | | | | | | | Includes changes from http://codereview.chromium.org/7244 by icefox (Torchmobile Inc.) Review URL: http://codereview.chromium.org/7319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3366 0039d316-1c4b-4281-b951-d872f2087c98
* Replace pragma with MSVC macroserg@google.com2008-10-141-2/+2
| | | | | | | | Review URL: http://codereview.chromium.org/6212 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3345 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CaptureImage on the Macamanda@chromium.org2008-10-101-1/+17
| | | | | | Review URL: http://codereview.chromium.org/7237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3233 0039d316-1c4b-4281-b951-d872f2087c98
* We need to layout child frames too!darin@chromium.org2008-10-031-0/+5
| | | | | | | | R=tony Review URL: http://codereview.chromium.org/6437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2822 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the chrome_webkit_merge_branch back on to trunk. This brings ustc@google.com2008-10-011-48/+51
| | | | | | | up to webkit@36102. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2778 0039d316-1c4b-4281-b951-d872f2087c98
* On the Mac, extract the CGContextRef to pass down to WebCore, since a blindamanda@chromium.org2008-09-301-2/+6
| | | | | | | reinterpret_cast will fail miserably. Review URL: http://codereview.chromium.org/5613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 455: Active match in Find is not selected and links are not focused ↵finnur@google.com2008-09-261-1/+44
| | | | | | | | after you close the Find box. Review URL: http://codereview.chromium.org/4283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2645 0039d316-1c4b-4281-b951-d872f2087c98
* Link fixing.avi@google.com2008-09-161-1/+5
| | | | | | Review URL: http://codereview.chromium.org/2871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage in r2110; fix the return typeavi@google.com2008-09-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2115 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 1669: Renderer crashes on FindNextfinnur@google.com2008-09-101-12/+42
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1669 Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0. When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping. To recap on how Find works (since I know it has been a while since you looked at this problem): Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead. BUG=1341577 Review URL: http://codereview.chromium.org/1847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
* remove platform includespinkerton@google.com2008-09-091-4/+2
| | | | | | Review URL: http://codereview.chromium.org/1677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1930 0039d316-1c4b-4281-b951-d872f2087c98
* back out part of last change, better fix upcoming.pinkerton@google.com2008-09-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1784 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 07:27:13 +0000