summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webkit_glue.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix UA Spoofing Condition for Linux.yuzo@chromium.org2012-01-131-1/+4
| | | | | | | | | | | | | Without this patch, headlines.yahoo.co.jp/videonews/* are erroneously considered to require UA spoofing for Linux Chrome. BUG=104426 TEST=none Review URL: http://codereview.chromium.org/9114065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117596 0039d316-1c4b-4281-b951-d872f2087c98
* Add --dart-flags and --disable-dart command line switches.podivilov@chromium.org2011-12-231-0/+6
| | | | | | | | R=darin@chromium.org Review URL: http://codereview.chromium.org/8905006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115707 0039d316-1c4b-4281-b951-d872f2087c98
* Update these includes to use the new header locationsabarth@chromium.org2011-12-031-5/+5
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/8787003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112824 0039d316-1c4b-4281-b951-d872f2087c98
* Work around wrong UA sniffing by Yahoo! JAPANyuzo@chromium.org2011-11-291-13/+53
| | | | | | | | | | | | | | Some Yahoo! JAPAN pages sniff UA wrongly and reject Chrome, misjudging that Silverlight is not supported. Work around this issue by spoofing the UA as Safari on Mac and Firefox on Win for the pages. See the bug below for the justification. This workaround should be removed once the pages are fixed. BUG=104426 TEST=Open the URLs listed in the bug Review URL: http://codereview.chromium.org/8590022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111877 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move the last two Escape() functions into the net namespace.tfarina@chromium.org2011-11-091-2/+2
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8507011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109298 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: extend experimental.debugger API to potentially allow non-tab ↵pfeldman@chromium.org2011-10-261-0/+11
| | | | | | | | | | | | | | | debuggees. This change migrates from attach(tabId, ...) syntax to the attach({tabId:tabId}, ...) as suggested during the extension API review. BUG= TEST= Review URL: http://codereview.chromium.org/8341017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107316 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r102336 (remove webkit_glue::BuildUserAgent) w/ fix.dpranke@chromium.org2011-09-261-20/+14
| | | | | | | | | | | | | | | | | | | | | | Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so that SetUserAgent() must be called before GetUserAgent(). This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build. For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()). As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it. R=jam@chromium.org,rsesek@chromium.org BUG=11136, 90442 TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning. Review URL: http://codereview.chromium.org/8045005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102763 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove webkit_glue::BuildUserAgent(), change the contract in ↵dpranke@chromium.org2011-09-221-14/+20
| | | | | | | | | | | | webkit_glue" TBR=jam@chromium.org BUG=90442 TEST=none Review URL: http://codereview.chromium.org/8002003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102353 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so ↵dpranke@chromium.org2011-09-221-20/+14
| | | | | | | | | | | | | | | | | | that SetUserAgent() must be called before GetUserAgent(). This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build. For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()). As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it. R=jam@chromium.org,tony@chromium.org BUG=11136,90442 TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning. Review URL: http://codereview.chromium.org/7922023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102336 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile failure.pkasting@chromium.org2011-07-021-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91398 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock around user agent calculations so the user agent can be safely ↵pkasting@chromium.org2011-07-011-32/+52
| | | | | | | | | | queried from multiple threads. This also moves the functionality into the UserAgentState class itself since that seemed a little more well-scoped. BUG=87698 TEST=none Review URL: http://codereview.chromium.org/7277067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91391 0039d316-1c4b-4281-b951-d872f2087c98
* Add Safari spoofing when visiting the Silverlight install/update page in Mac ↵stuartmorgan@chromium.org2011-07-011-0/+16
| | | | | | | | | | | | | Chrome. The update flow for Silverlight on the Mac takes the user to a page that does UA detection, and provides Mac Chrome users a page that makes it much less clear that they should update (and how to) just because it's not one of the officially supported platforms. Spoof as a supported browser on that page to increase the chances that users will successfully complete the update, since not updating is a potential security issue. BUG=None TEST=Visit the Silverlight update/install page in Mac Chrome; there should be a clear download link, and instructions for installing. Review URL: http://codereview.chromium.org/7210063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91329 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the GetProductVersion function from webkit_glue and replace it with ↵ananta@chromium.org2011-06-161-2/+2
| | | | | | | | | | | | | | | | | | the BuildUserAgent function. The BuildUserAgent function has been deleted from user_agent.cc. The implementation of this function in content\renderer_glue.cc calls the GetUserAgent API in ContentClient which is implemented by the embedder (Chrome). Added implementations of the BuildUserAgent function for test_shell and DumpRenderTree. To build the user agent string we need the webkit major and minor versions. Added getters for them in the webkit_glue namespace in the user_agent.h/.cc files. This helps reduce the implicit dependency of content on chrome. BUG=82454 Review URL: http://codereview.chromium.org/7166004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89415 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements a first pass in the effort to remove the dependency ↵twiz@chromium.org2011-05-261-1/+1
| | | | | | | | | | | | | | of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625 Review URL: http://codereview.chromium.org/7019013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86823 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86625 - This change implements a first pass in the effort to remove ↵vandebo@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | the dependency of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7019013 TBR=twiz@chromium.org Review URL: http://codereview.chromium.org/6987019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements a first pass in the effort to remove the dependency ↵twiz@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7019013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86625 0039d316-1c4b-4281-b951-d872f2087c98
* Map webkit glue when Mac build uses Skia.caryclark@chromium.org2011-05-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In webkit_glue::DecodeImage(), the WebImage is of type SkBitmap instead of CGImage, so take the general case if USE_SKIA is defined. The generic version of WebCursor defines SetCustomData and ImageFromCustomData only if WEBKIT_USING_SKIA is enabled, so disable the corresponding routines in the Mac version. In webkit_glue::WebThemeEngineImpl::paintScrollbarThumb(), map the WebCanvas (i.e. SkCanvas) to a CGContext to paint the scrollbar thumb, using the SkiaBitLocker utility class. SkiaBitLocker is described in http://codereview.chromium.org/7031006/ These changes make no functional change to any existing port, so have no new tests. BUG=79463 TEST=none Review URL: http://codereview.chromium.org/6840057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86151 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous webkit_glue namespace changes in preparation for building ↵ananta@chromium.org2011-05-191-5/+1
| | | | | | | | | | | | | | | | | | src\content as a dll. This CL removes the IsDefaultPluginEnabled function in the webkit_glue namespace. This function has been replaced by a flag in the PluginList instance which is set when the default plugin is registered as an internal plugin. The webkit_glue.cc file now implements the GetApplicationDirectory and GetExeDirectory functions in the webkit_glue namespace. Previously these functions were implemented in common_glue.cc and in test_shell. Removed the IsPluginRunningInRendererProcess function from webkit_glue and fixed the callers to not depend on this functionality. BUG=82454 Review URL: http://codereview.chromium.org/6975028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85937 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of changes to to build chrome\common as a dll. Moving some of the ↵ananta@chromium.org2011-05-121-1/+1
| | | | | | | | | | | | functionality provided by plugin_thread.cc to the default_plugin which is the only caller. Removed the unused AppendToLog function from the webkit_glue namespace. BUG=82326 Review URL: http://codereview.chromium.org/7012004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85202 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Properly return TYPE_MISMATCH_ERR for DirectoryExists/FileExistsadamk@chromium.org2011-02-251-2/+3
| | | | | | | | | | | | | | operation when the target isn't a directory/file, respectively. This matches what the File API spec says about error codes: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions BUG=none TEST=none Review URL: http://codereview.chromium.org/6591013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76098 0039d316-1c4b-4281-b951-d872f2087c98
* Expose WebCore log channels on the chrome command linegavinp@chromium.org2011-02-161-2/+8
| | | | | | | | | | | | | | Add --webcore-log-channels=Loading,ResourceLoading to your chrome command line to get WebKit debugging joy. See third_party/WebKit/Source/WebCore/platform/Logging.cpp for a list of log levels. BUG=none TEST=none Review URL: http://codereview.chromium.org/6528016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75117 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more DRT features from test_shell.tony@chromium.org2011-02-071-15/+0
| | | | | | | | | Specifically, remove the ability to run tests from the command line and remove a bunch of methods that dump state. Review URL: http://codereview.chromium.org/6334096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74012 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-171-13/+13
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: use string16 in webkit_glue.hevan@chromium.org2010-12-141-22/+25
| | | | | | | | | | And a few places that it touches. BUG=23581 Review URL: http://codereview.chromium.org/5729005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69147 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-141-13/+14
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-111-14/+13
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-111-13/+14
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* glue: use string16 in place of wstring for Unicode textevan@chromium.org2010-12-031-11/+11
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5591004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68208 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of 'using' declaration of StringAppendF.tfarina@chromium.org2010-11-151-3/+3
| | | | | | | | | | | Update the callers to append base:: in the calls to StringAppendF. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
* Removed Media Cache Enabled Flagatwilson@chromium.org2010-11-041-10/+0
| | | | | | | | | | | Removed methods for querying and enabling media cache as the cache has been stable enough we shouldn't have to worry about checking anymore. BUG=None. TEST=No specific test as this flag hasn't been used. Review URL: http://codereview.chromium.org/4266001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65077 0039d316-1c4b-4281-b951-d872f2087c98
* Allow unlimited quota for apps for FileSystem accesskinuko@chromium.org2010-10-081-0/+4
| | | | | | | | | | | | | | | | | | | | - allow unlimited access for apps/extensions that have "unlimited_storage" permission. - disallow any write access that may increase the filesystem usage (i.e. copy/move/create/write). for others. - allow unlimit access for file:/// URIs only if --allow-file-from-files flag is given. BUG=57211 TEST=FileSystemQuota.* TEST=Load a remote test page and verify that it throws QUOTA_EXCEEDED_ERR (22) for any write access. TEST=Load an app/extension page that has "unlimited_storage" permission and verify that any write access is allowed. TEST=Disable or uninstall the app/extension and do the same. Verify that it throws QUOTA_EXCEEDED_ERR (22) for any write access. TEST=Launch chromium without --allow-file-from-files flag, load a local test page (with file:/// URI) and verify that it throws SECURITY_ERR (18) for requesetFileSystem. TEST=Launch chromium with --allow-file-from-files flag and do the same. Verify that requestFileSystem returns a valid filesystem and any write access is allowed. Review URL: http://codereview.chromium.org/3561016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61934 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 61613 that was reverted for false valgrind alarm.kinuko@chromium.org2010-10-071-0/+2
| | | | | | | | | | | | | Original issue: http://codereview.chromium.org/3567012/show BUG=none TEST=FileSystemOperationTest.* TBR=ericu,thestig Review URL: http://codereview.chromium.org/3603014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61613 - possible culprit for valgrind error. (Support ↵kinuko@chromium.org2010-10-061-2/+0
| | | | | | | | | | | removeRecursively and new copy/move) BUG=none TEST=none Review URL: http://codereview.chromium.org/3576017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61713 0039d316-1c4b-4281-b951-d872f2087c98
* Second try for support removeRecursively and new copy/move behaviors added ↵kinuko@chromium.org2010-10-061-0/+2
| | | | | | | | | | | | | | | | | | | | | | to the spec recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. original issue: http://codereview.chromium.org/3567012 BUG=none TEST=FileSystemOperationTest.* TBR=ericu Review URL: http://codereview.chromium.org/3531012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61480 - Support removeRecursively and new copy/move behaviors added ↵kinuko@chromium.org2010-10-051-2/+0
| | | | | | | | | | | | | | | | | | | | | to the spec recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. BUG=32277 TEST=FileSystemOperationTest.* Review URL: http://codereview.chromium.org/3567012 TBR=kinuko@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61482 0039d316-1c4b-4281-b951-d872f2087c98
* Support removeRecursively and new copy/move behaviors added to the spec ↵kinuko@chromium.org2010-10-051-0/+2
| | | | | | | | | | | | | | | | | | | recently. http://lists.w3.org/Archives/Public/public-webapps/2010JulSep/1101.html > For a move/copy of a file on top of existing file, or a directory on > top of an existing empty directory, you get an automatic overwrite. > A move/copy of a file on top of an existing directory, or of a > directory on top of an existing file, will always fail. > A move/copy of a file or directory on top of an existing non-empty > directory will always fail. BUG=32277 TEST=FileSystemOperationTest.* Review URL: http://codereview.chromium.org/3567012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61480 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another try at submitting http://codereview.chromium.org/3397030/show.ericu@google.com2010-09-301-0/+20
| | | | | | | | | | | This hopefully fixes the linux x64 failure, which appears to be a disagreement between int64 and long long. BUG=none TEST=none Review URL: http://codereview.chromium.org/3601001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61020 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60981 - Resubmitting http://codereview.chromium.org/3397030 with the ↵ericu@google.com2010-09-291-20/+0
| | | | | | | | | | | | | | needed one-line deletion. Tested, reproed the breakage, verified the fix. BUG=none TEST=none TBR=ericu@google.com Review URL: http://codereview.chromium.org/3567006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60982 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting http://codereview.chromium.org/3397030 with the needed one-line ↵ericu@google.com2010-09-291-0/+20
| | | | | | | | | | | deletion. Tested, reproed the breakage, verified the fix. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60964 - This adds WebFileWriterImpl, which implements WebFileWriter ↵sky@chromium.org2010-09-291-20/+0
| | | | | | | | | | | | | | and AsyncFileWriterClient. BUG=none TEST=none Review URL: http://codereview.chromium.org/3397030 TBR=ericu@google.com Review URL: http://codereview.chromium.org/3590002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60966 0039d316-1c4b-4281-b951-d872f2087c98
* This adds WebFileWriterImpl, which implements WebFileWriter and ↵ericu@google.com2010-09-291-0/+20
| | | | | | | | | | | AsyncFileWriterClient. BUG=none TEST=none Review URL: http://codereview.chromium.org/3397030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60964 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-09-291-1/+2
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=None Review URL: http://codereview.chromium.org/3404027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60885 0039d316-1c4b-4281-b951-d872f2087c98
* Make the glob matcher support UTF8 strings.mnissler@chromium.org2010-09-101-2/+2
| | | | | | | | | | | This generalizes the existing pattern matching code to support UTF8 strings. BUG=53158 TEST=string_util_unittests.cc Review URL: http://codereview.chromium.org/3295018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59071 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at landing http://codereview.chromium.org/3214005tommi@chromium.org2010-08-271-101/+1
| | | | | | | | | | | Factoring BuildUserAgent out to a separate lib for GCF can use it. TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57717 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57692 - Factoring BuildUserAgent out to a separate lib for GCF can ↵dmazzoni@chromium.org2010-08-271-1/+95
| | | | | | | | | | | | | | use it. TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3214005 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/3275001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57696 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring BuildUserAgent out to a separate lib for GCF can use it.tommi@chromium.org2010-08-271-95/+1
| | | | | | | | | TEST=There should be no functional change. If anything breaks it should be the build. BUG=50788 Review URL: http://codereview.chromium.org/3214005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57692 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some wstrings used in ui_test.cc.evan@chromium.org2010-07-301-5/+4
| | | | | | | | | This removes all switch-related wstring APIs from ui_test.cc, and fixes all the callers. Review URL: http://codereview.chromium.org/3066026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54392 0039d316-1c4b-4281-b951-d872f2087c98
* Remove only use of clearName()atwilson@chromium.org2010-06-171-1/+1
| | | | | | | | | Now that WebFrame::setName() exists, we don't need clearName() any more. Remove the only use of the clearName() API in preparation of removing it upstream. Review URL: http://codereview.chromium.org/2868012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50171 0039d316-1c4b-4281-b951-d872f2087c98