summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webview_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.hmal@chromium.org2009-10-011-14/+38
| | | | | | | | | | | | | | | | | | | | | | | | ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/246060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.hdarin@chromium.org2009-10-011-38/+14
| | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional WebFrame parameter to WebView::findFrameByName.darin@chromium.org2009-09-301-2/+6
| | | | | | | | | | | | | This parameter is used to support _self and other names that need to be evaluated relative to a subframe. R=jam BUG=23009 TEST=none Review URL: http://codereview.chromium.org/257005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27646 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up webkit/api/public/WebView.hdarin@chromium.org2009-09-301-134/+135
| | | | | | | | | | | | | | This change does not completely eliminate webkit/glue/webview.h. Instead, the old WebView extends from the new WebView temporarily as we complete the transition. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/257001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
* WebView::DownloadImage refactoredyaar@chromium.org2009-09-291-32/+0
| | | | | | | | | The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView. DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView. Review URL: http://codereview.chromium.org/255006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cmd-up/cmd-down.thakis@chromium.org2009-09-291-22/+11
| | | | | | | | | | | | | | | | | The approach is to special-case moveToBeginningOfDocument and moveToEndOfDocument in WebFrameImpl::executeCommand(). With this (and the cocoa keyboard bindings patch being landed), the special-case code in WebViewImpl::ScrollViewWithKeyboard() can be removed. Also add a test for cmd-up/down. Change chrome.gyp so that it supports osx-only unit tests (_unittest_mac.mm). Move OnPrintPageAsBitmap to the other printing tests. BUG=22585 TEST=Go to a page with both text box and scrollbar (e.g. http://en.wikipedia.org ). Pressing cmd-down should scroll to end of page, cmd-up back to start. Clicking the text box and trying some emacs shortcuts should work (ctrl-a jumps to start of line, cmd-h acts as backspace, etc). Review URL: http://codereview.chromium.org/254002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27464 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48747:48766levin@chromium.org2009-09-271-1/+2
| | | | | | | | | | | | | | Rolling right up to the next breakage. Adding new breakages that I need to investigate. TBR=senorblanco@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/251006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more methods from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-241-2/+2
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/224010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27054 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 22712 -- REGRESSION: auto-complete close cause chrome crash.xji@chromium.org2009-09-231-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | crashed was caused by a dead loop introduced by a serial webkit changes in PopupMenuClient::hidePopup/PopupDidHide. Change AutocompletePopupMenuClient::popupDidHide() to call WebViewImpl::AutoCompletePopupDidHide() which only set the popup_showing_ flag instead of calling WebViewImpl::HideAutoCompletePopup(). BUG=http://crbug.com/22712 TEST= 1. Open the following html <html> <head> </head> <body> <form action="form_action.asp" method="get"> First name: <input type="text" name="fname" dir="rtl"/><br /> Last name: <input type="text" name="lname" /><br /> <input type="submit" value="Submit" /> </form> </body> </html> 2. Type some text in the "First name" input box, for example "abcd" 3. Click "Submit" 4. Open the file again 5. Type the first letter "a" and select "abcd". 6. "abcd" should be selected instead of crashing. Review URL: http://codereview.chromium.org/223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26935 0039d316-1c4b-4281-b951-d872f2087c98
* Shift+PageUp and Shift+PageDown should not scroll the web page.tony@chromium.org2009-09-211-1/+1
| | | | | | | | | | | | | | | | | Alt and Ctrl already don't scroll. Win+PageUp/PageDown does scroll. This matches Firefox. It doesn't match IE; IE lets you scroll using ctrl, shift or win. I'm doing this so the standard GTK+ key binding for ctrl+shift+page{up/down} can be used on linux to move tabs left/right (otherwise, the page scrolls and eats the key before we get to it). BUG=21594 Review URL: http://codereview.chromium.org/214026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26692 0039d316-1c4b-4281-b951-d872f2087c98
* Fold WebEditingClient into WebViewClient.darin@chromium.org2009-09-181-7/+4
| | | | | | | | | | R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/211032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused method and reorder methods to match the header.paul@chromium.org2009-09-181-7/+4
| | | | | | | | | BUG=22032 TEST=none. Review URL: http://codereview.chromium.org/210015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26626 0039d316-1c4b-4281-b951-d872f2087c98
* Newline at end of file for gcc to be happy.thomasvl@chromium.org2009-09-181-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/213024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26578 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebKitTabToLinksPreferenceKey for the test_shell.arv@chromium.org2009-09-171-0/+8
| | | | | | | | | | BUG=21267 TEST=Run layout tests Review URL: http://codereview.chromium.org/212004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26508 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug introduced by a WebKit merge where we did notpaul@chromium.org2009-09-171-0/+1
| | | | | | | | | | | | | tell our autocomplete popup to hide when it was closed. BUG=22032 TEST=Navigate to a page with an autocompletable input box (e.g. google.com login page) and notice that the autocomplete box hides when you select an item from it and hit enter. Review URL: http://codereview.chromium.org/211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26503 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-161-7/+8
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix canary bot.darin@chromium.org2009-09-141-0/+2
| | | | | | | | | | | | | Adds a missing function. We shouldn't need any extra implementation once we roll deps. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/205004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 2932: Chrome should not trigger page reloading when turn off ↵jshin@chromium.org2009-09-141-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | auto detect In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message). The new logic is as follows: -) If the user turns auto-detect OFF, nothing happens (as requested in the bug description) -) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding I.e., turning auto-detect on resets a previous override setting. The reverse is not true, however: specifiying a new override setting will not turn auto-detect off. BUG=2932 TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 : 1.) load the file while auto-detect is turned off -> garbage is displayed 2.) turn auto-detect on -> proper Chinese text should appear -> in the encoding menu, Chinese encoding should be highlighted 3.) turn auto-detect off -> proper Chinese text should remain -> in the encoding menu, Chinese encoding should remain highlighted 4.) choose any other encoding -> garbage is again displayed (in the new encoding) 5.) turn auto-detect on -> proper Chinese text should again appear -> in the encoding menu, Chinese should again be highlighted Original Review: http://codereview.chromium.org/173265 Patch by Roland Steiner (rolandsteiner@google.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
* Linux focus ring color: Go through WebKit::WebColor api rather than through ↵estade@chromium.org2009-09-111-9/+0
| | | | | | | | | | | | the webview. Also use SkColor isntead of a triplet of colors in RenderPreferences. BUG=21521 Review URL: http://codereview.chromium.org/195059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
* Supports Gtk keyboard themes.suzhe@chromium.org2009-09-101-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings). A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme. A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed. When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding. With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc. Known issue: If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events. BUG=11480 "Support GTK keyboard themes (emacs keybindings)" TEST=Switch to Emacs keyboard theme by changing the value of gconf key "/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and opens a webpage with a text input box. Input something into the text box, then press any of the Emacs key bindings defined in /usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For example, ctrl-p should move the cursor up one line, and ctrl-k should delete to the end of paragraph. Review URL: http://codereview.chromium.org/165293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient, replacing many WebViewDelegate methods.darin@chromium.org2009-09-101-6/+9
| | | | | | | | | | | | | | | | | | | Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none Review URL: http://codereview.chromium.org/200054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use gtk-cursor-blink from GtkSettings"evan@chromium.org2009-09-091-5/+0
| | | | | | This reverts commit r25797 due to Valgrind errors. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25812 0039d316-1c4b-4281-b951-d872f2087c98
* Use gtk-cursor-blink from GtkSettings to set theevan@chromium.org2009-09-091-0/+5
| | | | | | | | | | | | | | | | caret blink interval on Linux This can be set with the "Cursor Blinking" slider and checkbox in gnome-keyboard-properties. The changed setting will appear in a new renderer, so opening a new tab will see the change. WebKit side is at https://bugs.webkit.org/show_bug.cgi?id=28931 Patch by Joel Stanley <joel@jms.id.au> BUG=20772 Review URL: http://codereview.chromium.org/186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the os x spelling panel to chromium. Users canpinkerton@chromium.org2009-09-091-0/+8
| | | | | | | | | | | now access it from the main menu and context menu and use it to perform spelling tasks. For more detail, see http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc Patch from pwicks86@gmail.com (Paul Wicks). BUG=None TEST=The spelling panel should work in os x. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-081-2/+6
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the DragOperation through all the layers between the platform ↵snej@chromium.org2009-09-081-35/+61
| | | | | | | | | | | | | Drag-n-drop code and WebCore. This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec. (The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.) R=darin,pink BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985 TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html Review URL: http://codereview.chromium.org/174364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup to various WebCore client implementations.darin@chromium.org2009-09-051-11/+9
| | | | | | | | | | | | | | Replaced usage of MessageLoop in EditorClientImpl with WebCore::Timer. Changed the clients to be instance variables of WebViewImpl instead of being separately heap allocated. This cleaned up some of the lifetime issues. R=dglazkov Review URL: http://codereview.chromium.org/198030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25573 0039d316-1c4b-4281-b951-d872f2087c98
* Convert std::wstring encoding names to std::string in a bunch of files.tony@chromium.org2009-09-041-5/+5
| | | | | | | | | | | | | | | BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/179057/show Some linux related fixes by me. Review URL: http://codereview.chromium.org/192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test related to document.hasFocus.arv@google.com2009-09-041-3/+6
| | | | | | | | | | | | | | | Note that this fixes the test for the test_shell but Chrome is still having issues with this test due to 2 reasons: 1. Focusing and blurring windows are asynchronous. 2. We explicitly prevent an unfocused window to take focus again. See http://codesearch/p?sa=N&cd=1&ct=rc#chrome/trunk/src/chrome/renderer/render_widget.cc&q=RenderWidget::didFocus&l=648 BUG=16018 TEST=LayoutTests Review URL: http://codereview.chromium.org/180047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25491 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebEditingClient.darin@chromium.org2009-09-041-18/+13
| | | | | | | | | | | | | | | | | | | | Moves the WebViewDelegate parameter back to WebView::Create and adds a second parameter for WebEditingClient. I had hoped to make the WebEditingClient NULL for RenderView on Windows and Mac, but that turned out to not be an option. I need a few methods on all platforms. The Describe* functions from EditorClientImpl are moved into the TestWebViewDelegate since they are only applicable to layout tests. R=dglazkov BUG= TEST=none Review URL: http://codereview.chromium.org/195008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25432 0039d316-1c4b-4281-b951-d872f2087c98
* Set the focus ring color to match the Gtk theme focus color.estade@chromium.org2009-09-031-0/+9
| | | | | | | | BUG=8540 Review URL: http://codereview.chromium.org/173642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25278 0039d316-1c4b-4281-b951-d872f2087c98
* New WebKit API interfaces for desktop notifications.johnnyg@google.com2009-09-011-0/+8
| | | | | | | | | | | Everything is still currently disabled under compile-time flag. BUG=none TEST=none Review URL: http://codereview.chromium.org/174104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24989 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback rev 24947 since it seems to have broken other tests.arv@google.com2009-08-311-1/+0
| | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=24947 BUG=16018 TEST=None Review URL: http://codereview.chromium.org/173634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24952 0039d316-1c4b-4281-b951-d872f2087c98
* Fix document.hasFocus() for layout testarv@google.com2009-08-311-0/+1
| | | | | | | | | | | | | | | | | | | We were not setting the focused frame to null when we blurred a window. Therefore a document inside a frame inside a blurred window would think it was focused since its frame was the focused frame. This fixes the layout test for the test_shell but Chrome is still having issues with the test since blurring is asynchronous in chrome. Changing the layout test by adding timers makes the test pass in chrome as well. BUG=16018 TEST=Run LayoutTests/fast/dom/HTMLDocument/hasFocus.html Review URL: http://codereview.chromium.org/182032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24947 0039d316-1c4b-4281-b951-d872f2087c98
* More refactoring for WebPlugin.darin@chromium.org2009-08-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason from WebFrameLoaderClient. This CL also moves WebDataSourceImpl into webkit/api/src. That change was needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it, which WebFrameLoaderClient uses to communicate back to the WebPlugin upon completion of the frame load. WebViewDelegate::DidFinishLoadWithReason is modified to include url and notify_data parameters, eliminating the URLRequestRouted method. This is done so that we can support overlapping NPN_GetURLNotify targetting different frames. WebPluginContainer grows an executeScriptURL method to deal with javascript: URLs. NOTE: I'm working on some UI tests to better cover the case of overlapping NPN_GetURLNotify calls. R=jam BUG=10036 TEST=none yet Review URL: http://codereview.chromium.org/174514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
* On a middle click, check if the mouse is over a scrollbar before pasting the ↵vandebo@chromium.org2009-08-261-1/+5
| | | | | | | | | | | selection. BUG=16400 TEST=See bug description Review URL: http://codereview.chromium.org/173414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24454 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes "RTL: Form autofill pop-up is not right aligned".xji@chromium.org2009-08-241-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The complete patch includes 2 parts: 1. patch in webkit (https://bugs.webkit.org/show_bug.cgi?id=27889), mainly PopupMenuChromium.cpp 2. this one (depends on the first patch to be able to compile). The changes apply to autofill only, not <select>. It 1. restricts the popup box to be the same size as that of the input field. 2. displays the text in the popup box in the same directionality as the text in input field. BUGS=http://crbug.com/7323 TEST= 1. open the following HTML page: <html> <head> </head> <body> <form action="form_action.asp" method="get"> First name: <input type="text" name="fname" dir="rtl"/><br /> Last name: <input type="text" name="lname" /><br /> <input type="submit" value="Submit" /> </form> </body> </html> 2. Type some long text in the "Last name" input box >>Say "abcd abcd abcd abcd abcd abcd" 3. Click "Submit" 4. Open the file again 5. Type the first letter "a" 6. The form autofill pop-up should show up the same width as the input field, with the input text truncated to be "abcd abcd abcd abcd ab ...". 7. Type "hi!" in both "First name" and "Last name". Click "submit". Open the file again. Type "h" in "First name", "hi!" should be displayed as RTL ("!hi") in pop-up. Type "h" in "Last name", "hi!" should be displayed as LTR ("hi!") in pop-up Review URL: http://codereview.chromium.org/160613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24108 0039d316-1c4b-4281-b951-d872f2087c98
* Auto: change errant base::VKEY_* values to just VKEY_*.estade@chromium.org2009-08-211-4/+4
| | | | | | | | | | This shouldn't affect mac or windows as the definitions with our without base:: are identical there. BUG=19664 Review URL: http://codereview.chromium.org/174121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24000 0039d316-1c4b-4281-b951-d872f2087c98
* Move MediaPlayerAction out of context_menu.h into webview.h since it's ↵ajwong@chromium.org2009-08-201-0/+1
| | | | | | | | really only used by webview. Review URL: http://codereview.chromium.org/174143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webview's dependency on webpreferences.jorlow@chromium.org2009-08-171-106/+16
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/165513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23589 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 18844 (Take 2).hbono@chromium.org2009-08-171-3/+21
| | | | | | | | | | | | | | | | | This is the same change as <http://codereview.chromium.org/164309> that I reverted to investigate a test_shell_test failure (Issue 19263). This change checks if the modifier flag is a WebInputEvent::MetaKey flag to switch the scroll granularity when a user types a up/down key. Editor::Commands ("MoveToBeginningOfDocument" and "MoveToEndOfDocument") works only in an editable control, such as <textarea>. On the other hand, this WebViewImpl::ScrollViewWithKeyboard() is for scrolling a page. BUG=18844 "Apple (command) key + down arrow is not working" TEST=Type command+down keys in a web page which contains a scroll bar, and verify Chrome scrolls the page to its end. Review URL: http://codereview.chromium.org/165523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23540 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebFrame::selectAll and WebFrame::clearSelection in favor of havingdarin@chromium.org2009-08-141-1/+1
| | | | | | | | | | | | | consumers use executeCommand. Patch by Marshall Greenblatt R=darin BUG=19270 TEST=covered by unit tests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23442 0039d316-1c4b-4281-b951-d872f2087c98
* Move glue/event_conversion.{h,cc} into the WebKit API implementation.darin@chromium.org2009-08-141-13/+17
| | | | | | | | | | | | | | | | | | | I also renamed the MakeFoo classes to FooBuilder so that it would be more clear at the call sites that you are dealing with a class. I then translated the ToBar functions to also be BarBuilder classes. I just did this for consistency with the FooBuilders. For reference, "Foo" refers to WebCore Platform*Event classes and "Bar" refers to WebInputEvent subclasses :-) R=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/164524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23425 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23285 since a test_shell test ↵hbono@chromium.org2009-08-131-21/+3
| | | | | | | | "ICOImageDecoderTest.ChunkedDecoding" started failing since this change. Review URL: http://codereview.chromium.org/164468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23300 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 18844.hbono@chromium.org2009-08-131-3/+21
| | | | | | | | | | | This change checks if the modifier flag is a WebInputEvent::MetaKey flag to switch the scroll granularity when a user types a up/down key. Editor::Commands ("MoveToBeginningOfDocument" and "MoveToEndOfDocument") works only in an editable control, such as <textarea>. On the other hand, this WebViewImpl::ScrollViewWithKeyboard() is for scrolling a page. BUG=18844 "Apple (command) key + down arrow is not working" TEST=Type command+down keys in a web page which contains a scroll bar, and verify Chrome scrolls the page to its end. Review URL: http://codereview.chromium.org/164309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23285 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Playback Rate from the context menu.scherkus@chromium.org2009-08-121-4/+0
| | | | | | | | | | This feature is better implemented as an extension rather than being put into the absolute-core UI. Review URL: http://codereview.chromium.org/164301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a command line switch to enable the appcache, and plumb the switch ↵michaeln@google.com2009-08-121-0/+1
| | | | | | | | | | | throughto preferences and webcore settings. BUG=none TEST=none Review URL: http://codereview.chromium.org/164306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23135 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2: Remove WebView::SetDelegate because I'd like to avoid having a methoddarin@chromium.org2009-08-111-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | like this in the WebKit API. The only consumer was TestShell. It was using this method to replace its TestWebViewDelegate instance. Instead, with this change, it has a manual Reset method. To avoid duplication with the constructor, Reset uses operator=(). This required a couple changes: 1- Remove DISALLOW_COPY_AND_ASSIGN from WebViewDelegate. Anyways, that didn't make sense since you cannot 'copy' a class with pure virtual methods. 2- Change scoped_ptr members of TestWebViewDelegate to linked_ptr. The extra overhead of the linked_ptr seems warranted in this case. I also changed TestWebViewDelegate to not be reference counted since it wasn't necessary. Finally, to get this to work on Linux, I needed to revise the shutdown paths for WebWidgetHost. The problem is that the code wants to support destroying a WebWidgetHost directly by having its destructor called or indirectly by having a "destroy" signal handler notice destruction of the GtkWidget. This actually mirrors the Windows version as well, and so just like the Windows version I added a level of indirection to get from the GtkWidget to the WebWidgetHost. However, I only apply this indirection to the "destroy" signal handler. R=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/165341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23117 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23068.darin@chromium.org2009-08-111-0/+4
| | | | | | Review URL: http://codereview.chromium.org/165316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23071 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebView::SetDelegate because I'd like to avoid having a method like thisdarin@chromium.org2009-08-111-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | in the WebKit API. The only consumer was TestShell. It was using this method to replace its TestWebViewDelegate instance. Instead, with this change, it has a manual Reset method. To avoid duplication with the constructor, Reset uses operator=(). This required a couple changes: 1- Remove DISALLOW_COPY_AND_ASSIGN from WebViewDelegate. Anyways, that didn't make sense since you cannot 'copy' a class with pure virtual methods. 2- Change scoped_ptr members of TestWebViewDelegate to linked_ptr. The extra overhead of the linked_ptr seems warranted in this case. I also changed TestWebViewDelegate to not be reference counted since it wasn't necessary. R=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/164308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23068 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 01:05:53 +0000