summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webview_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Moves webview_impl.cc, webframe_impl.cc and webframeloaderclient_impl.cc intodarin@chromium.org2009-10-301-1925/+0
| | | | | | | | | | | | webkit/api/src. R=yaar BUG=25896,25897,25902 TEST=none Review URL: http://codereview.chromium.org/341030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30558 0039d316-1c4b-4281-b951-d872f2087c98
* Move glue/EditorClientImpl.h/cpp to webkit/api/srcyaar@chromium.org2009-10-271-2/+3
| | | | | | Review URL: http://codereview.chromium.org/330021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30270 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of files into webkit/api/srcdarin@chromium.org2009-10-271-1/+3
| | | | | | | | | | R=yaar BUG=25898,25899,25900,25901, TEST=none Review URL: http://codereview.chromium.org/338041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30232 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in glue to remove some remaining base dependencies.darin@chromium.org2009-10-261-2/+4
| | | | | | | | | | | | | Also moves the guts of WebFrameImpl::GetWebViewImpl to WebViewImpl's FromPage method since it involves dipping into ChromeClientImpl. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/339001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30052 0039d316-1c4b-4281-b951-d872f2087c98
* Replace MessageLoop+ScopedRunnableMethodFactory with WebCore::Timer+Vectordarin@chromium.org2009-10-261-8/+9
| | | | | | | | | | | | | This solution is clearly not as elegant, but it gets the job done, and it eliminates the last remaining base/ reference from webframe_impl.cc! R=dglazkov BUG=24608 TEST=none Review URL: http://codereview.chromium.org/335019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30035 0039d316-1c4b-4281-b951-d872f2087c98
* Moved castToHTMLXXXElement and getNameForInputElement to DOMUtilitiesPrivate.yaar@chromium.org2009-10-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/304013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29834 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in webkit/glue to remove some dependencies.darin@chromium.org2009-10-221-61/+50
| | | | | | | | | | | | | | | | Switch scoped_ptr to OwnPtr. Switch base::RefCounted to WTF::RefCounted. Switch string16/wstring to WebCore::String Switch DCHECK to ASSERT. Switch from Chromium #ifdefs to WebKit #ifdefs for ports. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/292042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29779 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Call setIsActive() when changing focus in layout test mode.rohitrao@chromium.org2009-10-211-6/+3
| | | | | | | | | | | This change effectively reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=25491 and fixes http://crbug.com/16018 in a different way. BUG=http://crbug.com/16018 BUG=http://crbug.com/21738 TEST=layout tests should still pass Review URL: http://codereview.chromium.org/258035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29644 0039d316-1c4b-4281-b951-d872f2087c98
* Moved Node/ElementToHTMLInputElement from glue/dom_utilities into ↵yaar@chromium.org2009-10-201-2/+2
| | | | | | | | src/DOMUtilities Review URL: http://codereview.chromium.org/287010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29483 0039d316-1c4b-4281-b951-d872f2087c98
* Neither of the hit tests in WebViewImpl worked if the page had scrolled. ↵vandebo@chromium.org2009-10-191-2/+4
| | | | | | | | | | | This makes it work. BUG=25261, 22810 TEST=Scroll the page down and test functionality... Review URL: http://codereview.chromium.org/305003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29474 0039d316-1c4b-4281-b951-d872f2087c98
* Delete glue/webview{_delegate}.hdarin@chromium.org2009-10-191-30/+35
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/293001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebDevToolsAgent{Delegate} into the WebKit API.darin@chromium.org2009-10-171-15/+10
| | | | | | | | | | | | | | | | | Moves corresponding WebView and WebViewDelegate methods too. This uses the term "Frontend" for what was previously known as "Client" in the devtools interfaces. This is to avoid awkward "ClientClient" naming. Frontend was Pavel Feldman's suggested renaming. In a follow up patch, I will be renaming WebDevToolsClient{Delegate} to WebDevToolsFrontend{Client}. R=dglazkov BUG=24597 TEST=none Review URL: http://codereview.chromium.org/287009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29369 0039d316-1c4b-4281-b951-d872f2087c98
* Kill WebViewDelegate::WasOpenedByUserGesture, and instead havedarin@chromium.org2009-10-161-1/+2
| | | | | | | | | | | | the RenderView implement the logic that was using that method. R=dglazkov BUG=24598 TEST=none Review URL: http://codereview.chromium.org/276059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29250 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-161-34/+35
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebAccessibility object, a wrapper for WebCore::AccessibilityObject.dglazkov@chromium.org2009-10-131-0/+14
| | | | | | | | | | | | | | | | | | | R=darin BUG=24596 TEST=none Implement getter/setter-based bound properties for CppBoundClass. This is necessary for AccessibilityController, which has non-trivial property accessors. R=darin BUG=10322 TEST=CppBoundClassTest.SetAndGetPropertiesWithCallbacks Review URL: http://codereview.chromium.org/272029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28821 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate WebView::GetDelegate and replace RenderViewSet with a map fromdarin@chromium.org2009-10-091-4/+0
| | | | | | | | | | | | WebView to RenderView. R=mpcomplete BUG=10033 TEST=none Review URL: http://codereview.chromium.org/265044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28515 0039d316-1c4b-4281-b951-d872f2087c98
* When middle clicking a link in Linux, an onpaste event is fired. Prevent ↵vandebo@chromium.org2009-10-081-1/+4
| | | | | | | | | | | the onpaste from firing when the hittest detects that the middle click is over a link. BUG=22810 TEST=Middle click a link on a page that has a body onpaste handler Review URL: http://codereview.chromium.org/269025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28460 0039d316-1c4b-4281-b951-d872f2087c98
* Invent WebFrameImpl::ClientHandle as a weak reference to WebFrameClient.darin@chromium.org2009-10-071-2/+11
| | | | | | | | | | | | | Unfortunately, I can't use base::WeakPtr for this since this code will all move into webkit/api shortly. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28267 0039d316-1c4b-4281-b951-d872f2087c98
* Move MediaPlayerAction to WebMediaPlayerAction. Switch to an enum and adarin@chromium.org2009-10-071-32/+32
| | | | | | | | | | | | boolean to express the action. R=ajwong BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28236 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll: 49206:49213.jparent@chromium.org2009-10-071-2/+3
| | | | | | | | | | | TEST=try servers BUG=none TBR=johnnyg Review URL: http://codereview.chromium.org/266001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28230 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. Re-submission of ↵jorlow@chromium.org2009-10-031-4/+6
| | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Review URL: http://codereview.chromium.org/258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
* More WebView / WebViewDelegate cleanup.darin@chromium.org2009-10-031-16/+8
| | | | | | | | | | | | Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.h darin@chromium.org2009-10-011-41/+16
| | | | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Originally reviewed here: http://codereview.chromium.org/251051 Review URL: http://codereview.chromium.org/255042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
* yMake ctrl-clicks in GMail open in background tabs rather than foreground tabs.ericu@google.com2009-10-011-0/+31
| | | | | | | | | | | This piggybacks on eseidel's fix last July that made middle-clicks work. BUG=2566 TEST=Manual testing on Vista with GMail and non-GMail links, with ctrl+click, middle-click, click, and ctrl+shift+click. Review URL: http://codereview.chromium.org/246040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27770 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27756.jorlow@chromium.org2009-10-011-6/+4
| | | | | | Review URL: http://codereview.chromium.org/249058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. The WebKit side can be ↵jorlow@chromium.org2009-10-011-4/+6
| | | | | | | | | | | found here: https://bugs.webkit.org/show_bug.cgi?id=29655 TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Review URL: http://codereview.chromium.org/223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.hmal@chromium.org2009-10-011-14/+38
| | | | | | | | | | | | | | | | | | | | | | | | ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/246060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.hdarin@chromium.org2009-10-011-38/+14
| | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional WebFrame parameter to WebView::findFrameByName.darin@chromium.org2009-09-301-2/+6
| | | | | | | | | | | | | This parameter is used to support _self and other names that need to be evaluated relative to a subframe. R=jam BUG=23009 TEST=none Review URL: http://codereview.chromium.org/257005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27646 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up webkit/api/public/WebView.hdarin@chromium.org2009-09-301-134/+135
| | | | | | | | | | | | | | This change does not completely eliminate webkit/glue/webview.h. Instead, the old WebView extends from the new WebView temporarily as we complete the transition. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/257001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
* WebView::DownloadImage refactoredyaar@chromium.org2009-09-291-32/+0
| | | | | | | | | The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView. DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView. Review URL: http://codereview.chromium.org/255006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cmd-up/cmd-down.thakis@chromium.org2009-09-291-22/+11
| | | | | | | | | | | | | | | | | The approach is to special-case moveToBeginningOfDocument and moveToEndOfDocument in WebFrameImpl::executeCommand(). With this (and the cocoa keyboard bindings patch being landed), the special-case code in WebViewImpl::ScrollViewWithKeyboard() can be removed. Also add a test for cmd-up/down. Change chrome.gyp so that it supports osx-only unit tests (_unittest_mac.mm). Move OnPrintPageAsBitmap to the other printing tests. BUG=22585 TEST=Go to a page with both text box and scrollbar (e.g. http://en.wikipedia.org ). Pressing cmd-down should scroll to end of page, cmd-up back to start. Clicking the text box and trying some emacs shortcuts should work (ctrl-a jumps to start of line, cmd-h acts as backspace, etc). Review URL: http://codereview.chromium.org/254002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27464 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48747:48766levin@chromium.org2009-09-271-1/+2
| | | | | | | | | | | | | | Rolling right up to the next breakage. Adding new breakages that I need to investigate. TBR=senorblanco@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/251006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more methods from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-241-2/+2
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/224010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27054 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 22712 -- REGRESSION: auto-complete close cause chrome crash.xji@chromium.org2009-09-231-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | crashed was caused by a dead loop introduced by a serial webkit changes in PopupMenuClient::hidePopup/PopupDidHide. Change AutocompletePopupMenuClient::popupDidHide() to call WebViewImpl::AutoCompletePopupDidHide() which only set the popup_showing_ flag instead of calling WebViewImpl::HideAutoCompletePopup(). BUG=http://crbug.com/22712 TEST= 1. Open the following html <html> <head> </head> <body> <form action="form_action.asp" method="get"> First name: <input type="text" name="fname" dir="rtl"/><br /> Last name: <input type="text" name="lname" /><br /> <input type="submit" value="Submit" /> </form> </body> </html> 2. Type some text in the "First name" input box, for example "abcd" 3. Click "Submit" 4. Open the file again 5. Type the first letter "a" and select "abcd". 6. "abcd" should be selected instead of crashing. Review URL: http://codereview.chromium.org/223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26935 0039d316-1c4b-4281-b951-d872f2087c98
* Shift+PageUp and Shift+PageDown should not scroll the web page.tony@chromium.org2009-09-211-1/+1
| | | | | | | | | | | | | | | | | Alt and Ctrl already don't scroll. Win+PageUp/PageDown does scroll. This matches Firefox. It doesn't match IE; IE lets you scroll using ctrl, shift or win. I'm doing this so the standard GTK+ key binding for ctrl+shift+page{up/down} can be used on linux to move tabs left/right (otherwise, the page scrolls and eats the key before we get to it). BUG=21594 Review URL: http://codereview.chromium.org/214026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26692 0039d316-1c4b-4281-b951-d872f2087c98
* Fold WebEditingClient into WebViewClient.darin@chromium.org2009-09-181-7/+4
| | | | | | | | | | R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/211032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused method and reorder methods to match the header.paul@chromium.org2009-09-181-7/+4
| | | | | | | | | BUG=22032 TEST=none. Review URL: http://codereview.chromium.org/210015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26626 0039d316-1c4b-4281-b951-d872f2087c98
* Newline at end of file for gcc to be happy.thomasvl@chromium.org2009-09-181-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/213024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26578 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebKitTabToLinksPreferenceKey for the test_shell.arv@chromium.org2009-09-171-0/+8
| | | | | | | | | | BUG=21267 TEST=Run layout tests Review URL: http://codereview.chromium.org/212004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26508 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug introduced by a WebKit merge where we did notpaul@chromium.org2009-09-171-0/+1
| | | | | | | | | | | | | tell our autocomplete popup to hide when it was closed. BUG=22032 TEST=Navigate to a page with an autocompletable input box (e.g. google.com login page) and notice that the autocomplete box hides when you select an item from it and hit enter. Review URL: http://codereview.chromium.org/211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26503 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-161-7/+8
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix canary bot.darin@chromium.org2009-09-141-0/+2
| | | | | | | | | | | | | Adds a missing function. We shouldn't need any extra implementation once we roll deps. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/205004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 2932: Chrome should not trigger page reloading when turn off ↵jshin@chromium.org2009-09-141-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | auto detect In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message). The new logic is as follows: -) If the user turns auto-detect OFF, nothing happens (as requested in the bug description) -) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding I.e., turning auto-detect on resets a previous override setting. The reverse is not true, however: specifiying a new override setting will not turn auto-detect off. BUG=2932 TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 : 1.) load the file while auto-detect is turned off -> garbage is displayed 2.) turn auto-detect on -> proper Chinese text should appear -> in the encoding menu, Chinese encoding should be highlighted 3.) turn auto-detect off -> proper Chinese text should remain -> in the encoding menu, Chinese encoding should remain highlighted 4.) choose any other encoding -> garbage is again displayed (in the new encoding) 5.) turn auto-detect on -> proper Chinese text should again appear -> in the encoding menu, Chinese should again be highlighted Original Review: http://codereview.chromium.org/173265 Patch by Roland Steiner (rolandsteiner@google.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
* Linux focus ring color: Go through WebKit::WebColor api rather than through ↵estade@chromium.org2009-09-111-9/+0
| | | | | | | | | | | | the webview. Also use SkColor isntead of a triplet of colors in RenderPreferences. BUG=21521 Review URL: http://codereview.chromium.org/195059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
* Supports Gtk keyboard themes.suzhe@chromium.org2009-09-101-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings). A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme. A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed. When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding. With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc. Known issue: If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events. BUG=11480 "Support GTK keyboard themes (emacs keybindings)" TEST=Switch to Emacs keyboard theme by changing the value of gconf key "/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and opens a webpage with a text input box. Input something into the text box, then press any of the Emacs key bindings defined in /usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For example, ctrl-p should move the cursor up one line, and ctrl-k should delete to the end of paragraph. Review URL: http://codereview.chromium.org/165293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient, replacing many WebViewDelegate methods.darin@chromium.org2009-09-101-6/+9
| | | | | | | | | | | | | | | | | | | Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none Review URL: http://codereview.chromium.org/200054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use gtk-cursor-blink from GtkSettings"evan@chromium.org2009-09-091-5/+0
| | | | | | This reverts commit r25797 due to Valgrind errors. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25812 0039d316-1c4b-4281-b951-d872f2087c98
* Use gtk-cursor-blink from GtkSettings to set theevan@chromium.org2009-09-091-0/+5
| | | | | | | | | | | | | | | | caret blink interval on Linux This can be set with the "Cursor Blinking" slider and checkbox in gnome-keyboard-properties. The changed setting will appear in a new renderer, so opening a new tab will see the change. WebKit side is at https://bugs.webkit.org/show_bug.cgi?id=28931 Patch by Joel Stanley <joel@jms.id.au> BUG=20772 Review URL: http://codereview.chromium.org/186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the os x spelling panel to chromium. Users canpinkerton@chromium.org2009-09-091-0/+8
| | | | | | | | | | | now access it from the main menu and context menu and use it to perform spelling tasks. For more detail, see http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc Patch from pwicks86@gmail.com (Paul Wicks). BUG=None TEST=The spelling panel should work in os x. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 04:03:24 +0000