| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=7986
R=finnur
Review URL: http://codereview.chromium.org/39141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change makes our IME backend run not only on Windows but also on Linux and Mac. This change also adds another unit-test which verifies the backend runs on Linux and Mac without problems.
Review URL: http://codereview.chromium.org/27124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
upstream's drawNodeHighlight methods.
BUG=5178
Review URL: http://codereview.chromium.org/31010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is. Will fix and recommit.
Review URL: http://codereview.chromium.org/28186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
A recommit of http://codereview.chromium.org/27056 .
Review URL: http://codereview.chromium.org/28136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used for gears file drag & drop in chrome, assign a drag id (identity) to
each drag and drop session.
Send the identity to the renderer WebViewImpl in drag enter notifications,
provide a getter method.
BUG=7995
Original patch by noel.gordon@gmail.com in:
http://codereview.chromium.org/28108/show
Review URL: http://codereview.chromium.org/28158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
be displayed in the wrong place when shown in a sub-frame.
BUG=8072
TEST=See bug.
Review URL: http://codereview.chromium.org/28141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or resized.
TEST=Bring up an autofill popup in a form, move the browser. The autofill popup should be closed.
BUG=7401
R=ben
Review URL: http://codereview.chromium.org/28126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.appspot.com/21071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=hbono
Review URL: http://codereview.chromium.org/21531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detached text field.
I am not sure how this could happen as when the text field has to have focus for the autofill popup to show and the popup is closed when it loses focus.
This CL is a work-around the crasher.
Hopefully someone will trigger the DCHECK and provide more info.
BUG=7708
TEST=Exercise the autofill.
Review URL: http://codereview.chromium.org/21528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change broke ui, interactive and Vista Perf tests. I felt like reverting.
Review URL: http://codereview.chromium.org/24020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process.
On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object.
On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.
This change is a slightly modified version of http://codereview.chromium.org/20221/show
Review URL: http://codereview.chromium.org/20430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct after scrolling page down.
This is caused by my bonehead mistake in fixing Issue 6652 that I forgot calling the FrameView::contentsToWindow() function. (I need to add a unit-test to prevent this regression, though.)
BUG=7651
Review URL: http://codereview.chromium.org/21338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change didn't have any description and it broke the tree
Review URL: http://codereview.chromium.org/21393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Internally, WebFrameImpl needs reference counting, so we still define it there.
Same goes for WebView and WebWidget.
While making this change, I noticed that WebInspectorClient was casting WebView
pointers to WebViewImpl pointers too much. By just starting with WebViewImpl
pointers, things could be cleaned up considerably.
R=brettw
Review URL: http://codereview.chromium.org/21342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Account for the renaming of toRange to toNormalizedRange done by Eric Seidel.
R=amanda
Review URL: http://codereview.chromium.org/20192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by a change in the PopupMenuChromium where the popup would first hide itself before setting the selection.
We use to delete our client on hide, causing a crasher when setting the selection.
This new CL makes the autocomplete popup and client live as long as the WebView is alive and the WebView reuse them (we just hide the popup when necessary).
TEST=In a form, type some text in an input field. Make sure the autocomplete popups up and behaves as expected.
BUG=7435
Review URL: http://codereview.chromium.org/21153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
option when the same-origin policy interferes with testing their web sites.
R=deanm
BUG=6449
Review URL: http://codereview.chromium.org/20101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a workaround for Issue 6971 "Chrome crashes if Javascript dynamically clears an input field while user attempts to type Korean into that field."
To prevent this crash, this code verifies if the parent nodes of an IME composition node exist and are editable before updating the composition node.
This change also changes an Editor::completeComposition() call to an Editor::setComposition() call to emulate the behavior of Safari. It seems Safari calls the Editor::setComposition() function when it cancels an ongoing composition.
Review URL: http://codereview.chromium.org/19619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
should be left to the text edit to proceed.
BUG=4874
Review URL: http://codereview.chromium.org/20046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
associated with. This is wrong, its font should be independent of the edit field.
TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font.
BUG=7372,6326
Review URL: http://codereview.chromium.org/20030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The death of FrameLoaderClient.cpp correspond with
<http://trac.webkit.org/changeset/40435>
* The custom V8 binding for V8HTMLFormElement::submit() corresponds with
<http://trac.webkit.org/changeset/40424>
* Changes to FrameLoader::loadFrameRequestWithFormAndValues() and
FrameLoadTypeRedirectWithLockedHistory correspond with
<http://trac.webkit.org/changeset/40432>
* No action was taken for the disable-web-security change
<http://trac.webkit.org/changeset/40449>, defaults to enabled.
* Frame::isFrameSet() moving to Document::isFrameSet corresponds with
<http://trac.webkit.org/changeset/40443>
* Frame::sendResizeEvent() moved to EventHandler::sendResizeEvent()
<http://trac.webkit.org/changeset/40444>
* Not sure which webkit change added RenderObjectChildList.cpp.
=======================
Rebaselined the following layout tests to reflect upstream changes:
=======================
* LayoutTests/fast/table/form-with-table-style.html
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/table/form-with-table-style-expected.png?rev=40457
* LayoutTests/fast/table/insert-row-before-form.html
http://trac.webkit.org/changeset/40456/trunk/LayoutTests/platform/mac/fast/table/insert-row-before-form-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/fast/table/insert-row-before-form-expected.txt
* LayoutTests/tables/mozilla/bugs/bug4527.html
http://trac.webkit.org/changeset/40458/trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt
* LayoutTests/tables/mozilla/bugs/bug96343.html
http://trac.webkit.org/changeset/40458/trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug96343-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug96343-expected.txt
* LayoutTests/tables/mozilla_expected_failures/bugs/bug1725.html
http://trac.webkit.org/changeset/40459/trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
* LayoutTests/tables/mozilla_expected_failures/other/test4.html
http://trac.webkit.org/changeset/40460/trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt?old=34683&old_path=trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
* LayoutTests/editing/deleting/deletionUI-single-instance-actual.png
http://trac.webkit.org/changeset/40454/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt?old=32226&old_path=trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt
Review URL: http://codereview.chromium.org/21007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
away from the input box".
This issue is caused by a recent WebKit merge that changes the behavior of the ScrollView::contentsToWindow() function.
To fix this issue, this change uses the SelectionController::absoluteCaretBounds() function instead of calling the ScrollView::contentsToWindow() function.
BUG=6252
Review URL: http://codereview.chromium.org/17638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=macdome
Review URL: http://codereview.chromium.org/18140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer).
Most of the file changes are just renaming focus_on_show to activatable.
TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderThemeChromiumWin (for now)
R=darin
Review URL: http://codereview.chromium.org/16211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
empty text-field:
- presses the up/down arrow key
- left-clicks it
The other browsers have that feature.
BUG=5130
TEST=See bug.
Review URL: http://codereview.chromium.org/14852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- we now reuse the existing popup if there is one (instead of creating a new on with each key stoke), this prevents the flickering we used to see.
- we don't hide the popup on every key stroke, instead we rely on the client editor telling us the field is not being edited anymore.
TEST=Enter some text in a form's text field several times, the autofill should show and not flicker.
BUG=5258
Review URL: http://codereview.chromium.org/14100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields.
Review URL: http://codereview.chromium.org/13731
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BackForwardListClientImpl.
R=dglazkov
Review URL: http://codereview.chromium.org/14407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ojan
Review URL: http://codereview.chromium.org/13768
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with where they will live once we upstream them.
R=ojan
Review URL: http://codereview.chromium.org/13727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Same as issue 12981 with but now with change to test_shell.vsprops. This change makes it actually compile on windows! It also makes it clear that test shell is looking in webkit directories for include files. Apparently this was already the case on linux and mac, but it is new for windows.
Review URL: http://codereview.chromium.org/13678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=ojan
Review URL: http://codereview.chromium.org/13675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
native key code.
Also match windows behavior for setting m_text field of platform event equal to key_code.
update: fixes at least 7 layout tests.
Review URL: http://codereview.chromium.org/12981
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pressing ESC.
I had to introduce another acceptOnAbandon member, though the name I came up with is pretty lame.
BUG=4803
TEST=Type some text in a from input text, in the autofill popup menu, use the arrow keys to select something then press ESC. The text input content should not change. Also, make sure the select input still does keep the selection when ESC is pressed.
Review URL: http://codereview.chromium.org/12667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6042 0039d316-1c4b-4281-b951-d872f2087c98
|