| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
self-contained.
Review URL: http://codereview.chromium.org/45047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The solution is to add a user-defined identifier to UploadData.
If that identifier is set, and if the request method is POST,
then HttpCache will enable caching for the response. (The cache
key will be a composition of the identifier and the URL.) A
subsequent POST request to the same URL with the same identifier
will "hit" the previously generated cache entry. Reuse from the
cache is subject to all of the standard rules.
For reference, here are the corresponding net changes:
http://codereview.chromium.org/52028
Here are the corresponding WebKit changes:
http://trac.webkit.org/changeset/41919
BUG=2636
R=sky
Review URL: http://codereview.chromium.org/52040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Writing a bitmap to the clipboard is a rather slow operation, as it involves piping it over IPC and then converting it to a PNG.
Review URL: http://codereview.chromium.org/42592
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8786
Review URL: http://codereview.chromium.org/42587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/47009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is almost the same change as <http://codereview.chromium.org/39252/show>, which caused a build break on a Linux buildbot while compiling my new template function in "chrome/common/render_messages.h".
Even though I was not able to reproduce the build errors on my Linux box, I removed this function and use the int type in my IPC message 'ViewMsg_SetTextDirection'.
BUG=1845
Review URL: http://codereview.chromium.org/42495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nico Weber <nicolasweber@gmx.de>.
Review URL: http://codereview.chromium.org/42561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the autofill popup.
Pressing up would not trigger that behavior.
This happened because the default processing of the up arrow key is to move the caret to the beginning of the text input.
Showing the autofill is done as a posted task.
Because the caret was not at the end of the text-field by the time that task got executed, the popup would not show.
The fix is to not default process the up/down arrow key messages when an autofill popup will be shown.
Also fixed the WebViewImpl::HideAutoCompletePopup (harmless bug, calling it twice would cause it to hide the already hidden popup).
BUG=6437
TEST=Make sure up/down arrow keys trigger the autofill menu correctly (especially when there is already text in the text-field). Make sure autofill still works as expected.
Review URL: http://codereview.chromium.org/53017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Mac test_shell. Once the changes to
WebKit/WebCore/platform/chromium/PopupMenuChromium* have
been upstreamed (then landed in our tree), we can enable
them in test_shell.
The WebKit part is contained in this bug:
https://bugs.webkit.org/show_bug.cgi?id=24692
BUG=5095 (http://crbug.com/5095)
Review URL: http://codereview.chromium.org/48149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the code triggering this was just checking that the focused element before and after processing the event was the same.
We need to do a hit test to ensure the click is really on the text field, otherwise in cases where clicking somewhere in the page does not change the focus, we would bogusly bring up the autofill popup.
BUG=8627
TEST=Ensure autocomplete popup still works as expected: when entering text, when using up/down arrows, when clicking selected text field. Also ensures the scenario from the bug does not trigger the popup.
Review URL: http://codereview.chromium.org/50038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag):
- Add new devtools IPC message
- Expose WebView's hit target
- Refactor dom_agent interaction not to send information known to client
- Collect incoming messages on the client until frontend is loaded
- Add Inspect Element scenario into the devtools_host_stub
Review URL: http://codereview.chromium.org/45022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
results.
Review URL: http://codereview.chromium.org/42262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the title in the task manager, and show an infobar when a page's workers die.
I also cleaned up the code in RenderView which creates a window and widget, since when I originally wrote it I wasn't aware of RenderViewHost::FromID.
Review URL: http://codereview.chromium.org/45025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The encoding parameter got dropped from Workers (r41871) so
drop it through the whole stack.
The upstream WorkerContextExecutionProxy has trackEvent with a lower
case t, but we pull in the wrong header in some places so make
both headers match.
Review URL: http://codereview.chromium.org/42538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move callbacks processing to the frontend
2. Dispatch calls directly to Javascript
3. Create CppBoundObject per agent flavor and wire it to IPC
4. Introduce Remote*Agent abstraction in the frontend
Review URL: http://codereview.chromium.org/42486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
type="range">.
This code will not be called until I land the upstream hooks to RenderThemeChromiumWin.cpp to use it.
BUG=8931
Review URL: http://codereview.chromium.org/42451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
deletes that suggestion from the DB.
BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.
Review URL: http://codereview.chromium.org/42258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(including the use of AccessibleBase and AccessibleDocument) in the glue accessibility implementation.Introduces the GlueAccessibilityObject, which serves as a platform-independent wrapper directly around WebKit's AccessibilityObject (also platoform-independent).Updates naming/comments to reflect the independence of IAccessible both in glue and (where appropriate) in the browser-side accessibility.
Review URL: http://codereview.chromium.org/46013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin would draw over the iframe DOM
element, effectively hiding it. This is handled by our IFrame shim geometry calculation, where we subtract the
rect of any IFrame above the plugin in the ZOrder from the plugin rect.
Webkit calls Widget::setFrameRect at various times, during layout/size changes/paints, etc. The reason this bug
showed up, was due to an optimization in our setFrameRect implementation, where we would bail out if the rect
passed in was the same size as the current plugin rect. Basically the IFrame appears above the plugin in the ZOrder
much later, which causes us to return without sending over the cutout rects to the browser when it moves the plugin
windows.
Fix is to move the rects equality check to WebPluginImpl::setFrameRect, where we don't send over the UpdateGeometry IPC to the plugin process if the rects are the same.
WebPluginImpl used to implement the webkit Widget interface a long time ago. This is no longer the case. So some
of the functions don't need to be virtual anymore. I also made this change.
This fixes bug http://b/issue?id=1722236 and http://code.google.com/p/chromium/issues/detail?id=8858
Bug=1722236,8858
Review URL: http://codereview.chromium.org/42413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we still have the hack where we pass raw pointers into the
renderer, we should catch the NULL case and return something sane.
Additionally, while I'm at it, always tell WebKit that it has a 32-bit
screen. Since it paints via IPC messages, it doesn't need to know what
the actual screen is using; we handle all that in the BackingStore.
Review URL: http://codereview.chromium.org/50030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8100
Review URL: http://codereview.chromium.org/42377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default configuration. This simplifies the build system.
My concern was that some consumers of the API might mix-up the defines.
R=dglazkov
Review URL: http://codereview.chromium.org/42392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes a change to not have third_party/WebKit/WebKit/chromium/public
in the global include path. Most of the code changes pertain to this.
I also took this opportunity to do some renaming:
browser/cache_manager_host -> browser/renderer_host/web_cache_manager
R=brettw
Review URL: http://codereview.chromium.org/42194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
perform autocomplete.
This matches FF behavior.
BUG=6310
TEST=See bug.
Review URL: http://codereview.chromium.org/48033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
find_bar_controller.cc:
Unused local variable created.
hwnd_view.cc:
The local definition of parent overshadows param passed in.
google_update.cc:
Uninitialized member variable.
webframe_impl.cc:
The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change.
Review URL: http://codereview.chromium.org/42321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/42332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/44007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below.
1. Emulating the implementation of Safari that changes the text-direction of an input element.
Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction.
2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys.
This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys.
BUG=1845
Review URL: http://codereview.chromium.org/39252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plumbing the security origin of the frame making the request to SSL land.
R=wtc
BUG=8706
Review URL: http://codereview.chromium.org/48038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expose some more accessors on WebFrame.
R=wtc
BUG=8706
Review URL: http://codereview.chromium.org/48034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We would like to use the entry response_data_file in ResourceResponseHead
(currently in chrome/browser/resource_handler.h) in chrome/renderer. So refactor the
member and move it to webkit_glue::ResourceLoaderBridge::ResponsseInfo which
is the base class of ResourceResponseHead.
Review URL: http://codereview.chromium.org/42199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes and can't be committed without first landing them and adding DEPS to this.
Review URL: http://codereview.chromium.org/48037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
routing id directly. This simplifies the renderer code and also allow this code to be used in worker processes, where we don't have a frame.
Review URL: http://codereview.chromium.org/46026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DevToolsAgent now implements WebDevToolsAgentDelegate, DevToolsClient covers WebDevToolsClientDelegate.
WebDevToolsAgent instance is being created by the WebView early in the init code and belongs to it. WebView exposes interface for accessing the agent; it also extends its delegate interface to pass WebDevToolsAgentDelegate into it.
Note that there is no call overhead unless particular sub-agents are enabled in the WebDevToolsAgent.
WebDevToolsClient instance is being created externally by the DevToolsClient.
Review URL: http://codereview.chromium.org/46032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a text-field, even if the text-field is not empty.
BUG=6437
TEST=Open a form with several fields. Start entering text in a text field to bring-up the autocomplete popup. Click somewhere else (so the popup is closed). Click again in the text-field (at the end). On the 2nd click the autocomplete popup should show.
Review URL: http://codereview.chromium.org/42198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"try multiple commits" feature.
Review URL: http://codereview.chromium.org/46062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11683 0039d316-1c4b-4281-b951-d872f2087c98
|