summaryrefslogtreecommitdiffstats
path: root/webkit/glue
Commit message (Collapse)AuthorAgeFilesLines
* Porting the browser tests to Unix.jcampan@chromium.org2009-06-052-13/+13
| | | | | | | | | | | | | The browser tests are an alternative to UI tests. They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes). In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/115896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes an issue where the MSAA information was not reported back correctly to ↵klink@chromium.org2009-06-053-7/+9
| | | | | | | | the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none Review URL: http://codereview.chromium.org/118206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: better handling of DevTools' reset and initial load.mnaganov@chromium.org2009-06-058-69/+111
| | | | | | | | | | | Rationale: as V8 can't be reset for the process, it means that profiling logs are permanent from the viewpoint of a DevTools instance. Thus, we don't need to reset Profiles panel UI as opposed to WebKit. BUG=none TEST=none Review URL: http://codereview.chromium.org/119175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17723 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension to expose some primitives to JS for doing mbelshe@google.com2009-06-051-0/+6
| | | | | | | | | | | | | | | | | benchmarking from within Chrome. Because the JS resides in the renderer and the HTTP logic resides in the browser, this required creation of two new, control messages which can be sent from the renderer to the browser. These are controlled under a new commandline option "--enable-benchmarking" BUG=6754 TEST=none Review URL: http://codereview.chromium.org/119191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17722 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix expression evaluation while on a breakpoint.pfeldman@chromium.org2009-06-041-1/+1
| | | | | | | | BUG=13251 Review URL: http://codereview.chromium.org/118236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17637 0039d316-1c4b-4281-b951-d872f2087c98
* One more attempt at fixing the keyboard focus issue when the windowless ↵ananta@chromium.org2009-06-041-2/+22
| | | | | | | | | | | | | | | | | | | | | | | Flash plugin puts up a context menu and we click on the browser window. The Flash plugin at times sets focus to its hidden popup window with class name SWFlash_PlaceholderX in the context of the TrackPopupMenu call. This causes the browser ui thread to receive a WM_ACTIVATEAPP message indicating that another top level window has become active, which causes this issue. This also happens in Firefox at times. However in Firefox the popup lives on the ui thread and hence the sideeffect is that no window has keyboard focus. Our workaround/fix for this scenario is to identify when this occurs and send over a raw mousedown/mouseup event via SendInput to the last focus window. Fixes http://code.google.com/p/chromium/issues/detail?id=8988 Bug=8988 Review URL: http://codereview.chromium.org/119049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17636 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: do not lose console message type on marshalling.pfeldman@chromium.org2009-06-041-1/+2
| | | | | | Review URL: http://codereview.chromium.org/119167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17627 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: reuse more code from WebKit Inspector.mnaganov@chromium.org2009-06-044-111/+118
| | | | | | | | | | | | | | | | This enables: - links to source code from call graph tree; - focusing and exlusion of functions; - search (but it seems not fully-functional in WebKit Inspector for now). Also moved to profiler_processor WebKit-specific code from V8/tools/profile_view. BUG=none TEST=none Review URL: http://codereview.chromium.org/118230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect parens around a format string call.deanm@chromium.org2009-06-041-1/+1
| | | | | | | | | | I noticed this from a GCC warning: webkit/glue/inspector_client_impl.cc:267: warning: cannot pass objects of non-POD type `class WebCore::String' through `...'; call will abort at runtime Review URL: http://codereview.chromium.org/119166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17625 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit 44372:44405, resubmit.dimich@google.com2009-06-042-10/+6
| | | | | | | | | | | | | | | | Fixed Mac build (needed to remove a file that was removed upstream). Added expected Linux layout tests failures from the first landing attempt. Removing the chromium-specific snapshot for list-wrapping-image-crash-expected.html test because the test was incorrectly added upstream. Will fix it upstream and then re-enable in Chromium. Original code review: http://codereview.chromium.org/118215 TBR=ukai BUG=13305, 13313, 13314 (layout tests - reenable, rebaseline) TEST=none Review URL: http://codereview.chromium.org/119156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17616 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17601 (build break on mac)dimich@google.com2009-06-042-6/+10
| | | | | | | | TBR=ukai BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17602 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit DEP roll 44372:44405dimich@google.com2009-06-042-10/+6
| | | | | | | | | | BUG=none TEST=no compile or layout test failures. There is a change (http://trac.webkit.org/changeset/44401) here which will likely break quite a few Linux layout tests. The plan is to run the build, then add all the tests with REBASELINE keyword into test_expectations.txt for automated rebaselining. Review URL: http://codereview.chromium.org/118215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17601 0039d316-1c4b-4281-b951-d872f2087c98
* Find in page should cause the scrollbar to repaint with tick marks.tc@google.com2009-06-031-1/+1
| | | | | | | | | | | | This method is used to invalidate the scrollbar which causes it to repaint. Enable this code to run on linux too. BUG=11706 Review URL: http://codereview.chromium.org/118089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser hang due to plugin deadlockamit@chromium.org2009-06-033-28/+57
| | | | | | | | | | | | | | | | | | | | | This involves two plugin instances with second instance making sync calls to the renderer while the first one is still servicing an incoming sync request. Our logic to unblock the renderer during the sync call fails since the 'in_dispatch_' counter is maintained per plugin channel (each plugin instance uses its own separate channel). Making 'in_dispatch_' counter static member of PluginChannelBase fixes this deadlock. Added a new NPAPI UI test for this scenario. BUG=12624 TEST=MultipleInstancesSyncCalls Review URL: http://codereview.chromium.org/119052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17492 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Catch up with InspectorController changes.pfeldman@chromium.org2009-06-037-2/+122
| | | | | | Review URL: http://codereview.chromium.org/119077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17474 0039d316-1c4b-4281-b951-d872f2087c98
* Implement InspectorClient's Settings API.pfeldman@chromium.org2009-06-034-7/+121
| | | | | | | | | | | | | | | This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done: - inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC. - There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update. Two things I don't like: 1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option. 2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one? Review URL: http://codereview.chromium.org/119041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17473 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to glue to get the full html of the page and also to check if ↵sverrir@google.com2009-06-024-0/+57
| | | | | | | | | | | the user has selected something. This is for enhanced printing support (in progress). Review URL: http://codereview.chromium.org/119043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17427 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: use sampling rate reported by V8 profiler.mnaganov@chromium.org2009-06-022-9/+30
| | | | | | | | | | | Also fix a small problem with displaying "Processing..." icon: handle the case when log processing finishes prior to 'didIsProfilingStarted_' arrived. BUG=none TEST=none Review URL: http://codereview.chromium.org/119039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17400 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler UI changes.mnaganov@chromium.org2009-06-023-13/+76
| | | | | | | | | | | | | - filter our V8 natives; - display a notification that profile is being processed to avoid confusion; - do not display ".000" part when displaying time. BUG=none TEST=none Review URL: http://codereview.chromium.org/118112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17399 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of that egregious serif font in autofill popups on os x by removing ↵thakis@chromium.org2009-06-011-16/+2
| | | | | | | | | | | NOTIMPLEMENTEDs. BUG=none TEST=Go to a page with a form with a text field, enter something, go to the page again, begin entering the same thing. A autofill popup appears. Check that the font in the popup looks like the system font. Review URL: http://codereview.chromium.org/115978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17355 0039d316-1c4b-4281-b951-d872f2087c98
* Have the find bar show number of matches on linux.tc@google.com2009-06-011-2/+2
| | | | | | | | | | | | We needed to enable some code in webkit/glue/webframe_impl.cc and add a line to clear the results in find_bar_gtk.cc. BUG=12955 Review URL: http://codereview.chromium.org/115960 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17335 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in webkit/gluephajdan.jr@chromium.org2009-06-0126-26/+20
| | | | | | | | | - reduce header dependencies - remove redundant forward declarations Review URL: http://codereview.chromium.org/115871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17313 0039d316-1c4b-4281-b951-d872f2087c98
* port webkit changeset 44066ukai@chromium.org2009-06-011-0/+2
| | | | | | | | | | | Look for the VLC plug-in's new name. BUG=0 TEST=no additional regtests Review URL: http://codereview.chromium.org/113813 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert WebURLLoader landing. Too many layout test failures.darin@chromium.org2009-05-3013-1236/+1215
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/115973 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test failures.darin@chromium.org2009-05-301-1/+2
| | | | | | | | | | | | | | | | | | | | 1- We need to be careful when converting from a null WebURL to a GURL since std::string(NULL, 0) crashes. 2- It turns out that in some layout tests, willSendRequest sets the request to null to indicate that we should not follow the redirect. In the few cases I debugged, this was happening because we were redirecting from "localhost" to "127.0.0.1". It seems like we probably need to change the hostname used to load HTTP based layout tests to match what the tests expect. For now, I just commented out the assertion since it was something that I had just newly added. BUG=none TEST=covered by layout tests TBR=dglazkov Review URL: http://codereview.chromium.org/115970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17291 0039d316-1c4b-4281-b951-d872f2087c98
* Start using WebURLLoader, et. al. from the WebKit API.darin@chromium.org2009-05-3013-1215/+1235
| | | | | | | | | | | | | | | | | | | | | | | | Moves our ResourceHandle to webkit/api/src/ResourceHandle.cpp from webkit/glue/resource_handle_impl.cc. A portion of resource_handle_impl.cc was moved into weburlloader_impl.{h,cc}, which now contains our implementation of WebURLLoader. The annoying parts of this CL involve WebPluginImpl. I had to convert it over to using WebURLLoader instead of ResourceHandle so that MultipartResourceDelegate can be shared. There is some complexity in WebURLRequest / WebURLResponse to make it cheap to wrap a ResourceRequest / ResourceResponse. I think this is worth it since there is a lot of conversion between the two types. BUG=10038 TEST=covered by existing tests R=dglazkov Review URL: http://codereview.chromium.org/113928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17290 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=12192rafaelw@chromium.org2009-05-303-330/+0
| | | | | | | | R=aa Review URL: http://codereview.chromium.org/115681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17269 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code path that passes a file handle to the rendererhclam@chromium.org2009-05-292-27/+0
| | | | | | | | | | | | | | | | | | | | | | Since the code now does range request without any caching the code path for passing file handle is not used any more. Changes: 1. Remove response_data_file in webkit_glue::ResourceResponseHead 2. Remove response_data_file in net::ResourceInfo 3. Remove code that passes file handle using IPC 4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost 5. Remove MediaResourceHandler 6. Remove code in disk_cache that expose the file handle 7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used 8. Reset cache size for media cache to default BUG=12249 BUG=12256 Review URL: http://codereview.chromium.org/113931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17227 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mimetype queries for media fileshclam@chromium.org2009-05-292-0/+6
| | | | | | | | | | Added code path from WebKit to net::mimt_util to query supported mime-types for media files. BUG=12777 Review URL: http://codereview.chromium.org/114060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17225 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: decouple class and method names from RPC message arguments. That ↵yurys@google.com2009-05-2913-77/+159
| | | | | | | | would allow to select dispatcher wothout parsing the message argument. Review URL: http://codereview.chromium.org/115862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17176 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Fix standalone mode for Inspector frontend.pfeldman@chromium.org2009-05-281-2/+2
| | | | | | Review URL: http://codereview.chromium.org/115864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17075 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add support for non-trivial console messages.pfeldman@chromium.org2009-05-281-2/+15
| | | | | | Review URL: http://codereview.chromium.org/113953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17074 0039d316-1c4b-4281-b951-d872f2087c98
* Separate results of profiling sessions.mnaganov@chromium.org2009-05-283-33/+75
| | | | | | | | | | Now data for each profiling session is collected separately (previously they were accumulated in a single profile). BUG=none TEST=none Review URL: http://codereview.chromium.org/113950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17072 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Migrate to InspectorController for network and console events.pfeldman@chromium.org2009-05-2721-882/+291
| | | | | | | | | | | | | | - introduced bound object on the agent side; - established remote dispatch of WebInspector calls - using fake InspectorFrontend for serializing events and sending them over the ipc - removed net agents from both sides - moved GetResource stuff to tools agent Assumes following is landed: https://bugs.webkit.org/show_bug.cgi?id=26010 Review URL: http://codereview.chromium.org/113836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16980 0039d316-1c4b-4281-b951-d872f2087c98
* The autofilling of passwords when the URL for visited page and the page the ↵jcampan@chromium.org2009-05-262-2/+22
| | | | | | | | | | | | | password was stored are different was broken. This happened as part as some refactoring done for the form autofill last year. BUG=12675 TEST=See bug. Review URL: http://codereview.chromium.org/113853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16950 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in ImageDecoder::Decode.mpcomplete@google.com2009-05-261-1/+5
| | | | | | | | BUG=12549 TEST=none Review URL: http://codereview.chromium.org/115793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16941 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we have a Cocoa NSGraphicsContext when needed.jrg@chromium.org2009-05-261-0/+2
| | | | | | | | | | | | For now we still use Cocoa so we need a NSGraphicsContext when drawing (not just a CGContext). BUG=12474 See related CL http://codereview.chromium.org/114020 Review URL: http://codereview.chromium.org/115732 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16886 0039d316-1c4b-4281-b951-d872f2087c98
* Set focus to the dummy plugin window used to ensure that keyboard focus ↵ananta@chromium.org2009-05-262-28/+26
| | | | | | | | | | | | | | | | | | | | | correctly works in context menu's put up by windowless plugins in the TrackPopupMenu intercept. We now intercept this API for windowless Flash plugins as well. Removed the code to unhook the message filter hook used to detect modal loops from HandleEvent, as this already happens in the OnModalLoopEntered function. We now intercept TrackPopupMenu for all windowless plugins. This fixes http://code.google.com/p/chromium/issues/detail?id=8988 Bug=8988 Review URL: http://codereview.chromium.org/113804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16878 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use event context to decide which agent should be used for ↵yurys@google.com2009-05-262-80/+49
| | | | | | | | | handling the event. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16586 Review URL: http://codereview.chromium.org/113629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16871 0039d316-1c4b-4281-b951-d872f2087c98
* Sync with the profiler changes in V8.mnaganov@chromium.org2009-05-265-61/+92
| | | | | | | | | - Use context prior to calling 'ResumeProfiler'. - Check the status of the profiler using 'IsProfilerPaused'. Review URL: http://codereview.chromium.org/115767 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16868 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: disable console autocompletion until we come up with some good ↵yurys@google.com2009-05-251-0/+11
| | | | | | | | | solution for asynchronouse completion. BUG=12435 Review URL: http://codereview.chromium.org/115753 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16853 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit to r44123darin@chromium.org2009-05-253-4/+4
| | | | | | | | | | | | | | | | | This required dealing with a few changes in WebKit: 1- ImageBuffer::create() now returns a PassOwnPtr instead of an auto_ptr. 2- ChromeClient::createHTMLParserQuirks() now returns a PassOwnPtr instead of a raw pointer. 3- HTMLFormControlElement::onChange was renamed dispatchFormControlChangeEvent. 4- dom/SelectElement.{h,cpp} were added to the tree. TEST=none R=ukai BUG=none Review URL: http://codereview.chromium.org/115751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16849 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that seekable streams are removed from the list of resource ↵ananta@chromium.org2009-05-233-2/+7
| | | | | | | | | | | | | | | | | | | | clients maintained by WebPluginProxy. The PluginStreamUrl object ensures that it notifies the webplugin object that it is being deleted in its destructor. The other change is to remove the call to CancelRequest in WebPluginDelegateImpl::CreateResourceClient for seekable streams, as this call does not do anything for manual streams created with a resource id of -1. In any case for byte range requests, receiving a new response does not mean that earlier requests should be cancelled. This fixes bug http://code.google.com/p/chromium/issues/detail?id=12445 BUG=12445 Review URL: http://codereview.chromium.org/113772 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16828 0039d316-1c4b-4281-b951-d872f2087c98
* CPAPI gears drag drop and renderer IPC.michaeln@google.com2009-05-222-3/+133
| | | | | | | | | | | | | | | CPAPI (0.10) functions for gears drag drop; one to extract thedrag type/data given an NPObject *event, one to override thedrop effect (drag cursor). Gears drag drop API receives a browser event as an NPObject* sothe event is untrusted. Provide IPC calls to the renderer sogears can pass the event to renderer/V8 for checking, prior todrag type/data extraction, or the setting of the drop effect. Original patch by Noel Gordon via: http://codereview.chromium.org/99240 BUG=7995 TEST=none Review URL: http://codereview.chromium.org/112056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16808 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS and fix build bustage. Propagate rename of policyBaseURL -> ↵abarth@chromium.org2009-05-222-11/+1
| | | | | | | | | | | | firstPartyForCookies a bit further. TBR=darin TEST=It complies! BUG=None Review URL: http://codereview.chromium.org/112055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16804 0039d316-1c4b-4281-b951-d872f2087c98
* Fix merge.abarth@chromium.org2009-05-221-4/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16788 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit DEPS and fix compile errors.abarth@chromium.org2009-05-225-15/+18
| | | | | | | | | | TBR=wtc BUG=None TEST=It compiles Review URL: http://codereview.chromium.org/115717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16784 0039d316-1c4b-4281-b951-d872f2087c98
* Make WebRequest be a wrapper for ResourceRequest instead of FrameLoadRequest.darin@chromium.org2009-05-226-69/+46
| | | | | | | | | | | | | It turns out that no one was ever reading the frameName field, so this change is quite trivial. BUG=10038 TEST=none R=brettw Review URL: http://codereview.chromium.org/115713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16780 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 8052 - Keyboard selection in Hebrew select element ↵xji@chromium.org2009-05-221-0/+9
| | | | | | | | | | | | | | | | doesn't work The fix consists of 2 parts: The 1st part is in WebKit/WebCore/platform/chromium/PopupMenuChromimu.cpp. The patch is in https://bugs.webkit.org/show_bug.cgi?id=25899. The 2nd part is in webkit/glue/webwidget_impl.cc: Adding WebInputEvent::Char event type handling in WebWidgetImpl::HandleInputEvent(). The comment should be self-explained. BUG=http://crbug.com/8052 TEST=In a HTML containing <select> tag and Hebrew character options, open the Hebrew select element, type a Hebrew letter which is the first letter of one option, that option should be selected. Review URL: http://codereview.chromium.org/113712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16752 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16748.abarth@chromium.org2009-05-221-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16750 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 02:17:17 +0000