| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
for all different scenarios.
Note I grabbed the plugin hwnd and manually checked it instead of looking for callbacks from the plugin's SetWindow since the latter isn't called if the visibility changes.
BUG=1842096
TEST=regression test included, test http://chromedashboard per bug
Review URL: http://codereview.chromium.org/115169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the activex shim for windows media player.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=11342
Bug=11342
Review URL: http://codereview.chromium.org/113131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=0
TEST=0
Review URL: http://codereview.chromium.org/113127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
KURL to WebURL. That conversion will go away once this code moves
into WebKit/chromium/src.
R=hclam
Review URL: http://codereview.chromium.org/114009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since mac doesn't use skia, there's no WebCanvas, so disable everything
using WebCanvas for mac.
TBR=scherkus, darin
Review URL: http://codereview.chromium.org/113076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Highlights:
1. WebCore::MediaPlayerPrivate now only has one static method that constructs WebMediaPlayerClient
2. Implementation of WebCore::MediaPlayerPrivateInterface now is WebMediaPlayerClient
3. WebMediaPlayerClient does the delgation to WebMediaPlayer
4. Implemtnation of real media player will go into chrome/renderer and implements WebMediaPlayer
Review URL: http://codereview.chromium.org/105007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebViewImpl by accessing it indirectly through the Frame's Page so that we
don't have to worry about cleaning up the WebFrameImpl -> WebViewImpl pointer.
WebCore already clears the Frame's Page pointer when the Page is destroyed by
the WebViewImpl.
Patch by Marshall Greenblatt
R=darin
Review: http://codereview.chromium.org/99283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to accomodate upcoming implementation changes.
Review URL: http://codereview.chromium.org/113041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11477
Review URL: http://codereview.chromium.org/113031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/109042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jam
Review URL: http://codereview.chromium.org/109028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for anything; it will be used for whitelisting popups by hostname.
BUG=11440
Review URL: http://codereview.chromium.org/105004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in fact are methods. Show the method names for them.
Review URL: http://codereview.chromium.org/108018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/109010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden.
BUG=8927
TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug
Review URL: http://codereview.chromium.org/106008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/108005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shell_ being null. Moved the RevokeDragDrop call to the
TestShell destructor instead.
Eliminate webkit/glue/webhistoryitem* in favor of adding a
NavigateBackForwardSoon method WebViewDelegate. This moves
all of the hacky details of how we intercept "history.{back,
forward,go}" into the webkit layer. My eventual plan is to
teach WebCore how to make this not hacky.
BUG=11423
R=mpcomplete
Review URL: http://codereview.chromium.org/108004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're constrained by hardcoded icon dimensions (pan_icon.png is limited to 20x20) in WebKit, but in the interest of time, we're going to play within those restrictions.
TBR=finnur
BUG=11277
TEST=Do some autoscrolling, verify that our icons are different to Safari's. Verify that they don't disappear on black-backgrounded webpages.
Review URL: http://codereview.chromium.org/105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Fix an 80-column issue
* Remove an unused param
* Remove an unnecessary setter
* Fix a variable capitalization style violation
Review URL: http://codereview.chromium.org/100361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PageAction code that serves the same purpose (and more).
BUG=9812
TEST=No test needed, this shouldn't result in any noticable difference
since the RSS parsing was disabled.
Review URL: http://codereview.chromium.org/100356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/99370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NavigateBackForwardSoon method WebViewDelegate. This moves
all of the hacky details of how we intercept "history.{back,
forward,go}" into the webkit layer. My eventual plan is to
teach WebCore how to make this not hacky.
BUG=11423
R=mpcomplete
Review URL: http://codereview.chromium.org/100353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets called from WebFrameLoaderClient::frameLoaderDestroyed().
The Chromium Embedded Framework needs this notification to properly clean up
memory associated with specific WebFrame instances (for example, custom
NPObject types bound to the WebFrame via BindToWindowObject()).
This patch was contributed by Marshall Greenblatt.
R=aa,darin
Review: http://codereview.chromium.org/99283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions by posting a task back to the message loop before
notifying the RenderWidgetHost to perform these operations.
Otherwise, the JS code races with the browser to use the
modified window.
BUG=http://crbug.com/6377
BUG=http://crbug.com/6192
Also, because window resizing is asynchronous between the renderer
and browser, added a renderer-side cache of "pending window rect"
to ChromeClientImpl. Before the change, calling setWindowRect() would
schedule a call to the RenderViewHost to do the work, but a subsequent
call to windowRect() would return the current size, as through the
call to setWindowRect() had never happened. We cache a pending size
and then schedule a task on the message loop to clear the cached size.
This allows javascript which writes and reads the WindowRect sizes to
work, and once we come out of JS and return to the message loop, we'll
go back to asking the RenderViewHost for the true values.
This pending_window_size is my only concern about this patch. It does
pass all layout tests, and the ChromeClientImpl code is executed in the
test_shell.exe code path.
BUG=http://crbug.com/835
TEST=LayoutTests have tests which cover all of these actions. The
problem is that we run layout tests using the test_shell, not Chrome.
Review URL: http://codereview.chromium.org/101019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
host functions.
Review URL: http://codereview.chromium.org/100254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for file download via context-menu.
For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later.
Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu).
If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage).
This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following:
1. RFC 2047
2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage.
3. %-escaped UTF-8.
In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests.
BUG=1148
TEST=net unit test: NetUtilTest.GetFileNameFromCD
NetUtilTest.GetSuggestedFilename
unittest : DownloadManagerTest.TestDownloadFilename
Review URL: http://codereview.chromium.org/83002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rest of the WebKit API, which is single threaded. Also a bunch of small fixes to make layout tests pass: the dll was being unloaded while its functions were still queued to be dispatched, and a string allocated in the dll was being GC'd in test shell.
BUG=11011
Review URL: http://codereview.chromium.org/102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin's windowproc, otherwise if it ends up dispatching another message to itself we'll hit the NOTREACHED at the beginning of the function.
Review URL: http://codereview.chromium.org/99267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11263
TEST=Go to any page and then click on a link to navigate to a new page.
Review URL: http://codereview.chromium.org/99263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(https://bugs.webkit.org/show_bug.cgi?id=25347).TBR=yurys
Review URL: http://codereview.chromium.org/99274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Activex shim for media player along with their associated extensions.
This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source
URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime
and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the
mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin
from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message.
With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player
handling it in Chrome.
I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it.
Added plugin tests for the mp3 and mpe extensions.
Bug=11054
Review URL: http://codereview.chromium.org/100180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/43092.
R=levin
BUG=10898
TEST=0
Review URL: http://codereview.chromium.org/100227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used for gears file drag & drop in chrome, define the values of
the drop effect overrides to match the gears definitions.
BUG=7995
Original patch by Noel Gordon via:
http://codereview.chromium.org/99231
Review URL: http://codereview.chromium.org/102016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
2. Function actual parameters are not shown in the call stack panel because they are alredy displayed in the scopes panel.
Review URL: http://codereview.chromium.org/99185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, "Alt" key will set both alt and meta is on (issue 2215).
But Alt-Gr is used to insert alternate character.
BUG=10846
Review URL: http://codereview.chromium.org/99216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>.
In WebKit, EditorClient::handleKeyboardEvent in
WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drops such events.
On Mac, it emits key events with ASCII text and meta is on for Command-<x>.
These key events should not emit text insert event.
Alt key would be used to insert alternative character, so we should let through.
Ctrl-Alt combination may equal to AltGr key, which is also used to insert
alternative character.
In summary, we can't think of a scenario where you'd use control(w/o alt) or
meta to do insertion of a ASCII character.
BUG=10846,11070,11165
Review URL: http://codereview.chromium.org/99209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98
|