| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=tc
BUG=NONE
The changes are to account for:
http://trac.webkit.org/changeset/40925 -- Adding MediaPlayerPrivate
http://trac.webkit.org/changeset/40981 -- Converting GKURL constructor arg to CString.
Review URL: http://codereview.chromium.org/20409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change didn't have any description and it broke the tree
Review URL: http://codereview.chromium.org/21393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This keep the sizing operations in WebPluginDelegateImpl, and does the moving in DidMove. This more or less matches what currently happens on Windows.
Add a comment explaining this situation better. Add some random comments and small code cleanup.
Remove the flash useragent spoofing hack on non-Windows, we don't need to worry about this for now.
Review URL: http://codereview.chromium.org/20304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) the Interactive Tests (dbg) buildbot needs the SSL cert installed
2) the same buildbot showed a refcounting problem, e.g.
FATAL:ref_counted.cc(22)] Check failed: in_dtor_. RefCounted object deleted without calling Release()
c:\b\slave\chromium-dbg-builder\build\src\chrome\browser\views\find_bar_win_interactive_uitest.cc(57): error: Value of: NULL != server.get()
Actual: false
Expected: true
[ FAILED ] FindInPageTest.CrashEscHandlers (2109 ms)
3) the Webkit Linux buildbot failed four tests
redirect302-frames.html cross-frame-access-protocol-explicit-domain.html
cross-frame-access-protocol.html origin-header-for-https.html
I'm leaving the tcp_pinger files in for the moment, they shouldn't hurt anything.
Review URL: http://codereview.chromium.org/23028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than use bugs.webkit.org, fixes TODO(darin)
Add tests with bad server certs
ssl_client_socket_nss.cc: fix bugs revealed by new tests
tcp_pinger.cc: helper class to do synchronous connect from tests.
Has to work inside ui tests where one can't use TestCompletionCallback.
ssl_test_util: renamed class TestServerLauncher, added Start/Stop methods.
Make part of net.lib to work around link error in test_shell_tests.
url_request_unittest.h: use TestServerLauncher to manage server.
SSL client tests disabled for now on Mac.
BUG=7114
Review URL: http://codereview.chromium.org/16207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=jhawkins
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
filenames/file extensions.
Review URL: http://codereview.chromium.org/21327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also cached the NPObject we create for a CppBoundClass, so we only create one each time we bind it to a frame.
This will be useful for extensions.
Review URL: http://codereview.chromium.org/21337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Internally, WebFrameImpl needs reference counting, so we still define it there.
Same goes for WebView and WebWidget.
While making this change, I noticed that WebInspectorClient was casting WebView
pointers to WebViewImpl pointers too much. By just starting with WebViewImpl
pointers, things could be cleaned up considerably.
R=brettw
Review URL: http://codereview.chromium.org/21342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://dev.chromium.org.
Now that webkit merge has landed, actually create a RenderView in
RenderThread.
With these changes, there is only manual tweak needed (locally called
"disable-button.diff") to get bits on the screen for OSX without
crashing.
Review URL: http://codereview.chromium.org/20349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface whenever we receive the initial response for a byte range request and when the request eventually completes.
This ensures that the throbber continues to spin when these requests take a while.
It stops spinning during load when the document load is cancelled by the plugin process. This occurs when the plugin invokes NPN_RequestRead the first time on the stream.
This fixes http://code.google.com/p/chromium/issues/detail?id=7375
Bug=7375
Review URL: http://codereview.chromium.org/20333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
when displaying javascript alerts into the glue code. This
moves them out of DOMWindow.cpp.
Review URL: http://codereview.chromium.org/20317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Darin: primary
Brett: FYI
Review URL: http://codereview.chromium.org/21243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Stop directly referencing WebPluginDelegateImpl.
- Make the password manager to not allocation the data on heap.
- Remove some unneeded includes.
Review URL: http://codereview.chromium.org/20208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This matches the behavior of Firefox on Windows and Linux. This change is especially important for plugin compatability on Linux. This also nicely removes a quirk mode.
Review URL: http://codereview.chromium.org/21290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation to rev 9214. The pages_ member of WebFrameImpl must be set
properly or printing will fail.
Patch contributed by Marshall Greenblatt <magreenblatt@gmail.com>
Review url: http://codereview.chromium.org/20222/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=6107
Review URL: http://codereview.chromium.org/20280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead of relying on the command line, RenderProcess will attempt to load and enable the media player if possible. This is the first in a few changes where I'll be adding in hooks to load media DLLs at runtime if present.
Review URL: http://codereview.chromium.org/20253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also it applies a clean-up to remove any empty values previously stored in the DB.
BUG=6111
TEST=Submit a form and leave some fields empty. Come back to that form, click on a field that was empty. No autofill popup should show up (or if one show up, it should not contains empty values).
Review URL: http://codereview.chromium.org/21217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
build, add another missed file (plugin_impl_mac.h) to unbreak the
Mac build.
Review URL: http://codereview.chromium.org/21245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in to help stay in sync with linux plugin mods and ensure that it doesn't
break Windows plugins.
Review URL: http://codereview.chromium.org/21095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amanda
Review URL: http://codereview.chromium.org/21193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Account for the renaming of toRange to toNormalizedRange done by Eric Seidel.
R=amanda
Review URL: http://codereview.chromium.org/20192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
side.R=darin,brettw
Review URL: http://codereview.chromium.org/19725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkContainer to a GtkFixed container.
Our previous custom container did not track its children, which meant it couldn't propagate size-request and size-allocate. In some ways this is what we wanted, however it prevented GtkSocket from running some important code. Specifically an expose event wouldn't trigger initially on the GtkSocket, leaving the widget window unpainted.
Instead of writing / copying container code to manage children, it is much easier if we can reuse an existing container. This changes makes the drawing area a GtkFixed backed by a GdkWindow, and we paint into its window. We implement a small custom widget around GtkSocket, which allows us to control the size requisition phase. This solves the problem of controlling the GtkSocket layout within the container.
Plugins are now painted correctly, without having to jiggle the scrollbar.
This change additionally groups all of the widget code in a class of statics. GtkFixedSocket implements the GtkSocket with custom size requisition. WebWidgetHostGtkWidget is just a GtkFixed with a window, along with the signal connection handlers.
This also means we'll have no custom container implementation to share across test_shell and the browser.
It seems we still don't handle keyboard focus exactly right, and youtube videos still need mouse events to repaint. I believe these are subtle issues, and can be solved while keeping the GtkFixed container approach.
Review URL: http://codereview.chromium.org/20128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
locally so I am checking this in again and debugging
live.
TBR=nsylvain (already reviewed by mbelshe)
Review URL: http://codereview.chromium.org/21175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by a change in the PopupMenuChromium where the popup would first hide itself before setting the selection.
We use to delete our client on hide, causing a crasher when setting the selection.
This new CL makes the autocomplete popup and client live as long as the WebView is alive and the WebView reuse them (we just hide the popup when necessary).
TEST=In a form, type some text in an input field. Make sure the autocomplete popups up and behaves as expected.
BUG=7435
Review URL: http://codereview.chromium.org/21153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Relanding merge for the third time. Darin will fix mac build.
Review URL: http://codereview.chromium.org/20183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Merge still broken on a mac clobber build.
Review URL: http://codereview.chromium.org/20182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Try again to land webkit merge.
Review URL: http://codereview.chromium.org/21173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting merge. Mac build mysteriously broken
Review URL: http://codereview.chromium.org/21164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting due to failures in layout tests
Review URL: http://codereview.chromium.org/21159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTest/fast/dom/assign-to-window-status.html
which is testing whether we can assign values to
window.status.
BUG=1143492
Review URL: http://codereview.chromium.org/21147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is failing to load.
Review URL: http://codereview.chromium.org/21138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
option when the same-origin policy interferes with testing their web sites.
R=deanm
BUG=6449
Review URL: http://codereview.chromium.org/20101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This initiates the landslide of linker hell in Chromium.app,
bringing in webkit, v8, and the kitchen sink.
Review URL: http://codereview.chromium.org/21123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we would return something like ".html", because that's how it's stored in the registry on Windows. For a variety of reasons, it's much simpler to work without the prefixed dot. In fact, the only two consumers were manually stripping of the prefix dot.
There is a cooresponding change that should happen in WebKit / ChromiumBridge, but since it's checking if there is a prefix dot and removing it, the code will still work, and I'll follow up with that change.
Review URL: http://codereview.chromium.org/23010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems at some point we disabled the platform
test folder entirely in order to disable some Mac
specific tests and in the process disabled some
Windows tests because they appear in a sub-folder
of the platform folder.
This change makes us pass 6 more tests from platform/win/fast/events/,
tests which needed the function dispatchMessage
(and a few properties) added to TestShell.
I also implemented the IS_NUMPAD modifier on
the Keyboard event.
A good test that relies on dispatchMessage, the
properties and the NumPad detection is:
LayoutTests\platform\win\fast\events\keyLocation-numpad.html.
Note: This folder also contains...
LayoutTests/platform/win/editing/shift-page-up-down.html
... which was added to the defer list for now.
Review URL: http://codereview.chromium.org/21113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that webkit's timers are all based off the WTF/CurrentTime
implementation, but the bridge was doing math between a webkit that
implementation of currentTime and Chromium's base/Time implementation.
Subtracting two different times leads to skew, which turned out to
always be negative, so the CPU was spinning for most all timers.
This bug was introduced during the merge which brought in timers. From
the outside, functionality was correct (timers fired at the right time),
but internally we could spin the CPU in while waiting for the timer to
fire.
There is some code to remove from SystemTimeChromium, which I will do,
but that is in the webkit tree, so I'll do that separately.
Review URL: http://codereview.chromium.org/21122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashing. Also fixes the plugin positioning.
We needed to catch plug-removed and return TRUE, as well as implement a bit
more of the GtkContainer API. Also, Flash seems to crash no matter what when
I call the SetWindow with a NULL window, so don't do that for now. (It can
be revisited once that code is remerged.)
Review URL: http://codereview.chromium.org/22003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make unit tests link with libglue.a directly.
OSX-only change.
Review URL: http://codereview.chromium.org/21065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Use the code from PrintContext instead.
Review URL: http://codereview.chromium.org/20058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=3953
Bug=3953
Review URL: http://codereview.chromium.org/20087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9224 0039d316-1c4b-4281-b951-d872f2087c98
|