summaryrefslogtreecommitdiffstats
path: root/webkit/glue
Commit message (Collapse)AuthorAgeFilesLines
* Fixing 1669: Renderer crashes on FindNextfinnur@google.com2008-09-102-20/+57
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1669 Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0. When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping. To recap on how Find works (since I know it has been a while since you looked at this problem): Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead. BUG=1341577 Review URL: http://codereview.chromium.org/1847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out webplugin_impl to make more progress on testshellpinkerton@google.com2008-09-101-0/+54
| | | | | | Review URL: http://codereview.chromium.org/1701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1987 0039d316-1c4b-4281-b951-d872f2087c98
* Bring layout_test_controller.cc into the mac project.avi@google.com2008-09-101-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1986 0039d316-1c4b-4281-b951-d872f2087c98
* make more cross platform, use process_utils to get proc id. remove unused ↵pinkerton@google.com2008-09-101-6/+6
| | | | | | | | header. Review URL: http://codereview.chromium.org/1857 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1985 0039d316-1c4b-4281-b951-d872f2087c98
* Simply use a named enum instead of a typedef.evanm@google.com2008-09-101-1/+1
| | | | | | | | | BUG=1872 Patch from James Vega <vega.james@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1964 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=643, whichiyengar@google.com2008-09-102-35/+52
| | | | | | | | | | | | | | | | | | | is an issue with the shockwave game not loading. The plugin issues a number of geturlnotify requests. Some of these requests come in with response headers without the content length. We would pass in -1 in the NPStream passed down to the plugin. As the end field in the NPStream structure is an unsigned integer, the plugin would expect more data to arrive and hence the issue. The fix is to emulate Safari behavior and set the end field to 0 if the length is -1. Bug=643 Review URL: http://codereview.chromium.org/1676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1958 0039d316-1c4b-4281-b951-d872f2087c98
* remove platform includespinkerton@google.com2008-09-091-4/+2
| | | | | | Review URL: http://codereview.chromium.org/1677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1930 0039d316-1c4b-4281-b951-d872f2087c98
* define constants for strings in absence of GRIT machinery on mac&linux as a ↵pinkerton@google.com2008-09-092-1/+49
| | | | | | | | temporary boostraping measure. Review URL: http://codereview.chromium.org/1854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1929 0039d316-1c4b-4281-b951-d872f2087c98
* fill in a missing routine for MacOSpinkerton@google.com2008-09-092-0/+10
| | | | | | Review URL: http://codereview.chromium.org/1673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1923 0039d316-1c4b-4281-b951-d872f2087c98
* remove reference in mac ifdef to a function not in the shared RendeTheme headerpinkerton@google.com2008-09-091-4/+0
| | | | | | Review URL: http://codereview.chromium.org/1674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1922 0039d316-1c4b-4281-b951-d872f2087c98
* Apply xcconfigs to Mac TestShell, fix warningsmmentovai@google.com2008-09-091-0/+2
| | | | | | Review URL: http://codereview.chromium.org/1668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1917 0039d316-1c4b-4281-b951-d872f2087c98
* fix platform differences in editor client, make compile on non-windowspinkerton@google.com2008-09-092-9/+41
| | | | | | Review URL: http://codereview.chromium.org/1852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1916 0039d316-1c4b-4281-b951-d872f2087c98
* fix win bustagepinkerton@google.com2008-09-092-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1912 0039d316-1c4b-4281-b951-d872f2087c98
* if-def the event conversion code to fit with the ifdefs in WebCore.pinkerton@google.com2008-09-092-3/+37
| | | | | | Review URL: http://codereview.chromium.org/1846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1908 0039d316-1c4b-4281-b951-d872f2087c98
* stub out win-only routines and impl user agent for MacOS Xpinkerton@google.com2008-09-091-2/+23
| | | | | | Review URL: http://codereview.chromium.org/262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1904 0039d316-1c4b-4281-b951-d872f2087c98
* Use a GURL instead of a string when creating object, saves two string ↵pinkerton@google.com2008-09-092-6/+5
| | | | | | | | conversions. Review URL: http://codereview.chromium.org/253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1898 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-084-15/+9
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* fix build issue on Linux with GCC 4.1.2evanm@google.com2008-09-082-0/+2
| | | | | | | | | | | related to non-virtual destructors in classes having virtual methods BUG=1859 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1860 0039d316-1c4b-4281-b951-d872f2087c98
* Need to close the plugin stream if NPP_Write fails.darin@google.com2008-09-082-9/+17
| | | | | | | | | | This occurs on YouTube when the user moves the slider to advance the video. Flash is doing this to inform the browser that it should cancel the existing stream. Without handling this error, we end up downloading the video multiple times from multiple offsets. After the user moves the slider 6 times, we will end up having saturated the maximum of 6 connections per host, and then YouTube video playback will appear to be wedged. R=joshia Review URL: http://codereview.chromium.org/1622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1859 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome trunk's v8 dependency from trunk@101 to trunk@138.ericroman@google.com2008-09-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This picks up the "in" operator fix that was made in branches/v8_bleeding@117. $ svn log -r 102:138 http://v8.googlecode.com/svn/trunk ------------------------------------------------------------------------ r138 | ager@chromium.org | 2008-09-04 06:52:27 -0700 (Thu, 04 Sep 2008) | 10 lines Added support for running tests on the ARM simulator. Fixed bug in the 'in' operator where negative indices were not treated correctly. Fixed build issues on gcc-4.3.1. Changed Date.prototype.toLocaleTimeString to not print the timezone part of the time. Renamed debug.h to v8-debug.h to reduce the risk of name conflicts with user code. ------------------------------------------------------------------------ Review URL: http://codereview.chromium.org/1602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1851 0039d316-1c4b-4281-b951-d872f2087c98
* Just compile some basic files so we get a libGlue.a.evanm@google.com2008-09-074-17/+39
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1829 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback the rollback of r1806. Wasn't the cause of the test failure.ojan@google.com2008-09-062-3/+5
| | | | | | Review URL: http://codereview.chromium.org/272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1821 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 1806, requested by Ojan.evanm@google.com2008-09-062-5/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1816 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webkit.xcodeproj. Make it use our new xcconfig and common build directorymmentovai@google.com2008-09-061-0/+1
| | | | | | | setup. Turn off headermaps and use explicit #include paths everywhere. Review URL: http://codereview.chromium.org/269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1815 0039d316-1c4b-4281-b951-d872f2087c98
* tweaks for mac and linuxpinkerton@google.com2008-09-052-3/+5
| | | | | | Review URL: http://codereview.chromium.org/254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1806 0039d316-1c4b-4281-b951-d872f2087c98
* back out part of last change, better fix upcoming.pinkerton@google.com2008-09-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1784 0039d316-1c4b-4281-b951-d872f2087c98
* fix copy/paste errorpinkerton@google.com2008-09-051-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1783 0039d316-1c4b-4281-b951-d872f2087c98
* pick up another forked file in pending/kjs, if-def scrollView and bitmap ↵pinkerton@google.com2008-09-051-1/+35
| | | | | | | | usage in webframe until we're ready to tackle it. Review URL: http://codereview.chromium.org/248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1780 0039d316-1c4b-4281-b951-d872f2087c98
* ifdef around windows codepinkerton@google.com2008-09-051-1/+10
| | | | | | Review URL: http://codereview.chromium.org/249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1779 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the following bugs reported with the Silverlight plugin:-iyengar@google.com2008-09-041-0/+10
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=248 http://code.google.com/p/chromium/issues/detail?id=666 The basic issue here was that the plugin would not paint correctly. The URLs mentioned in this bug load windowed silverlight plugin instances, which invoke the NPN_InvalidateRect API to paint. We send over the rects to the renderer, however these don't generate paints as the plugin is windowed. A peek at Safari's webkit implementation revealed that they merely invoke the InvalidateRect windows API in this context. The fix is to emulate this behavior. Review URL: http://codereview.chromium.org/431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1735 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to pending to get WebCore to compile on linux. Thistc@google.com2008-09-041-1/+1
| | | | | | | | | | | | | | | | | | doesn't enable it yet since there are more changes to WebKit that we need from the merge. Once the merge lands, pending will probably be clobbered, so this is temporary to allow us to keep moving forward. Go ahead and switch from PLATFORM_CHROME to PLATFORM_CHROMIUM and try to change all the places in the mac code. This change includes bits from http://codereview.chromium.org/228 which is by Seo Sanghyeon. Everything still compiles on Windows. Review URL: http://codereview.chromium.org/1201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1725 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=493, whichiyengar@google.com2008-09-031-2/+2
| | | | | | | | | | | | | | was a crash in the 3dvia plugin. A script on the page tries to interact with the plugin by obtain its npobject. The plugin's does not implement the corresponding NPP_GetValue function correctly and returns NPERR_NO_ERROR without filling in the NPObject pointer passed in. The fix is to initialize the NPObject pointer on the stack to NULL and check for this along with the error check. Review URL: http://codereview.chromium.org/212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1692 0039d316-1c4b-4281-b951-d872f2087c98
* Change the path of the V8 API headers from public to includesgjesse@google.com2008-09-032-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1672 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last minute #define and change UA string to Chromemal@google.com2008-09-021-2/+2
| | | | | | | | | on trunk. BUG=1431137 TBR= darin@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1625 0039d316-1c4b-4281-b951-d872f2087c98
* Update Copyright text in SCons config files.sgk@google.com2008-09-012-56/+8
| | | | | | TBR: beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1607 0039d316-1c4b-4281-b951-d872f2087c98
* platform ifdefs for webview. Add platform_viewdefs to wrap things like HWNDs ↵pinkerton@google.com2008-08-299-23/+104
| | | | | | to keep APIs more crossplatform. Fix uses of PlatformCanvasWin to just use PlatformCanvas. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1528 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to the JavaScript debugger in preparing for an upcomingsgjesse@google.com2008-08-292-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change in V8 where the implicit breaks currently issued when receiving a command while running will be removed. To get in contact with the V8 debugging interface and send messages V8 needs to be in the break state. Getting V8 into the break state will be the responsebility of the debugger using the V8 debugging interface. Changed the messages between the renderer and the debugger. There are now explicit messages for break and detach. Alse renamed the SendToDebugger message to DebugCommand. There is now messages DebugAttach, DebugBreak, DebugCommand and DebugDetach. The message DebugBreak has a force flag to indicate whether the renderer should issue some JavaScript to help the break along or whether it should just schedule a break to happen whenever JavaScript executes. Removed the artificial attach JSON response send by the renderer and replaced that with an on debug attach call to the debugger shell. This call is reouted to the on_attach function in the debugger JavScript code. Changed the debugger to issue break requests whenever a suitable command, e.g. setting a break point, is issued. In this case a flag is used to track whether execution should be automatically resumed after the command have been send to the V8 debugger interface. Changed the handling of the plain break event to not force a break by executing additional JavaScript. Thereby a plain break does not break JavaScript execution until code on the tab beeing debugged is actually executed. Set the command name explicitly on all commands. Removed parseSimpleCommand as it was just used for the the continue command for which an explicit parseContinueCommand has been added. Removed the last_command field from DebugShell as it was not used. Updated the debugger protocol test to reflect the removed attach event. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1526 0039d316-1c4b-4281-b951-d872f2087c98
* The GetWindowRect must return the rect of the container HWND; not the actual ↵erg@google.com2008-08-282-3/+5
| | | | | | | | | | window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls. So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect(). BUG=1344367,1186573,1334505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1496 0039d316-1c4b-4281-b951-d872f2087c98
* Move std::string16 to base::string16. Don't pollute the std namespace. Don'tmmentovai@google.com2008-08-274-11/+11
| | | | | | assume that all string types can be represented as std::basic_string<CHAR>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1464 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct decls for non-windows platforms. Create a platform-neutral ↵pinkerton@google.com2008-08-271-4/+4
| | | | | | wrapper for everyone to use. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1463 0039d316-1c4b-4281-b951-d872f2087c98
* include basictypes for mac/linuxpinkerton@google.com2008-08-271-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1453 0039d316-1c4b-4281-b951-d872f2087c98
* include config.h first otherwise bad things happenpinkerton@google.com2008-08-271-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1452 0039d316-1c4b-4281-b951-d872f2087c98
* use the correct string converstion utilpinkerton@google.com2008-08-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1437 0039d316-1c4b-4281-b951-d872f2087c98
* make reference parameters const.pinkerton@google.com2008-08-273-15/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1436 0039d316-1c4b-4281-b951-d872f2087c98
* use the correct string conversion. pinkerton@google.com2008-08-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1402 0039d316-1c4b-4281-b951-d872f2087c98
* Use appropriate string conversion on |url_|.pinkerton@google.com2008-08-261-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1401 0039d316-1c4b-4281-b951-d872f2087c98
* Add UTF8 <-> UTF-16 conversion functions, and a WebCore::String -> ↵brettw@google.com2008-08-262-14/+25
| | | | | | std::string function. We already have a std::string -> WebCore::String function. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1393 0039d316-1c4b-4281-b951-d872f2087c98
* can't forward declare enums outside MSVC.pinkerton@google.com2008-08-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1390 0039d316-1c4b-4281-b951-d872f2087c98
* need to include config.h firstpinkerton@google.com2008-08-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1386 0039d316-1c4b-4281-b951-d872f2087c98
* Mac-ify webinputeventavi@google.com2008-08-264-11/+209
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1382 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 03:47:34 +0000