| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames.
Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden).
Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it.
I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious).
Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test.
Review URL: http://codereview.chromium.org/13130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes Evan's change to use char instead of wchar_t for counter
names.
Also, because of changes to the regexp parser, we need to rebaseline a
couple of tests mainly because of error message changes. Most of the
tests were already rebaselined because of differences in error
messages.
Review URL: http://codereview.chromium.org/12902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Properly initialize ResourceLoaderBridge::ResponseInfo for data: urls. This is similar to the problem fixed in r5921.
Review URL: http://codereview.chromium.org/12906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we can have special handlings on media resources
Review URL: http://codereview.chromium.org/12858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a COMPtr<IAccessible> instead. This ensures that it is refcounted.
I saw an instance while debugging bug 4582, where the map actually had
a junk IAccessible pointer with a valid accessibility id.
Bug=4582
R=jam
Review URL: http://codereview.chromium.org/10980
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes http://code.google.com/p/chromium/issues/detail?id=3977, which is an issue with Acrobat Reader internet preferences being set to always open PDF files in Reader. This operation when performed in chrome and Safari
brings up an error message from the Acrobat Reader plugin that the file could not be found.
The plugin in this case returns NP_ASFILE as the plugin mode from NPP_NewStream. The data is written accordingly to the temp file created. When we finish receiving the data we pass the file name in NPP_StreamAsFile to the plugin. The plugin does not open the file immediately as per our expectation. It opens the file after the stream has been destroyed which ends up deleting the temp file created above.
Debugged Firefox and found that it never deletes these temp files and leaves them around in the cache.
We can go one step forward and track all these files on a per instance basis. These are deleted when the plugin instance is destroyed.
Bug=3977
R=jam
Review URL: http://codereview.chromium.org/12875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted.
Review URL: http://codereview.chromium.org/12859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test shell.
I implemented it in the webview delegate, so when we switch to the
multiprocess architecture, we will need to find out if the clipboard callback
can be async (the current method would require a sync call from browser to
renderer to get the selected text).
Review URL: http://codereview.chromium.org/12700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
delegated to ScrollView instead of FrameView, printing scrollbars on the paper.
TEST=print a long page, no scrollbar should appear and it should print on multiple pages correctly.
BUG=3670
Review URL: http://codereview.chromium.org/13012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
during a nested message loop.
I also fixed another null dereference in InitAccessibilityRoot that I saw during debugging.
BUG=4582
Review URL: http://codereview.chromium.org/10418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which they don't have to be.
BUG=4825
TEST=Go to www.blogger.com, login, click Add. Type something in the URL input field of the frame that is opened.
Review URL: http://codereview.chromium.org/12499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by phajdan.jr@gmail.com
R=darin
Review URL: http://codereview.chromium.org/12004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The net impact is that "times new roman" is fallen back to instead of "Times" for a couple of layout tests.
Overall this affects 9 tests. 6 have been rebased, and 3 marked as expected fail (since am uncertain of their correctness).
This also removes some dead code relating to IMLangFontLink.
Review URL: http://codereview.chromium.org/12457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by phajdan.jr@gmail.com
R=darin
Review URL: http://codereview.chromium.org/12004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pressing ESC.
I had to introduce another acceptOnAbandon member, though the name I came up with is pretty lame.
BUG=4803
TEST=Type some text in a from input text, in the autofill popup menu, use the arrow keys to select something then press ESC. The text input content should not change. Also, make sure the select input still does keep the selection when ESC is pressed.
Review URL: http://codereview.chromium.org/12667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instance.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=4691
The windowless instance of the Silverlight plugin calls the WindowFromPoint API and passes the window handle returned as the owner window in the TrackPopupMenu API call. The TrackPopupMenu API fails if the owner window does not live on the same thread as the caller. It works in the other browsers as the window where the windowless plugin is embedded is in the same thread.
The fix is to add a quirk specific for the TrackPopupMenu issue, IAT patch the Silverlight plugin and pass in the handle to the dummy activation window as the owner.
The other fix made is to have a focus window for the duration of the WM_RBUTTONDOWN/WM_RBUTTONUP sequence. This ensures that keyboard navigation works in the context menu displayed by the Silverlight plugin.
Bug=4691
R=jam
Review URL: http://codereview.chromium.org/12626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Without this, we leak undefined data into V8 and cause lots of Valgrind
errors.
Review URL: http://codereview.chromium.org/12441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
so the order they're run in doesn't matter.
Review URL: http://codereview.chromium.org/12627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::wstring for HTTP header fields
The HTTP specification guarantees that all fields in the header will be ASCII
and thus fit fine in a std::string. The GetHttpHeaders/SetHttpHeaders
interfaces use std::string values for HTTP headers. This patch fixes
GetHttpMethod(), SetHttpMethod(), GetHttpHeaderValue() and SetHttpHeaderValue()
and callers to use std::string as well.
Patch by James Robinson <jamesr@google.com>
R=darin
Review URL: http://codereview.chromium.org/12412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to discard a bunch of code and plumbing related to
maintaining and passing around the tickmark vector.
WebKit now owns the drawing of the highlights for inactive matches and
we use the selection controller to draw the active highlight.
I also simplified the code by eliminating the separate FindNext
function, which has been merged into Find.
This change also requires minor changes to WebKit upstream (sold
seperately, void where prohibited).
It simply consists of adding one empty virtual paint function to
ScrollbarThemeComposite.h (paintTickmarks) and in
ScrollbarThemeComposite::paint call paintTickmarks().
This fixes/makes obsolete a slew of bugs:
BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599
... and a couple of external ones as well. Full list:
1326399 Find highlighting disappears on ThinkPad x60s
1241554 Find doesn't highlight word inside blinky tag
1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode
1070190 Find should begin searching from caret/selection
1023019 Find not highlighting correctly
984786 Find highlight drawing code causes ClearType text to look bad
893737 Find in page should search textareas
868599 Find in page tick marks incorrectly appear on nested scrollbars
298 Find-In-page should highlight elided entries
4389 Find-in-box is not highlighting all the instances of the search word
3908 Find in page highlighting and tickmarks are broken
Review URL: http://codereview.chromium.org/11364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same as the previous patch except it doesn't
change the WEBCORE_DIR variable. It needs the OBJ_ROOT in
the resolution path so .o files end up in Hammer/. I'll
fix the include paths in a follow up change.
TBR=sgk
Review URL: http://codereview.chromium.org/12411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's putting .o files next to .cpp files. I will debug offline
then resubmit.
TBR=sgk
Review URL: http://codereview.chromium.org/12610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also did a little cleanup in getPlugins. I found that there was a
WebPluginInfo struct declared within the WebCore namespace that was causing us
to need '::' in front of WebPluginInfo. I killed the erroneous declaration so
that the rest could be cleaned up. I also renamed getPlugins to plugins since
I think that is more consistent with how Apple names these kinds of methods.
There was some old, unused USE(JSC) code in ScriptController.cpp that I deleted.
R=erikkay
Review URL: http://codereview.chromium.org/12601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By reducing the number of include paths that are specified
as $WEBKIT_DIR/port, we reduce the number of paths that get
expanded by the addRepository functions. Instead, we only specify directories from $WEBKIT_DIR/port if we have header files in those directories. The down side is that if we add a header to port, we need to update the include paths.
Also, don't specify WebCore includes with OBJ_ROOT as the fallback repository so we save on -I expansion.
Remove $WEBKIT_PORT_DIR because it's the same as $PORT_DIR.
The change to glue/SConscript is to pick up webkit_version.h since glue is the only place that needs it.
Review URL: http://codereview.chromium.org/11598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
forwarded to the skia ones.
Review URL: http://codereview.chromium.org/11588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r5847.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scrollbars to not overlap the in-window resizer widget.
Review URL: http://codereview.chromium.org/11353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
some of these sneaked in.
BUG=2053
Review URL: http://codereview.chromium.org/11801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has been added to this CB.
Fix Silverlight windowless plugin painting issues. This fixes the
following
issues:-
1. http://code.google.com/p/chromium/issues/detail?id=4272
2. http://code.google.com/p/chromium/issues/detail?id=301 (Partially)
The fixes are as below:-
1. Silverlight in the NPP_HandleEvent call for WM_PAINT,
calls NPN_GetProperty for a bunch of properties like
pageXOffset, pageYOffset, etc. It expects these
properties to have integer types on return. We always
return double. Firefox returns integer for these
properties. Added a check in the conversion
to NPVariant function in v8 to check for whether the
value is an integer and return the intger type.
2. When the windowless plugin calls NPN_InvalidateRect we
ask the plugin to paint in the same call, which the
Silverlight plugin does not like. It relies
on the fact that browsers would initiate invalidation
asynchronously and eventually paint. This is a perfectly
legal assumption. The Flash plugin does work if we
synchronously ask it to paint. However other plugins
could have similar issues. I verified with
worldofwarcraft.com to see if the async paint
has any sideeffects and there were none.
3.If the Silverlight plugin is not visible initially as on
msdn.microsoft.com, it does not paint. This occurs
because the plugin expects proper paints to
come from the browser. It does not invalidate itself in
UpdateGeometry as Flash. The plugin widget on msdn is not
dynamic. It does call NPN_InvalidateRect
initially when it is not visible. We don't send the call
to the renderer as the plugin is not visible. To workaround
this we now track the damaged rect even if the rect does not
intersect the clipping rect of the plugin. In a geometry update
if the plugin is visible, we send over the accumulated damaged rect
to the renderer.
The Silverlight plugin instance on msdn.microsoft.com does not work correctly
even with these fixes. However it paints correctly.
R=jam
Bug=4272,301
Review URL: http://codereview.chromium.org/11569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
following
issues:-
1. http://code.google.com/p/chromium/issues/detail?id=4272
2. http://code.google.com/p/chromium/issues/detail?id=301 (Partially)
The fixes are as below:-
1. Silverlight in the NPP_HandleEvent call for WM_PAINT,
calls NPN_GetProperty for a bunch of properties like
pageXOffset, pageYOffset, etc. It expects these
properties to have integer types on return. We always
return double. Firefox returns integer for these
properties. Added a check in the conversion
to NPVariant function in v8 to check for whether the
value is an integer and return the intger type.
2. When the windowless plugin calls NPN_InvalidateRect we
ask the plugin to paint in the same call, which the
Silverlight plugin does not like. It relies
on the fact that browsers would initiate invalidation
asynchronously and eventually paint. This is a perfectly
legal assumption. The Flash plugin does work if we
synchronously ask it to paint. However other plugins
could have similar issues. I verified with
worldofwarcraft.com to see if the async paint
has any sideeffects and there were none.
3.If the Silverlight plugin is not visible initially as on
msdn.microsoft.com, it does not paint. This occurs
because the plugin expects proper paints to
come from the browser. It does not invalidate itself in
UpdateGeometry as Flash. The plugin widget on msdn is not
dynamic. It does call NPN_InvalidateRect
initially when it is not visible. We don't send the call
to the renderer as the plugin is not visible. To workaround
this we now track the damaged rect even if the rect does not
intersect the clipping rect of the plugin. In a geometry update
if the plugin is visible, we send over the accumulated damaged rect
to the renderer.
The Silverlight plugin instance on msdn.microsoft.com does not work correctly even with these fixes. However it paints correctly.
R=jam
Bug=4272,301
Review URL: http://codereview.chromium.org/11492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We eventually need to figure out our localization / resources on Linux, but this will unblock some parallel work for now.
Review URL: http://codereview.chromium.org/11553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I rolled it back yesterday, it broke the Linux and Mac builds.
TBR=tim
Review URL: http://codereview.chromium.org/11543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rebase 2 tests that use it. The only difference is font size.
BUG=http://b/1124435
Review URL: http://codereview.chromium.org/11536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
corner graphic. This makes the resize corner look less
janky when in classic mode.
Review URL: http://codereview.chromium.org/11523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The ScrollView tries to load an image before setting the cursor
to a pan scroll cursor. Not sure why this is needed, but add
the image so it works.
Review URL: http://codereview.chromium.org/11302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5753 0039d316-1c4b-4281-b951-d872f2087c98
|