| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
"config.h" needs to be included first
TBR=mark
Review URL: http://codereview.chromium.org/9647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of these files that I don't added to the build would even compile
and link, but don't yet pass with current test_shell on Linux.
They just hang.
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> on
http://codereview.chromium.org/9417
Review URL: http://codereview.chromium.org/9641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but no user name associated.
This was causing some wekbit layout tests to fail.
TEST=Run the webkit layout tests.
Review URL: http://codereview.chromium.org/9612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge.
The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner.
R=iyengar,eseidel
Review URL: http://codereview.chromium.org/9072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was a hang while loading certain PDF files. This was a regression caused by support for NPN_RequestRead (PDF Fast Webview). We had incorrectly assumed that the Content Type showing up for partial HTTP Responses would always end with the boundary. A content type can show up like multipart/byteranges; boundary=--bound--; charSet=utf8. As a result we would look for the wrong boundary in the actual data resulting in a hang.
The parsing code now accounts for this. Added a unit test to test this case.
Bug=4076
R=jam
Review URL: http://codereview.chromium.org/9198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
#includes.
Review URL: http://codereview.chromium.org/9195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
entries in text input elements in forms. Also added the class AutofillManager which gets instantiated once per WebContents and provides an API from which the database can be easily accessed to provide a list of possible desired values to be entered in a text field given what the user has already typed there.
Review URL: http://codereview.chromium.org/8845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup.
Listeners are set on the form text field in a similar fashion than for password save.
The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows.
The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown.
Review URL: http://codereview.chromium.org/8885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
where content_changed is false). These calls to repaint are safe to ignore
given our painting architecture.
BUG=4108
R=brettw
Review URL: http://codereview.chromium.org/9174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org
Review URL: http://codereview.chromium.org/9154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I realised that some of the comments and namespacing does not apply anymore.
patch from Paweł Hajdan jr <phajdan.jr@gmail.com> in
http://codereview.chromium.org/9109
Review URL: http://codereview.chromium.org/9343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=3912
Review URL: http://codereview.chromium.org/9273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now running 60 tests on Linux.
Patch from Paweł Hajdan jr and from:
http://codereview.chromium.org/8677/show
Review URL: http://codereview.chromium.org/9268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was NPAPI plugin UI test failures. This occured as a sideeffect of the webkit
merge. Some functions in widget.h which were implemented by WebPluginContainer
no longer exist. We need to implement their replacements on similar lines.
Bug=3881
R=jam
Review URL: http://codereview.chromium.org/8775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/8790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/8789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces ChromiumBridge as a means for our WebCore port to depend on the embedder indirectly. This will be extended to support the rest of our port.
WebWidgetImpl and ChromeClientImpl both needed to have their platformWindow getter implemented. This fixes a regression related to the most recent merge.
Removes the orphaned Language.cpp (see the real one in the platform/chromium directory.
Changed webkit_glue::GetMonitorInfoForWindow to webkit_glue::GetScreenInfo. This resulted in a varied amount of plumbing changes. It also pushes the platform specific bits up into the browser where they belong.
ScreenInfo is a struct that is part of the webkit/glue API.
R=dglazkov,eseidel
Review URL: http://codereview.chromium.org/8761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.history object. I've reverted our original changes and gone with a
different approach.
The idea is to fake the HistoryItem that FrameLoader asks for synchronously,
and give it a special URL that we can intercept later and do the back/forward
navigation.
BUG=3912
Review URL: http://codereview.chromium.org/8756
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
results in the wrong word being selected. The solution seems to lie in a tricky webkit hack, which requires the use of point() and localPoint() in different situations.
Issue = 613
Review URL: http://codereview.chromium.org/8895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the same HEADER_SEARCH_PATHS. For the couple of cases where we want to use
headers from third_party/WebKit, redirect the #includes in the port headers.
Review URL: http://codereview.chromium.org/8964
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than using tacked-on functions on GraphicsContext. Clean up the associated GraphicsContext objects.
Merge SkGraphicsContext, SkPaintContext, and PlatformContextSkia into one class, PlatformContextSkia. This tries to change no code related to this, the code in PlatformContextSkia is just a concatenation of those existing files, and hopefully doesn't need much review. This file is in the wrong style and is a terrible mess, I will clean it up in successive passes so it can be reviewed reasonably.
Review URL: http://codereview.chromium.org/8754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involved fixing up vcproj files and making some KJS -> JSC changes. I also had to fix some issues related to ScriptCallContext.
I had to create a ScriptControllerChromium.cpp for the JSC build to provide an implementation of createScriptInstanceForWidget that knows how to talk to our plugin implementation. This file belongs in bindings/js alongside files like ScriptControllerWin.cpp, so I created webkit/port/bindings/js to house it.
R=dglazkov,ojan
Review URL: http://codereview.chromium.org/8947
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8928
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Include more code from the main test_shell.cc into the GTK version. Wherever
possible the code has been copied and pasted in directly to make the future
merge easy.
Review URL: http://codereview.chromium.org/8670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
structure. The member is no longer used.
R=tony,avi
BUG=3834
Review URL: http://codereview.chromium.org/8705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8000
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a readonly textarea. This triggered lots of asserts.
Review URL: http://codereview.chromium.org/8860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
word is selected. This is because we use the wrong node when
getting the selection. We want to use the shadow inner node,
but the hit test result provided to the ContextMenu is not
the shadow node. To work around this, we recompute the
hit test result.
BUG=613
TEST=Go to a page with a text area, add text until a scroll bar
appears, scroll the text area and right click on a word. The
word under the cursor should be highlighted.
Review URL: http://codereview.chromium.org/8853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as we need to simulate mousemoves here. ui tests run on machines which are locked,
causing this test to fail.
Moved the NPAPITester and NPAPIVisiblePluginTester classes to a common file
npapi_test_helper.cc so it can be used from both tests.
Relanding the SetCursor patch. It has already been approved by John.
Description below:-
Proposed fix for http://b/issue?id=1362948, which is a crash in the rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent.
This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which
returns NULL and hence the crash.
The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed.
Added a unit test which deletes the plugin instance in a mousemove event.
R=jam
Bug=1362948
Review URL: http://codereview.chromium.org/8691
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent.
This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which
returns NULL and hence the crash.
The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed.
Added a unit test which deletes the plugin instance in a mousemove event.R=jamBug=1362948
Review URL: http://codereview.chromium.org/8178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
typing working.
Review URL: http://codereview.chromium.org/8663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit 54dfed3ab933cea7492ae1ed2f35cdbfe822e8a4.
Review URL: http://codereview.chromium.org/8839
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8000
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
were using the width of the image, when the width is actually inferred by the
Windows API call. Instead, we were supposed to pass the height.
BUG=100
Review URL: http://codereview.chromium.org/8646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3224
Caveats:
* Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer.
* Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.)
* Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version.
Review URL: http://codereview.chromium.org/8186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed some files from test_files because scons complains (warns)
when a file is both in test_files and input_files. So the files removed from
test_files also exist in input_files and at some pointed will be ported anyway.
I also made some linking stubs.
BUG=3674
Review URL: http://codereview.chromium.org/7974
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on return from NPObjectStub::OnInvoke. This is because of a bug in the plugin,
where in it returns a string in the variant which is not allocated using NPN_MemAlloc. As a result it crashes when we free the memory for the string.
It also crashes in Firefox. Firefox 3 disables the plugin. (http://kb.mozillazine.org/Issues_related_to_plugins).
We disable this plugin as well. This fixes http://b/issue?id=1362948
R=jam
Bug=1362948
Review URL: http://codereview.chromium.org/8179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There doesn't appear to be a WebKit PLATFORM macro for LINUX and, since we're
in the middle of a merge, adding one isn't a great idea either. So I'm using
__linux__ here. Also, several the stubs were very temporary and since stubbing
them required getting their headers to work as well I just aliased them away.
Review URL: http://codereview.chromium.org/8131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7980
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3935 0039d316-1c4b-4281-b951-d872f2087c98
|