| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a few helper methods on WebFrame.
R=jam
BUG=10036
TEST=none
Review URL: http://codereview.chromium.org/173152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplying r23820, this time interactive UI tests should not fail.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mnaganov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
refactoring change (http://src.chromium.org/viewvc/chrome?view=rev&revision=23589). Do that now.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18970
TEST=test matrix videos ending in 0 should have mute context menu disabled
Review URL: http://codereview.chromium.org/174018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This member was of type HTMLPlugInElement. This is a step toward removing all
WebCore includes from webplugin_impl.cc.
R=jam
BUG=10036
TEST=none
Review URL: http://codereview.chromium.org/173126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=load an audio/video with an unsupported input, then right click on it.. the playback control items should be disabled
BUG=19740
Review URL: http://codereview.chromium.org/174119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
really only used by webview.
Review URL: http://codereview.chromium.org/174143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brg
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tested with a Japanese locale, I saw Japanese plugin descriptions
when I assumed UTF-8.
BUG=18866
Review URL: http://codereview.chromium.org/174078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to restore a windowless_ check that used to exist in
webplugin_impl.cc prior to r23797. The goal of this change is to not
handle input events for windowed plugins.
R=hbono
BUG=none
TEST=pending/plugins/iframe-shims.htm
Review URL: http://codereview.chromium.org/173114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
called takes a void pointer! Argh :(
TBR=jam
BUG=10036
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/174126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the following new interfaces:
WebPlugin
WebPluginContainer
The implementation of WebPluginContainer is moved to webkit/api/src/WebPluginContainerImpl.{h,cpp}, and WebPluginImpl from webkit/glue now implements WebKit::WebPlugin.
This change does not completely eliminate dependencies in WebPluginImpl on WebCore. The rest will be removed in a separate change.
A hack was added to TemporaryGlue to deal with the fact that ChromeClientImpl still resides in webkit/glue. Also, StackingOrderIterator in webkit/glue because there is another CL out to remove that from the source tree.
Note: This change depends on another CL that I am brewing to make WebCanvas be a CGContext on Mac.
R=jam
BUG=10036
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/165464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ananta
Review URL: http://codereview.chromium.org/173108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes the code that previously existed to render HTML5 video on Mac. That code was already broken (video doesn't work at all on tip-of-tree), and so instead of trying to translate broken code, I just removed it. Andrew approved this.
R=amanda,scherkus
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mnaganov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mnaganov
Review URL: http://codereview.chromium.org/173053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tracks.
There is a WebKit side to this patch out for review as well:
https://bugs.webkit.org/show_bug.cgi?id=28310
BUG=18970
TEST=play a video without audio (i.e., trek0.ogv), the UI should display a disabled audio icon
Review URL: http://codereview.chromium.org/171091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18969,18970
TEST=watch for a faded out play/mute button
Review URL: http://codereview.chromium.org/171094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
track down all callers, also removes the
deprecated function that uses std::wstring.
BUG=3078 (http://crbug.com/3078)
TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests.
Review URL: http://codereview.chromium.org/164537
Patch from Thiago Farina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/172091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
distribution.
This helps to reveal memory size occupied by compiled code and engine's data. And this is also an eye candy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/172090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19521
TEST=Go to http://htmlfive.appspot.com/static/video.html and it will play.
r23255 introduced a regression that causes an extra seek in the
beginning of playing a video file. This extra seek causes FFmpeg
to look for index at the end of file which issue a range request
at the end of the file.
Review URL: http://codereview.chromium.org/171084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and instead accesses the attributes directly.
BUG=none
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/172053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
breakpoint effectively removes it in our implementation).
Review URL: http://codereview.chromium.org/164561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same change as <http://codereview.chromium.org/164309> that I reverted to investigate a test_shell_test failure (Issue 19263).
This change checks if the modifier flag is a WebInputEvent::MetaKey flag to
switch the scroll granularity when a user types a up/down key.
Editor::Commands ("MoveToBeginningOfDocument" and "MoveToEndOfDocument") works
only in an editable control, such as <textarea>. On the other hand, this
WebViewImpl::ScrollViewWithKeyboard() is for scrolling a page.
BUG=18844 "Apple (command) key + down arrow is not working"
TEST=Type command+down keys in a web page which contains a scroll bar, and
verify Chrome scrolls the page to its end.
Review URL: http://codereview.chromium.org/165523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18970
TEST=play a video with no audio hardware, verify that UI changes
Review URL: http://codereview.chromium.org/169010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17973
When a WebCore::Document is loaded, a resource request
for the document is made. In case of MediaDocument the
request for the media file is made separately through
<video> and so the DocumentLoader should be stopped.
This change mimic what is done in WebHTMLRepresentation
(which is similar to our RenderView) and stops the
resource loading in WebFrameLoaderClient since RenderView
doesn't have access to WebCore types.
Review URL: http://codereview.chromium.org/165286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consumers use executeCommand.
Patch by Marshall Greenblatt
R=darin
BUG=19270
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=none
TEST=reliability
Review URL: http://codereview.chromium.org/165532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also renamed the MakeFoo classes to FooBuilder so that it would be
more clear at the call sites that you are dealing with a class.
I then translated the ToBar functions to also be BarBuilder classes.
I just did this for consistency with the FooBuilders.
For reference, "Foo" refers to WebCore Platform*Event classes and
"Bar" refers to WebInputEvent subclasses :-)
R=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18969,18970
TEST=none
Review URL: http://codereview.chromium.org/164356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InspectorController::clearConsole call.
Landing for pfeldman@chromium.org
TBR=mnaganov
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/165498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and later removed in rev 19669. From the original commit message:
Rev 12100 changed the way that we spool and render printed output, most notably
introducing use of the PrintContext class. The existing
PrintContext::spoolPage() method applies a webkit scaling factor before
rendering output to the graphics context. ChromePrintContext::spoolPage() (in
webframe_impl.cc), which is used by chromium instead of
PrintContext::spoolPage(), does not apply this scaling factor, but instead
eventually returns the scaling factor via WebFrame::PrintPage(). This is a
problem for the Chromium Embedded Framework (CEF) because, unlike chromium, the
CEF renders directly to the printer device context. It is therefore important
for CEF that we retrieve and apply the webkit scaling factor before calling
PrintPage(). In order to support this capability the following adds a
WebFrame::GetPrintPageShrink() method.
Patch by Marshall Greenblatt
R=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18988
TEST=None, since this is currently redundant with the plugin whitelist
Review URL: http://codereview.chromium.org/164487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On the Mac, Flash appears to cache the CGContextRef provided in NPP_SetWindow until the next NPP_SetWindow call, so we need to call it sometime before the next plugin paint. This allows us to call NPP_SetWindow before telling the plugin to paint, but not from the Paint function itself (where it could have bad side-effects).
BUG=18894,18980
TEST=Switch to HQ on a YouTube video; Flash should not crash.
Review URL: http://codereview.chromium.org/165344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which just appeared with the latest roll of webkit (on Linux)
Add temporary exceptions to test_expectations.txt
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/164471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"ICOImageDecoderTest.ChunkedDecoding" started failing since this change.
Review URL: http://codereview.chromium.org/164468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23300 0039d316-1c4b-4281-b951-d872f2087c98
|