| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This code was wrong from the start; I know better now.
TEST=windowless plugins still draw (I tried in in test_shell)
BUG=19238
Review URL: http://codereview.chromium.org/180051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47907 where KURL no longer has
a single argument constructor.
TBR=brettw@chromium.org,michaeln@chromium.org
TEST=try server
BUG=none
Review URL: http://codereview.chromium.org/180049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We can use this to get more info from users about which plugins
we're loading and using.
Review URL: http://codereview.chromium.org/178040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=24947
BUG=16018
TEST=None
Review URL: http://codereview.chromium.org/173634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were not setting the focused frame to null when we blurred a window.
Therefore a document inside a frame inside a blurred window would think
it was focused since its frame was the focused frame.
This fixes the layout test for the test_shell but Chrome is still
having issues with the test since blurring is asynchronous in chrome.
Changing the layout test by adding timers makes the test pass in chrome
as well.
BUG=16018
TEST=Run LayoutTests/fast/dom/HTMLDocument/hasFocus.html
Review URL: http://codereview.chromium.org/182032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18947, various nspluginwrapper-related bugs perhaps
Review URL: http://codereview.chromium.org/173617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
upstream.
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/183014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.
This forces local storage and database to be enabled on
chrome-extension:// pages.
Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.
erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff
BUG=19511
Review URL: http://codereview.chromium.org/173306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/175012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scrollbarsModeDidChange was also added to HostWindow.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/183001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new method to ChromeClient, so now ours doesn't compile. I'm not 100% sure
that doing nothing is the right course of action here, but it seems to be what
most ports are doing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
set by the DOM agent.
BUG=20482
Review URL: http://codereview.chromium.org/182009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19982
TEST=Assign @role=article on a DOM element. It will be exposed as MSAA role document.
Review URL: http://codereview.chromium.org/182006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
We also ignore xpcom-related errors while loading plugins, as that
breaks layout tests.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ROLE_SYSTEM_LISTITEM.
BUG=19982
TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively.
Review URL: http://codereview.chromium.org/173488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason
from WebFrameLoaderClient.
This CL also moves WebDataSourceImpl into webkit/api/src. That change was
needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it,
which WebFrameLoaderClient uses to communicate back to the WebPlugin upon
completion of the frame load.
WebViewDelegate::DidFinishLoadWithReason is modified to include url and
notify_data parameters, eliminating the URLRequestRouted method. This is done
so that we can support overlapping NPN_GetURLNotify targetting different
frames.
WebPluginContainer grows an executeScriptURL method to deal with javascript:
URLs.
NOTE: I'm working on some UI tests to better cover the case of overlapping
NPN_GetURLNotify calls.
R=jam
BUG=10036
TEST=none yet
Review URL: http://codereview.chromium.org/174514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/178003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r173550, due to WebKit failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getting accessed
after it was invalidated.
This should fix the embed-tag.html and object-embed-tag.html layout test failures.
TBR=jam
Review URL: http://codereview.chromium.org/174598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context of NPP_NewStream.
The plugin would invoke NPN_Evaluate to display an alert in the context of NewStream. This would cause the didFail IPC to be dispatched which would cause the plugin to invoke another call to NPP_NewStream which would repeat these steps and crash.
The didFail call from the renderer did not honor the deferred load flag which we set in WebPluginImpl
prior to dispatching stream IPCs to the plugin.
Fix is to dispatch the didFail call when we receive an ack from the plugin indicating that it is ready to accept stream data.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=20063
The other change is in WebPluginImpl::TearDownPluginInstance, where we run through the list of resource
clients and cancel them. We call didFail on these clients here, which occurs anyway through the PluginDestroyed
code path.
Bug=20063
Test=Convered by interactive UI test.
Review URL: http://codereview.chromium.org/174383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by tfarina.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
credentials and cookies from being sent to along with a
request.
I added the parameter for credentials to WebURLRequestPrivate
since it isn't in ResourceRequest for now and then checked
all places that do WebURLRequest::toMutableResourceRequest()
or WebURLRequest::toResourceRequest() to ensure that they
were not loosing information.
Right now, there is a non-orthogonal relationship between
setAllowStoredCredentials and setAllowCookies which is a
carry over from WebKit but I could change this to make
setAllowStoredCredentials only refer to user name/password
if it thought that this is better.
TEST=Covered by layout tests.
BUG=http://crbug.com/10961
Review URL: http://codereview.chromium.org/174495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessagePort.postMessage() to accept multiple MessagePorts.
Original review: http://codereview.chromium.org/173193
TBR=atwilson
TEST=None (new functionality not yet exposed via bindings, so existing tests suffice)
BUG=19948
Review URL: http://codereview.chromium.org/174566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for geometry updates while the plugin is hidden so that when it
becomes visible, the plugin is properly positioned.
In this change, I also revised RenderWidget::SchedulePluginMove to properly
merge a move that only updates the visible state, and I fixed up TestShell
to properly handle moves that only update the visible state.
R=jam
BUG=19888,20260
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/174513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
selection.
BUG=16400
TEST=See bug description
Review URL: http://codereview.chromium.org/173414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
affect JSON.stringify.
BUG=19850
Review URL: http://codereview.chromium.org/160098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Algorithm:
- copy win to shared
- for each diff between shared and lin, delete/refactor shared
- for each diff between shared and lin, delete in lin
- for each diff between shared and win, delete in win
The change should be mostly deletes.
Please verify that I didn't change any behavior on Windows or GTK.
Note: coincidentally, this change also fixes a bug that we've seen
on Linux that was fixed in the Windows version of the file. I only
noticed it because the Windows/Linux files differed, but after this
unforking the change is now in the shared code.
Mac shouldn't be too hard to do too.
Review URL: http://codereview.chromium.org/174479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'd like to print any dlopen() errors, but opening a 32-bit plugin
on a 64-bit system is an avoidable one. This also filters out any
Firefox-specific .xpis that may happen to be in the plugin directory.
TEST=about:plugins shows same plugins as before, but with less console spew
Review URL: http://codereview.chromium.org/174487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Another instance of HTMLMediaElement becoming out of sync with WebMediaPlayerImpl. Most of these bugs are a result of HTMLMediaElement re-creating WebMediaPlayerImpl whenever src changes but not completely resetting internal state, causing inconsistent behaviour.
BUG=16768,20152
TEST=change src and call load(), wait until the end of the clip -- ended should fire
Review URL: http://codereview.chromium.org/173388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL reworks the GtkSocket/GtkPlug code for windowed plugins on linux. Instead of having the plugin ask the browser to create a socket to plug into, it simply creates a plug and sends it to the browser. The browser creates a socket and attaches the plug when the socket becomes realized
This fixes 2 main issues:
- we can create windowed plugins in background tabs (Issue 16125)
- we can detach tabs with windowed plugins and reattach them (Issue 17110)
I reworked the IPCs, so it removes some amount of linux-specific things. We also need less synchronous IPCs to create/destroy plugins, so that should be a bit faster. In particular, I removed the plugin pid map, and instead made sure the renderer always destroys the plugin containers if the plugin process crashes - they will be destroyed if the renderer process crashes. Let me know if you have an issue with that.
Also, the intermediate plug/socket creation now happens in webplugin_delegate_impl_gtk. That means test_shell uses it as well. It made the code a lot simpler, and means we're testing it as well, albeit with a bit of extra overhead.
Bonus: I found a big bad bug in the GtkPluginContainer that made its width/height alias with some internal gtk structures. That was certainly causing some amounts of bugs.
Bonus 2: scrolling now looks more in sync with the rest of the page, though I'm not exactly sure which part caused that.
BUG=16125,17110
TEST=a lot of manual testing involving YouTube videos
Review URL: http://codereview.chromium.org/174295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
outgoing sync calls.
I will be watching the reliability test runs closely for any crashes which creep in due to reentrancies into plugins caused by this CL.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=15985
It is a touch tricky to implement a test case for this. Will add one hopefully in a subsequent CL
Bug=15985
Test=Covered by UI test
Review URL: http://codereview.chromium.org/173211
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/173384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I will be watching the reliability test runs closely for any crashes which creep in due to reentrancies into plugins caused by this CL.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=15985
It is a touch tricky to implement a test case for this. Will add one hopefully in a subsequent CL
Bug=15985
Test=Covered by UI test
Review URL: http://codereview.chromium.org/173211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
separator, status and tooltip.
BUG=19982
TEST=Assign @role application, document, radiogroup, region, separator, status or tooltip to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly.
Review URL: http://codereview.chromium.org/174382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
events.
HTMLMediaElement keeps track of network/ready state separately. When re-using an element by setting the src and calling load(), HTMLMediaElement's network/ready states became out of sync with the actual values inside WebMediaPlayerImpl. This led to the second media never firing 'loadedmetadata' and other events.
BUG=16768,20152
TEST=change src of an audio/video, call load(), should see durationchange and loadedmetadata events
Review URL: http://codereview.chromium.org/174385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.
This forces local storage and database to be enabled on
chrome-extension:// pages.
Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.
erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff
BUG=19511
Review URL: http://codereview.chromium.org/173306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
patch by Philippe Beauchamp (see http://codereview.chromium.org/149742 ), r=me.
BUG=6173
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24136 0039d316-1c4b-4281-b951-d872f2087c98
|