| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, many of our tests rely on being able to use WebURLLoader to load
data: URLs when there is no ResourceLoaderBridge implementation. In those tests,
we would crash if we try to use the ResourceLoaderBridge. To workaround that,
and because it probably a good optimization anyways, I decided to check if the
data URL has a supported MIME type, and if it does, then I let it load directly
as before.
Since data URLs may be very large, I modified DataURL::Parse to skip parsing the
'data' section of the URL if the corresponding out param is null.
R=tony
BUG=38546
TEST=none (I would like to add a download test, but they are all disabled or flaky.)
Review URL: http://codereview.chromium.org/5542001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/5591004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Confusingly, we had a ToString() that returned a UTF-8 string and
a ToStringVector() that returned wstrings. Since CppVariant is
a small wrapper around NPVariant I made them both use UTF-8; it
simplified most of the users anyway (which only dealt with ASCII
anyway).
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/5631002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
off for background pages
We don't support turning compositing on for a background page currently and it doesn't seem necessary. This disables all GPU-requiring features for background pages for now. When we have valid use cases we can re-enable features as needed.
BUG=64512
TEST=load extension that uses 3d CSS in a background page and verify that there is no browser crash or GPU process created on startup
Review URL: http://codereview.chromium.org/5369008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of a MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/5619002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
respectively.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version of this API synchronous. Otherwise, the caller may end up trying to
draw over the text that isn't there yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5555004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65170
TEST=unit_tests
Review URL: http://codereview.chromium.org/5619001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the accelerated compositor for 3D CSS, Video, Plugins and Animations.
Also the compositor will now always be enabled for WebGL and accelerated 2D
canvas content.
In addition, added an about:flags entry for the flag using the same name and description as our old "enable accelerated compositing" entry had, however triggering the new flag.
This CL must be checked in after the patch for https://bugs.webkit.org/show_bug.cgi?id=50301 lands.
BUG=64589
Review URL: http://codereview.chromium.org/5421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=proxied audio works (manual test)
BUG=none
Review URL: http://codereview.chromium.org/5522003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to the basic proxying, this required some changes to the dispatcher
and process infrastructure to get the handles of the processes available when
I need them so I can duplicate the shared memory handles properly into the
different processes.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4985001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=63774
TEST=Visit http://vescam.com/select_crasher.html and try all the selects
in that page.
Review URL: http://codereview.chromium.org/5302009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62865
TEST=none
Review URL: http://codereview.chromium.org/5406004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are now doubles (to match Safari). This was done in
http://trac.webkit.org/changeset/72974
BUG=64874
Review URL: http://codereview.chromium.org/5482002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- shm handle uint64_t -> int
- more unification of shm size from int32_t -> uint32_t
- GetNativeMemoryHandle() -> GetSharedMemory()
BUG=none
TEST=src/ppapi/examples/
Review URL: http://codereview.chromium.org/5410001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer).
The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case.
BUG=53867,61293
TEST=Completing the first level in gwtquake shouldn't crash the renderer.
Review URL: http://codereview.chromium.org/5362003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- change comment style in ppb_audio_trusted_dev.h to c style
- change shm_size to uint32_t to match other interfaces
BUG=none
TEST=src/ppapi/examples/audio/audio.cc
Review URL: http://codereview.chromium.org/5292010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5139006
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5270010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64234
TEST=None
Review URL: http://codereview.chromium.org/5258005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fields one at a time.
BUG=63437, 62638
TEST=unit_tests --gtest_filter=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/5334005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* webkit/glue/
- Add overloads of queryLocalizedString() functions
They will be added to WebKit::WebKitClient later.
- Add implementations for WebLocalizedString::Validation*
- Add message strings
The English strings are different from WebKit's to avoid the brusque
WebKit's strings.
Port some messages from Mozilla.
* webkit/tools/test_shell/ and webkit/support/
Hook queryLocalizedString() functions in order to return messages same as
WebKit in layout test.
BUG=28264
TEST=LayoutTests/fast/forms/validationMessage.html
Review URL: http://codereview.chromium.org/4678006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- includes Darin's changes to move StreamCreated() to main thread
- callback for delivering handles to proxy
- changes to trusted interface
BUG=none
TEST=chrome/src/ppapi/examples/audio/audio.cc
Review URL: http://codereview.chromium.org/5202002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61121
TEST=None
Review URL: http://codereview.chromium.org/5270003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugin rectangle is small.
BUG=49832
TEST=NONE
Review URL: http://codereview.chromium.org/5378001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestShell no longer needs this since we load from {Debug,Release}/plugins
now. Also remove the code to copy the plugin into
TestShell.app/Contents/PlugIns.
BUG=48471
Review URL: http://codereview.chromium.org/5274001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
Bug=63030
Review URL: http://codereview.chromium.org/5306004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add API to WebCursor to return a native-cursor, and implementation for windows,
linux and mac.
For linux: Move gtk_util::GetCursor into gfx:: namespace. Also, get rid of
ref/unref'ing the cursors from everywhere. Instead, do almost all of it in one
place (in gfx). Also, show proper cursors for web-pages with touchui=1 (i.e. add
support for updating cursor in RenderWidgetHostViewViews).
Review URL: http://codereview.chromium.org/5110010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URL redirect
notifications which are sent out from the browser while processing URL requests issued
by the plugin via the NPN_GetURLNotify and NPN_PostURLNotify APIs.
For more info please see https://wiki.mozilla.org/NPAPI:HTTPRedirectHandling
As part of this CL we also block cross origin 307 POST url redirects.
Test=Covered by NPAPI UI test GetURLRedirectNotification
Bug=63030,63698
Review URL: http://codereview.chromium.org/5228007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashing
BUG=62565
TEST=Run with --use-gl=osmesa on 10.6, and open a YouTube video. The plugin should not crash, and audion should still play (but without video).
Review URL: http://codereview.chromium.org/5233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to synchronize its checks, since in order to assert correctly, it needs to make sure the thread id is synchronized on all threads.
It doesn't need scoped_ptr. It was trying to use NULL to catch invalid thread ids. 0 is already assumed to be invalid (see base::Thread's use).
Eliminating scoped_ptr fixes a valgrind/heapcheck issue where they don't follow LazyInstance objects' member pointers. So they think the ThreadChecker's member variable is leaked, even though the global object still has a pointer to it.
Removing the scoped_ptr.h caused a bunch of other lame files to fail to compile. I had to fix those places. #include what you use please :(
TBR=levin (I want to green the memory bots)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5180006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5091005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63440
TEST=browser_tests --gtest_filter=FormManagerTest.*
Review URL: http://codereview.chromium.org/5137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorder
plugin is installed on the machine. This plugin intercepts LoadLibrary calls issued by
chrome.dll and wraps NPAPI calls provided the actual plugin dll, in this case media player.
This is to provide the Download this video functionality.
Crash occurs probably due to an interacton with Real player and media player. Fix is to
load the plugin dynamically via the exported kernel32 function LoadLibrary instead of invoking
it via the LoadLibrary import from chrome.dll. This would bypass the recorder plugin.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=63552
Bug=63552
Test=Install real player and media player on the machine and navigate to the url mentioned
in the bug. It should not crash
Review URL: http://codereview.chromium.org/5190005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=63779
Review URL: http://codereview.chromium.org/5224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5194003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44867
TEST=
Review URL: http://codereview.chromium.org/5106002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GL naming convention.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5210001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The up/down resize one is used by Google Calendar when growing/shrinking
events.
I verified manually this looks good, but I was unable to get a screenshot
with the cursor to provide evidence. It looks like a simple
black double-ended up/down arrow on my computer.
TEST=manually verified, fewer notimpls
Review URL: http://codereview.chromium.org/5154005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
draw into them.
Previously, the logic was:
1.) Clear plugin background
2.) If the plugin didn't update, return early
3.) Paint plugin
4.) "Swap buffers"
But the "Swap buffers" step only unbound and rebound an FBO object If the plugin didn't change, its backing store would contain transparent black, and if the graphics driver decided to flush the FBO for another reason than a "swap buffers" call, the blackness would show up in the browser.
This CL swaps steps 1 and 2, so even if the FBO is flushed for some unrelated reason, we display something valid.
BUG=60341
TEST=Open the file attached to the bug. Resize the window for a few minutes, put the computer to sleep and back on, resize window for a few more minutes. The plugin area (the 191x60px rect in the middle) shouldn't become black. YouTube should still work. CPU usage shouldn't be worse than it was before for the browser, plugin, and renderer processes.
Review URL: http://codereview.chromium.org/5220002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/4832002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These were probably copied to c/b/renderer_host a while ago, and nobody removed them from their old location.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5169001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebKit r72243.
TBR=levin
Review URL: http://codereview.chromium.org/5125002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Someone moved the files in PPAPI around and hand-modified autogenerated files.
This CL moves the change to the .py file used to generate them.
BUG=none
TEST=generated files identical to hand-modified version.
Review URL: http://codereview.chromium.org/5147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
external files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is "single file" or "multiple files".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5109002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium side of http://trac.webkit.org/changeset/72141, needed to pass Acid3.
Changes the default minimum font size from 1 to 0.
BUG=none
TEST=acid3
Review URL: http://codereview.chromium.org/4954002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 8d410ce0aae7acbbcd816425ba49e79d8d7b9a1d.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66398 0039d316-1c4b-4281-b951-d872f2087c98
|