summaryrefslogtreecommitdiffstats
path: root/webkit/glue
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 20854.darin@chromium.org2009-07-1619-487/+618
| | | | | | Review URL: http://codereview.chromium.org/155621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWidget from the WebKit API. This change also makesdarin@chromium.org2009-07-1619-618/+487
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of WebKitClient (replacing WebWidgetDelegate from glue). The ripple effects of this change are rather large, but most of the impact is mechanical. The more interesting changes include: 1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't matter at all to RenderWidget or RenderView, but it did cause some changes to be made to TestWebViewDelegate. Now, it is not possible to share a delegate implementation for both the WebView and a popup menu, so I have a second instance of the delegate owned by TestShell for use with popup menus. 2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting to be a pretty large change, so I stopped short of deleting WindowOpenDisposition. That way the Chrome side can remain mostly unmodified. I then added a mapping function to convert from WebNavigationPolicy to WindowOpenDisposition. 3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and there is now an enum to specify the composition command (WebCompositionCommand). 4- I added IPC serialization for WebCompositionCommand and WebTextDirection, which cleaned up some code that was just using ints in IPC messages. R=jam BUG=16234 TEST=none Review URL: http://codereview.chromium.org/149620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid dereferencing uninitialized pointers.cevans@chromium.org2009-07-162-6/+49
| | | | | | | | | | | | Thanks to "The Mighty Hoppy" for requesting a browser crash investigation. BUG=NONE TEST=GlueSerializeTest.BadMessagesTest TBR=cpu Review URL: http://codereview.chromium.org/149738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20849 0039d316-1c4b-4281-b951-d872f2087c98
* Adding callback support to media filter Initialize() and Seek().scherkus@chromium.org2009-07-162-12/+21
| | | | | | | | | | | | | Also includes unit tests for AudioRendererBase and VideoRendererBase. I had to rollback my first attempt at this change. Original review: http://codereview.chromium.org/155469 BUG=16014,16031 TEST=media_unittests, layout tests Review URL: http://codereview.chromium.org/155608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20836 0039d316-1c4b-4281-b951-d872f2087c98
* Removed extraneous call to the now depreacted WebCore::parseURL().japhet@chromium.org2009-07-151-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20804 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable content script messaging test.mpcomplete@chromium.org2009-07-151-4/+0
| | | | | | | | | | | Remove temporary change now that webkit DEPS roll landed. TEST=no BUG=16228 Review URL: http://codereview.chromium.org/149655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20755 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: provisional commit for new WebInspector's 'last opened panel' change.pfeldman@chromium.org2009-07-155-2/+36
| | | | | | Review URL: http://codereview.chromium.org/149613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20751 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the bool parameter from PipelineCallback and cleaned up ↵scherkus@chromium.org2009-07-152-106/+73
| | | | | | | | | | | | | WebMediaPlayerImpl::Proxy. This forces clients to check Pipeline::GetError() instead of using a simple true/false check for success. Also the bool parameter wasn't being used for Seek() and Stop() callbacks, further hinting at its removal. BUG=16009 TEST=media_unittests pass, layout tests pass Review URL: http://codereview.chromium.org/149584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20738 0039d316-1c4b-4281-b951-d872f2087c98
* linux: destroy browser-side plugin windows on plugin crashevan@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | | | | | Because the plugin windows must be destroyed by the UI thread, we store the map of plugin PID -> plugin windows there, on the RenderWidgetHostView. This differs slightly from Windows, where the map is stored on the PluginProcessHost, but is otherwise pretty similar. TEST=crash a windowed plugin; you should see a sad plugin icon in the place of the plugin Review URL: http://codereview.chromium.org/155517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20693 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20683.jorlow@chromium.org2009-07-141-1/+0
| | | | | | Review URL: http://codereview.chromium.org/155539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20686 0039d316-1c4b-4281-b951-d872f2087c98
* linux: destroy browser-side plugin windows on plugin crashevan@chromium.org2009-07-141-0/+1
| | | | | | | | | | | | | | | | Because the plugin windows must be destroyed by the UI thread, we store the map of plugin PID -> plugin windows there, on the RenderWidgetHostView. This differs slightly from Windows, where the map is stored on the PluginProcessHost, but is otherwise pretty similar. TEST=crash a windowed plugin; you should see a sad plugin icon in the place of the plugin Review URL: http://codereview.chromium.org/155517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20683 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side of fixes for content-script messaging.mpcomplete@chromium.org2009-07-143-8/+29
| | | | | | | | | | | | | | | | | | This change adds registration of content scripts, parented to a frame's context. When a frame's context goes away, we unregister it and any content script contexts for it. There's a corresponding webkit change that lets us know when a content script context is created. Filed upstream as https://bugs.webkit.org/show_bug.cgi?id=27104. BUG=16228 TEST=install an extension with a content script that communicates with a parent process. Messages should be sendable both ways. Review URL: http://codereview.chromium.org/155309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20677 0039d316-1c4b-4281-b951-d872f2087c98
* Middle clicks on all fragment links open in new tab.cmp@google.com2009-07-141-22/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Middle clicking on an anchor tag that points to an in-doc fragment should result in a new background tab being opened. Before this change, we were overriding this behavior to cause a middle click to behave like a left click. This patch allows middle clicks to function similar to the behavior seen in Firefox and Safari. No change in behavior should be seen by users for left clicks on anchor tags that refer to in-doc fragments. While testing, I see at times issues due to scrolling within the tab to the correct fragment identifier or start of the page. This has already been identified in issues such as 9319, so I'm ignoring that for now. BUG=2913 TEST=Load Wikipedia, visit a page with many subheadings, left click on a subheading, verify the current page scrolls to the correct heading. Click back, verify you are taken back to your original position. Middle click on the same subheading, verify a new tab is loaded in the background that is scrolled to the correct heading. Review URL: http://codereview.chromium.org/155522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20674 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where playbackRate wasn't being respected.scherkus@chromium.org2009-07-142-4/+18
| | | | | | | | | BUG=16502 TEST=setting defaultPlaybackRate before the media starts playing should be respected when play() is called Review URL: http://codereview.chromium.org/155404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20652 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo. Also,darin@chromium.org2009-07-1410-112/+99
| | | | | | | | | | | | | | | | | | make use of WebPopupMenuInfo from the WebKit API. WebMenuItem remains in webkit/glue for convenience with IPC marshalling and related usage in Chrome. This work is precursor to switching over to using WebWidget from the WebKit API. BUG=16234 TEST=html select drop downs should still work on the mac. try switching languages on news.google.com. R=paul Review URL: http://codereview.chromium.org/155378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20624 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: mitigate WebKit console API changes.pfeldman@chromium.org2009-07-143-18/+2
| | | | | | Review URL: http://codereview.chromium.org/155490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20613 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 16597.hbono@chromium.org2009-07-141-1/+1
| | | | | | | | | | Our autofill code handles keyboard events by itself and it prevents dispatch a return key to WebKit when the key is comsumed by the autofill. Unfortunately, this code is enclosed with "#if defined(OS_WIN)" and "#endif". This change just activates this code on Linux. BUG=16597 "Prevents submitting a form when pressing a return key in an auto-fill popup" TEST=Type a return key on an auto-fill popup and verify this is not submitted. Review URL: http://codereview.chromium.org/149517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ConsoleLog test and enable it. It was previously disabled because ↵dimich@google.com2009-07-141-10/+10
| | | | | | | | | | | | WebKit change http://trac.webkit.org/changeset/45786 had split the 'type' and 'level' parameters of the ConsoleMessage into 2 separate parameters, which changed the way CSS styles are formatted for messages in Inspector front-end. Updated test expectations. BUG=16684 TEST=the test DevToolsSanityTest.TestConsoleLog is enabled by this CL Review URL: http://codereview.chromium.org/155482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20609 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS from 45738 to 45840.dimich@google.com2009-07-147-3/+18
| | | | | | Review URL: http://codereview.chromium.org/149575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20589 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill dropdown support for password forms.tim@chromium.org2009-07-147-217/+93
| | | | | | | | BUG=5406 Review URL: http://codereview.chromium.org/155399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20585 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary flag to enable plugins on the Mac and Linux whileamanda@chromium.org2009-07-131-5/+2
| | | | | | | | | | | | | | leaving the default to "disabled" until they work better. Temporary, for use by people who like living on the bleeding edge. BUG=none TEST=none jam: review evan,jon: FYI Review URL: http://codereview.chromium.org/149570 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20540 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the carbon event dispatcher from the main thread of the plugin processamanda@chromium.org2009-07-132-7/+31
| | | | | | | | | | | | and replace it with a pump for null events on the plugin thread. This removes a deadlock that the previous code inadvertently created, and is a much more focused solution to the problem. BUG=10809 TEST=none Review URL: http://codereview.chromium.org/155439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previous clipping rect change for Cairo to see if it fixes the build.brettw@chromium.org2009-07-131-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20516 0039d316-1c4b-4281-b951-d872f2087c98
* Keep the cairo clipping region in sync with the Skia one.brettw@chromium.org2009-07-131-10/+10
| | | | | | | | | | The PlatformCanvas now tracks this, so we don't need to have the similar code in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the cairo_t has a transform and clip but the surface does not. Review URL: http://codereview.chromium.org/149409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20499 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: allow reload while on a breakpoint: detach agent on navigation ↵pfeldman@chromium.org2009-07-135-0/+16
| | | | | | | | | | attempt. BUG=16606 Review URL: http://codereview.chromium.org/149529 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20480 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable styles editing.pfeldman@chromium.org2009-07-131-1/+1
| | | | | | | | BUG=16194 Review URL: http://codereview.chromium.org/149524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20478 0039d316-1c4b-4281-b951-d872f2087c98
* Correct bad WebKit merge.abarth@chromium.org2009-07-131-0/+10
| | | | | | | | | | BUG=12969 R=darin TEST=I wish I could write a test, but I can't reproduce the issue. Review URL: http://codereview.chromium.org/149510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20473 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up windowless plugins. Mostly Mac related, some crossamanda@chromium.org2009-07-113-167/+236
| | | | | | | | | | platform aspects. BUG=10809 TEST=none Review URL: http://codereview.chromium.org/113637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20453 0039d316-1c4b-4281-b951-d872f2087c98
* Unreverting "Implemented injected message loops for PipelineImpl"scherkus@chromium.org2009-07-112-26/+34
| | | | | | | | | | Guess it was a flaky layout test. TBR=hclam Review URL: http://codereview.chromium.org/155400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20444 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Roll WebKit DEPS to 45685michaeln@google.com2009-07-104-16/+20
| | | | | | | | | | | This roll picks up changes to WebCore::Widget which make that a RefCounted class. 2) Mods to plugin handling in our "glue" needed to recover from the above Review URL: http://codereview.chromium.org/149443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20440 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Implemented injected message loops for PipelineImpl."scherkus@chromium.org2009-07-102-34/+26
| | | | | | | | | | | | I cannot repro the layout test failures, seeing if this helps. TBR=hclam BUG=none TEST=none Review URL: http://codereview.chromium.org/155396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20439 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented injected message loops for PipelineImpl.scherkus@chromium.org2009-07-102-26/+34
| | | | | | | | | | | For now both the player and WebMediaPlayerImpl create a thread and inject its message loop into the pipeline. The end result is more-or-less the same as what we have today, but we could end up moving the pipeline onto the render thread. BUG=16008 TEST=layout tests, media_unittests should pass Review URL: http://codereview.chromium.org/155338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20417 0039d316-1c4b-4281-b951-d872f2087c98
* Enables find in page match counts on Mac.rohitrao@chromium.org2009-07-101-9/+0
| | | | | | | | BUG=http://crbug.com/16148 TEST=Find in page should report match counts correctly. Review URL: http://codereview.chromium.org/155353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20377 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: postpone after-compile event propagation to the UI until scripts ↵pfeldman@chromium.org2009-07-102-9/+24
| | | | | | | | panel is shown. Review URL: http://codereview.chromium.org/155352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20374 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Show exception message in a resource message bubble while stopped ↵pfeldman@chromium.org2009-07-101-0/+69
| | | | | | | | on exception. Review URL: http://codereview.chromium.org/155349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20373 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-091-5/+5
| | | | | | | | | | | More cleanup relating to pipeline cleanup. BUG=16008 TEST=no real code chage, nothing should change Review URL: http://codereview.chromium.org/155230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20338 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Made MediaFilter::host_ and MediaFilter::message_loop_ private."scherkus@chromium.org2009-07-091-5/+5
| | | | | | | | | | TEST=none BUG=none TBR=evmar Review URL: http://codereview.chromium.org/155333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20336 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-091-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20335 0039d316-1c4b-4281-b951-d872f2087c98
* Fix custom cursors on Mac. Null and 0 turn out not to be opposites.darin@chromium.org2009-07-091-0/+4
| | | | | | | | | | | | | | I also added an assertion to webcursor_mac.mm that is probably a bit redundant with the one in AppKit, but this way the assertion is more visible to someone reading this file. BUG=16346 TEST=load a page that uses a custom css cursor. R=pinkerton Review URL: http://codereview.chromium.org/155320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20327 0039d316-1c4b-4281-b951-d872f2087c98
* Remove reference counting from WebWidgetDelegate.darin@chromium.org2009-07-093-8/+2
| | | | | | | | | | | | | | | | | This was added as a speculative crash fix by eseidel back in June of 2008. See http://b/1211911 for details. It didn't appear to resolve the crash then (as another patch was required to fix the bug), and it doesn't seem to be necessary since the RenderView, which is the delegate and owns the WebView, is the one in charge of allocating the WebView and destroying the WebView. So, it is not possible for the WebView to outlive the RenderView. BUG=16234 TEST=none R=brettw Review URL: http://codereview.chromium.org/155292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert unintentional change.abarth@chromium.org2009-07-091-5/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20263 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPSabarth@chromium.org2009-07-095-11/+15
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/155278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20254 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: show property type names in Elements panel and Console.yurys@google.com2009-07-092-28/+49
| | | | | | | BUG=15988 Review URL: http://codereview.chromium.org/149341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20253 0039d316-1c4b-4281-b951-d872f2087c98
* GtkPluginContainerManager::UnrealizeCallback should be void.craig.schlenter@chromium.org2009-07-092-3/+3
| | | | | | Review URL: http://codereview.chromium.org/149347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20245 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add images for disabled checkboxes and radio buttons.agl@chromium.org2009-07-096-0/+8
| | | | | | | | | | (WebKit side still to land, however this side can be safely landed without it.) BUG=16170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20224 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebWidgetDelegate::GetContainingView since it is not needed.darin@chromium.org2009-07-094-12/+2
| | | | | | | | | | TEST=none BUG=16234 R=jam Review URL: http://codereview.chromium.org/155243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20213 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to r45634 and fix buildhclam@chromium.org2009-07-081-2/+2
| | | | | | Review URL: http://codereview.chromium.org/155241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20196 0039d316-1c4b-4281-b951-d872f2087c98
* Start using WebCursorInfo from the WebKit API. WebCursorInfo is adarin@google.com2009-07-0818-277/+352
| | | | | | | | | | | | | | | | lightweight struct containing a description of a cursor that the embedder should render. WebCursor still exists. Instead of WebCursor initializing from a PlatformCursor, it now initializes from a WebCursorInfo. TEST=none BUG=10039 R=jam Review URL: http://codereview.chromium.org/155172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20194 0039d316-1c4b-4281-b951-d872f2087c98
* Land Anton's patch to avoid throwing away type information on theager@chromium.org2009-07-081-1/+1
| | | | | | | | | | | window wrapper in the debugger agent. Review URL: http://codereview.chromium.org/155179 TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20187 0039d316-1c4b-4281-b951-d872f2087c98
* Load extension plugins before looking for plugins in other places, e.g.abarth@chromium.org2009-07-081-5/+5
| | | | | | | | | | | | | | | | | Firefox's plugins directory. This allows extensions to override the user's default plugin for a particular mime type. BUG=15943 TEST=none R=mpcomplete Patch by Collin Jackson Review URL: http://codereview.chromium.org/149346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20185 0039d316-1c4b-4281-b951-d872f2087c98