summaryrefslogtreecommitdiffstats
path: root/webkit/media/buffered_data_source_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert 118546 because it caused PrerenderHTML5VideoNetwork to timeout on ↵sadrul@chromium.org2012-01-211-31/+7
| | | | | | | | | | | | | | | | | | | | | | windows and linux """ Fire canplaythrough as soon as download defers to fix autoplay Reenables delayed firing of canplaythrough for media elements, and fixes the bug that had been introduced where a video with autoplay=true sometimes never starts. With this change, a video with autoplay=true should always (though not necessarily immediately) start playback on its own. BUG=106480,73609 TEST=media_unitests, manually checking video files in various conditions Review URL: https://chromiumcodereview.appspot.com/9113023 TBR=vrk@google.com Review URL: https://chromiumcodereview.appspot.com/9269027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118590 0039d316-1c4b-4281-b951-d872f2087c98
* Fire canplaythrough as soon as download defers to fix autoplayvrk@google.com2012-01-201-7/+31
| | | | | | | | | | | | | | Reenables delayed firing of canplaythrough for media elements, and fixes the bug that had been introduced where a video with autoplay=true sometimes never starts. With this change, a video with autoplay=true should always (though not necessarily immediately) start playback on its own. BUG=106480,73609 TEST=media_unitests, manually checking video files in various conditions Review URL: https://chromiumcodereview.appspot.com/9113023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118546 0039d316-1c4b-4281-b951-d872f2087c98
* Replace DataSourceFactory with explicitly initialized DataSources.scherkus@chromium.org2012-01-191-1/+1
| | | | | | | | | BUG=107324 TEST=layout tests Review URL: https://chromiumcodereview.appspot.com/9243016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118338 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ActiveLoader::Cancel().scherkus@chromium.org2012-01-131-3/+1
| | | | | | | | | | | This will force clients to rely on the destructor to cancel loaders instead and prevents the situation where you hold onto an ActiveLoader that has been cancelled. BufferedResourceLoader did this inside of didFail(), which led to WillFulfillRead() returning true, which led to a hang since the loader had been cancelled. BUG=106751 TEST=http/tests/appacache/video.html Review URL: http://codereview.chromium.org/9112035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117712 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete references to http://crbug.com/109026fischman@chromium.org2012-01-121-4/+1
| | | | | | | | | | | TBR=scherkus BUG=none TEST=none Review URL: http://codereview.chromium.org/9186041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117526 0039d316-1c4b-4281-b951-d872f2087c98
* Take advantage of the new Pass() machinery on scoped_ptr{,_malloc}.fischman@chromium.org2012-01-101-3/+6
| | | | | | | | | | | | | | | | | | | | | Pass() was announced in https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RTd7rNxHjqk/discussion This CL replaces comments about ownership transfer (in all files whose paths contain media/) with the explicit passing of the appropriate scoper. The exceptions that are not touched by this CL: - scoped_refptr<> doesn't support Pass() and so is untouched. - media/audio code defines its own callback machinery, mimicking the old-style callbacks (pass by pointer, explicit deletes). I think that whole pile needs to be replaced with new-style (Bind) callbacks, so left it alone for now. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/9015015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117009 0039d316-1c4b-4281-b951-d872f2087c98
* Removing DataSource from Filter hierarchy and refactoring FilterHost into ↵acolwell@chromium.org2011-12-161-2/+2
| | | | | | | | | | | | | | DemuxerHost & DataSourceHost. Over the last year, several refactorings have caused DataSource to have almost nothing in common with the Filter interface. This change removes it from the Filter class hierarchy and splits up the FilterHost interface so that DataSource, Demuxer, and Filter have their own host interfaces. Splitting FilterHost improves encapsulation and makes it easier to reason about which host methods are required by different parts of the code. BUG= TEST=media_unittests Review URL: http://codereview.chromium.org/8936014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114819 0039d316-1c4b-4281-b951-d872f2087c98
* Updating TODO bug number for BufferedDataSourceTest.Range_NotSupported.scherkus@chromium.org2011-12-071-1/+1
| | | | | | | | | BUG=104783 TBR=acolwell Review URL: http://codereview.chromium.org/8849009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113461 0039d316-1c4b-4281-b951-d872f2087c98
* Update these includes to use the new header locationsabarth@chromium.org2011-12-031-1/+1
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/8787003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112824 0039d316-1c4b-4281-b951-d872f2087c98
* Split a portion of BufferedResourceLoader into a separate class ActiveLoader.scherkus@chromium.org2011-12-021-12/+15
| | | | | | | | | | | | ActiveLoader encapsulates an active WebURLLoader and takes care of maintaining deferred status, references to parent object, and automatic cancelation during teardown. As a result of fixing the imbalanced reference counts to BufferedResourceLoader there were a few use-after-free bugs due to doing work after executing callbacks. The ordering has been updated to ensure that no more work is done after executing callbacks. BUG=100914 Review URL: http://codereview.chromium.org/8667002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112747 0039d316-1c4b-4281-b951-d872f2087c98
* Fire CanPlayThrough immediately for local and streaming media filesvrk@google.com2011-12-011-5/+1
| | | | | | | | | | | | | | | | | | Changes DownloadRateMonitor logic to know to immediately fire CanPlayThrough for media files with local sources, including local webcam streams. Renamed the concept of "loaded" source to "local" source in the media pipeline for clarity. Also updated the DownloadRateMonitor logic slightly to lean toward optimism in firing CanPlayThrough, including firing the event immediately for streaming media. BUG=105163 TEST=media_unittests,test_shell_tests, wjia's media stream test page works Review URL: http://codereview.chromium.org/8661002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112560 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite BufferedDataSource tests to use real BufferedResourceLoader objects.scherkus@chromium.org2011-11-291-605/+271
| | | | | | | | | | The new tests expose the very real memory leak described in bug 100914. The fix for the leak is non trivial and will be addressed in a follow up patch. BUG=100914 Review URL: http://codereview.chromium.org/8649002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell_test breakage due to missing SetBufferedBytes expectationvrk@google.com2011-11-181-6/+6
| | | | | | | | | | | | | SetBufferedBytes may be called independent of having a valid total bytes size for the media element. Update test to reflect this. BUG=NONE TEST=test_shell_tests TBR=acolwell Review URL: http://codereview.chromium.org/8566046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110743 0039d316-1c4b-4281-b951-d872f2087c98
* Fire canplaythrough event at the proper time for audio/videovrk@google.com2011-11-181-4/+5
| | | | | | | | | | | | | In this CL, the browser fires the canplaythrough event based on an approximation of the download speed of the media instead of firing the event right away. BUG=73609 TEST=NONE Review URL: http://codereview.chromium.org/8399023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110733 0039d316-1c4b-4281-b951-d872f2087c98
* Moving media-related files from webkit/glue/ to webkit/media/.scherkus@chromium.org2011-11-171-0/+791
Files under webkit/media/ are now under their very own webkit_media namespace. Review URL: http://codereview.chromium.org/8570010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110438 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 18:20:24 +0000