summaryrefslogtreecommitdiffstats
path: root/webkit/plugins
Commit message (Collapse)AuthorAgeFilesLines
* Addressing review comments from brettw.ananta@chromium.org2011-03-041-6/+2
| | | | | | | | | BUG=41157 TEST=none Review URL: http://codereview.chromium.org/6603033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76873 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper/Flapper: Add very basic clipboard support.viettrungluu@chromium.org2011-03-043-0/+127
| | | | | | | | | | | | Note that this is a trusted private interface; we rely on Flash to do a user action check. BUG=none TEST=Trung can cut-and-paste in his Flapper Review URL: http://codereview.chromium.org/6611034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76857 0039d316-1c4b-4281-b951-d872f2087c98
* Adding resources for PDF loading progress control.gene@chromium.org2011-03-031-0/+13
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6612022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76838 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetP2PSocketDispatcher() in ppapi::PluginDelegate.sergeyu@chromium.org2011-03-033-1/+13
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6609028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76818 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the grab/grabbing cursors (for Mac/GTK).avi@chromium.org2011-03-022-2/+4
| | | | | | | | | BUG=73356 TEST=comment 12 on the bug has a test page; ensure the last two cursors (grab and grabbing) show open and closed hand cursors (respectively) and don't crash Review URL: http://codereview.chromium.org/6591105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76616 0039d316-1c4b-4281-b951-d872f2087c98
* Add PPB_URLUtil_Dev::GetDocumentURLpiman@google.com2011-03-023-22/+36
| | | | | | | | | | | This also renames "Url" into "URL" for consistency. BUG=74569 TEST=http://www.espn.go.com/nba/ Review URL: http://codereview.chromium.org/6594107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76608 0039d316-1c4b-4281-b951-d872f2087c98
* Applying factory pattern (through NativeMetafileFactory class). It is used ↵dpapad@chromium.org2011-03-021-5/+14
| | | | | | | | | | | | | | | to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76553 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=76555 Review URL: http://codereview.chromium.org/6544028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76581 0039d316-1c4b-4281-b951-d872f2087c98
* Inform the browser about mouse input in windowed plugins to ensure that we ↵ananta@chromium.org2011-03-021-1/+11
| | | | | | | | | | | | | | | | | | | | | expect actions which correspond to user gesture like downloads, external protocol launches, etc. Actions occurring in the context of user input need to be allowed. To achieve this we send over the WM_PARENTNOTIFY message to the RVH window which turns on user gesture. As per msdn this message should be received automatically which does not appear to be the case. All this means that we trust the plugin. However this does not add a new attack vector as the plugin can send messages to other windows in the desktop anyway. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41157 BUG=41157 TEST=As described in the bug. Review URL: http://codereview.chromium.org/6592092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76566 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76553 - Applying factory pattern (through NativeMetafileFactory ↵jam@chromium.org2011-03-021-14/+5
| | | | | | | | | | | | | | class). It is used to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6544028 TBR=dpapad@chromium.org Review URL: http://codereview.chromium.org/6594121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76555 0039d316-1c4b-4281-b951-d872f2087c98
* Applying factory pattern (through NativeMetafileFactory class). It is used ↵dpapad@chromium.org2011-03-021-5/+14
| | | | | | | | | | | to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6544028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76553 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper/Flapper: Get rid of unimplemented private file ref stuff and ↵viettrungluu@chromium.org2011-03-021-32/+0
| | | | | | | | | | | implement proxy. BUG=none TEST=builds? works? Review URL: http://codereview.chromium.org/6594099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76488 0039d316-1c4b-4281-b951-d872f2087c98
* Pure pedantry: Replace all ".size() == 0" with ".empty()".erg@google.com2011-03-021-1/+1
| | | | | | | | | BUG=carnitas TEST=compiles; existing unit tests. Review URL: http://codereview.chromium.org/6602049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76467 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper/Flapper: Add an interface to do sync file ops on FileRefs.viettrungluu@chromium.org2011-03-016-3/+114
| | | | | | | | | | | | | Such FileRefs are typically obtained from the Pepper file chooser. The interface corresponds exactly to the one for module-local files. (The implementation is only enabled if Flapper hacks are enabled.) BUG=none TEST=Flapper file uploads work for me Review URL: http://codereview.chromium.org/6592071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76446 0039d316-1c4b-4281-b951-d872f2087c98
* Added EnabledPlugins policy.pastarmovj@chromium.org2011-03-013-73/+270
| | | | | | | | | | | | | | | | | | | | | | | | | The EnabledPlugins policy is linked to the plugins.plugins_whitelist preference. Renamed some methods to clarify that policies can both disable and enable plugins. Updated plugins.html (about:plugins) to display policy-enabled plugins. Lots of tweaks in PluginGroup and PluginList (webkit/plugins/npapi) to preserve the user's preference across policy changes. Removing a policy on a plugin restores the state that the user had configured before. TODO: The interaction of "EnabledPlugins" and "DisabledPlugins" when overlapping isn't very well addressed yet. Currently, any plugin matching the "disabled" list will be disabled, regardless of matching or not the "enabled" list. Small fixes: Added missing "noPlugins" string to the jstemplate strings for plugins.html. BUG=55022 TEST=Create a policy enabling a specific plugin and check about:plugins. Also test_shell_test PluginGroupTest.ManagedByPolicy, and unit_tests. Review URL: http://codereview.chromium.org/6469068 Patch from Joao da Silva <joaodasilva@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76373 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow multiple opens for Pepper FileSystem.yzshen@chromium.org2011-02-282-3/+9
| | | | | | | | | BUG=73667 TEST=test_file_system.{h,cc} Review URL: http://codereview.chromium.org/6596026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76278 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use crashed plugins when instantiating new ones. Before, when a pluginbrettw@chromium.org2011-02-275-7/+22
| | | | | | | | | | | | | crashed and was still referenced by a plugin in the same renderer, it would try to re-use the crashed one, which obviously doesn't work very well. This change removes crashed plugins from the renderer's list. TEST=Manual: instantiate two tabs sharing the same renderer using a plugin, kill the plugin, then reload one of the tabs. BUG=none Review URL: http://codereview.chromium.org/6594036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76194 0039d316-1c4b-4281-b951-d872f2087c98
* The IcedTea version updates corresponding to the recent JDK 6u24 fixes.cevans@chromium.org2011-02-271-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=bauerb Review URL: http://codereview.chromium.org/6599027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76176 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper/Flapper: Refactor module-local file stuff to make it easier/nicer to ↵viettrungluu@chromium.org2011-02-266-128/+226
| | | | | | | | | | | add file ref versions. BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/6599015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76124 0039d316-1c4b-4281-b951-d872f2087c98
* OOL code in CarbonPluginWindowTracker.erg@google.com2011-02-242-4/+7
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6581038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75968 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Actually add PPB_FLASH_FILE_MODULE_LOCAL_INTERFACE to GetInterface().viettrungluu@chromium.org2011-02-241-0/+4
| | | | | | | | | BUG=none TEST=updated Flapper actually works Review URL: http://codereview.chromium.org/6580045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75949 0039d316-1c4b-4281-b951-d872f2087c98
* Pin the PPAPI custom cursor value. PPAPI is intended to be frozen, so make ↵avi@chromium.org2011-02-242-3/+11
| | | | | | | | | | | space now for expanding the number of named cursors. BUG=73356 TEST=no visible change; PPAPI custom cursors are currently not implemented anyway Review URL: http://codereview.chromium.org/6576034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75928 0039d316-1c4b-4281-b951-d872f2087c98
* PPB_Flash cleanup part 2: move all the file stuff to ppb_flash_file.*.viettrungluu@chromium.org2011-02-243-174/+226
| | | | | | | | | | | | ppb_flash_file.* is intended to contain multiple (very similar) interfaces, of which the ModuleLocal stuff is one. BUG=none TEST="everything" still works Review URL: http://codereview.chromium.org/6579026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that disabled some plugin groups at startup.bauerb@chromium.org2011-02-245-81/+67
| | | | | | | | | | | An empty plugin group is disabled by definition (because it doesn't contain any enabled plugins), and we wrongly transferred the disabled state when reloading the list. BUG=73717 TEST=PluginListTest.HardcodedGroups Review URL: http://codereview.chromium.org/6541072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75874 0039d316-1c4b-4281-b951-d872f2087c98
* Check for NULL |surface_| in WebPluginDelegateImpl before accessing its context.bauerb@chromium.org2011-02-241-1/+1
| | | | | | | | | BUG=73897 TEST=see bug for manual test Review URL: http://codereview.chromium.org/6575003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75860 0039d316-1c4b-4281-b951-d872f2087c98
* Don't access WebPluginInfo array out of bounds in PluginGroup::RemovePlugin.bauerb@chromium.org2011-02-242-2/+8
| | | | | | | | | BUG=73893 TEST=PluginGroupTest.MultipleVersions Review URL: http://codereview.chromium.org/6579004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75858 0039d316-1c4b-4281-b951-d872f2087c98
* PPB_Flash cleanup part 1: move the net connector stuff to its own files.viettrungluu@chromium.org2011-02-235-235/+271
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/6578007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75800 0039d316-1c4b-4281-b951-d872f2087c98
* Parse version string of debug Flash builds correctly.bauerb@chromium.org2011-02-232-1/+3
| | | | | | | | | BUG=58235 TEST=PluginGroupTest.VersionExtraction Review URL: http://codereview.chromium.org/6542057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75735 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the filesystem proxy. This allows the FileRef tests (the ones whichbrettw@chromium.org2011-02-212-2/+27
| | | | | | | | | | | | | | | | | | | | don't use FileIO which isn't don yet) to pass in the proxy. Hook up the code from the URLLoader that downloads to a file. This allows all URLLoader tests to pass in the proxy. Change code in dispatcher that zeros out the array to take into account padding. It was only zero-filling half of the array since sizeof(enum) * # elts seems to be half as large as the actual array due to padding on 64-bit systems. Make the aborted completion callbacks run asynchronously. This was caught by one of the file ref tests. We really need a system for doing this better, but I don't want to do that in this patch. TEST=ppapi_tests run under proxy Review URL: http://codereview.chromium.org/6543028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75566 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Windows minimum QuickTime version. Unfortunately, we can't do thiscevans@chromium.org2011-02-211-1/+1
| | | | | | | | | | | | | for Mac yet as the QuickTime versioning is inconsistent in Mac OS X 10.5.x vs. 10.6.x. 10.6.x leaves the version as 7.6.6 even with the security updates applied?? BUG=none TEST=none Review URL: http://codereview.chromium.org/6541049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75534 0039d316-1c4b-4281-b951-d872f2087c98
* Implement proxying for FileRef and FileChooser.brettw@chromium.org2011-02-172-25/+11
| | | | | | | | | | This also changes the FileRef interface to remove the Query function, since there is no close function, there's no way to cancel the current request, which makes memory management of the info structure very difficult. Review URL: http://codereview.chromium.org/6519057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75331 0039d316-1c4b-4281-b951-d872f2087c98
* Reset plugin group version to "0" instead of NULL.bauerb@chromium.org2011-02-171-1/+1
| | | | | | | | | | | This guards against dereferencing NULL when the group is empty. BUG=72946 TEST=PluginGroupTest.* Review URL: http://codereview.chromium.org/6532024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some of the more common chromium-style errors on the mac clang builder.erg@google.com2011-02-166-9/+34
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6525038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75141 0039d316-1c4b-4281-b951-d872f2087c98
* Update minimum Java version numbers to reflect the latest critical patch:cevans@chromium.org2011-02-161-2/+2
| | | | | | | | | | | | http://www.oracle.com/technetwork/java/javase/6u24releasenotes-307697.html BUG=73150 TEST=none TBR=bauerb Review URL: http://codereview.chromium.org/6529047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75107 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly update description and version when changing a PluginGroup.bauerb@chromium.org2011-02-164-58/+89
| | | | | | | | | | | PluginListTest:UpdatedPlugin tests that we don't regress on updating a disabled plugin. BUG=72946 TEST=PluginGroupTest.MultipleVersions:PluginListTest:UpdatedPlugin Review URL: http://codereview.chromium.org/6525012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75088 0039d316-1c4b-4281-b951-d872f2087c98
* Basic implementation of Pepper Transport API.sergeyu@chromium.org2011-02-162-87/+250
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6478018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75035 0039d316-1c4b-4281-b951-d872f2087c98
* Even more test cleanup. Some fixes to non-test code that's regressed.erg@google.com2011-02-151-1/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6523032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75014 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75003 - Basic implementation of Pepper Transport API.sergeyu@chromium.org2011-02-152-250/+87
| | | | | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6478018 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/6480086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75010 0039d316-1c4b-4281-b951-d872f2087c98
* Basic implementation of Pepper Transport API.sergeyu@chromium.org2011-02-152-87/+250
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6478018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75003 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Un-blacklist gecko-mediaplayer.thestig@chromium.org2011-02-151-3/+0
| | | | | | | | BUG=24507 TEST=none Review URL: http://codereview.chromium.org/6523030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74999 0039d316-1c4b-4281-b951-d872f2087c98
* Implement proxy for FlashMenu and Run/QuitMessageLooppiman@google.com2011-02-153-6/+6
| | | | | | | | | BUG=none TEST=Pepper Flash Review URL: http://codereview.chromium.org/6432001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74981 0039d316-1c4b-4281-b951-d872f2087c98
* Implement basic crash detection and shutdown handling for out of process PPAPIbrettw@chromium.org2011-02-158-53/+157
| | | | | | | | | | | | | | | | | | plugins. Currently when a crash is detected we just delete as much stuff as is convenient, clear the plugin's backing store, and continue running. It does not hook up a sad plugin page yet. This adds a "proxy" interface for the proxy to tell the PPAPI backend implementation in the renderer about proxy-related stuff (like the plugin crashing). This also implements keeping the process alive for a period of time so we can re-use the same process. Review URL: http://codereview.chromium.org/6493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74965 0039d316-1c4b-4281-b951-d872f2087c98
* New versions for Adobe Reader, Flash, Shockwave and RealPlayer.panayiotis@google.com2011-02-141-23/+22
| | | | | | | | | | | | | | http://www.adobe.com/support/security/bulletins/apsb11-03.html http://www.adobe.com/support/security/bulletins/apsb11-02.html http://www.adobe.com/support/security/bulletins/apsb11-01.html http://service.real.com/realplayer/security/01272011_player/en/ BUG=72480 TEST=Install latest versions of Realplayer, Adobe Reader, Flash (disabling the bundled), Reader and go to about:plugins. No warnings should show up. If the versions are old, warnings should show up. Review URL: http://codereview.chromium.org/6471004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74870 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that if Reader is installed after Chrome and the internal PDF ↵jam@chromium.org2011-02-141-0/+10
| | | | | | | | | | | reader is enabled, that Reader is disabled. Make PluginList not forget that a hardcoded group is disabled by the user after it loads the plugins. Also ensure a lock is grabbed before calling AddToPluginGroups, since it uses groups_to_disable_. BUG=72617 Review URL: http://codereview.chromium.org/6507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74834 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Fix several -Woverloaded-virtual warnings.thakis@chromium.org2011-02-112-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Real bugs: net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here new CaptureGroupNameTCPSocketPool(NULL, NULL); ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here new CaptureGroupNameSOCKSSocketPool(NULL, NULL); ^ In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o 4 errors generated. net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here new CapturePreconnectsTCPSocketPool( ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here new CapturePreconnectsSOCKSSocketPool( ^ In file included from net/http/http_stream_factory_unittest.cc:17: In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o 4 errors generated. make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1 media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual] MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:12: In file included from ./testing/gmock/include/gmock/gmock.h:61: testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from: ^ media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:9: ./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here virtual AudioInputStream* MakeAudioInputStream(AudioParameters params); ^ CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o 1 error generated. No bug, just confusing: In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1 CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7: In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. BUG=72205 TEST=none Review URL: http://codereview.chromium.org/6503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
* Fix re-entrant destroy issues in pepperpiman@google.com2011-02-111-0/+34
| | | | | | | | | | | | | | When the pepper plugin is called into, it has the ability to remove itself from the DOM, using the Var interface. To prevent the instance from going away while it's still in the stack, we need to keep a reference to it, any time we call into the plugin but need to access the interface afterwards. BUG=chromium-os:11694 TEST=With pepper flash (needs separate fix), go to www.nick.com, let it play the video and check it doesn't crash Review URL: http://codereview.chromium.org/6488017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74635 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the accidentially changed auto-generated files.jochen@chromium.org2011-02-101-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6490005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74460 0039d316-1c4b-4281-b951-d872f2087c98
* Only invoke WebKit methods in browsing data helpers on the WEBKIT thread.jochen@chromium.org2011-02-101-1/+1
| | | | | | | | | BUG=71786 TEST=browser & unit tests Review URL: http://codereview.chromium.org/6246105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74433 0039d316-1c4b-4281-b951-d872f2087c98
* Restore old title in WebViewPlugin only when loading the plugin.bauerb@chromium.org2011-02-102-2/+8
| | | | | | | | | BUG=72437 TEST=see bug for manual test Review URL: http://codereview.chromium.org/6476006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74428 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crashing on errors in PPB_Context_3D_Impls.neb@chromium.org2011-02-091-12/+10
| | | | | | | | | BUG=none TEST=Calling PPB_Context_3D_Trusted functions before calling InitRaw() shouldn't crash the renderer. Review URL: http://codereview.chromium.org/6368148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74249 0039d316-1c4b-4281-b951-d872f2087c98
* Update the checked-in GLES2 bindings and implementation to match the ↵bryner@chromium.org2011-02-081-1/+1
| | | | | | | | | | | | | auto-generated files. This allows you to build all targets without ending up with spurious comment changes in your client. BUG=none TEST=none Review URL: http://codereview.chromium.org/6441001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74177 0039d316-1c4b-4281-b951-d872f2087c98