| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
and refer to the bindings in svn.webkit.org
BUG=11558
Review URL: http://codereview.chromium.org/113301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now have RetrieveFrameForCurrentContext() and
RetrieveFrameForEnteredContext().
These terms means the same thing they do in V8::Context --
'current' is the top of the js stack and 'entered' is the
bottom.
I needed 'entered' to fix a bug in extensions where if you
call an extension API through the web inspector we get
confused and think the web inspector's view is the one who
called.
Review URL: http://codereview.chromium.org/113085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=0
TEST=layout tests
Review URL: http://codereview.chromium.org/113117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Android:
0005fad6 _NPN_UnregisterObject
external/webkit/V8Binding/v8/npruntime.cpp:401
0005fb6a _NPN_DeallocateObject
external/webkit/V8Binding/v8/npruntime.cpp:296
0005fba2 NPN_ReleaseObject
external/webkit/V8Binding/v8/npruntime.cpp:312
0005e1e6 ForgetV8ObjectForNPObject(NPObject*)
external/webkit/V8Binding/v8/V8NPObject.cpp:367
0005fb1e _NPN_UnregisterObject
external/webkit/V8Binding/v8/npruntime.cpp:428
Review URL: http://codereview.chromium.org/113107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only interesting change is in v8_custom.cpp to account for recently upstreamed
V8 bindings.
R=dglazkov,japhet
Review URL: http://codereview.chromium.org/115090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
42932:42994.
Do not allow cross-frame access to a frame whose document is
unavailable.
See http://trac.webkit.org/changeset/42983 for details. The rest of the changes from that change set will follow as a separate changelist.
BUG=11178
Review URL: http://codereview.chromium.org/113093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The v8_proxy.h change was authored by asargent and already reviewed here:
http://codereview.chromium.org/79059
R=dglazkov
Review URL: http://codereview.chromium.org/113056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://bugs.chromium.org/11467
TEST=Verify that Document.location works from javascript.
Review URL: http://codereview.chromium.org/108024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/109042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
happening, so it seems unlikely that this is a reference counting
problem.
BUG=9746
Review URL: http://codereview.chromium.org/100247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
issue by adding the style declaration wrappers to the object groups of
the elements they belong to.
Review URL: http://codereview.chromium.org/100204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=11264
Integer 0 and -1 have special meaning in HashMap<int, ...>, both cannot be used as key.
Specially filter out these two keys.
Review URL: http://codereview.chromium.org/100242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3285.
A NPObject can be called as a construct if it implements NPN_Construct, and NOT implements
NPN_InvokeDefault. Otherwise, NPN_InvokeDefault is called even when the object is called
as a constructor.
Review URL: http://codereview.chromium.org/56167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebKit gurus, please review the change carefully, WTF::HashMap interface is not well documented, so I have implement
customized hash functions and HashTraits in order to use StringKey as the hash key.
Review URL: http://codereview.chromium.org/100069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On translate.google.com, it fails to show balloon, because of JavaScript
exception in following code:
p=a.getClientRects(); ... p[0].top // p[0] is undefined!
Current v8 binding misses indexed access method in ClientRectList.
CSSOM View Module draft says
http://dev.w3.org/csswg/cssom-view/#clientrectlist
In ECMAScript implimentations, objects that implement the ClientRectList
interface must also have a [[GET]] method that, when invoked with a number,
acts like the item() method would when invoked with that argument.
BUG=10697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
activeDocumentLoader's url, not the document's current URL.
BUG=10924
Review URL: http://codereview.chromium.org/92090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
external V8 strings.
We seem to be occasionally losing the data for our external strings.
The current hypothesis is that there is a reference counting bug in
WebCore somewhere which is leading to premature deletion of the string
data. This change is an attempt to verify that this is in fact the
case. By artificially increasing the ref count on the strings, we
should reduce the likelihood of accidental deletion because of ref
counting being slightly off. If we can confirm that this removes most
of the crashes, we know that the problem is WebCore ref counting
related.
BUG=9746
Review URL: http://codereview.chromium.org/99174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gross offenders:
* Unforking LazyEventListeners: http://trac.webkit.org/changeset/42843
* Removing ListMarkerBox: http://trac.webkit.org/changeset/42846
* SVG changes: http://trac.webkit.org/changeset/42840
* Window object is now an event target: http://trac.webkit.org/changeset/42882
R=jeremy
BUG=0
TEST=trybots
Review URL: http://codereview.chromium.org/99147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rebaselines:
http://trac.webkit.org/changeset/42722 resulted in
LayoutTests/editing/inserting/insert-3907422-fix.html
LayoutTests/editing/pasteboard/paste-text-015.html
LayoutTests/editing/style/font-family-with-space.html
http://trac.webkit.org/changeset/42723 resulted in
LayoutTests/editing/selection/select-all-iframe.html
LayoutTests/svg/custom/pointer-events-path.svg
http://trac.webkit.org/changeset/42716 resulted in
LayoutTests/fast/dom/HTMLSelectElement/named-options.html
http://trac.webkit.org/changeset/42725
Broke the close event behavior and resulted in disabling these ui tests:
* BrowserCloseBeforeUnloadOK and
* BrowserCloseBeforeUnloadCancel
Review URL: http://codereview.chromium.org/92051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
V8Utilities in project.
Review URL: http://codereview.chromium.org/92044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates DOMWrapperToNodeHelper to preform the actual work (in the .cpp) and DOMWrapperToNode just does the cast.
This function has a lot of callers from the generated bindings, and I am skeptical an extra call instruction will hurt.
25740168 /tmp/chrome.after
25902672 /tmp/chrome.before
Review URL: http://codereview.chromium.org/88029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This increases our score on the DOM Perf benchmarks by about 10%
Review URL: http://codereview.chromium.org/79055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/88007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gross offenders:
* http://trac.webkit.org/changeset/42633, event listener creation
helpers moved to JSC-specific files.
* http://trac.webkit.org/changeset/42647, our refactoring of XHR code.
* http://trac.webkit.org/changeset/42671, unforking of DOMWindow.event
R=levin
Review URL: http://codereview.chromium.org/84002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10693
Review URL: http://codereview.chromium.org/67298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/67052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to ScriptController, glue due to http://trac.webkit.org/changeset/42583
Test rebaselines due to:
* http://trac.webkit.org/changeset/42599
* http://trac.webkit.org/changeset/42583
* http://trac.webkit.org/changeset/42600
* http://trac.webkit.org/changeset/42586
R=levin
Review URL: http://codereview.chromium.org/79038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/42579
ScriptController::createInlineEventListener was changed to take
4 params instead of 3, so I updated the V8 ScriptController
to do the same. We don't seem to need the extra arg because both
v8_proxy::createSVGEventHandler and
v8_proxy::createInlineEventListener are identical.
Also one new .cpp/.h file from
http://trac.webkit.org/changeset/42580
Review URL: http://codereview.chromium.org/79008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
elements if there are multiple options that share a name.
Currently Safari and chromium differ in their behavior in this area. Safari
returns
multiple options in a collection if necessary, but only for
HTMLOptionsCollection. For
HTMLSelectElement it always returns null.
Chromium returns a single option no matter what, but for both HTMLSelectElement
and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit
cache.
The HTML5 doc states that a collection should be returned if necessary for both.
The relevant parts of the spec are:
http://dev.w3.org/html5/spec/Overview.html#the-select-element
and
http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0
So if you have:
<select id="sl1"><option value="Value" name="test" /></select>
and in JS code you do:
var test = document.getElementById("sl1").test
test should be a single HTMLOptionElement.
If instead you have:
<select id="sl2"><option value="Value1" name="test" /><option value="Value2"
name="test" /></select>
test should be a collection with 2 HTMLOptionElements.
This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against
webkit, with a new layout test to confirm the behavior
Review URL: http://codereview.chromium.org/69014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
elements if there are multiple options that share a name.
Currently Safari and chromium differ in their behavior in this area. Safari returns
multiple options in a collection if necessary, but only for HTMLOptionsCollection. For
HTMLSelectElement it always returns null.
Chromium returns a single option no matter what, but for both HTMLSelectElement
and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit cache.
The HTML5 doc states that a collection should be returned if necessary for both.
The relevant parts of the spec are:
http://dev.w3.org/html5/spec/Overview.html#the-select-element
and
http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0
So if you have:
<select id="sl1"><option value="Value" name="test" /></select>
and in JS code you do:
var test = document.getElementById("sl1").test
test should be a single HTMLOptionElement.
If instead you have:
<select id="sl2"><option value="Value1" name="test" /><option value="Value2"
name="test" /></select>
test should be a collection with 2 HTMLOptionElements.
This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against
webkit, with a new layout test to confirm the behavior
Review URL: http://codereview.chromium.org/67148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This undoes changes from:
http://codereview.chromium.org/66045
Review URL: http://codereview.chromium.org/67114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is sometimes the functions to remove event listeners get called
outside of a ContextScope (even though we still have a valid context).
BUG=9775
Review URL: http://codereview.chromium.org/66045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Includes change to v8_proxy.cpp to account for addition of
MessagePortProxy class.
Review URL: http://codereview.chromium.org/66062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mbelshe
Review URL: http://codereview.chromium.org/67040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removing V8EventListenerList from v8_proxy and change the project files to compile V8EventListenerList.
Review URL: http://codereview.chromium.org/60102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can take advantage of lazy wrapper
initialization.
Dependent on the webkit fix.
will roll the deps for webkit as well.
Review URL: http://codereview.chromium.org/57086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
alive across GCs.
This change needs a WebKit change to go in first which adds frame and
type accessors to these objects.
Review URL: http://codereview.chromium.org/49038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread, not owning thread.
This patch contains the fix to the Purify failure: memory leaks of thread specific data for main thread. The fix is to switch to using the static maps for main thread.
Compared with previous patch being reviewed, the main change in this patch is in V8DOMMap.cpp: I introduce NonMainThreadSpecificDOMData and MainThreadSpecificDOMData that are both derived from ThreadSpecificDOMData.
Review URL: http://codereview.chromium.org/49044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the DOM, we need to explicitly keep the history wrapper object alive
for the lifetime of the DOMWindow object with which it is associated.
Review URL: http://codereview.chromium.org/53092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tree and the purify tests.
Review URL: http://codereview.chromium.org/42634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the security token in V8 was set to the string
"null" for all data urls. Therefore, the access check succeeded. The
cause of the regression was that securityOrigin's toString
implementation was changed in WebKit to return "null" instead of
String().
R=kasperl@chromium.org
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/53049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Before submitting, I'll add DEPS with corresponding WebKit rev (see http://codereview.chromium.org/52007)
Review URL: http://codereview.chromium.org/45035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12377 0039d316-1c4b-4281-b951-d872f2087c98
|