summaryrefslogtreecommitdiffstats
path: root/webkit/port/platform/chromium
Commit message (Collapse)AuthorAgeFilesLines
* Use platform/chromium from third_party/WebKit, etc.darin@chromium.org2008-12-2360-10852/+0
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/16217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7405 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of another base/ include by inlining the NSView/HWND/GtkWidget typdefs.eseidel@chromium.org2008-12-201-3/+4
| | | | | | Review URL: http://codereview.chromium.org/13770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7348 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash when clicking empty select element.darin@chromium.org2008-12-201-5/+6
| | | | | | | | | | | | | | | | | | | | | | I believe this is not needed: if (windowHeight == 0) windowHeight = min(getRowHeight(-1), kMaxHeight); windowHeight is dependent on the number of items within the popup, if you have no items within the popup, it returns 0. I don't understand why we need to do "min(getRowHeight(-1), kMaxHeight)" when its 0, that doesn't make sense to me. Since getRowHeight gets the height of that item@index, everyone knows there are no item for index -1 (hence crash). Patch by Mohamed Mansour R=darin BUG=4334 (http://crbug.com/4334) TEST=<select></select> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7347 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependencies from port on base/gfx/native_theme and base/win_util. ↵darin@chromium.org2008-12-204-69/+141
| | | | | | | | | | Introduce plaform/chromium/ChromiumUtilsWin and extend ChromiumBridge to access wrappers for uxtheme calls. R=dglazkov Review URL: http://codereview.chromium.org/15101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7346 0039d316-1c4b-4281-b951-d872f2087c98
* Kill our forked copy of MIMETypeRegistry.cpp by moving the customized methodsdarin@chromium.org2008-12-181-16/+90
| | | | | | | | | | | | into MimeTypeRegistryChromium.cpp, and stop building MIMETypeRegistry.cpp. It turns out that there just isn't enough of that file that we have in common to make it worth sharing. R=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7246 0039d316-1c4b-4281-b951-d872f2087c98
* Move the "platform" wrappers in skia/ext to the skia namespace.brettw@google.com2008-12-171-3/+3
| | | | | | Review URL: http://codereview.chromium.org/14110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7182 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a hack that was unnecessarily affecting Linux layout tests.evanm@google.com2008-12-161-1/+7
| | | | | | | Review URL: http://codereview.chromium.org/14488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7102 0039d316-1c4b-4281-b951-d872f2087c98
* I bow down before Dean and his "I don't need sleep, I'll just read every ↵agl@chromium.org2008-12-161-1/+1
| | | | | | | | | | | line of code" ways. TBR=evan Review URL: http://codereview.chromium.org/14166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7088 0039d316-1c4b-4281-b951-d872f2087c98
* It appears that the GTK theme doesn't always draw the full rectangleagl@chromium.org2008-12-161-0/+11
| | | | | | | | | | | | | when we ask it to draw a scrollbar button. It's not clear if it expects the background to already be filled in, or if we are brearking it by giving it WebKit metrics. Either way, it's messing up our pixeltest baselines with undefined pixels so we paint seafoam-green under scrollbar buttons before GTK draws. Review URL: http://codereview.chromium.org/14477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7081 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to the autofill popup:jcampan@chromium.org2008-12-162-0/+8
| | | | | | | | | | | - we now reuse the existing popup if there is one (instead of creating a new on with each key stoke), this prevents the flickering we used to see. - we don't hide the popup on every key stroke, instead we rely on the client editor telling us the field is not being edited anymore. TEST=Enter some text in a form's text field several times, the autofill should show and not flicker. BUG=5258 Review URL: http://codereview.chromium.org/14100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7017 0039d316-1c4b-4281-b951-d872f2087c98
* Fun file renaming patch.darin@google.com2008-12-153-73/+41
| | | | | | | | | | | | SoundPosix.cpp -> SoundChromiumPosix.cpp IconMac.cpp -> IconChromiumMac.cpp IconLinux.cpp -> IconChromiumLinux.cpp R=evan Review URL: http://codereview.chromium.org/14433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7007 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FileSystemPosix.cpp since it is actually unnecessary. This makes thedarin@chromium.org2008-12-154-31/+42
| | | | | | | | | | Linux port more like the Windows and Mac ports. R=evanm Review URL: http://codereview.chromium.org/14431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6997 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate port/platform/win directory. Stop building a fork of BString, anddarin@chromium.org2008-12-151-0/+35
| | | | | | | | | | | | | | stop depending on COMPtr.h. I avoided BString by definining a bastard shim in AccessibleBase.cpp. I did that because the one from WebCore's platform/win would require #if !USE(JSC) to avoid UString issues. Eventually, AccessibleBase.cpp is going to be rewritten to not use COM, so this issue will go away. R=dglazkov Review URL: http://codereview.chromium.org/13808 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6986 0039d316-1c4b-4281-b951-d872f2087c98
* Implement visited link coloring.brettw@google.com2008-12-132-4/+54
| | | | | | Review URL: http://codereview.chromium.org/12928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6970 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderThemeGtk match RenderThemeWin a bit more.deanm@chromium.org2008-12-122-6/+8
| | | | | | Review URL: http://codereview.chromium.org/14048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6888 0039d316-1c4b-4281-b951-d872f2087c98
* Drop search field methods in RenderThemeGtk.deanm@chromium.org2008-12-122-37/+0
| | | | | | | | These were originally in RenderThemeWin, but were dropped when removing layout test mode hacks. We don't really care about search fields, they are a macism, and we should match the Windows metrics better this way. Review URL: http://codereview.chromium.org/14047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6887 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewHandle to NativeView et al.agl@chromium.org2008-12-111-1/+1
| | | | | | | | | | | ViewHandle is a very unfortunate name when we actually start dealing with views, so we are renaming the cross-platform typedefs to make it clear that they refer to platform specific native UI elements. Review URL: http://codereview.chromium.org/13754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6826 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit merge 39050:39100 (CL 5 of 5).ericroman@google.com2008-12-111-0/+4
| | | | | | Review URL: http://codereview.chromium.org/13740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6810 0039d316-1c4b-4281-b951-d872f2087c98
* Clip the scrollbars on linux.estade@chromium.org2008-12-112-9/+20
| | | | | | | | And rebaseline the image on a layout test that now passes. Review URL: http://codereview.chromium.org/13728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6770 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we've synced to my WebKit changes I can remove the usefinnur@google.com2008-12-101-13/+6
| | | | | | | | | | of highlevel WebCore types in the scrollbar code. I also found some code that had been ifdef-ed that I missed deleting during my last pass. Review URL: http://codereview.chromium.org/13713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6723 0039d316-1c4b-4281-b951-d872f2087c98
* Be stricter when clipping gtk widgets.estade@chromium.org2008-12-101-0/+3
| | | | | | | | This fixes a layout test on linux but we still hve to rebaseline the image. Review URL: http://codereview.chromium.org/13801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6685 0039d316-1c4b-4281-b951-d872f2087c98
* Only copy image data to the clipboard when users selecttc@google.com2008-12-081-1/+22
| | | | | | | | | | "Copy Image" from the context menu. BUG=1176 Review URL: http://codereview.chromium.org/13253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6531 0039d316-1c4b-4281-b951-d872f2087c98
* Update themes since we merged webkit r38911.deanm@chromium.org2008-12-072-17/+20
| | | | | | | | | | | | - A blink value of 0 should no longer paint storm. Return a non-blinking caret in linux layout test mode again. - Update a mismerge from Chromium r6487. The virtual method was renamed to creatBlinkInterval, so now we are created an additional virtual method instead of overriding the theme's. Review URL: http://codereview.chromium.org/13611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6494 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux broken layout tests. They want the windows UA sheet.mpcomplete@google.com2008-12-052-0/+15
| | | | | | Review URL: http://codereview.chromium.org/13193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6466 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing tab with no selection while the form autofill was showing would crash.jcampan@chromium.org2008-12-011-3/+5
| | | | | | | | BUG=4847 TEST=Open a form, type something so the autofill shows, press tab with no selection. Review URL: http://codereview.chromium.org/13019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6153 0039d316-1c4b-4281-b951-d872f2087c98
* Match Windows select metrics.deanm@chromium.org2008-11-282-31/+78
| | | | | | | | | We now pass basic-selects.html. Also fix a enum type mismatch (both NoPart and NoControlPart are 0, it was only the type that was wrong). Review URL: http://codereview.chromium.org/10982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6115 0039d316-1c4b-4281-b951-d872f2087c98
* Match Windows checkbox and radio metrics. We now pass basic-inputs.html.deanm@chromium.org2008-11-272-48/+20
| | | | | | Review URL: http://codereview.chromium.org/10788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6095 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependencies on base/ from MIMETypeRegistry.cppdarin@chromium.org2008-11-261-1/+4
| | | | | | | | | | | Patch by phajdan.jr@gmail.com R=darin Review URL: http://codereview.chromium.org/12004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6049 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependencies on base/glue from these 2 port files.jam@chromium.org2008-11-261-0/+3
| | | | | | Review URL: http://codereview.chromium.org/12460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6046 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6043.ojan@google.com2008-11-261-3/+0
| | | | | | Review URL: http://codereview.chromium.org/12689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6044 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependencies on base/ from MIMETypeRegistry.cppdarin@chromium.org2008-11-261-0/+3
| | | | | | | | | | | Patch by phajdan.jr@gmail.com R=darin Review URL: http://codereview.chromium.org/12004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6043 0039d316-1c4b-4281-b951-d872f2087c98
* The autofill menu does not accept the selection on abandon, such as when ↵jcampan@chromium.org2008-11-262-8/+39
| | | | | | | | | | | | pressing ESC. I had to introduce another acceptOnAbandon member, though the name I came up with is pretty lame. BUG=4803 TEST=Type some text in a from input text, in the autofill popup menu, use the arrow keys to select something then press ESC. The text input content should not change. Also, make sure the select input still does keep the selection when ESC is pressed. Review URL: http://codereview.chromium.org/12667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a rash of uninit data errors reported by Valgrind.agl@chromium.org2008-11-251-0/+2
| | | | | | | | | | We fail to set several values when painting scrollbars, causing errors throughout GTK, GDK and GTK theme painting libraries. Review URL: http://codereview.chromium.org/12437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5987 0039d316-1c4b-4281-b951-d872f2087c98
* Use the default handling for input styles.deanm@chromium.org2008-11-252-10/+0
| | | | | | | | Right now we're trying to match the GTK theme, using code with a bunch of FIXMEs because it's not correct. Let's use the default code path which will style us the same as Windows. Review URL: http://codereview.chromium.org/12435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5980 0039d316-1c4b-4281-b951-d872f2087c98
* More GTK theme work.deanm@chromium.org2008-11-251-52/+36
| | | | | | | | Throw away mmoss's hard work. We should be matching Chromium Windows for now, not Firefox Linux. Disable the DPI querying code until I can figure out why it is never right. This makes our input boxes look good (matches Windows). Review URL: http://codereview.chromium.org/12426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my caret blinking change for now.deanm@chromium.org2008-11-251-2/+5
| | | | | | Review URL: http://codereview.chromium.org/12419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5961 0039d316-1c4b-4281-b951-d872f2087c98
* Don't paint storm in layout test mode.deanm@chromium.org2008-11-251-5/+2
| | | | | | | | Blinking caret frequency sets a repeating timer, before it was 0 which causes the timer to fire constantly. Review URL: http://codereview.chromium.org/12416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5956 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the PlatformContext's current transform when returning the cairo ↵estade@chromium.org2008-11-251-20/+18
| | | | | | surface in GdkSkia. Fixes linux test shell widget rendering. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5952 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in RenderThemeGtk.erg@google.com2008-11-251-2/+5
| | | | | | | Review URL: http://codereview.chromium.org/12617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5947 0039d316-1c4b-4281-b951-d872f2087c98
* Find now uses WebKit's TextMatch highlighting for Find-in-page.finnur@google.com2008-11-242-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to discard a bunch of code and plumbing related to maintaining and passing around the tickmark vector. WebKit now owns the drawing of the highlights for inactive matches and we use the selection controller to draw the active highlight. I also simplified the code by eliminating the separate FindNext function, which has been merged into Find. This change also requires minor changes to WebKit upstream (sold seperately, void where prohibited). It simply consists of adding one empty virtual paint function to ScrollbarThemeComposite.h (paintTickmarks) and in ScrollbarThemeComposite::paint call paintTickmarks(). This fixes/makes obsolete a slew of bugs: BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599 ... and a couple of external ones as well. Full list: 1326399 Find highlighting disappears on ThinkPad x60s 1241554 Find doesn't highlight word inside blinky tag 1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode 1070190 Find should begin searching from caret/selection 1023019 Find not highlighting correctly 984786 Find highlight drawing code causes ClearType text to look bad 893737 Find in page should search textareas 868599 Find in page tick marks incorrectly appear on nested scrollbars 298 Find-In-page should highlight elided entries 4389 Find-in-box is not highlighting all the instances of the search word 3908 Find in page highlighting and tickmarks are broken Review URL: http://codereview.chromium.org/11364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
* A bit of RenderThemeGtk::systemFont refactoring and merge with recent changes.mmoss@google.com2008-11-241-39/+53
| | | | | | | Review URL: http://codereview.chromium.org/11400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5932 0039d316-1c4b-4281-b951-d872f2087c98
* Bridge calls to get the root NPObject from a WebPluginContainer.darin@chromium.org2008-11-241-2/+4
| | | | | | | | | | | | | | | | I also did a little cleanup in getPlugins. I found that there was a WebPluginInfo struct declared within the WebCore namespace that was causing us to need '::' in front of WebPluginInfo. I killed the erroneous declaration so that the rest could be cleaned up. I also renamed getPlugins to plugins since I think that is more consistent with how Apple names these kinds of methods. There was some old, unused USE(JSC) code in ScriptController.cpp that I deleted. R=erikkay Review URL: http://codereview.chromium.org/12601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5928 0039d316-1c4b-4281-b951-d872f2087c98
* Progress on form button metrics.deanm@chromium.org2008-11-242-224/+235
| | | | | | | | | | | | | | | | | | | | | | We are very very close to matching Windows metrics for buttons. - Sort RenderThemeGtk.h declarations in the same order as RenderThemeWin.h - Sort RenderThemeGtk.cpp implementations in the same order as declared in the header. - Put all internal static helpers together. - Merge in some comments and code from RenderThemeWin. - Drop incorrect button style methods, when really we want the default behavior instead. - Use 11px Times New Roman for the layout test mode system font. - Switch to Mist as the default layout test theme. This matches Windows much better, with square buttons, etc. - Sort the font list in test_shell_gtk. Review URL: http://codereview.chromium.org/11390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5920 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderThemeWin and RenderThemeGtk a bit closer to each other. This is ↵deanm@chromium.org2008-11-222-11/+3
| | | | | | | | | | | | just a baby step in getting RenderThemeGtk to be more like RenderThemeWin. - Remove some cosmetic differences from prototypes. - Remove the unused systemFont(X, X) from GTK. - Make supportsFocus have internal linkage, there is no RenderTheme::supportsFocus. This matches GTK. Review URL: http://codereview.chromium.org/11591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5903 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r5890 (accidental commit).estade@chromium.org2008-11-221-18/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5893 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly render scroll bars on web frames by setting a matrix translation ↵estade@chromium.org2008-11-221-20/+18
| | | | | | | | on the cairo surface in the canvas's GdkSkiaObjet that matches the canvas's matrix translation. Change rendering of some other widgets (buttons, entry fields, etc) that were being translated manually. Review URL: http://codereview.chromium.org/11562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-221-3/+2
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback "Remove use of wide characters in stats table identifiers."evanm@google.com2008-11-211-2/+3
| | | | | | | This reverts commit r5847. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-211-3/+2
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap MSVC-specific pragmas. As -Wunknown-pragmas has been disabled for wtf,deanm@chromium.org2008-11-214-8/+26
| | | | | | | | | | some of these sneaked in. BUG=2053 Review URL: http://codereview.chromium.org/11801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5830 0039d316-1c4b-4281-b951-d872f2087c98