| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=3319
TEST=none
Review URL: http://codereview.chromium.org/113903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=amanda
Review URL: http://codereview.chromium.org/18369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/18365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
port. These are port classes, so they have to be hand merged.
BUG=5827
TEST=none
Review URL: http://codereview.chromium.org/17437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/16472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace it with an implementation of GetScreenInfoHelper like
the other platforms. This webkit glue function is implemented
in webkit_glue_mac.mm.
Now that we have a GetScreenInfoHelper implemented for each
platform, I moved the implementation of GetScreenInfo into
test_shell.cc.
R=dglazkov
Review URL: http://codereview.chromium.org/16470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/16217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The KeyboardCodes.h removal is to delete an unused file. The Mac build was already using the KeyboardCodes.h file from platform/chromium.
R=dglazkov
Review URL: http://codereview.chromium.org/16215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Kill a gtest include in UniscribeHelper.h.
2. Kill a webkit_glue:: type used in MediaPlayerPrivateChromium.h
3. Remove the dummy MediaPlayerPrivateChromium.cpp, which has been superceded by webkit/glue/media_player_private_impl.cc
4. Cleanup some webkit style errors.
R=dglazkov
Review URL: http://codereview.chromium.org/16404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13770
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe this is not needed:
if (windowHeight == 0)
windowHeight = min(getRowHeight(-1), kMaxHeight);
windowHeight is dependent on the number of items within the popup, if you have
no items within the popup, it returns 0. I don't understand why we need to do
"min(getRowHeight(-1), kMaxHeight)" when its 0, that doesn't make sense to me.
Since getRowHeight gets the height of that item@index, everyone knows there are
no item for index -1 (hence crash).
Patch by Mohamed Mansour
R=darin
BUG=4334 (http://crbug.com/4334)
TEST=<select></select>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Introduce plaform/chromium/ChromiumUtilsWin and extend ChromiumBridge to access wrappers for uxtheme calls.
R=dglazkov
Review URL: http://codereview.chromium.org/15101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
match WebKit style.
R=brettw
Review URL: http://codereview.chromium.org/15058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of the .tiff version. Point testShell at the resources folder rather than the source tree for loading resources on Mac. Move ImageMac.cpp into the chromium port and give it a new name.
Review URL: http://codereview.chromium.org/14893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tools/webcore_unit_tests directory. I chose this directory because we have a
bunch of similar "tests" directories inside webkit/tools.
R=dglazkov
Review URL: http://codereview.chromium.org/14861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove MediaPlayerPrivateChromium.cpp and move it to webkit/glue/media_player_private_impl.cc
- Added the following classes:
WebMediaPlayer
WebMediaPlayerImpl
WebMediaPlayerDelegate
WebMediaPlayerDelegateImpl
TestWebMediaPlayerDelegate
VideoStackMediaPlayer (Just a forward declaration)
- One include fix for webkit/glue/webframe.h
- Overview of what each class is doing:
WebMediaPlayer and WebMediaPlayerImpl
Wrapper over the MediaPlayerPrivate, it provides methods like Repaint(), NotifyNetworkStateChange(), etc to VideoStackMediaPlayer. It also creates the ResourceHandle for VideoStackMediaPlayer for resource loading, or maybe VideoStackMediaPlayer can simply use webkit_glue::ResourceDispatcher?
WebMediaPlayerDelegate, WebMediaPlayerDelegateImpl
Delegate calls from webkit to the internal media player.
MediaPlayerPrivate
Forward calls to WebMidiaPlayerDelegate, creates WebMediaPlayerDelegate and WebMediaPlayer in the constructor. Expose some public methods to WebMediaPlayer so we can actually do repaint and notification of changes.
Review URL: http://codereview.chromium.org/13762
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was in the port group that belonged in the webcore group.
R=awalker
Review URL: http://codereview.chromium.org/15049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
text shadow patch, and is why the layout tests are failing.
Review URL: http://codereview.chromium.org/15045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into MimeTypeRegistryChromium.cpp, and stop building MIMETypeRegistry.cpp. It
turns out that there just isn't enough of that file that we have in common to
make it worth sharing.
R=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
KURL.h
This makes us defile USE(GOOGLEURL) and use that instead of USE_GOOGLE_URL_LIBRARY.
I also fixed some places to be able to compile without it if possible (I think
I will be wanting that capability in the future to test changes they may make
upstream).
Review URL: http://codereview.chromium.org/14494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
drawing the text using Skia after getting the outlines from Windows. A cache of these outlines is maintained because the outlines are very slow to retrieve. This new functionality is in SkiaFontWin.*, and is called when the context detects text attributes that are not supported by Windows.
Review URL: http://codereview.chromium.org/8615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This now performs a similar origin translation as ImageCG.cpp, which seems to work, though it also seems to imply a relationship between the src and dest rects which I haven't found explicitly documented or enforced anywhere.
Review URL: http://codereview.chromium.org/13375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pixel data. When creating the subsequent frame, we'd try and copy this frame's data, assuming it was sized properly, when in fact we'd allocated no space; then writing pixel data into this buffer overwrote whatever was sitting in memory.
Basically, we need to ensure that every frame gets properly initialized (sized, allocated, and data copied or cleared as appropriate) before we move to the next frame. Since we can't rely on haveDecodedRow() getting called for all frames, we now also initialize as needed in frameComplete().
BUG=5573
Review URL: http://codereview.chromium.org/14168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
necessary for the KURL.h refactor since it's becoming more and more difficult
to do my hack where the old types are defined to a different name.
This also adds deep copy to GKURL.
Review URL: http://codereview.chromium.org/14161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
line of code" ways.
TBR=evan
Review URL: http://codereview.chromium.org/14166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when we ask it to draw a scrollbar button. It's not clear if it expects
the background to already be filled in, or if we are brearking it by
giving it WebKit metrics. Either way, it's messing up our pixeltest
baselines with undefined pixels so we paint seafoam-green under
scrollbar buttons before GTK draws.
Review URL: http://codereview.chromium.org/14477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- we now reuse the existing popup if there is one (instead of creating a new on with each key stoke), this prevents the flickering we used to see.
- we don't hide the popup on every key stroke, instead we rely on the client editor telling us the field is not being edited anymore.
TEST=Enter some text in a form's text field several times, the autofill should show and not flicker.
BUG=5258
Review URL: http://codereview.chromium.org/14100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match where the files will live once we upstream them.
(There are no mac project changes because our mac port does not
use any of these files.)
R=evan
Review URL: http://codereview.chromium.org/14127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SoundPosix.cpp -> SoundChromiumPosix.cpp
IconMac.cpp -> IconChromiumMac.cpp
IconLinux.cpp -> IconChromiumLinux.cpp
R=evan
Review URL: http://codereview.chromium.org/14433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to apply the context transform to the shadow before
rendering it. There's also a weird case where we have to
flip the y offset if we're not applying the transform. I'm
not sure why this is necessary, but it allows us to pass
canvas-shadow tests.
BUG=5503
Review URL: http://codereview.chromium.org/14125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=pinkerton
Review URL: http://codereview.chromium.org/14123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Linux port more like the Windows and Mac ports.
R=evanm
Review URL: http://codereview.chromium.org/14431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes: LayoutTests/fast/canvas/fillrect_gradient.html
Note: That test is fixed now, but it still won't pass because the baseline is actually wrong; a new baseline is on the way.
Review URL: http://codereview.chromium.org/14404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stop depending on COMPtr.h. I avoided BString by definining a bastard shim in
AccessibleBase.cpp. I did that because the one from WebCore's platform/win
would require #if !USE(JSC) to avoid UString issues. Eventually,
AccessibleBase.cpp is going to be rewritten to not use COM, so this issue will
go away.
R=dglazkov
Review URL: http://codereview.chromium.org/13808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=5525
Review URL: http://codereview.chromium.org/14113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12928
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cache that never evicts anything, so they are not real leaks. We just used to
free them before to probably make purify happy, and I didn't realize that when
I made recent changes to the file. Now we clean up the FontData structs again.
R=brettw
Review URL: http://codereview.chromium.org/14410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and having the height offset reversed.
These work now that we pull in webkit @r39105.
http://trac.webkit.org/changeset/39105
The images need to be rebaselined due to some text on the page, but the shadows match.
BUG=2969
Review URL: http://codereview.chromium.org/14089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(but not all) base types.
Review URL: http://codereview.chromium.org/13726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/13793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
LayoutTests/fast/canvas/gradient-add-second-start-end-stop.html
Review URL: http://codereview.chromium.org/14044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6888 0039d316-1c4b-4281-b951-d872f2087c98
|