| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/42579
ScriptController::createInlineEventListener was changed to take
4 params instead of 3, so I updated the V8 ScriptController
to do the same. We don't seem to need the extra arg because both
v8_proxy::createSVGEventHandler and
v8_proxy::createInlineEventListener are identical.
Also one new .cpp/.h file from
http://trac.webkit.org/changeset/42580
Review URL: http://codereview.chromium.org/79008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
elements if there are multiple options that share a name.
Currently Safari and chromium differ in their behavior in this area. Safari
returns
multiple options in a collection if necessary, but only for
HTMLOptionsCollection. For
HTMLSelectElement it always returns null.
Chromium returns a single option no matter what, but for both HTMLSelectElement
and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit
cache.
The HTML5 doc states that a collection should be returned if necessary for both.
The relevant parts of the spec are:
http://dev.w3.org/html5/spec/Overview.html#the-select-element
and
http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0
So if you have:
<select id="sl1"><option value="Value" name="test" /></select>
and in JS code you do:
var test = document.getElementById("sl1").test
test should be a single HTMLOptionElement.
If instead you have:
<select id="sl2"><option value="Value1" name="test" /><option value="Value2"
name="test" /></select>
test should be a collection with 2 HTMLOptionElements.
This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against
webkit, with a new layout test to confirm the behavior
Review URL: http://codereview.chromium.org/69014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
elements if there are multiple options that share a name.
Currently Safari and chromium differ in their behavior in this area. Safari returns
multiple options in a collection if necessary, but only for HTMLOptionsCollection. For
HTMLSelectElement it always returns null.
Chromium returns a single option no matter what, but for both HTMLSelectElement
and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit cache.
The HTML5 doc states that a collection should be returned if necessary for both.
The relevant parts of the spec are:
http://dev.w3.org/html5/spec/Overview.html#the-select-element
and
http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0
So if you have:
<select id="sl1"><option value="Value" name="test" /></select>
and in JS code you do:
var test = document.getElementById("sl1").test
test should be a single HTMLOptionElement.
If instead you have:
<select id="sl2"><option value="Value1" name="test" /><option value="Value2"
name="test" /></select>
test should be a collection with 2 HTMLOptionElements.
This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against
webkit, with a new layout test to confirm the behavior
Review URL: http://codereview.chromium.org/67148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This undoes changes from:
http://codereview.chromium.org/66045
Review URL: http://codereview.chromium.org/67114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is sometimes the functions to remove event listeners get called
outside of a ContextScope (even though we still have a valid context).
BUG=9775
Review URL: http://codereview.chromium.org/66045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Includes change to v8_proxy.cpp to account for addition of
MessagePortProxy class.
Review URL: http://codereview.chromium.org/66062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mbelshe
Review URL: http://codereview.chromium.org/67040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removing V8EventListenerList from v8_proxy and change the project files to compile V8EventListenerList.
Review URL: http://codereview.chromium.org/60102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can take advantage of lazy wrapper
initialization.
Dependent on the webkit fix.
will roll the deps for webkit as well.
Review URL: http://codereview.chromium.org/57086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
alive across GCs.
This change needs a WebKit change to go in first which adds frame and
type accessors to these objects.
Review URL: http://codereview.chromium.org/49038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread, not owning thread.
This patch contains the fix to the Purify failure: memory leaks of thread specific data for main thread. The fix is to switch to using the static maps for main thread.
Compared with previous patch being reviewed, the main change in this patch is in V8DOMMap.cpp: I introduce NonMainThreadSpecificDOMData and MainThreadSpecificDOMData that are both derived from ThreadSpecificDOMData.
Review URL: http://codereview.chromium.org/49044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the DOM, we need to explicitly keep the history wrapper object alive
for the lifetime of the DOMWindow object with which it is associated.
Review URL: http://codereview.chromium.org/53092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tree and the purify tests.
Review URL: http://codereview.chromium.org/42634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the security token in V8 was set to the string
"null" for all data urls. Therefore, the access check succeeded. The
cause of the regression was that securityOrigin's toString
implementation was changed in WebKit to return "null" instead of
String().
R=kasperl@chromium.org
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/53049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Before submitting, I'll add DEPS with corresponding WebKit rev (see http://codereview.chromium.org/52007)
Review URL: http://codereview.chromium.org/45035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
results.
Review URL: http://codereview.chromium.org/42262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The encoding parameter got dropped from Workers (r41871) so
drop it through the whole stack.
The upstream WorkerContextExecutionProxy has trackEvent with a lower
case t, but we pull in the wrong header in some places so make
both headers match.
Review URL: http://codereview.chromium.org/42538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Break out ToAtomicWebCoreString in addition to ToWebCoreString.
Re-enables the v8 string morphing; there is no longer degradation
on intl1 page cycler.
Review URL: http://codereview.chromium.org/42445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/50071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which we just clone.
This fix cannot land until we get the latest v8.
Review URL: http://codereview.chromium.org/50056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Split V8XMLHttpRequestCustom into appropriate files.
Review URL: http://codereview.chromium.org/45018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
semantics as having specified an attribute as readonly.
This allows us to unfork IDL differences where V8 wants
readonly and JSC does not by using the V8ReadOnly
tag.
Review URL: http://codereview.chromium.org/50037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
setIsWebWorkersEnabled to follow isFoo/setIsFoo pattern.
Also pull DEPS to bring in the WebKit/chromium/src part.
Review URL: http://codereview.chromium.org/48157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
initContextIfNeeded can be called without a handle scope in place
which will lead to a renderer crash when creating the first handle.
Also V8Proxy::initContextIfNeeded creates a number of local handles
that should be deallocated on exit.
BUG=8922
Review URL: http://codereview.chromium.org/48131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/42332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This is to move corresponding files out of http://codereview.chromium.org/48106/ so that this can be checked in before the change to enable worker. The reason for doing this is to avoid build break since the already checked-in third_party/WebKit/WebKit/chromium/src/WebKit.cpp has the ifdef guarded code depend on this.
Review URL: http://codereview.chromium.org/42313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
preparation for upstreaming.
Review URL: http://codereview.chromium.org/42294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit 11870.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/41029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Layout tests changes (and baselines):
* LayoutTests/fast/css/font-face-default-font.html
Fixed by aa upstream. The change was in the test itself.
* LayoutTests/fast/replaced/width100percent-searchfield.html
Fixed by levin upstream -- the themeChromiumWin.css change.
* LayoutTests/fast/forms/input-appearance-height.html
* LayoutTests/fast/repaint/search-field-cancel.html
Rebase needed due to themeChromiumWin.css change
* LayoutTests/fast/layers/normal-flow-hit-test.html
A slightly different font seems to be used in chromium which
casued some pixel differences in this test.
* LayoutTests/fast/forms/placeholder-pseudo-style.html
* LayoutTests/fast/forms/search-placeholder-value-changed.html
New tests which needed chromium baselines due to differences
in the search input box display.
* LayoutTests/fast/forms/placeholder-set-value.html
Differences in fonts and search input boxes were the cause
for the chromium baseline.
Review URL: http://codereview.chromium.org/46071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"try multiple commits" feature.
Review URL: http://codereview.chromium.org/46062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove NAMED_PROPERTY_SETTER interceptor for HTMLDocument.
Review URL: http://codereview.chromium.org/42157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit\port\bindings\v8, webkit\build files
These are all adjustments to use the recently upstreamed V8Events files.
percent-top-value-with-relative-position-expected
This is a new test that has the same result in chromium but uses a slightly
different font to display it, so pixels and coordinates were also different.
search-field-cancel-expected
This is a new test that verifies the visual aspects of the search field.
Since chromium doesn't implement this field in a special way, chromium's
results are expected to be different.
Review URL: http://codereview.chromium.org/42163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
worker process.
Review URL: http://codereview.chromium.org/44003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11570 0039d316-1c4b-4281-b951-d872f2087c98
|