summaryrefslogtreecommitdiffstats
path: root/webkit/support
Commit message (Collapse)AuthorAgeFilesLines
* Add runtime enabled command-line flag for data transfer itemsdcheng@chromium.org2011-03-081-0/+1
| | | | | | | | | BUG=75233 TEST=none Review URL: http://codereview.chromium.org/6626067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77355 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: use ASCII path for WebKit root directoryevan@chromium.org2011-03-081-1/+3
| | | | | | | | | | This path is only used for layout tests. BUG=69467 Review URL: http://codereview.chromium.org/6628066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77341 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceDispatcher to content. I've moved the Chrome-specific ↵jam@chromium.org2011-03-071-7/+0
| | | | | | | | SecurityFilterPeer to renderer directory, and factored out its creation so that it's the same as how we create ExtensionLocalizationPeer. Review URL: http://codereview.chromium.org/6626046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77156 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the extension dependency in ResourceDispatcher by calling out to ↵jam@chromium.org2011-03-041-0/+7
| | | | | | | | a webkit_glue function that can update the peer. No point sending the boolean flag from the browser since the same check is done in the renderer. Review URL: http://codereview.chromium.org/6628006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76957 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit_support::TaskAdaptor to make tasks have the desttructor.morrita@chromium.org2011-03-012-0/+39
| | | | | | | | | BUG=73675 TEST=none Review URL: http://codereview.chromium.org/6602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76362 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak and add the webkit_quota library to the project.michaeln@google.com2011-02-221-0/+1
| | | | | | | | | BUG=73268 TEST=look at the memory bots this time Review URL: http://codereview.chromium.org/6469036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75633 0039d316-1c4b-4281-b951-d872f2087c98
* Set the minimum timer interval on a per-page basis, and adjust it whenkbr@google.com2011-02-182-0/+10
| | | | | | | | | | | | | | | tabs are brought to the foreground and sent to the background. This CL does not actually increase the background timer interval. That will be done separately, so that it can easily be reverted without removing all of the associated code. BUG=66078 TEST=none (tested manually with minimal test case) Review URL: http://codereview.chromium.org/6532012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75404 0039d316-1c4b-4281-b951-d872f2087c98
* IndexedDB: Allow injection of keys into values via key path.hans@chromium.org2011-02-172-0/+12
| | | | | | | | | BUG=70118 TEST=browser_tests Review URL: http://codereview.chromium.org/6529021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75258 0039d316-1c4b-4281-b951-d872f2087c98
* Missed file for ClearCache signature change.mbelshe@chromium.org2011-02-161-1/+1
| | | | | | | | | BUG=none TEST=fix-build Review URL: http://codereview.chromium.org/6480095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75038 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-052-2/+2
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/gfx/ to src/ui/gfxsail@chromium.org2011-02-021-1/+1
| | | | | | | | | | | To reduce the size of this change I've left stub header files in src/gfx/. Once all includes have been updated I'll delete the stub files. BUG=71063 TEST=Still doing test builds. Review URL: http://codereview.chromium.org/6246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73530 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup everything but net/ for our first clang plugins.erg@google.com2011-02-026-17/+44
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6250088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73396 0039d316-1c4b-4281-b951-d872f2087c98
* Don't register WebKitWeightWatcher fontstkent@chromium.org2011-02-011-9/+2
| | | | | | | | | | | Registering many fonts causes a probelm. We don't register them at this moment. BUG=http://webkit.org/b/50709 TEST=LayoutTests/fast/css/font-weight-1.html Review URL: http://codereview.chromium.org/6287039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73378 0039d316-1c4b-4281-b951-d872f2087c98
* Update GetWebKitRootDirFilePath to handle the move of WebKit/ into Source/.mihaip@chromium.org2011-02-011-3/+4
| | | | | | | | BUG=none TEST=layout tests Review URL: http://codereview.chromium.org/6334024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73306 0039d316-1c4b-4281-b951-d872f2087c98
* Fix input-speech related failures on DRTtkent@chromium.org2011-01-262-41/+5
| | | | | | | | | | | Windows and Mac implementations lacked IDR_INPUT_SPEECH* handling. This change fixes them by removing resource ID checking. TEST=Some of LayoutTests/fast/speech/. BUG=none Review URL: http://codereview.chromium.org/6303017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72581 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the plugin lists handling code.pastarmovj@chromium.org2011-01-241-1/+1
| | | | | | | | | | | | | | | | | Effects of this refactor: 1. The WebPluginInfo now keep information not only if a plugin is disabled but also the reason for that. It can either be user, policy or both. That way we can restore the right value after policies stop to control the feature. 2. Plugins can be correctly enabled and disabled either as a group or separately. 3. The code is cleaner and PluginGroup is not duplicating information from PluginList but stores all needed information and provides it through cleaner interface. BUG=54681,66505,69374,69148 TEST=Manual for the policy. DefaultPluginUITest.DefaultPluginLoadTest from ui_tests and Plugin* from test_shell_tests. Review URL: http://codereview.chromium.org/5699005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72341 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-202-6/+6
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Move more web widgets painting from webkit to chrome.xiyuan@chromium.org2011-01-201-0/+11
| | | | | | | | | | | | | | | - Move linux web widgets painting code from webkit; - Move dependent resources from webkit_resources into gfx_resources and follow the pattern in net package to add resource loading support to gfx package; - Update ChromeOS theme engine to follow mocks in chromium-os:9256. BUG=chromium-os:9256 TEST=Verify default web widgets has desired look on ChromeOS. Review URL: http://codereview.chromium.org/6254004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove forced use of Software mode GLscheib@chromium.org2011-01-181-4/+0
| | | | | | | | | | | A Continuation of the change in http://codereview.chromium.org/6258001 BUG=68797 TEST=previous buildbots test old path, new buildbots will test the GPU path Review URL: http://codereview.chromium.org/6240005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71670 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS past WebKit move. Update gyp files and include paths to ↵abarth@chromium.org2011-01-179-40/+40
| | | | | | reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71586 0039d316-1c4b-4281-b951-d872f2087c98
* Remove MessageLoop methods from Filter interface toacolwell@chromium.org2011-01-151-1/+7
| | | | | | | | | | | | | | separate Filter management from MessageLoop management. This sets the stage for filters to share threads in the future which will reduce resource consumption when multiple <video> tags are on the same page. BUG=69451 TEST=None Review URL: http://codereview.chromium.org/6171009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71548 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial OWNERS files for src/webkit/.darin@chromium.org2011-01-141-0/+2
| | | | | | | | R=ben Review URL: http://codereview.chromium.org/6327005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71492 0039d316-1c4b-4281-b951-d872f2087c98
* webkit_support_common should depend on ↵tkent@chromium.org2011-01-141-0/+7
| | | | | | | | | | setup_third_party.gyp:third_party_headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/6251007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71405 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for DumpRenderTree to use the GPU rather than software rendererscheib@chromium.org2011-01-132-0/+20
| | | | | | | | | | | | BUG=68797 TEST=previous buildbots test old path, new buildbots will test the GPU path Support for webkit side changes: https://bugs.webkit.org/show_bug.cgi?id=52333 Review URL: http://codereview.chromium.org/6258001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71332 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-132-15/+16
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* Make a separated library for files common between webkit_support and test_shelltkent@chromium.org2011-01-131-18/+29
| | | | | | | | | | in order to avoid that test_shell links webkit_support-dedicated files. BUG=67457 TEST=none; No behavior change. Review URL: http://codereview.chromium.org/6111001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71293 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist WebKitTestNetscapePlugIn so we can rename the plugintony@chromium.org2011-01-121-3/+2
| | | | | | | | | | | | | to TestNetscapePlugIn. After webkit r75561, both plugins are the same so we can now delete WebKitTestNetscapePlugIn. TEST=plugin layout tests still pass Review URL: http://codereview.chromium.org/6158007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71247 0039d316-1c4b-4281-b951-d872f2087c98
* Change namespace of WebGraphicsContext3DInProcessImpl based on review feedback.kbr@google.com2011-01-121-1/+1
| | | | | | | | | BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/6166008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71234 0039d316-1c4b-4281-b951-d872f2087c98
* Move the in-process WebGL implementation from the WebKit to thekbr@google.com2011-01-113-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Chromium repository to break circular dependencies on Chromium's OpenGL bindings in app/gfx/gl. The minimal changes to the code were made in order to break dependencies on WebCore types and to make the code fit the Google C++ style guide as closely as possible. There are many references to undesirable types like "long" in the WebGraphicsContext3D interface, which are the source of the majority of lint errors and which will be fixed in follow-on work. The upstream WebGraphicsContext3DDefaultImpl will be deleted after this lands. Tested: - Various WebGL demos in Chrome - Built and ran WebGL layout tests in DRT BUG=none TEST=none (see above) Review URL: http://codereview.chromium.org/6100009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71069 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-1/+2
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-2/+1
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-1/+2
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-2/+1
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-1/+2
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/mac_util.h to base/mac and use the base::mac namespace.brettw@chromium.org2011-01-012-5/+5
| | | | | | | | | | | Fix up callers to use the new location & namespace. Remove includes from  files where it wasn't necessary. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6046009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70359 0039d316-1c4b-4281-b951-d872f2087c98
* Expose Mac WebThemeEngine hooks added by r70278 (and r74581 on the WebKit side)mihaip@chromium.org2010-12-304-6/+6
| | | | | | | | | | | to test_shell/DRT. BUG=23498 TEST=Layout tests Review URL: http://codereview.chromium.org/6090002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70319 0039d316-1c4b-4281-b951-d872f2087c98
* Move data pack from base to app (it's just part of the resource bundle system).brettw@chromium.org2010-12-232-6/+6
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5992006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70038 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land earlier patch that moves the NPAPI implementation from ↵brettw@chromium.org2010-12-214-21/+24
| | | | | | webkit/glue/plugins to webkit/plugins/npapi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69808 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi"chase@chromium.org2010-12-214-24/+21
| | | | | | | | | | | | Manually reverting r69755, which broke the tree. BUG=none TEST=none TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/5998002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 69755 - Move the NPAPI files from webkit/glue/plugins to ↵chase@chromium.org2010-12-204-21/+24
| | | | | | | | | | | | | | | webkit/plugins/npapi" Manually reverting r69766, which was itself a failed revert of r69755. BUG=none TEST=none TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/5996003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69755 - Move the NPAPI files from webkit/glue/plugins to ↵brettw@chromium.org2010-12-204-24/+21
| | | | | | | | | | | | | | | webkit/plugins/npapi and put them in the webkit::npapi namespace. BUG=none TEST=none Review URL: http://codereview.chromium.org/6012002 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/5961004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69766 0039d316-1c4b-4281-b951-d872f2087c98
* Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi and putbrettw@chromium.org2010-12-204-21/+24
| | | | | | | | | | them in the webkit::npapi namespace. BUG=none TEST=none Review URL: http://codereview.chromium.org/6012002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69755 0039d316-1c4b-4281-b951-d872f2087c98
* Try to get webkit tests green by letting DRT load CrApplication early.thakis@chromium.org2010-12-194-0/+39
| | | | | | | | | | | | This mirrors the change I made to test_shell in r69615 BUG=46929 TEST=webkit tests on waterfall are green TBR=tony^work Review URL: http://codereview.chromium.org/5987003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69664 0039d316-1c4b-4281-b951-d872f2087c98
* Separate BufferedDataSource and BufferedResourceLoader into two files.annacc@chromium.org2010-12-161-7/+0
| | | | | | | | | | | | | | | It's time to finally separate the huge monster files buffered_data_source.[h/cc] into two. ericroman: There are some variables and short methods that both BufferedDataSource and BufferedResourceLoader rely on and that I have moved to src/net/http/http_util.h. Could you please verify that this is an ok place to put them? Also, appcache issues have been resolved (and approved by michaeln) so I've removed those comments. BUG=None. TEST=Compiles. Review URL: http://codereview.chromium.org/5756004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69429 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-061-25/+4
| | | | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363). One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader ↵scherkus@chromium.org2010-12-031-4/+25
| | | | | | | | | | | | | | | | | | | | instead of a MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/5619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MediaFilter and MediaFilterCollection to Filter and FilterCollection, ↵scherkus@chromium.org2010-12-031-2/+3
| | | | | | | | | | | respectively. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-021-25/+4
| | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
* Stopgap fix for crash in issue 53867 comment 15thakis@chromium.org2010-12-011-3/+9
| | | | | | | | | | | | | gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer). The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case. BUG=53867,61293 TEST=Completing the first level in gwtquake shouldn't crash the renderer. Review URL: http://codereview.chromium.org/5362003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the forked npapi layout test plugin from the tree.tony@chromium.org2010-11-291-3/+0
| | | | | | | | | | All dependencies were already removed. BUG=64260 Review URL: http://codereview.chromium.org/5318009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67586 0039d316-1c4b-4281-b951-d872f2087c98