| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/5992006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
webkit/glue/plugins to webkit/plugins/npapi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually reverting r69755, which broke the tree.
BUG=none
TEST=none
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/5998002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/plugins/npapi"
Manually reverting r69766, which was itself a failed
revert of r69755.
BUG=none
TEST=none
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/5996003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/plugins/npapi and put
them in the webkit::npapi namespace.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6012002
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/5961004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
them in the webkit::npapi namespace.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6012002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mirrors the change I made to test_shell in r69615
BUG=46929
TEST=webkit tests on waterfall are green
TBR=tony^work
Review URL: http://codereview.chromium.org/5987003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's time to finally separate the huge monster files buffered_data_source.[h/cc] into two.
ericroman: There are some variables and short methods that both BufferedDataSource and BufferedResourceLoader rely on and that I have moved to src/net/http/http_util.h. Could you please verify that this is an ok place to put them?
Also, appcache issues have been resolved (and approved by michaeln) so I've removed those comments.
BUG=None.
TEST=Compiles.
Review URL: http://codereview.chromium.org/5756004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaResourceLoaderBridge.
Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363).
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of a MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/5619002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
respectively.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer).
The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case.
BUG=53867,61293
TEST=Completing the first level in gwtquake shouldn't crash the renderer.
Review URL: http://codereview.chromium.org/5362003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
All dependencies were already removed.
BUG=64260
Review URL: http://codereview.chromium.org/5318009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* webkit/glue/
- Add overloads of queryLocalizedString() functions
They will be added to WebKit::WebKitClient later.
- Add implementations for WebLocalizedString::Validation*
- Add message strings
The English strings are different from WebKit's to avoid the brusque
WebKit's strings.
Port some messages from Mozilla.
* webkit/tools/test_shell/ and webkit/support/
Hook queryLocalizedString() functions in order to return messages same as
WebKit in layout test.
BUG=28264
TEST=LayoutTests/fast/forms/validationMessage.html
Review URL: http://codereview.chromium.org/4678006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that most of the code paths that run in chromium can be tested
in test_shell.
Also removed SandboxedFileSystemContext::CheckIfFilePathIsSafe that is not used at all.
BUG=60243
TEST=fast/filesystem
Review URL: http://codereview.chromium.org/4879001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1) Blacklist the old plugin (TestNetscapePlugIn) in DRT. I didn't think it got copied into {Debug,Release}/plugins, but it does.
2) Enable loading plugins from {Debug,Release}/plugins in TestShell. This causes us to load the new plugin (WebKitTestNetscapePlugIn). We have code to blacklist the new plugin, but it was wrong.
BUG=48471
Review URL: http://codereview.chromium.org/5252001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will enable us to switch to using the upstream TestNetscapePlugIn
on Windows and Linux.
Review URL: http://codereview.chromium.org/5218001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when passed a net::ERR_NETWORK_ACCESS_DENIED error. This results in a
error code being output by the security/block-test-no-port.html
layout test on OSX that is consistent with other platforms.
The test is also temporarily disabled on OSX until the expected results
are updated.
BUG=61655
TEST=security/block-test-no-port.html (Currently disabled)
Review URL: http://codereview.chromium.org/5012005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaFilterCollection is the only code that uses FilterType now so
I'm moving the enum into that class and removing all references from
the MediaFilter & derived classes.
BUG=61823
TEST=No new functionality. Existing tests pass.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66125
Review URL: http://codereview.chromium.org/4653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaFilterCollection is the only code that uses FilterType now so
I'm moving the enum into that class and removing all references from
the MediaFilter & derived classes.
BUG=61823
TEST=No new functionality. Existing tests pass.
Review URL: http://codereview.chromium.org/4653005
TBR=acolwell@chromium.org
Review URL: http://codereview.chromium.org/4991003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaFilterCollection is the only code that uses FilterType now so
I'm moving the enum into that class and removing all references from
the MediaFilter & derived classes.
BUG=61823
TEST=No new functionality. Existing tests pass.
Review URL: http://codereview.chromium.org/4653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored FilterType usage a bit to remove the need to manually associate
FilterType values to filter base classes.
Patch by acolwell@chromium.org:
http://codereview.chromium.org/4176006/show
BUG=60778
TEST=media_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors.
BUG=28083
TEST=None
Review URL: http://codereview.chromium.org/4192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the private Pepper API).
BUG=61142
Review URL: http://codereview.chromium.org/4158013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4171001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::debug namespace.
This splits apart debug_util into base/debugger and base/stack_trace
There are still two functions in debug_util that I'm not sure what to do with.
Since this uses the base::debug namespace, I removed the functions in
debugger.h from the static class and just made them free functions in the
namespace.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FilterFactory, IsMediaFormatSupported and CreateFactory are the source
of evil. They also have have a gang of template functions. This patch
terminate them all and make the world a better place.
BUG=28207
TEST=<video> runs
Review URL: http://codereview.chromium.org/3878001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds an Abort() method to BufferedDataSource, which will
wake up a blocking read if one exists. When WebMediaPlayerImpl being
destroyed, it now tells BufferedDataSource to abort before it tells
the pipeline to stop, so the pipeline will not hang while waiting
for a never-ending Read() to return.
BUG=54465
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/4009002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the docstring.
TBR=jorlow
Review URL: http://codereview.chromium.org/4043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/4058003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for webkit.org checkouts. This avoid the chance of someone
accidentally editing a file in WebKit/chromium/third_party/WebKit/
or the files being out of date.
BUG=56677
Review URL: http://codereview.chromium.org/3961001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The valgrind bots sometimes report the leaks of our cached resources. To fix these occasional leaks, this change cleans up all the cached resources of both our test shell and DumpRenderTree when they run on valgrind.
BUG=31800
TEST=make the "WebKit Linux (valgrind layout)" bot greener.
Review URL: http://codereview.chromium.org/3861002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3779005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/3747010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
path for TestShell.app and DumpRenderTree.app. This avoids having
to copy the plugin into the DumpRenderTree.app/Contents/PlugIns and
makes Mac more consistent with Win/Linux.
TEST=put an npapi plugin in xcodebuild/Debug/plugins and see that it
exists in navigator.plugins.
BUG=48471
Review URL: http://codereview.chromium.org/3779013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
match the criterion (mime type/url) instead of just the first one that matches.
This is in preparation for implementing a way for us to switch which flash plugin we select based on a whitelist of domains.
BUG=http://crosbug.com/7403
TEST=ran chrome unit_tests, ran chromeos version of chrome, passed trybots.
Review URL: http://codereview.chromium.org/3530017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
retrying "Revert 62068 - Move implementation of linux scrollbars from webkit using new"
See: http://codereview.chromium.org/3618014
TBR:jam@chromium.org
BUG=chromium-os:6857
TEST=Verify that both linux and chromeos scrollbars look right.
Review URL: http://codereview.chromium.org/3697001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58095
TEST=Build chromium
Review URL: http://codereview.chromium.org/3616008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=scarybeasts
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3620003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebURLLoaderClient::didFinishLoading(WebURLLoader*)
with WebURLLoaderClient::didFinishLoading(WebURLLoader*, double), so that the
former can be removed.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/3573006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This is a TODO in string_util.h)
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3404027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DumpRenderTree.
BUG=none
TEST=none; This is a part of test code.
Review URL: http://codereview.chromium.org/3479005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
previously done for test_shell. Verified that Mesa will be used for
WebGL tests after DRT dependencies are updated.
BUG=none
TEST=none (ran a couple of WebGL tests in DRT via new-run-webkit-tests)
Review URL: http://codereview.chromium.org/3439007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactored a bunch of code from chrome/browser to webkit/fileapi for reuse.
Added class hierarchy. Test shell and browser operations now inherit from
common webkit/fileapi/file_system_operation.
Review URL: http://codereview.chromium.org/3186009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm going to use this to get
http/tests/security/local-user-CSS-from-remote.html
passing. Instead of trying to load a file:/// URL for the
user style sheet, use a data: URL. This matches what happens
in Chromium.
Review URL: http://codereview.chromium.org/3425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
simple_resource_loader_bridge.cc, so that it happens for both test_shell and the
Chromium DRT (allowing blob layout tests to pass with the latter too).
BUG=55587
TEST=blob-related layout tests (with both test_shell and DRT)
Review URL: http://codereview.chromium.org/3397002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> webkit_support_gfx.h:41:8: warning: extra tokens at end of #endif directive
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3303026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59307 0039d316-1c4b-4281-b951-d872f2087c98
|