summaryrefslogtreecommitdiffstats
path: root/webkit/tools/test_shell
Commit message (Collapse)AuthorAgeFilesLines
* Adds some ifdefs so that test_shell can be compiled on linuxsky@chromium.org2009-04-103-7/+23
| | | | | | | | | | | | | without GTK. I had to recreate this patch as my workspace for various resonds. UGH! BUG=none TEST=none Review URL: http://codereview.chromium.org/67024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of the WebKit popup changes.paulg@google.com2009-04-104-25/+29
| | | | | | | | | | | Implements HTML select popups on Mac OS X as native Cocoa controls. BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/67018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13495 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 13480 (change to gyp for webkit on windows).bradnelson@google.com2009-04-102-0/+824
| | | | | | | | Too many loose ends. Review URL: http://codereview.chromium.org/66020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13485 0039d316-1c4b-4281-b951-d872f2087c98
* Switching webkit to gyp on windows.bradnelson@google.com2009-04-092-824/+0
| | | | | | Review URL: http://codereview.chromium.org/63152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13480 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing gyp description for windows with webkit/test_shell.bradnelson@google.com2009-04-091-9/+83
| | | | | | | | This does not throw the switch to turn it on for the world yet. Review URL: http://codereview.chromium.org/66008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13474 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebPoint, WebRect, and WebSize in more of the gluedarin@chromium.org2009-04-099-44/+67
| | | | | | | | | | | | | | | | | layer interface. This will help when we move those interfaces into the WebKit API. This is a second attempt at r13381, which was already reviewed here: http://codereview.chromium.org/63126 The only change between that CL and this one is in render_view.h, where I needed to change a parameter type from gfx::Rect to WebRect. TBR=dglazkov Review URL: http://codereview.chromium.org/64005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13424 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting dfisher changes 133386 and 13381cpu@google.com2009-04-089-67/+44
| | | | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/58018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13387 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac bustagedarin@chromium.org2009-04-081-3/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13386 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebPoint, WebRect, and WebSize in more of the gluedarin@chromium.org2009-04-088-41/+61
| | | | | | | | | | | layer interface. This will help when we move those interfaces into the WebKit API. R=dglazkov Review URL: http://codereview.chromium.org/63126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13381 0039d316-1c4b-4281-b951-d872f2087c98
* Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build:sgk@google.com2009-04-081-1/+1
| | | | | | | | | parameterize the 'type' setting of the various library targets, with a default of 'static_library'. (Hat tip to Craig Schlenter.) Review URL: http://codereview.chromium.org/62127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 12739, 12740, and 12741 because we're going to fix Issue 7448 purely ↵abarth@chromium.org2009-04-081-1/+0
| | | | | | in WebKit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13343 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebDragData in WebView and WebViewDelegate.darin@chromium.org2009-04-0710-52/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | I also cleaned up some of the WebView and WebViewDelegate methods to pass WebPoint instead of pairs of ints or gfx::Point. With this change, I am keeping webkit/glue/webdropdata.{h,cc}, which is what Chrome uses to pass around the equivalent data. Now, it is possible to construct a WebDropData from a WebKit::WebDragData and to also get a WebKit::WebDragData from a WebDropData. Hence, the conversion between WebDropData and ChromiumDataObject (see clipboard_conversion.{h,cc}) is now removed in favor of conversion between WebDropData and WebKit::WebDragData. Conversion between WebKit::WebDragData and WebCore::ChromiumDataObject is very cheap (just reference counting). Finally, this change also brings in WebData, which is now used by the return value of WebKitClient::loadResource. As a companion to that change, I also changed webkit_glue::GetDataResource to return StringPiece instead of std::string. That also saves on an unnecessary buffer copy. R=dglazkov Review URL: http://codereview.chromium.org/63084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13305 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent test shell editing events from getting to the webview delegate after ↵estade@chromium.org2009-04-071-7/+8
| | | | | | | | | | test shell shutdown. BUG=9486 Review URL: http://codereview.chromium.org/63091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13294 0039d316-1c4b-4281-b951-d872f2087c98
* Use an in-memory cache when running layout tests.ojan@google.com2009-04-071-1/+4
| | | | | | | This reduces flakyness when running them in parallel. Review URL: http://codereview.chromium.org/63082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13280 0039d316-1c4b-4281-b951-d872f2087c98
* Adds new messages and widens some existing messages between the renderer and ↵michaeln@google.com2009-04-071-2/+9
| | | | | | | | browser processes to support an implementation of the HTML5AppCache spec with most of the logic running in the browser process. The gist of most of the changes are to indicate which frame each resource request is coming from, and to indicate which appcache each response was retrieved from (if any).See https://docs.google.com/a/google.com/Doc?docid=agv6ghfsqr_15f749cgt3&hl=en Review URL: http://codereview.chromium.org/9712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13258 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-074-11/+16
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a selection clipboard leak.estade@chromium.org2009-04-071-0/+1
| | | | | | | | BUG=9503 Review URL: http://codereview.chromium.org/62087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13219 0039d316-1c4b-4281-b951-d872f2087c98
* The test was failing because the ui_test run before it failed to delete the ↵jam@chromium.org2009-04-021-7/+13
| | | | | | | | test plugin (it must have still been locked by the browser process). As a result, test_shell_tests loaded that plugin into its plugin info cache. Review URL: http://codereview.chromium.org/58005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tests that depend on setCustomPolicyDelegate and waitForPolicyDelegate.darin@chromium.org2009-04-026-27/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 1- Need to support a second parameter to setCustomPolicyDelegate that controls whether subsequent loads are permitted or not. Previously, we would always deny any subsequent loads. 2- Need to change the string that we produce when writing out the URL that is impacted by a custom policy delegate. We need to write out only the filename part of the URL. (We need to do this only for file:// URLs.) 3- Add LayoutTestController::waitForPolicyDelegate and corresponding method on TestWebViewDelegate. 4- Improve the way we reset the TestWebViewDelegate. Now, instead of having support for reseting individual fields, we just reallocate the delegate. This requires adding a SetDelegate method to WebView. BUG=9582 R=dglazkov Review URL: http://codereview.chromium.org/56169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13014 0039d316-1c4b-4281-b951-d872f2087c98
* Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.hdarin@chromium.org2009-04-017-7/+43
| | | | | | | | | | | | | This also eliminates webkit_glue::GetScreenInfo and webkit_glue::GetScreenInfoHelper. As part of this CL, I also extracted all of the ParamTraits for WebKit API types into chrome/common/webkit_param_traits.h. R=dglazkov Review URL: http://codereview.chromium.org/58008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12993 0039d316-1c4b-4281-b951-d872f2087c98
* The layoutTestController had its queueScript method broken into two:darin@chromium.org2009-04-012-17/+50
| | | | | | | | | | | | | | | | | | | | | queueLoadingScript and queueNonLoadingScript. The behavior of the work queue also changed to be a bit simpler. Now, each WorkItem reports whether or not it kicked off a load. There is a bit more work to do here to determine if work items actually resulted in a load. For now, I am just guessing, which is almost always correct. I will follow-up with the other part of the CL once this one clears the bots. This change corresponds roughly to: http://trac.webkit.org/changeset/42082 BUG=9581 R=dglazkov Review URL: http://codereview.chromium.org/56164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12991 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-011-328/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Fresh build problem: make sure test_shell is built and installedsgk@google.com2009-04-011-0/+2
| | | | | | | when we ask for test_shell_tests. Review URL: http://codereview.chromium.org/56161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12980 0039d316-1c4b-4281-b951-d872f2087c98
* Use the better gyp pattern to make sure test_shell.pak is installed nextsgk@google.com2009-04-011-4/+6
| | | | | | | to test_shell on Linux. Review URL: http://codereview.chromium.org/59004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12976 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebScriptSource and WebFindInPageRequest from the WebKit API.darin@chromium.org2009-03-311-3/+7
| | | | | | | | | | | | | | | | | | This change introduces some helper functions in glue_util.cc for efficient conversion between WebString and WebCore::String when inside the implementation of webkit/glue. This is a temporary change since eventually all code in glue that uses WebCore will be moved into the WebKit API implementation. Instead of making the Chrome automation use WebFindInPageRequest, I decided to introduce AutomationMsg_Find_Params as a copy of the old FindInPageRequest structure. That preserves the IPC protocol and avoids making the automation library depend on WebKit. R=dglazkov Review URL: http://codereview.chromium.org/57060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12881 0039d316-1c4b-4281-b951-d872f2087c98
* Reland changes to enable worker layout tests. Compared to last review ↵jianli@chromium.org2009-03-308-2/+176
| | | | | | | | | | | (http://codereview.chromium.org/50045), the following changes are made: 1) Add chrome/test/worker/DEPS to address checkdeps error. 2) Change test_expectations.txt to skip some worker layout tests. 3) Add test_worker.vcproj to webkit.sln so that test_worker.dll can be built for WebKit build. Review URL: http://codereview.chromium.org/56074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12822 0039d316-1c4b-4281-b951-d872f2087c98
* Enable running webkit tests in parallel and make it useojan@google.com2009-03-3010-4/+158
| | | | | | | | | | | | | | | | | | | | the number of cpus as the default number of test_shells to spawn. This involved ignoring focus/blur messages and mocking out the clipboard. The test_shell window still sometimes seems to get focus, so there's still a bit more work to do, but the tests seem to all pass. We still default to 1 test_shell at a time. Once I get this committed, I'll try multiple. I just don't want to have to rollback this whole thing. Review URL: http://codereview.chromium.org/56040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12821 0039d316-1c4b-4281-b951-d872f2087c98
* Always fall through to NetResourceProvider, rather than NOTREACHED()ing here.evan@chromium.org2009-03-301-7/+0
| | | | | | | | | | There's a subsequent LOG(ERROR) in that code, so we still crash if a resource is missing, but it means we don't need to enumerate all resources again here. Fixes chrome/fast/forms/basic-inputs.html . TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12792 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side of using setKeyIdentifierFromWindowsKeyCode instead ofdarin@chromium.org2009-03-302-16/+2
| | | | | | | | | | | KeyIdentifier.h. BUG=9460 R=avi,dglazkov Review URL: http://codereview.chromium.org/55056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12788 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 12763.jianli@chromium.org2009-03-308-174/+0
| | | | | | Review URL: http://codereview.chromium.org/56055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12764 0039d316-1c4b-4281-b951-d872f2087c98
* Enable worker layout tests. In order for test_shell to run worker, we link ↵jianli@chromium.org2009-03-308-0/+174
| | | | | | | | all of the code required to run the worker into a DLL and then load that DLL in test_shell. This allows us to host a separate V8 instance. Review URL: http://codereview.chromium.org/50045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12763 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a test that's been failing since around r12725.evan@chromium.org2009-03-291-1/+1
| | | | | | | | | It looks like a relatively new test, so I'm going to guess this is preferable to rolling changes back. TBR=jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12755 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to specify a default MIME type when loading a resource. ↵abarth@chromium.org2009-03-281-0/+1
| | | | | | | | | | | | | We'll need this to correctly load stylesheets that lack a Content-Type header in standards mode. We're waiting on https://bugs.webkit.org/show_bug.cgi?id=24904 upstream before this works fully. This change, as it stands, is a no-op. R=wtc BUG=7448 Review URL: http://codereview.chromium.org/55049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12739 0039d316-1c4b-4281-b951-d872f2087c98
* Use Webkit::WebInputEvent and remove webkit/glue/webinputevent.darin@chromium.org2009-03-2711-105/+153
| | | | | | | | | | This change adds a temporary dependency on src/KeyIdentifier.{h,cpp} which I am going to remove after this CL. I didn't want to grow this CL any larger. R=dglazkov Review URL: http://codereview.chromium.org/53099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12728 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test to test_shell_tests to verify that navigator.plugins.refresh() works.jam@chromium.org2009-03-271-87/+54
| | | | | | | | Also get rid of the duplicate disabled verify_plugin_window_rect test. Review URL: http://codereview.chromium.org/42687 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12725 0039d316-1c4b-4281-b951-d872f2087c98
* Support the IDR_SEARCH_xxx images in test_shell. Untested outside of ↵pkasting@chromium.org2009-03-273-3/+18
| | | | | | | | | | | Windows. Not going to work on mac since NetResourceProvider() is NOTIMPLEMENTED(). Take 2, this time hopefully compiles on Mac/Linux. BUG=9210 Review URL: http://codereview.chromium.org/55027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12674 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Support the IDR_SEARCH_xxx images in test_shell. Untested outside ↵evan@chromium.org2009-03-273-18/+3
| | | | | | | | of Windows. Not going to work on mac since NetResourceProvider() is NOTIMPLEMENTED()." This reverts commit r12670. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12672 0039d316-1c4b-4281-b951-d872f2087c98
* Support the IDR_SEARCH_xxx images in test_shell. Untested outside of ↵pkasting@chromium.org2009-03-273-3/+18
| | | | | | | | | Windows. Not going to work on mac since NetResourceProvider() is NOTIMPLEMENTED(). BUG=9210 Review URL: http://codereview.chromium.org/56012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12670 0039d316-1c4b-4281-b951-d872f2087c98
* Report the plugin position to windowed plugins as (0,0)jam@chromium.org2009-03-261-14/+1
| | | | | | | | | | . the NPAPI documentation says it should be reported relative to the parent HWND, which is the plugin's coordinates on the page. This assumption breaks in Chrome because we have an intermediate HWND. I've tested on a bunch of pages to see if this change causes regressions, if we find any in the future we can reconsider this. BUG=6742 Review URL: http://codereview.chromium.org/42626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12587 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to support cached form submissions.darin@chromium.org2009-03-251-0/+7
| | | | | | | | | | | | | | | | | | | | | | The solution is to add a user-defined identifier to UploadData. If that identifier is set, and if the request method is POST, then HttpCache will enable caching for the response. (The cache key will be a composition of the identifier and the URL.) A subsequent POST request to the same URL with the same identifier will "hit" the previously generated cache entry. Reuse from the cache is subject to all of the standard rules. For reference, here are the corresponding net changes: http://codereview.chromium.org/52028 Here are the corresponding WebKit changes: http://trac.webkit.org/changeset/41919 BUG=2636 R=sky Review URL: http://codereview.chromium.org/52040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12485 0039d316-1c4b-4281-b951-d872f2087c98
* Don't override user's default cursor with GDK_ARROW.estade@chromium.org2009-03-251-2/+6
| | | | | | | | BUG=8786 Review URL: http://codereview.chromium.org/42587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12474 0039d316-1c4b-4281-b951-d872f2087c98
* Dump Keystone integration from Mac TestShellmark@chromium.org2009-03-254-164/+0
| | | | | | Review URL: http://codereview.chromium.org/53042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12455 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a trivial commandline memory leak that shows up in the valgrind run ↵dkegel@google.com2009-03-251-0/+2
| | | | | | | | | | | | | | | | | | | | of test_shell_tests. Fixes following valgrind warning: 380 bytes in 9 blocks are possibly lost in loss record 331 of 423 at operator new(unsigned int) vg_replace_malloc.c:230 by std::string::_Rep::_S_create(unsigned int, unsigned int, std::allocator<char> const&) (in libstdc++.so.6.0.9) by (within libstdc++.so.6.0.9) by std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in libstdc++.so.6.0.9) by CommandLine::CommandLine(int, char const* const*) src/base/command_line.cc:96 by CommandLine::Init(int, char const* const*) src/base/command_line.cc:177 by main src/webkit/tools/test_shell/run_all_tests.cc:57 Review URL: http://codereview.chromium.org/45041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12429 0039d316-1c4b-4281-b951-d872f2087c98
* First stage of implementing HTML select popup menus forpaulg@google.com2009-03-245-2/+167
| | | | | | | | | | | | | | | | the Mac test_shell. Once the changes to WebKit/WebCore/platform/chromium/PopupMenuChromium* have been upstreamed (then landed in our tree), we can enable them in test_shell. The WebKit part is contained in this bug: https://bugs.webkit.org/show_bug.cgi?id=24692 BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/48149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12382 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the following layout test:hclam@chromium.org2009-03-241-0/+8
| | | | | | | | | | | | | | LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post.html The crash happens in simple_resource_loader_bridge.cc, there is a case when MaybeUpdateUploadProgress is posted as a task and in the queue while a redirect response by the server cancels the upload. Leaving request_->get_upload() returns NULL, and of cource using of the pointer failes. Review URL: http://codereview.chromium.org/50077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12379 0039d316-1c4b-4281-b951-d872f2087c98
* We need to extend the timeouts on Mac and Linux, too,dkegel@google.com2009-03-241-5/+3
| | | | | | | | now that we're valgrinding. Review URL: http://codereview.chromium.org/42471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12350 0039d316-1c4b-4281-b951-d872f2087c98
* Update the gyp Linux build:sgk@google.com2009-03-201-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | * Add Linux settings to target_defaults in common.gypi so gyp-generated SConscript files no longer depend on build/SConscript.main or the Hammer infrastructure. * Copy the FilterOut() function from Hammer to the chromium_builders.py Tool module. * Add a ChromiumLoadableModule() builder to chromium_builders.py. * Add dependencies on the 'views' library to the chrome link (target 'app'). * Add missing views/*/*_unittest.cc modules to the 'unit_tests' target. Exclude all but the one that builds on Linux from the non-Windows builds. * Crib a list of chrome/views files to exclude from the Linux build from the old SCons configuration. * Add a new build/linux/system.gyp file with new 'settings' targets to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2. * Add depenedencies in the other targets on the new gtk, nss and pangoft2 'settings' targets from build/linux/system.gyp. * Add a pkg_config_wrapper.py script that keeps gyp happy by simply exiting 0 if the package isn't found. * DEPS roll for latest gyp changes to support the above. Review URL: http://codereview.chromium.org/42340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side of http://codereview.chromium.org/42394thomasvl@chromium.org2009-03-191-1/+2
| | | | | | | | | | | | | | | | - Remove the use of the mac specific type 'application' and use 'executable' with 'mac_bundle' set to 1. - update common.gypi to default mac_bundle to zero. - update common.gypi to look at mac_bundle for some of the base behaviors that were on 'application'. - Roll DEPS to get the new version of gyp w/ the matching support. Review URL: http://codereview.chromium.org/50015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build (and clean TestShell build).darin@chromium.org2009-03-191-4/+0
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/50022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12115 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate using_webkit.{scons,vsprops} in favor of having WebCommon.h set thedarin@chromium.org2009-03-192-4/+4
| | | | | | | | | | | | default configuration. This simplifies the build system. My concern was that some consumers of the API might mix-up the defines. R=dglazkov Review URL: http://codereview.chromium.org/42392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12110 0039d316-1c4b-4281-b951-d872f2087c98