| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
We spend a lot of time doing PNG encoding now for passing tests.
There's more work to be done for the --run-singly case still.
This seems to save another ~2minutes on Windows Release.
Review URL: http://codereview.chromium.org/79035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13911 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
makes bug entries for them. This cleans up --lint-test-files.
Review URL: http://codereview.chromium.org/79034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13904 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
results because the font matching is so close. Only one test needed
rebaselining.
http://trac.webkit.org/changeset/42549
The Windows side change was r13900.
Review URL: http://codereview.chromium.org/79033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13902 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
This was caused by http://trac.webkit.org/changeset/42549 upstream.
Will rebaseline on linux in the next change.
Review URL: http://codereview.chromium.org/79030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13900 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13889 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/79027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13886 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/42579
ScriptController::createInlineEventListener was changed to take
4 params instead of 3, so I updated the V8 ScriptController
to do the same. We don't seem to need the extra arg because both
v8_proxy::createSVGEventHandler and
v8_proxy::createInlineEventListener are identical.
Also one new .cpp/.h file from
http://trac.webkit.org/changeset/42580
Review URL: http://codereview.chromium.org/79008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
It had 200 seconds on the linux bot and still failed
on one run and passed on another in 1.1 seconds.
Review URL: http://codereview.chromium.org/67231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13875 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checkin, I'll add a ton of slow tests and reduce the timeout for non-slow tests to something like 1 second.
To aid in that, I've added 90th percentile and 99th percentile times to the statistics we report. Also made it so that tests marked as slow and timeout/crash tests are listed separately from the slowest 50 tests so that list can be used to know which tests to mark slow.
Tests cannot be marked as both SLOW and TIMEOUT. If the test times out, then we want it to timeout early to avoid waiting a long timeout for a test that we know is just going to timeout.
TestShell can now do per-test timeouts. We could easily make run-webkit-tests do per-test timeouts, but I think just having the one modifier of SLOW is easier to grok. Makes the test lists simpler and allows for having longer timeouts on debug/purify builders.
BUG=9324
Review URL: http://codereview.chromium.org/67198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13867 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
NPP_HandleEvent, as it might have gone away depending on JavaScript that was executed by the plugin.
BUG=9955
Review URL: http://codereview.chromium.org/75026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13858 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inlineBoxWrapperNullCheck.html is a test that changed due to drawRect.
generated.html is the same output as windows, just with anti-aliased
fonts on linux.
The other three (bug56201 bug23847 008) are tests that have checksums
checked in, but no png. I'm checking in the pngs so they're there
for comparison.
Review URL: http://codereview.chromium.org/75025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13849 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13828&r2=13827&pathrev=13828
TBR=brettw
Review URL: http://codereview.chromium.org/77005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13846 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, I removed the GetWebFrame method on WebDataSource since it is not
actually needed.
Removed some dead-code from webframe_impl.cc.
Removed some bogus null-checking of WebCore::Frame::loader().
R=dglazkov
Review URL: http://codereview.chromium.org/67169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13844 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
| |
(I think they were from a previous change).
Review URL: http://codereview.chromium.org/75018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13828 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
The --gdb flag isn't needed with the new way of handling crash reporting. I don't quite understand what the new code is doing, but I tried both a crashing test_shell and stepping past SuppressErrorReporting via gdb in xcode.
In addition to saving developer annoyance with ReportCrash popping up, this should considerably improve the performance of running the webkit tests.
Review URL: http://codereview.chromium.org/67193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13820 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is analogus to the windows rebaselines in r13815. This is from
the skia drawrect changes.
Also add inlineBoxWrapperNullCheck to the linux merge regression list and add timeout to the new video tests that are timing out on mac.
TBR=ojan
Review URL: http://codereview.chromium.org/67196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13817 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/41683 , we accidentally
broke the skia drawRect method. E.g., images that fail to load
didn't get an outline. This was landed in a merge and the
tests rebaselined to not have the rectangle (there were other
skia changes so this was missed). In
http://trac.webkit.org/changeset/42547 , we restored the rectangle,
so this is me rebaselining on windows.
I manually verified that these only change borders. I spot-checked
a few upstream mac results and this seems to match.
Linux is coming next.
Review URL: http://codereview.chromium.org/75024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13815 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13809 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r12179 makes painting always call DidMove(), even when the plugin hasn't moved,
in case the cutout rects need to change. DidMove() on Linux test_shell causes
the window to invalidate, causing an endless cycle of repaints.
r12179: http://src.chromium.org/viewvc/chrome?view=rev&revision=12179
This code will be very different in the real multiproc case, so this is just
the minimal change to make test_shell work again.
BUG=10059
Review URL: http://codereview.chromium.org/67147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13804 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/67192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13802 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13800 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/75016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13797 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13793 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13789 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13774 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=9850
Review URL: http://codereview.chromium.org/69005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13729 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
id and the path not existing non-fatal. There are too many false positives in those cases to
stop webkit tests from running for those errors.
Also add a bit more error checking that the modifiers for a test are valid.
Review URL: http://codereview.chromium.org/73049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13712 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/69008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13710 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13708 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
Also remove some tests that have passed consistently in the last ~30 runs.
BUG=none
TEST=covered by buildbot
Review URL: http://codereview.chromium.org/73050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13706 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13673 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
bugs and not marked as WONTFIX.
The bugs have already been created, this just updates the expectations file.
R=ojan
Review URL: http://codereview.chromium.org/73026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13663 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Prints these for the time spent in test_shell and the time
spent doing each diff comparison.
Also removes the check to compute statistics only in debug mode.
That was an overoptimization (computing the statistics takes ~100ms).
Review URL: http://codereview.chromium.org/73017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13638 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/67110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13633 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
| |
9798 and 9797 bugs alphanumerically.
Review URL: http://codereview.chromium.org/67090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13630 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put LayoutTests/compositing/overflow/overflow-positioning.html back in for
Linux, removed accidentally.
File a new bug for non-shadow-related merge 43264:42403 regressions and move
those three tests into it.
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/67103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13625 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
that now pass after http://codereview.chromium.org/59006 .
This CL should be the last change needed to fix http://code.google.com/p/chromium/issues/detail?id=9581
Review URL: http://codereview.chromium.org/73011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13621 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
We compiled before, but we'd crash with missing symbols when test_shell tried to load it. I also ported some bits of code, and added comments to the other bits that need porting.
Review URL: http://codereview.chromium.org/73015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13620 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/69002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13614 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r13555
Log:
Remove the Activex shim registration for generic Activex controls. The Activex shim only handles windows media
player in the wild and will continue to do so for the forseeable future.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which is basically related to our NPAPI plugin
installer not getting instantiated on pages which instantiated flash using an object tag, which would result in
webkit attempting to instantiate the activex shim. The shim only loads the windows media player classid, thus causing
this issue.
Added a test shell test which tests whether the default plugin loaded correctly. This is done by attempting to instantiate
a special mime type application/chromium-test-default-plugin, which serves as an indicator to the default plugin to
call a function in the page indicating that the test succeeded. I also made a change to ensure that the default plugin
is loaded in test_shell_tests.
Removed the activexshim dll project from chrome.sln
Bug=8584
New Revision: 13558
Log:
Removing the Activex shim plugin from the list of default plugins caused some activex shim tests to fail. This basically
fails for pages which instantiate the media player like an activex only. To handle this case we attempt to map the clsid
to a NPAPI mime type if possible in the shim. If we succeed then the shim is instantiated as an NPAPI plugin as before.
It internally loads the media player activex.
The other changes are to ensure that the default plugin is only enabled in test_shell for windows for now.
Bug=8584
Review URL: http://codereview.chromium.org/72004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13610 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Also add back a line that was deleted in 13529. The comment of 13529
does not talk about this, and the rietveld link shows a diff that does
not include this change either. It looks like what got submitted is not
what was reviewed.
Review URL: http://codereview.chromium.org/72001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13576 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
tests and the test_shell_tests on linux.
PLEASE back yourself out when you see you can't fix
a bug instead of leaving it red for days.
Review URL: http://codereview.chromium.org/67074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13575 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Activex shim only handles windows media
player in the wild and will continue to do so for the forseeable future.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which is basically related to our NPAPI plugin
installer not getting instantiated on pages which instantiated flash using an object tag, which would result in
webkit attempting to instantiate the activex shim. The shim only loads the windows media player classid, thus causing
this issue.
Added a test shell test which tests whether the default plugin loaded correctly. This is done by attempting to instantiate
a special mime type application/chromium-test-default-plugin, which serves as an indicator to the default plugin to
call a function in the page indicating that the test succeeded. I also made a change to ensure that the default plugin
is loaded in test_shell_tests.
Removed the activexshim dll project from chrome.sln
Bug=8584
Review URL: http://codereview.chromium.org/63151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13555 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
Includes change to v8_proxy.cpp to account for addition of
MessagePortProxy class.
Review URL: http://codereview.chromium.org/66062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13553 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that histograms move data from renderer to browser, there
is less reason to connect to stats counters.
Stats counters were using shared memory, and now they may
plausibly use the histogram's IPC mechanism instead to
move data to the browser. The first step is remove the
inheritance, and teh next (plausible/future) step
would be to implement counters as histograms with only
one bucket.
r=mbelshe
Review URL: http://codereview.chromium.org/66029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
I measured a ~10ms startup regression when the DLLs are not present and a ~20ms
regression when the DLLs are present and loaded in render_process.cc.
Not sure how else to tackle this problem since we need these DLLs loaded before
the sandbox is engaged.
Review URL: http://codereview.chromium.org/63101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13542 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
is basically a webkit+v8+helpers to simulate separate process with worker v8 threads. This is similar way we do on Win32.
Review URL: http://codereview.chromium.org/66043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13537 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
rebaselined upstream.
Updates to test_expectations for fixes after that merge.
BUG=9924
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/67047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13529 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
from recent merge. This test has been consistently failing on
LINUX. Also, LayoutTests/http/tests/misc/image-blocked-src-change.html
just failed on a MAC, so I'm marking it flakey on all platforms.
BUG=none
TBR=pamg
TEST=none
Review URL: http://codereview.chromium.org/66034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13505 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
without GTK.
I had to recreate this patch as my workspace for various
resonds. UGH!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/67024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
|