| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR since this breaks the layout test dashboard.
Review URL: http://codereview.chromium.org/401008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ager
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/397022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the layout test dashboard. Tries to be conservative and not update
in any cases that are questionable.
Cases that don't currently end up modifying test_expectations:
1. Tests that aren't already listed in test_expectations don't get added.
2. Tests that have expectations listed by directory don't get modified.
In order to use the script.
1. Go to http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#expectationsUpdate=true
2. Copy-paste that JSON into a local file.
3. python update_expectations_from_dashboard.py --update-json-file path/to/local/file
I'll document those steps on the dashboard page itself once I'm comfortable
enough with other people using it.
test_expectations.py changes:
1. Consolidate line parsing logic between
running webkit tests, rebaseline script and this script.
2. Add a way to suppress lint errors (for testing)
3. Add a way to pass in test expectations as a string instead of
a file path, again, for testing.
Review URL: http://codereview.chromium.org/385110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/399017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17398
TEST=none
Patch by kinuko@g
Original review URL: http://codereview.chromium.org/396008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline differences are due to KURL/GURL implementation disagrements.
R=brettw
BUG=27548
TEST=none
Review URL: http://codereview.chromium.org/391083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27683
BUG=27164
TBR=ananta
TEST=none
Review URL: http://codereview.chromium.org/391082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
linux, win.
TBR: erikkay, idana
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/50851
R=japhet
BUG=27555
TEST=none
Review URL: http://codereview.chromium.org/399008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=unit_tests
Patch by Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/375016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
It makes it more sane to view and serves it's primary purpose (addressing flakiness!).
Review URL: http://codereview.chromium.org/396004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to IMAGE (or) TEXT, since mac only fails on image while linux and win fail also on text.
TBR: idana@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The differences reflect KURL and GURL implementation differences.
R=brettw
TEST=none
BUG=27548
Review URL: http://codereview.chromium.org/391077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a new test added in WebKit r50869.
BUG=27555
TEST=none
Review URL: http://codereview.chromium.org/397007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This test was converted to a dumpAsText test in WebKit changeset 50813. Now it should pass in Chromium.
BUG=10280
TEST=none
Review URL: http://codereview.chromium.org/385062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to set register_cygwin.
Disbale wss server for now. We need to install pyOpenSSL on buildbots
and we don't have any tests that requires wss now.
BUG=27556
TEST=layout_* bots succeed
Review URL: http://codereview.chromium.org/385131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bots. If you add '#buildDir=Debug' or '#buildDir=Release' to the URL
it will load files from 'src/webkit/$buildDir/layout-test-results'.
BUG=none
R=ojan@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/391041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=michaeln
Review URL: http://codereview.chromium.org/396005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/384118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/384135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests. These were landed in webkit
as fixes for bug https://bugs.webkit.org/show_bug.cgi?id=31067
The layout test plugin changes are on similar lines as the version upstream.
We need to rebaseline the expectations as the line numbers differ in test shell and dumprendertree.
The document-open.html crashes in test_shell as this test causes the existing document to be taken down
which takes down the plugin instance and the associated plugin stream. This works in the webkit plugin
implementation as they grab a reference on the plugin stream before calling into the plugin to protect
from the stream being destroyed.
Our fix is on similar lines.
Bug=27164
Review URL: http://codereview.chromium.org/393017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I spot checked a random sample of these to make sure it was
actually doing the right thing. Will send out the script for this shortly.
There's a few categories the script doesn't touch yet:
1. Tests that need both SLOW/TIMEOUT need manual attention
2. Tests that have passed for the past 750 runs are not updated
3. Tests that are not listed in test_expectations already don't get added
2 and 3 will come in following changes. For now, I want to make
the test_expectations changes as contained as possible.
Review URL: http://codereview.chromium.org/384037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_expectations. For those tests, we just say that the expectations they're
currently listed with are "extra".
Also reduce the MIN_RUNS_FOR_FLAKE to 2. If a test has the same results
twice in a row, assume it's not flakiness. In the cases where a test
is so flaky that sometimes it has the same results twice in a row, it'll
show up as flakiness due to other runs.
Review URL: http://codereview.chromium.org/393018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes http://codereview.chromium.org/394008 which restores
interactive tests for devtools.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/386029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by Kinuko Yasuda <kinuko@google.com>.
Original review URL: http://codereview.chromium.org/385033
R=victorw,wtc
BUG=20566
TEST=none
Review URL: http://codereview.chromium.org/394012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are necessary due to differences in GURL and KURL implementations (our's right).
R=brettw
TEST=none
BUG=27548
Review URL: http://codereview.chromium.org/387052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when we follow a redirect, because WebKit's
MainResourceLoader::willSendRequest method may change the "first party for
cookies" URL of the resource request.
R=abarth
BUG=25133
TEST=In Options menu, change cookie policy to "Accept cookies only from
sites I visit" and then follow the instructions in issue 25133 comment 20.
Review URL: http://codereview.chromium.org/385024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=scherkus@chromium.org
BUG=27569
TEST=LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
Review URL: http://codereview.chromium.org/393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=31373
R=dglazkov@chromium.org
BUG=10274
TEST=LayoutTests/fast/dom/Window/window-screen-properties.html
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=levin@chromium.org
BUG=none
TEST=LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem.html
Review URL: http://codereview.chromium.org/393015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Changes yasm to be built for host instead of target.
Also don't need to depend on yasm if build ing for arm.
Review URL: http://codereview.chromium.org/387023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22014
TEST=LayoutTests/http/tests/loading/redirectwith-no-location-crash.html
Checked in for Kinuko Yasuda
Original review: http://codereview.chromium.org/384082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some text expectation fixes.
TBR=brettw@chromium.org
BUG=27555
TEST=None
Review URL: http://codereview.chromium.org/384119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/391049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in subtle and devious ways.
Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln,
which occured unbeknownst to the builders who continued to build webkit.sln
for most of the day. This wasn't an issue until we did a WebKit roll, where
the trickery was discovered and hell broke loose.
TBR=yaar
TEST=green bots
BUG=none
Review URL: http://codereview.chromium.org/385084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After the WK roll, 750 unexpected crashes are happening,
so it is being reverted.
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/384111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the WK roll, 750 unexpected crashes are happening,
so it is being reverted.
Review URL: http://codereview.chromium.org/391043
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/387046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the failure on Mac, but apparently Linux's TEXT-only failure doesn't get
covered by this rule. Trying "IMAGE TEXT" instead of "IMAGE+TEXT" to see if it
fixes the problem.
TEST=this is a friggin test
BUG=none
Review URL: http://codereview.chromium.org/391043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and naming files according to the row ID of the respective DB in the
tracker database. Also, fixing a bug: caching the renderer process
handle in DatabaseDispatcherHost after it was set in
ResourceMessageFilter.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/392009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/387040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Partial revert of http://codereview.chromium.org/387034
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/391038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=5406
BUG=none
TEST=tools/valgrind/chrome_tests.sh -t test_shell --gtest_filter=WebkitGlueTest.\*
Review URL: http://codereview.chromium.org/391026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in issue tracker. A couple of tests don't seem to fail any more so I
deleted them (in this change). The rest are bugs that need to be
reopened.
R=dglazkov@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/387034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/386016
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/384074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
been fixed and it looks arial to me now.
BUG=10277
TEST=none
Patch by kinuko@g
Original review: http://codereview.chromium.org/384043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31766 0039d316-1c4b-4281-b951-d872f2087c98
|