summaryrefslogtreecommitdiffstats
path: root/webkit
Commit message (Collapse)AuthorAgeFilesLines
* Fix printing of expectations in the generated HTML when runningojan@chromium.org2009-04-181-3/+3
| | | | | | | webkit tests. Review URL: http://codereview.chromium.org/67275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13990 0039d316-1c4b-4281-b951-d872f2087c98
* Fix duplicate expectations. TBR.ojan@chromium.org2009-04-181-38/+19
| | | | | | Review URL: http://codereview.chromium.org/67277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13989 0039d316-1c4b-4281-b951-d872f2087c98
* An initial batch of slow tests. I took all the testsojan@chromium.org2009-04-171-0/+22
| | | | | | | | | that took >=5 seconds on a run of the release bots. I'd like to take the timeout for release down to 5 seconds. TBR. Review URL: http://codereview.chromium.org/79065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13986 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of style issues.michaeln@google.com2009-04-174-8/+9
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/67259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13978 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork Inspector, Chromium side.dglazkov@google.com2009-04-178-14/+117
| | | | | | | | R=darin Review URL: http://codereview.chromium.org/67052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13975 0039d316-1c4b-4281-b951-d872f2087c98
* Restore a line in test expectations. Not sure why this got changed.ericroman@google.com2009-04-171-2/+2
| | | | | | | | TBR=awalker Review URL: http://codereview.chromium.org/79058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix error suppressing. It turns out that both the signal handlingojan@chromium.org2009-04-173-1/+15
| | | | | | | | | | and the exception port bits are needed to avoid the crash reporter. There are still cases we miss. I was able to hit a TestShell that popped up the crash reporter running the tests, but I was only able to hit it once. Review URL: http://codereview.chromium.org/67270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13972 0039d316-1c4b-4281-b951-d872f2087c98
* Quickfix to the v8 code generator to properly handle combination of ↵ericroman@google.com2009-04-171-0/+8
| | | | | | | | "CustomGetter" + "Replaceable". Review URL: http://codereview.chromium.org/67261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13968 0039d316-1c4b-4281-b951-d872f2087c98
* Add rebaselines, missed from the merge commit.dglazkov@google.com2009-04-179-0/+53
| | | | | | | | TBR=levin Review URL: http://codereview.chromium.org/79052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13966 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 42580:42609, Chromium side.dglazkov@google.com2009-04-1758-111/+73
| | | | | | | | | | | | | | | | Changes to ScriptController, glue due to http://trac.webkit.org/changeset/42583 Test rebaselines due to: * http://trac.webkit.org/changeset/42599 * http://trac.webkit.org/changeset/42583 * http://trac.webkit.org/changeset/42600 * http://trac.webkit.org/changeset/42586 R=levin Review URL: http://codereview.chromium.org/79038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13965 0039d316-1c4b-4281-b951-d872f2087c98
* Rename AllowCrossOriginAccessHack to GrantUniversalAccess, and move the HACKmpcomplete@google.com2009-04-173-7/+6
| | | | | | | warnings to the callsite. Review URL: http://codereview.chromium.org/79028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13953 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 10573: Dismissing Find-in page doesn't set focusfinnur@chromium.org2009-04-171-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | to the link found. We no longer use the selection controller to highlight the active match. Before this change, the focus would not be set if the user had changed the selection. After this change, the focus will be set unless the user has selected something on the page. I also wrote an in-browser unit test for this to catch this regression in the future, but it is disabled due to problem with running multiple in-process browser tests in a row (teardown problem). BUG=10573 TEST=Covered by in process browser test now, see bug for repro steps. Review URL: http://codereview.chromium.org/79024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in the kill -9 in the hopes that it fixes hanging TestShells on mac ↵ojan@google.com2009-04-171-0/+3
| | | | | | | | bots. Review URL: http://codereview.chromium.org/77009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13914 0039d316-1c4b-4281-b951-d872f2087c98
* Only dump image results if the hashes don't match.ojan@google.com2009-04-175-20/+56
| | | | | | | | | | We spend a lot of time doing PNG encoding now for passing tests. There's more work to be done for the --run-singly case still. This seems to save another ~2minutes on Windows Release. Review URL: http://codereview.chromium.org/79035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13911 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make all devtools messages dispatch through debugger interrupt.pfeldman@chromium.org2009-04-178-26/+74
| | | | | | Review URL: http://codereview.chromium.org/73002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13910 0039d316-1c4b-4281-b951-d872f2087c98
* Mark pending/ and chrome/ bugs as BUG_GWILSON until someonetc@google.com2009-04-171-22/+22
| | | | | | | | | makes bug entries for them. This cleans up --lint-test-files. Review URL: http://codereview.chromium.org/79034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13904 0039d316-1c4b-4281-b951-d872f2087c98
* Linux side rebaseline for upstream changes. These match the windowstc@google.com2009-04-163-14/+1
| | | | | | | | | | | | | | results because the font matching is so close. Only one test needed rebaselining. http://trac.webkit.org/changeset/42549 The Windows side change was r13900. Review URL: http://codereview.chromium.org/79033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13902 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests where the output changed upstream.tc@google.com2009-04-1614-258/+226
| | | | | | | | | | This was caused by http://trac.webkit.org/changeset/42549 upstream. Will rebaseline on linux in the next change. Review URL: http://codereview.chromium.org/79030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13900 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two nits that arrived after checkindkegel@google.com2009-04-161-3/+2
| | | | | | Review URL: http://codereview.chromium.org/67230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo. Fixes --run-singly option of run_webkit_tests. TBR.ojan@google.com2009-04-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/67238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13889 0039d316-1c4b-4281-b951-d872f2087c98
* Mark tests that are failing from the merge. I'm investingating now.tc@google.com2009-04-161-0/+11
| | | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/79027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13886 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of webkit merge from 42547 to 42580.tc@google.com2009-04-167-24/+17
| | | | | | | | | | | | | | | | In http://trac.webkit.org/changeset/42579 ScriptController::createInlineEventListener was changed to take 4 params instead of 3, so I updated the V8 ScriptController to do the same. We don't seem to need the extra arg because both v8_proxy::createSVGEventHandler and v8_proxy::createInlineEventListener are identical. Also one new .cpp/.h file from http://trac.webkit.org/changeset/42580 Review URL: http://codereview.chromium.org/79008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
* linux: users of glue require GTK in the include path.evan@chromium.org2009-04-162-0/+6
| | | | | | Review URL: http://codereview.chromium.org/79018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13876 0039d316-1c4b-4281-b951-d872f2087c98
* Add some flaky tests. Mark dns-prefetch-control as slow.ojan@google.com2009-04-161-5/+9
| | | | | | | | It had 200 seconds on the linux bot and still failed on one run and passed on another in 1.1 seconds. Review URL: http://codereview.chromium.org/67231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13875 0039d316-1c4b-4281-b951-d872f2087c98
* JavaScriptCore is not using the webkit common defines.mbelshe@google.com2009-04-161-1/+1
| | | | | | | | | | | | | | In particular the USE_SYSTEM_MALLOC macros aren't properly defined. This turns out to be benign in our current builds, but will be significant with my future checkins. Overall, this checkin doesn't change anything, except to get the right definitions in place for JSC. Review URL: http://codereview.chromium.org/79014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13871 0039d316-1c4b-4281-b951-d872f2087c98
* Add concept of slow tests. Only mark one test as slow for now. After ↵ojan@google.com2009-04-165-100/+198
| | | | | | | | | | | | | | | | checkin, I'll add a ton of slow tests and reduce the timeout for non-slow tests to something like 1 second. To aid in that, I've added 90th percentile and 99th percentile times to the statistics we report. Also made it so that tests marked as slow and timeout/crash tests are listed separately from the slowest 50 tests so that list can be used to know which tests to mark slow. Tests cannot be marked as both SLOW and TIMEOUT. If the test times out, then we want it to timeout early to avoid waiting a long timeout for a test that we know is just going to timeout. TestShell can now do per-test timeouts. We could easily make run-webkit-tests do per-test timeouts, but I think just having the one modifier of SLOW is easier to grok. Makes the test lists simpler and allows for having longer timeouts on debug/purify builders. BUG=9324 Review URL: http://codereview.chromium.org/67198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13867 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break due to incorrect merge, TBR=awalkerjam@chromium.org2009-04-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13860 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we check the page pointer before using it after we come out of ↵jam@chromium.org2009-04-168-42/+88
| | | | | | | | | | NPP_HandleEvent, as it might have gone away depending on JavaScript that was executed by the plugin. BUG=9955 Review URL: http://codereview.chromium.org/75026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13858 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some tests on linux.tc@google.com2009-04-1610-6/+40
| | | | | | | | | | | | | | | | inlineBoxWrapperNullCheck.html is a test that changed due to drawRect. generated.html is the same output as windows, just with anti-aliased fonts on linux. The other three (bug56201 bug23847 008) are tests that have checksums checked in, but no png. I'm checking in the pngs so they're there for comparison. Review URL: http://codereview.chromium.org/75025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13849 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Supported 'lookup' and 'evaluate' requests in the front end.yurys@google.com2009-04-162-19/+247
| | | | | | | 2. Lookup object properties before expanding them in the sidebar. Review URL: http://codereview.chromium.org/69013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13848 0039d316-1c4b-4281-b951-d872f2087c98
* remove tests that accidentally got re-added:tc@google.com2009-04-161-85/+0
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13828&r2=13827&pathrev=13828 TBR=brettw Review URL: http://codereview.chromium.org/77005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13846 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to support WebKit API changes.darin@chromium.org2009-04-167-67/+12
| | | | | | | | | | | | | | | Also, I removed the GetWebFrame method on WebDataSource since it is not actually needed. Removed some dead-code from webframe_impl.cc. Removed some bogus null-checking of WebCore::Frame::loader(). R=dglazkov Review URL: http://codereview.chromium.org/67169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13844 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my rebaseline of these tests. I made a mistake in checking these inbrettw@chromium.org2009-04-165-5/+86
| | | | | | | (I think they were from a previous change). Review URL: http://codereview.chromium.org/75018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a painting problem observed with windowless flash plugins, when they are ↵ananta@chromium.org2009-04-162-19/+8
| | | | | | | | | | | | | | | | | | | | | | | | | initially created with a zero clip rect, which eventually changes to a non zero clip rect. We don't send over geometry updates to the plugin if the window dimensions don't change, which is true in this case. This causes the plugin process to not send over paints to the renderer process as the plugin clip rect remains zero. The fix based on a discussion with John is to remove the check for whether the plugin dimensions changed and always send over the update geometry IPC to the plugin, where we do check whether these rects changed before calling the underlying plugin. This fixes bug http://code.google.com/p/chromium/issues/detail?id=10536 I am trying to come up with a unit test for this case. Will add it to this CB or submit those as a separate CB. Bug=10536 Review URL: http://codereview.chromium.org/73071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SupressErrorReporting on the mac and remove --gdb flag from test_shell. ↵ojan@google.com2009-04-164-26/+23
| | | | | | | | | | The --gdb flag isn't needed with the new way of handling crash reporting. I don't quite understand what the new code is doing, but I tried both a crashing test_shell and stepping past SuppressErrorReporting via gdb in xcode. In addition to saving developer annoyance with ReportCrash popping up, this should considerably improve the performance of running the webkit tests. Review URL: http://codereview.chromium.org/67193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13820 0039d316-1c4b-4281-b951-d872f2087c98
* Per Mark's request, add back the CPU type on Linuxdkegel@google.com2009-04-161-2/+20
| | | | | | | | | | | the way Firefox does it. While I've got your attention: how bad an idea would it be to (for nonofficial builds only) append 'r' and the svn revision number to the chrome version? Review URL: http://codereview.chromium.org/67146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13819 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests on linux side.tc@google.com2009-04-16140-160/+78
| | | | | | | | | | | | | | This is analogus to the windows rebaselines in r13815. This is from the skia drawrect changes. Also add inlineBoxWrapperNullCheck to the linux merge regression list and add timeout to the new video tests that are timing out on mac. TBR=ojan Review URL: http://codereview.chromium.org/67196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13817 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a bunch of tests after the merge.tc@google.com2009-04-16167-167/+167
| | | | | | | | | | | | | | | | | | | In http://trac.webkit.org/changeset/41683 , we accidentally broke the skia drawRect method. E.g., images that fail to load didn't get an outline. This was landed in a merge and the tests rebaselined to not have the rectangle (there were other skia changes so this was missed). In http://trac.webkit.org/changeset/42547 , we restored the rectangle, so this is me rebaselining on windows. I manually verified that these only change borders. I spot-checked a few upstream mac results and this seems to match. Linux is coming next. Review URL: http://codereview.chromium.org/75024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13815 0039d316-1c4b-4281-b951-d872f2087c98
* Make HTMLSelectElement and HTMLOptionsCollection return collections of optionsdavemoore@chromium.org2009-04-163-9/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | elements if there are multiple options that share a name. Currently Safari and chromium differ in their behavior in this area. Safari returns multiple options in a collection if necessary, but only for HTMLOptionsCollection. For HTMLSelectElement it always returns null. Chromium returns a single option no matter what, but for both HTMLSelectElement and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit cache. The HTML5 doc states that a collection should be returned if necessary for both. The relevant parts of the spec are: http://dev.w3.org/html5/spec/Overview.html#the-select-element and http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0 So if you have: <select id="sl1"><option value="Value" name="test" /></select> and in JS code you do: var test = document.getElementById("sl1").test test should be a single HTMLOptionElement. If instead you have: <select id="sl2"><option value="Value1" name="test" /><option value="Value2" name="test" /></select> test should be a collection with 2 HTMLOptionElements. This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against webkit, with a new layout test to confirm the behavior Review URL: http://codereview.chromium.org/69014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13814 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a few more tests that are passing on the bots. TBR.ojan@google.com2009-04-151-4/+0
| | | | | | Review URL: http://codereview.chromium.org/75019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13809 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make windowless plugins work again after r12179 regressed it.evan@chromium.org2009-04-152-8/+28
| | | | | | | | | | | | | | | | | r12179 makes painting always call DidMove(), even when the plugin hasn't moved, in case the cutout rects need to change. DidMove() on Linux test_shell causes the window to invalidate, causing an endless cycle of repaints. r12179: http://src.chromium.org/viewvc/chrome?view=rev&revision=12179 This code will be very different in the real multiproc case, so this is just the minimal change to make test_shell work again. BUG=10059 Review URL: http://codereview.chromium.org/67147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13804 0039d316-1c4b-4281-b951-d872f2087c98
* Mark regressions from the merge. I'm investigating now.tc@google.com2009-04-151-0/+85
| | | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/67192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13802 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of webkit merge from r42523 to r42547.tc@google.com2009-04-154-0/+32
| | | | | | Review URL: http://codereview.chromium.org/75012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13800 0039d316-1c4b-4281-b951-d872f2087c98
* Flag some Windows layout tests as failing.mmoss@chromium.org2009-04-151-0/+4
| | | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/75016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13797 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert "Miscellaneous API sprucing."aa@chromium.org2009-04-153-15/+0
| | | | | | | | This reverts commit 052b8f424d1550deebf3dc562d7c47dde72d7f76. Review URL: http://codereview.chromium.org/78001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13796 0039d316-1c4b-4281-b951-d872f2087c98
* Had a duplicate expectation. TBR to fix mac release build.ojan@google.com2009-04-151-1/+0
| | | | | | Review URL: http://codereview.chromium.org/75013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13793 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous API sprucing.aa@chromium.org2009-04-153-0/+15
| | | | | | | | | | | | | - Camel-case event names. - Rename chromium.self in content scripts to chromium.extension. - Move onConnect in extension process to chromium.self.onConnect. - Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API. - Make toolstrips not wrap by default - Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack. Review URL: http://codereview.chromium.org/67162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13792 0039d316-1c4b-4281-b951-d872f2087c98
* Add a hack to enable cross-origin XHR for all pages with a "chrome-extension"mpcomplete@google.com2009-04-153-0/+14
| | | | | | | | URL as the toplevel frame. This is a temporary workaround until we can do it the proper way, which requires a webkit refactoring in progress by Alexei. Review URL: http://codereview.chromium.org/67153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13790 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to better match state of the tree. TBR.ojan@google.com2009-04-151-8/+19
| | | | | | Review URL: http://codereview.chromium.org/75009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash for <audio>hclam@chromium.org2009-04-151-1/+6
| | | | | | | | | | | | WebKit doesn't provide a FrameView for <audio> in MediaPlayer which is need for us to create a WebMediaPlayerDelegateImpl, so don't rely on MediaPlayer::m_frameView but static_cast MediaPlayer::m_mediaPlayerClient to HTMLMediaElement and gets FrameView from it's Document object. Review URL: http://codereview.chromium.org/69012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13782 0039d316-1c4b-4281-b951-d872f2087c98