| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
webkit tests.
Review URL: http://codereview.chromium.org/67275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that took >=5 seconds on a run of the release bots.
I'd like to take the timeout for release down to 5 seconds.
TBR.
Review URL: http://codereview.chromium.org/79065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/67259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/67052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awalker
Review URL: http://codereview.chromium.org/79058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and the exception port bits are needed to avoid the crash
reporter. There are still cases we miss. I was able to hit
a TestShell that popped up the crash reporter running the tests,
but I was only able to hit it once.
Review URL: http://codereview.chromium.org/67270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"CustomGetter" + "Replaceable".
Review URL: http://codereview.chromium.org/67261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/79052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to ScriptController, glue due to http://trac.webkit.org/changeset/42583
Test rebaselines due to:
* http://trac.webkit.org/changeset/42599
* http://trac.webkit.org/changeset/42583
* http://trac.webkit.org/changeset/42600
* http://trac.webkit.org/changeset/42586
R=levin
Review URL: http://codereview.chromium.org/79038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
warnings to the callsite.
Review URL: http://codereview.chromium.org/79028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the link found.
We no longer use the selection controller to
highlight the active match. Before this change,
the focus would not be set if the user had changed
the selection. After this change, the focus will
be set unless the user has selected something on
the page.
I also wrote an in-browser unit test for this to
catch this regression in the future, but it is
disabled due to problem with running multiple
in-process browser tests in a row (teardown
problem).
BUG=10573
TEST=Covered by in process browser test now, see
bug for repro steps.
Review URL: http://codereview.chromium.org/79024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bots.
Review URL: http://codereview.chromium.org/77009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We spend a lot of time doing PNG encoding now for passing tests.
There's more work to be done for the --run-singly case still.
This seems to save another ~2minutes on Windows Release.
Review URL: http://codereview.chromium.org/79035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
makes bug entries for them. This cleans up --lint-test-files.
Review URL: http://codereview.chromium.org/79034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
results because the font matching is so close. Only one test needed
rebaselining.
http://trac.webkit.org/changeset/42549
The Windows side change was r13900.
Review URL: http://codereview.chromium.org/79033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was caused by http://trac.webkit.org/changeset/42549 upstream.
Will rebaseline on linux in the next change.
Review URL: http://codereview.chromium.org/79030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/79027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/42579
ScriptController::createInlineEventListener was changed to take
4 params instead of 3, so I updated the V8 ScriptController
to do the same. We don't seem to need the extra arg because both
v8_proxy::createSVGEventHandler and
v8_proxy::createInlineEventListener are identical.
Also one new .cpp/.h file from
http://trac.webkit.org/changeset/42580
Review URL: http://codereview.chromium.org/79008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/79018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It had 200 seconds on the linux bot and still failed
on one run and passed on another in 1.1 seconds.
Review URL: http://codereview.chromium.org/67231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular the USE_SYSTEM_MALLOC macros aren't properly defined.
This turns out to be benign in our current builds, but will be significant
with my future checkins.
Overall, this checkin doesn't change anything, except to get the right
definitions in place for JSC.
Review URL: http://codereview.chromium.org/79014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checkin, I'll add a ton of slow tests and reduce the timeout for non-slow tests to something like 1 second.
To aid in that, I've added 90th percentile and 99th percentile times to the statistics we report. Also made it so that tests marked as slow and timeout/crash tests are listed separately from the slowest 50 tests so that list can be used to know which tests to mark slow.
Tests cannot be marked as both SLOW and TIMEOUT. If the test times out, then we want it to timeout early to avoid waiting a long timeout for a test that we know is just going to timeout.
TestShell can now do per-test timeouts. We could easily make run-webkit-tests do per-test timeouts, but I think just having the one modifier of SLOW is easier to grok. Makes the test lists simpler and allows for having longer timeouts on debug/purify builders.
BUG=9324
Review URL: http://codereview.chromium.org/67198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPP_HandleEvent, as it might have gone away depending on JavaScript that was executed by the plugin.
BUG=9955
Review URL: http://codereview.chromium.org/75026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inlineBoxWrapperNullCheck.html is a test that changed due to drawRect.
generated.html is the same output as windows, just with anti-aliased
fonts on linux.
The other three (bug56201 bug23847 008) are tests that have checksums
checked in, but no png. I'm checking in the pngs so they're there
for comparison.
Review URL: http://codereview.chromium.org/75025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
2. Lookup object properties before expanding them in the sidebar.
Review URL: http://codereview.chromium.org/69013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13828&r2=13827&pathrev=13828
TBR=brettw
Review URL: http://codereview.chromium.org/77005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, I removed the GetWebFrame method on WebDataSource since it is not
actually needed.
Removed some dead-code from webframe_impl.cc.
Removed some bogus null-checking of WebCore::Frame::loader().
R=dglazkov
Review URL: http://codereview.chromium.org/67169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(I think they were from a previous change).
Review URL: http://codereview.chromium.org/75018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initially created with a zero clip
rect, which eventually changes to a non zero clip rect. We don't send over geometry updates to the plugin
if the window dimensions don't change, which is true in this case.
This causes the plugin process to not send over paints to the renderer process as the plugin clip rect remains zero.
The fix based on a discussion with John is to remove the check for whether the plugin dimensions changed and always
send over the update geometry IPC to the plugin, where we do check whether these rects changed before calling the
underlying plugin.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=10536
I am trying to come up with a unit test for this case. Will add it to this CB or submit those as a separate
CB.
Bug=10536
Review URL: http://codereview.chromium.org/73071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The --gdb flag isn't needed with the new way of handling crash reporting. I don't quite understand what the new code is doing, but I tried both a crashing test_shell and stepping past SuppressErrorReporting via gdb in xcode.
In addition to saving developer annoyance with ReportCrash popping up, this should considerably improve the performance of running the webkit tests.
Review URL: http://codereview.chromium.org/67193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the way Firefox does it.
While I've got your attention: how bad an idea would
it be to (for nonofficial builds only)
append 'r' and the svn revision number to the chrome version?
Review URL: http://codereview.chromium.org/67146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is analogus to the windows rebaselines in r13815. This is from
the skia drawrect changes.
Also add inlineBoxWrapperNullCheck to the linux merge regression list and add timeout to the new video tests that are timing out on mac.
TBR=ojan
Review URL: http://codereview.chromium.org/67196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In http://trac.webkit.org/changeset/41683 , we accidentally
broke the skia drawRect method. E.g., images that fail to load
didn't get an outline. This was landed in a merge and the
tests rebaselined to not have the rectangle (there were other
skia changes so this was missed). In
http://trac.webkit.org/changeset/42547 , we restored the rectangle,
so this is me rebaselining on windows.
I manually verified that these only change borders. I spot-checked
a few upstream mac results and this seems to match.
Linux is coming next.
Review URL: http://codereview.chromium.org/75024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
elements if there are multiple options that share a name.
Currently Safari and chromium differ in their behavior in this area. Safari
returns
multiple options in a collection if necessary, but only for
HTMLOptionsCollection. For
HTMLSelectElement it always returns null.
Chromium returns a single option no matter what, but for both HTMLSelectElement
and HTMLOptionsCollection. It's also very slow at this, as it bypasses a webkit
cache.
The HTML5 doc states that a collection should be returned if necessary for both.
The relevant parts of the spec are:
http://dev.w3.org/html5/spec/Overview.html#the-select-element
and
http://dev.w3.org/html5/spec/Overview.html#htmloptionscollection-0
So if you have:
<select id="sl1"><option value="Value" name="test" /></select>
and in JS code you do:
var test = document.getElementById("sl1").test
test should be a single HTMLOptionElement.
If instead you have:
<select id="sl2"><option value="Value1" name="test" /><option value="Value2"
name="test" /></select>
test should be a collection with 2 HTMLOptionElements.
This bug: https://bugs.webkit.org/show_bug.cgi?id=25191 has been filed against
webkit, with a new layout test to confirm the behavior
Review URL: http://codereview.chromium.org/69014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r12179 makes painting always call DidMove(), even when the plugin hasn't moved,
in case the cutout rects need to change. DidMove() on Linux test_shell causes
the window to invalidate, causing an endless cycle of repaints.
r12179: http://src.chromium.org/viewvc/chrome?view=rev&revision=12179
This code will be very different in the real multiproc case, so this is just
the minimal change to make test_shell work again.
BUG=10059
Review URL: http://codereview.chromium.org/67147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/67192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/75016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 052b8f424d1550deebf3dc562d7c47dde72d7f76.
Review URL: http://codereview.chromium.org/78001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.
Review URL: http://codereview.chromium.org/67162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
URL as the toplevel frame. This is a temporary workaround until we can do it
the proper way, which requires a webkit refactoring in progress by Alexei.
Review URL: http://codereview.chromium.org/67153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/75009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit doesn't provide a FrameView for <audio> in MediaPlayer
which is need for us to create a WebMediaPlayerDelegateImpl,
so don't rely on MediaPlayer::m_frameView but static_cast
MediaPlayer::m_mediaPlayerClient to HTMLMediaElement and
gets FrameView from it's Document object.
Review URL: http://codereview.chromium.org/69012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13782 0039d316-1c4b-4281-b951-d872f2087c98
|