| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/175012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10398
TEST=green webkit builders
Review URL: http://codereview.chromium.org/178014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/177022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html for Windows and Linux. Chrome allows xhr's to local directories (if the security origin of the document is file://) and Safari does not, so when testXHRDirectory is run on Safari hits an error handler, but returns a real result in Chrome. Mac is still marked as failing because of unimplemented test shell features (See http://crbug.com/20458 for more details).
TEST=layout test try bots
BUG=20458,20450,18686
Review URL: http://codereview.chromium.org/173598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scrollbarsModeDidChange was also added to HostWindow.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/183001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new method to ChromeClient, so now ours doesn't compile. I'm not 100% sure
that doing nothing is the right course of action here, but it seems to be what
most ports are doing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
set by the DOM agent.
BUG=20482
Review URL: http://codereview.chromium.org/182009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sorry for a layout-test failure caused by my WebKit change.
I forgot sending this change that implements code that makes test_shell sends function-key events when submitting my WebKit change.
BUG=20332 "Need to implement the handling of function key values passed to EventSendingController::keyDown"
TEST=LayoutTests/fast/events/keydown-function-keys.html
Review URL: http://codereview.chromium.org/174601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/181004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19982
TEST=Assign @role=article on a DOM element. It will be exposed as MSAA role document.
Review URL: http://codereview.chromium.org/182006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeout on the mac.
TBR=wtc
BUG=20438
TEST=none
Review URL: http://codereview.chromium.org/173596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was a silly oops. I had intended to call clearPluginContainer on each
WebPluginLoadObserver held in WebPluginContainerImpl's m_pluginLoadObservers
array when the WebPluginContainerImpl is destroyed, but I never hooked that up.
Here it is.
R=jam
BUG=10036
TEST=layout test: chrome/plugins/get-url-with-iframe-target-no-crash.html
Review URL: http://codereview.chromium.org/182003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
We also ignore xpcom-related errors while loading plugins, as that
breaks layout tests.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
other issues as well.
BUG=10398
TEST=green webkit builders
Review URL: http://codereview.chromium.org/179007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests used to be flaky and now looks like stable.
The current results show it is a rebaselining issue.
TBR=dglazkov
TEST=layouy test
BUG=877986
Review URL: http://codereview.chromium.org/178006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now, if a builder isn't found, it won't spew a stack trace.
Also, fixed a problem with mis-reporting PNG diff failures.
BUG=none
TEST=Run test_output_formatter.py with a bogus builder, verify error message.
Review URL: http://codereview.chromium.org/176008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is not reproducible.
BUG=19519,20430
TEST=none
Review URL: http://codereview.chromium.org/182002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html. It never crashed on Windows or Mac, so this should have been limited to Linux anyway. Looking through flakyness dashboard for Linux release, it hasn't crashed in the last 100 runs. I also looked at the past 10 runs of Linux dbg. Pretty sure the crash was fixed by http://src.chromium.org/viewvc/chrome?view=rev&revision=23944.
TEST=none
BUG=18686
Review URL: http://codereview.chromium.org/176007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I just added this test, so the failure is probably not a regression.
TBR=wtc
BUG=20438
TEST=none
Review URL: http://codereview.chromium.org/177009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Fix bug in detecting whether expectations applied to a test.
foo/bar = PASS FAIL
MAC : foo/bar/baz.html = TIMEOUT
On WIN/LINUX, we would incorrectly think that there were
no expectations for foo/bar/baz.html because we'd see the
results for the mac and assume there were no others.
Review URL: http://codereview.chromium.org/178004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
these tests.
TBR=levin
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/173590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ROLE_SYSTEM_LISTITEM.
BUG=19982
TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively.
Review URL: http://codereview.chromium.org/173488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the file (with other lighthttpd issues). Old bug was just the webkit merge bug, updated to more specific bug.
TEST=none, no functional change
BUG=8941,9916
Review URL: http://codereview.chromium.org/177006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=20430
TEST=none
Review URL: http://codereview.chromium.org/175003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=none
BUG=16237
Review URL: http://codereview.chromium.org/173587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason
from WebFrameLoaderClient.
This CL also moves WebDataSourceImpl into webkit/api/src. That change was
needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it,
which WebFrameLoaderClient uses to communicate back to the WebPlugin upon
completion of the frame load.
WebViewDelegate::DidFinishLoadWithReason is modified to include url and
notify_data parameters, eliminating the URLRequestRouted method. This is done
so that we can support overlapping NPN_GetURLNotify targetting different
frames.
WebPluginContainer grows an executeScriptURL method to deal with javascript:
URLs.
NOTE: I'm working on some UI tests to better cover the case of overlapping
NPN_GetURLNotify calls.
R=jam
BUG=10036
TEST=none yet
Review URL: http://codereview.chromium.org/174514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/178003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8630
TBR=levin
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of them.
TBR=levin
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/176001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=14885
Review URL: http://codereview.chromium.org/173579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=18412
Review URL: http://codereview.chromium.org/174618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by decodeURLEscapeSequences.
See: https://bugs.webkit.org/show_bug.cgi?id=28767
TBR=darin (his original patch: http://codereview.chromium.org/174614)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r173550, due to WebKit failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/174617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20359
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/173575
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=20399
TEST=none
Review URL: http://codereview.chromium.org/174615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dimich
BUG=19635
TEST=none
Review URL: http://codereview.chromium.org/173573
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getting accessed
after it was invalidated.
This should fix the embed-tag.html and object-embed-tag.html layout test failures.
TBR=jam
Review URL: http://codereview.chromium.org/174598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24598 0039d316-1c4b-4281-b951-d872f2087c98
|