| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore/config.h.
I cleaned up the config target in webkit.gyp so it doesn't copy config.h
around. This way wtf/pcre and webcore each use the appropriate config file.
Tested on mac/linux/win platforms.
Patch by Yaar Schnitman <yaar@chromium.org>
Code review URL: http://codereview.chromium.org/196098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
runs according to the flakiness dashboard.
Review URL: http://codereview.chromium.org/200108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
access change.
BUG=21522
TEST=none
Review URL: http://codereview.chromium.org/203039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
possible. (it can now see which tests were run each chunk)
BUG=18475
Review URL: http://codereview.chromium.org/173595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the webview.
Also use SkColor isntead of a triplet of colors in RenderPreferences.
BUG=21521
Review URL: http://codereview.chromium.org/195059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginStreamUrl::DidReceiveData
function. This crash occurs if the PluginStreamUrl instance is deleted in the context of
PluginStream::Write which occurs if the underlying NPP_Write call to the plugin returns
a negative value, indicating that the plugin did not accept data. We close the stream in
this case which releases existing references to the PluginStream which results in the object
being deleted.
Added a UI test for this case.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=19393
Bug=19393
Review URL: http://codereview.chromium.org/199093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current implementation doesn't really work so no worker tests
are run from test shell.
The dummy implementation is only present to allow tests
to pass that enumerate objects and their properties generically
(without actually using the objects like
fast/js/instanceof-operator.html).
BUG=18676
TEST=layout tests fast/js/instanceof-operator.html
Review URL: http://codereview.chromium.org/193082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous IPCs to fetch a document tag on platforms other than Mac.
R=pinkerton
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes WebFrame::reportFindInPageSelection since it was only
ever called by WebFrameImpl. Now it is a private method.
Removes WebViewDelegate::DownloadUrl since it can be expressed
using WebFrameClient::loadURLExternally.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
order to mimic what run-webkit-tests does.
Search "http/tests/local/" in http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests for what it does.
This is needed by http/tests/local/resources/send-dragged-file.js.
Turn on file URL universal access in the test_shell. Delete rebaseline results of those layout tests that pass due to this change. Also add a UI test to make sure it is not on for the browser.
BUG=9275,12882
TEST=none
Review URL: http://codereview.chromium.org/201048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
glue directly. Everything now goes through webkitclient.
This is the first step to be able to split webkit in its
own dll.
Review URL: http://codereview.chromium.org/196051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
probably shoudln't have been added in to begin with.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code in TestWebViewDelegate was unreachable.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/193079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
upstream WebKit patch.
BUG=20833
TEST=LayoutTests/editing/selection/click-in-margins-inside-editable-div.html, LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html
Review URL: http://codereview.chromium.org/199088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
API change and related changes to support multiple buffered time ranges.
This change doesn't change any behavior.
BUG=21305
TEST=Open a video or audio file, you see the full bar of buffered ranges.
Review URL: http://codereview.chromium.org/199037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=jparent
BUG=8630
BUG=21386
BUG=18772
BUG=21510
TEST=none
Review URL: http://codereview.chromium.org/194074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=21522
Review URL: http://codereview.chromium.org/200085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with the StringPiece class in icu4.2, which is a problem
when trying to use the system version of icu.
Review URL: http://codereview.chromium.org/193072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces WebViewDelegate::OnNavStateChanged.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a bogus Chrome/0.0.0.0 in case we fail to read file version info for
chrome.dll. This should help anyone who is bringing up a new port know
that they need to make the file version info stuff work.
R=pkasting
BUG=4111
TEST=none
Review URL: http://codereview.chromium.org/193074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
source root.
Fix some tests that were manually getting sourcedir from DIR_EXE instead of using DIR_SOURCE_ROOT.
BUG=none
TEST=rm -r out, ln -s /somedir/out out, run tests
Review URL: http://codereview.chromium.org/192064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell_pak dependency."
This needs to wait on a master.cfg update to make f_webkit_dbg_linux_builder build 'test_shell'.
TBR:mark
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
since r25855 V8 update.
BUG=21501
TEST=bot color
Review URL: http://codereview.chromium.org/195055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dependency.
This fixes the missing requirement that test_shell was previously satisifying for test_shell_tests.
Review URL: http://codereview.chromium.org/201067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/193070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings).
A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme.
A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed.
When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding.
With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc.
Known issue:
If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events.
BUG=11480 "Support GTK keyboard themes (emacs keybindings)"
TEST=Switch to Emacs keyboard theme by changing the value of gconf key
"/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and
opens a webpage with a text input box. Input something into the text box, then
press any of the Emacs key bindings defined in
/usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For
example, ctrl-p should move the cursor up one line, and ctrl-k should delete to
the end of paragraph.
Review URL: http://codereview.chromium.org/165293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason these just started acting up now.
TBR=eroman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved NavigationGesture out of webview_delegate.h into its own
header in chrome/common since it is only needed by Chrome.
Adds WebFrame::isProcessingUserGesture to facilitate the removal
of NavigationGesture.
Cleaned up some TestShell methods related to URL loading. The
method to load an URL now takes a GURL instead of a wchar_t*.
R=dglazkov
BUG=21332
TEST=none
Review URL: http://codereview.chromium.org/200054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=21439,21442
Review URL: http://codereview.chromium.org/200073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/195047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
throws a 500 when there is an unsupported query parameter. Use hash parameters
for everything instead.
TBR since the dashboard is broken until this is checked in.
TBR=arv@chromium.org
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/193066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
smaller, which should make the dashboard load a ton faster and
allows us to store a lot more runs. Changing the default to 500 runs
for now.
JS Changes:
-Add ability to control the number of results shown per test.
-Add a debug mode for easier local testing
-Consolidate query and hash parameter handling
-Identify tests that need to be marked "SLOW"
-Hide tests that fail for many runs then start passing for many runs.
Tony, can you review the python?
Arv, can you review the JS?
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/201073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r25797 due to Valgrind errors.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caret blink interval on Linux
This can be set with the "Cursor Blinking" slider and checkbox in gnome-keyboard-properties. The changed setting will appear in a new renderer, so opening a new tab will see the change.
WebKit side is at https://bugs.webkit.org/show_bug.cgi?id=28931
Patch by Joel Stanley <joel@jms.id.au>
BUG=20772
Review URL: http://codereview.chromium.org/186009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/202031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
script-load-and-error-events.svg which has been failing for past 2 days.
BUG=http://crbug.com/21411
Review URL: http://codereview.chromium.org/201072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
now access it from the main menu and context menu and use it to perform
spelling tasks. For more detail, see
http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc
Patch from pwicks86@gmail.com (Paul Wicks).
BUG=None
TEST=The spelling panel should work in os x.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It's also empty; this works around a scons warning.
Review URL: http://codereview.chromium.org/202029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/196069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
As discussed in
http://groups.google.com/group/chromium-dev/browse_thread/thread/7a70e5fcbac786a9
Review URL: http://codereview.chromium.org/195044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Original Review URL: http://codereview.chromium.org/174189
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/193047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium today has its own config.h
(over here
http://src.chromium.org/svn/trunk/src/webkit/config.h.in), which was forked
a while back from webkit's config.h. I'm preparing the ground for the webkit
port, I'm depreciating chromium's config.h and moving its chromium-specific
defines into the ifdef PLATFORM(CHROMIUM) section of webkit's config.h.
Due the complexity of this step, it is broken into three steps:
Step 1: Merge in changes from webkit's config.h into chromium's config.h.in.
Step 2: Copy config.h.in into webkit as the new config.h.
Step 3: Delete chromiums config.h.in and make it use webkit's config.h.
THIS PATCH IS FOR STEP 1.
Patch by yaar@chromium.org, see review here:
http://codereview.chromium.org/201056
Review URL: http://codereview.chromium.org/192056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the Google Talk voice & video plugin.
BUG=none
TEST=video chats should work with recent versions of the Google Talk voice and video chat plugin.
Review URL: http://codereview.chromium.org/199061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/201063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
feature was broken by one of the recent WebKit rolls.
Review URL: http://codereview.chromium.org/202021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/195028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nuke some methods that now live in WebKit.
BUG=21277
Review URL: http://codereview.chromium.org/199055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to figure out why settings are inavailable through InspectorController.
For now, just stub them.
BUG=http://crbug.com/21277
TEST=none
Review URL: http://codereview.chromium.org/196060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a).
Also updated is the test results for net_util_unittests.
This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there).
BUG=8198
TEST=On all platforms, all the targets are built fine.
Review URL: http://codereview.chromium.org/172031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
|