| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more consistent with the stuff in shared_impl, and removes a lot of
namespace using goop.
Add a unified resource tracker shared between the proxy and the impl.
This renames the old ResourceObjectBase to Resource and removes the old
PluginResource. It moves the resource tracker from the impl to the
shared_impl, and makes the proxy use it.
Some things become a little less neat because there's no proxy resource base
class. In particular GetDispatcher() is now gone. I considered whether to
add a helper base class that provides this function, but decided against it
and had individual resource classes implement this when their implementation
would find it useful. This is because ultimately I want more of this
functionality to move into the shared_impl, and it's easier to do that if
there are fewer proxy-specific things in the resources.
This changes the way that plugins are added to the tracker. Previously they
would only be in the tracker if the plugin had a reference to them, although
they could be alive if the impl had a scoped_ptr referencing an object. This
actually has the bug that if we then give the resource back to the plugin,
it wouldn't be refcounted properly and everything would get confused.
Now the tracker tracks all live resource objects whether or not the plugin
has a ref. This works basically like the var tracker (it would be nice if
the var and resource trackers shared more code, but that would further
complicate this already overcomplicated patch). The resource tracker takes an
extra ref whenever the plugin has one or more, and otherwise just tracks live
resources.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7655002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A crash can trigger if the script removes the plugin from the dom and returns a
non-trivial var (e.g. string).
BUG=chromium-os:19269
TEST=Directed test with Pepper Flash.
Review URL: http://codereview.chromium.org/7669041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The comment mentions CppBoundObject, which doesn't exist. It seems to
be a typo from the initial commit.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7677014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames the old ResourceObjectBase to Resource and removes the old
PluginResource. It moves the resource tracker from the impl to the
shared_impl, and makes the proxy use it.
Some things become a little less neat because there's no proxy resource base
class. In particular GetDispatcher() is now gone. I considered whether to
add a helper base class that provides this function, but decided against it
and had individual resource classes implement this when their implementation
would find it useful. This is because ultimately I want more of this
functionality to move into the shared_impl, and it's easier to do that if
there are fewer proxy-specific things in the resources.
This changes the way that plugins are added to the tracker. Previously they
would only be in the tracker if the plugin had a reference to them, although
they could be alive if the impl had a scoped_ptr referencing an object. This
actually has the bug that if we then give the resource back to the plugin,
it wouldn't be refcounted properly and everything would get confused.
Now the tracker tracks all live resource objects whether or not the plugin
has a ref. This works basically like the var tracker (it would be nice if
the var and resource trackers shared more code, but that would further
complicate this already overcomplicated patch). The resource tracker takes an
extra ref whenever the plugin has one or more, and otherwise just tracks live
resources.
Review URL: http://codereview.chromium.org/7629017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch depends on this webkit patch:
https://bugs.webkit.org/show_bug.cgi?id=66139
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7637012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as well as on URLRequestJob's NotifyDone event.
The primary motivation of this change is to log
CONTENT_DECODING_FAILED errors to the NetLog.
BUG=89648
TEST=none
Review URL: http://codereview.chromium.org/7604043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's just one:
webkit/tools/test_shell/test_shell_mac.mm:311:26: error: incompatible pointer types sending 'WindowDelegate *' to parameter of type 'id<NSWindowDelegate>'
[-Werror,-Wincompatible-pointer-types]
[m_mainWnd setDelegate:[[WindowDelegate alloc] initWithWebView:web_view]];
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
webkit/tools/test_shell/test_shell_mac.mm:102:1: note: instance method 'initWithWebView:' is assumed to return an instance of its receiver type ('WindowDelegate *')
- (id)initWithWebView:(TestShellWebView*)view;
^
1 error generated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7621034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=green mem bots
Review URL: http://codereview.chromium.org/7655025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the project files.
BUG=92102
Review URL: http://codereview.chromium.org/7528010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
now uses a scoped resource ID for this purpose.
TEST=manual
BUG=92971
Review URL: http://codereview.chromium.org/7655001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::FileUtilProxy::Write
Also made some minor changes to fix lint warnings.
There are no tests for base::FileUtilProxy.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2076
TEST= test_shell_tests
Review URL: http://codereview.chromium.org/7651002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/chromium/issues/detail?id=92751
TEST=ui_tests
Review URL: http://codereview.chromium.org/7631007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Another version of change to fix PPB_URLRequestInfo::AppendFileToBody using synchronous IPC.
BUG=90878
TEST=PPAPITest.TestURLLoader
Review URL: http://codereview.chromium.org/7618039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since bytes loaded never equal to total bytes if the resource is from http
the branch is never reached and lead to confusion about the logic.
This was discovered while working on other platforms.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7646016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SpecialStoragePolicy.
BUG=NONE
TEST=Existing tests pass: FileSystemDirURLRequestJobTest.*, FileSystemURLRequestJobTest.*, FileSystemContextTest.*, DatabaseTrackerTest.*, QuotaFileUtilTest.*, FileSystemPathManagerTest.*, SandboxMountPointProviderMigrationTest.*
Review URL: http://codereview.chromium.org/7633016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the new pepper plugin can arrive later we needed a way to
integrate better with the webkit::PluginList, unfortunately there
is still value on the PepperPluginRegistry for development use
cases.
So this change adds new plugins to both the pepper plugin lists in
the browser (in PluginService) and the renderer (in PepperPluginRegistry)
on demand.
TEST=see bug
BUG=89248
Review URL: http://codereview.chromium.org/7670003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14322
TEST=Pepper Flash on Youtube, go full screen
Review URL: http://codereview.chromium.org/7670008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iframes.
BUG=55200
TEST=MagicIframeBrowserTest.TransferIframeCloseWindow
Review URL: http://codereview.chromium.org/7647003
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/7669009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync_integration_test crash on MacOS.
Update routing id of pending resource requests for reparented iframes.
BUG=55200
TEST=MagicIframeBrowserTest.TransferIframeCloseWindow
Review URL: http://codereview.chromium.org/7647003
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/7627003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55200
TEST=MagicIframeBrowserTest.TransferIframeCloseWindow
Review URL: http://codereview.chromium.org/7647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the EGL helper library.
Also removed redundant enums from the API.
Review URL: http://codereview.chromium.org/7576012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92748
TEST=none
Review URL: http://codereview.chromium.org/7649029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPObject reference counting and was double-freeing the object.
TEST=tools/valgrind/chrome_tests.sh -t test_shell --gtest_filter="ResourceTrackerTest.*"
BUG=92279
Review URL: http://codereview.chromium.org/7658002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that are backed by base::MessageThreads and thus base's MessageLoops. Doing this allows Chromium services to be more easily used on webkit threads.
Review URL: http://codereview.chromium.org/7600016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
contexts. This makes it easier to enable GPU acceleration from a lower
level in WebKit. Also allow the in-process implementation of glTexImage2D()
to take a NULL pixels ptr. It's semantically valid in GL, and the command
buffer implementation already seems to handle it fine.
Review URL: http://codereview.chromium.org/7633076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86993
TEST='QuotaTemporaryStorageEvictorTest.*'
Review URL: http://codereview.chromium.org/7582027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stages:
1. Remove chromium files from leveldb repo. [Done]
2. Put chromium leveldb files in third_party/leveldatabase and leveldb in third_party/leveldatabase/src. Update leveldb references in chrome to use third_party/leveldatabase/src instead of third_party/leveldb. Leave third_party/leveldb so it can be referred to by WebCore.gyp.
3. Change third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp to use third_party/leveldatabase.
4. Delete third_party/leveldb
Eventually: 5. Rename third_party/leveldatabase back to third_party/leveldb
We can't avoid the leveldb-checkout duplication by just changing third_party/leveldb from an unversioned to a versioned directory. Doing so would break everyone's gclient sync update.
BUG=89378
TEST=indexeddb layout and browser tests
Review URL: http://codereview.chromium.org/7522008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allowes us to more efficiently manage ids. It is
not OpenGL ES 2.0 compatible though it probably fits most OpenGL ES
programs.
Note that we need to turn this off on Pepper and/or probably
provide a way for Pepper to turn on on. I'm not sure of the
path Pepper takes to setup. Assuming it goes through
GraphicsContext3D then changes to webkit will be needed to
get the flag all the way down through IPC to the GPU process.
TEST=unit tests and ran a few pages in a chrome build
BUG=92260
Review URL: http://codereview.chromium.org/7633060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
setting the HTTP method to a multi-line string.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2024
TEST=TestShellTests, url_request_info_unittest.cc
Review URL: http://codereview.chromium.org/7645010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL, WM_APPCOMMAND (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
storage policy. Listen for those changes in the usage tracking system and fixup the cache to accurately reflect how much usage should be characterised as "unlimited" usage.
TEST=modified quota_manager_unittest.cc
Review URL: http://codereview.chromium.org/7618025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92892
TEST=no code change
Review URL: http://codereview.chromium.org/7647030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7583053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92845
TEST=as in bug
Review URL: http://codereview.chromium.org/7645026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enum types should be named using CamelCase as class and function names,
not using MACRO_STYLE.
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7618037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- To account for pepper plugins, it grows a type field
- move WebPluginInfo from webkit::npapi to webkit:: and move the files as well.
This will allow us to remove hacks to get pepper plugins to load soon
BUG=89248
TEST=none
Review URL: http://codereview.chromium.org/7648017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/7648011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DCHECKs don't trigger in release, and in any case it's a bit rude to have
the renderer crash on a plugin that did the wrong thing, so send an error
instead.
BUG=None
TEST=Pepper Flash
Review URL: http://codereview.chromium.org/7628025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7639009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7637018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=66037 upstream.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7637002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used.
Review URL: http://codereview.chromium.org/7587011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7634013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Skia) not to create and destroy a GL texture on
each upload of a new frame.
Review URL: http://codereview.chromium.org/7620011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
quota change
BUG=86556
TEST=no functional change
Review URL: http://codereview.chromium.org/7639011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96520 0039d316-1c4b-4281-b951-d872f2087c98
|