| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is one string update, for
<message
name="IDS_FORM_FILE_MULTIPLE_UPLOAD"
desc="text to display next to file buttons in HTML forms when 2 or more files
are selected for uploading. This is not used for a case that just 1
file is selected."
>
R= tony,dglazkov
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/165152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18802
TEST=none
Review URL: http://codereview.chromium.org/164213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no layout test failures
TBR=pkasting
Review URL: http://codereview.chromium.org/164197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation.
This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs.
BUG=18203,18553
TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus.
Review URL: http://codereview.chromium.org/164100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=10278,11613,11810,11898,12341,18794
TEST=none
Review URL: http://codereview.chromium.org/164192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18784
TEST=more green please
TBR=agl
Review URL: http://codereview.chromium.org/165156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18784,http://crbug.com/18786
TEST=less redness == more goodness
TBR=tim
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wk 46885) and some layout rebaselines (for pkasting's 46871 and rniwa's 46860).
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/164154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/165143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=18772, 9798
Review URL: http://codereview.chromium.org/164156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/43355
Webkit changed html.css in that CL.
BUG=http://crbug.com/11613
TEST=NONE
(Over the shoulder review by dglazkov because it 500s the code review tool).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Displays memory usage by object constructor. Sorting works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the StorageAreaImpl exists since it only stores a pointer to it and
thus it'll refer to freed memory if we don't.
Trying to commit this again because I can't repro the errors.
TEST=none
BUG=none
Original CL: http://codereview.chromium.org/160675
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22562
Review URL: http://codereview.chromium.org/164037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=9798
TEST=none
Review URL: http://codereview.chromium.org/165114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18740
TEST=none
Review URL: http://codereview.chromium.org/164126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18733
TEST=none
Review URL: http://codereview.chromium.org/164122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently on linux windowless Flash needs a paint after a NPP_SetWindow, otherwise it cancels its timer to do InvalidateRect.
Also in this change: WebKit calls WebPluginImpl::setFrameRect at each paint, even if the rects haven't changed. That used to always send a message to the plugin process, which is unnecessary (that case is always a no-op in the WebPluginDelegateImpl), so I fixed that too.
BUG=18423
Review URL: http://codereview.chromium.org/159907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18724
TEST=none
Review URL: http://codereview.chromium.org/164111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=18598
TBR=nsylvain
TEST=none
Review URL: http://codereview.chromium.org/164108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=17635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it is about closing a page, WebView is a better home for it.
R=dglazkov
BUG=10034
TEST=none
Review URL: http://codereview.chromium.org/164105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This avoids spurious messages when the plugin crashes, and potential issues (plugin crashes, the HWND/XID gets destroyed, a new one gets created by a new instance and gets the same HWND/XID, the browser operates on the new one instead of the old one).
Review URL: http://codereview.chromium.org/160614
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the same across platforms. WTC tells me that it should be ready to go, and it
anyways is only exercised by these two security/block-test*.html tests.
Also, add back the fix from r22651.
Extend that fix a bit so that when we do not have a special mapping, we just spit out the existing error code value. This way, if we get an unexpected result, the output will tell us what the original error code was. This change doesn't impact any layout tests.
R=dglazkov,wtc
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/165091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=18702
TEST=none
Review URL: http://codereview.chromium.org/165093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added unittests for manifest parser to test_shell_tests.
This is a clone of jennb's CL here.
http://codereview.chromium.org/160608
TBR=jennb
BUG=none
TEST=manifest_parser_unittest.cc
Review URL: http://codereview.chromium.org/165072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=18461
TEST=tests should be disabled
Review URL: http://codereview.chromium.org/165082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=included ui test
Review URL: http://codereview.chromium.org/160576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
255.255.255.255 results in ERR_ADDRESS_UNREACHABLE whereas on Windows it
results in ERR_ADDRESS_INVALID. Map both of these errors to the same value of
-1004 for the sake of matching the layout test behavior of WebKit for the Mac.
This may also fix ChromiumMac, but I haven't tested it there yet.
R=dglazkov
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/165077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream bug was fixed and test did not crash after 100 iterations locally, nor
did valgrind find anything amiss.
http://crbug.com/10439
Review URL: http://codereview.chromium.org/164083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15267
TBR=pkasting
Review URL: http://codereview.chromium.org/165074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=scherkus
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebFrameLoaderClient.
This ensures that we never attempt loading an empty URL and fixes the crash in the layout test, mentioned below.
BUG=16754
TEST=LayoutTests/fast/loader/empty-embed-src-attribute.html
R=darin
Review URL: http://codereview.chromium.org/164078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/164081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also revises how we print resource errors to make our results more
close resemble those of Mac WebKit.
security/block-test-no-port.html is no longer WONTFIX since we always run
layout tests with a no-proxy configuration now.
security/block-test.html does not need to be skipped on mac since we now have a
FTP implementation ;-)
R=dglazkov
BUG=18610
TEST=none
Review URL: http://codereview.chromium.org/165038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=18598
TEST=WebKit purify bot stays green.
Review URL: http://codereview.chromium.org/164073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18461
TEST=test_shell_tests --gtest_filter=MediaLeakTest.*
Enabling the MediaLeakTest(s) because they should pass now
due to the problematic webkit change at r46769 was reverted.
Review URL: http://codereview.chromium.org/164005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18659
TEST=none
Review URL: http://codereview.chromium.org/165069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18656
TEST=none
Review URL: http://codereview.chromium.org/164075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16675
TBR=pkasting
Review URL: http://codereview.chromium.org/164072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux.
BUG=18206
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/165050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is my stupid mistake that I forgot removing the platform-dependent code in our renderer code.
This change just add defined(OS_MACOSX) instead of removing #ifdef blocks since they are used by Chrome OS.
BUG=18353 "Regression: Arrow Keys and Page Up/Down Keys Have No Affect"
TEST=Type an arrow key in a web page and see it scrolls the page.
Review URL: http://codereview.chromium.org/159839
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html = TIMEOUT FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html = FAIL
Maybe the following webkit patch changed this.
http://trac.webkit.org/changeset/46809
BUG=9962
TEST=none
Review URL: http://codereview.chromium.org/164051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I saw both success and fail with the same revision r22595.
Success: http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/10482
Fail: http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/10481
BUG=10475
TEST=none
Review URL: http://codereview.chromium.org/165042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The original bug was apple specific and we don't need to fix our code.
BUG=18016
Review URL: http://codereview.chromium.org/160640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22596 0039d316-1c4b-4281-b951-d872f2087c98
|