| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initial patch contains no edits except for the chromium header and a brief
comment; it is uploaded as a basis for future diffs. Subsequent patches will
contain the edits for this port and tests.
Patch by Jennifer Braithwaite
R=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out-of-date baselines.
I'll cycle back and rebaseline once the bots generate new
results.
TBR=pkasting
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17454
TEST=as bug
Review URL: http://codereview.chromium.org/159209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/159260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=https://crbug.com/17509
Review URL: http://codereview.chromium.org/159259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify test_shell so that it will handle checking system dependencies on
Vista and XP. Clean up a bunch of error messages so that we provide
better diagnostics about what is and isn't configured correctly.
BUG=none
TEST=none
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/159111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
python 2.4's implementation of sys.popen() keeps a list of subprocesses
around to handle cleanup, but the list isn't safe against concurrent access,
leading it to sometimes through a ValueError exception. The list is kind
of pointless, and the exception can be ignored (which it is in 2.5).
BUG=none
R=maruel
TEST=none
Review URL: http://codereview.chromium.org/155782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 21252 seems to have had some svn brokenness (not sure why). I've recreated
it and resubmitted it. The changes are to move image_diff from
chrome/tools/test to tools/, and to make test_shell depend on image_diff
and npapi_layout_test_plugin (and test_worker, where applicable)
R=nsylvain@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17300
TEST=none
Review URL: http://codereview.chromium.org/159232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/155968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockWebClipboardImpl is only used in layout test mode and it
contains some member variables. Since the destructors weren't
virtual, it was leaking these member variables.
BUG=17184
Review URL: http://codereview.chromium.org/159238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse hovering on every web page
Should check tooltip text against empty before adding Unicode Marks for directionality.
BUG=http://crbug.com/17468
BUG=http://crbug.com/17176
BUG=http://crbug.com/5996
TEST= open a webpage, mouse over plain text area, empty square should not show up as tooltip.
Review URL: http://codereview.chromium.org/159222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't get called back in our signal handlers and access freed memory.
BUG=17188
TEST=sh tools/valgrind/valgrind_webkit_tests.sh LayoutTests/editing/pasteboard works
Review URL: http://codereview.chromium.org/155893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=4773
BUG=17081
TEST=Compile, run, and browse google.com with Chromium.
Review URL: http://codereview.chromium.org/159227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/155949
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've updated revelant bugs to indicate new test status.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155948
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. FFmpegGlue now taks a FFmpegProtocol instead of DataSource as input
2. FFmpegDemuxr implements FFmpegProtocol and does the blocking read and submit asynchronous read request to DataSource (with unit tests)
3. Changed SimpleDataSource to work with asynchronous read (with unit tests)
4. Reimplemented BufferedDataSource to work with asynchronous read (with unit tests)
5. Moved BufferedDataSource from chrome/renderer/media to webkit/glue/media (for faster build/debug and better coverage in automated testing)
TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*, FFmpegDemuxerTest.*
Review URL: http://codereview.chromium.org/149567
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus, nsylvain
Review URL: http://codereview.chromium.org/159226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=MediaLeakTest.ManyVideoBear
This test inject and remove a <video> element many (50) times.
Trying to exploit memory leaks during the creation and
destruction of the internal media player and the glue code
with WebKit.
Review URL: http://codereview.chromium.org/159204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12283
TEST=as described in bug
Review URL: http://codereview.chromium.org/159098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ChromeClientImpl::focus(), we need to do a null check
for 'delegate' before calling
delegate->FocusAccessibilityObject().
R=klink
BUG=http://crbug.com/17101
TEST=none
Review URL: http://codereview.chromium.org/159182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG:13907
TEST: The one I'm disabling.
Review URL: http://codereview.chromium.org/155878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus on Mac. This entails the following:
- getting notifications that the main window has become or lost key
window status (in BrowserWindowController) [new]
- ... which tells the RenderWidgetHostView(Mac) to (de)activate [new]
- ... which tells the RenderWidgetHost to (de)activate [new]
- ... which sends a ViewMsg_SetActive message [new message] to the
RenderView [new]
- ... which tells the WebView(Impl) to (de)activate [new]
- ... which tells its page()'s FocusController to (de)activate [new]
- ... which is now in WebKit-land.
N.B.: "Activate" is the nomenclature used in WebKit; "focus"/"blur" can
sometimes (kind of) mean the same thing, but is ambiguous, since "focus"
has a more specific meaning.
Added a WebView unit test, which currently only tests to make sure that
SetActive() (and IsActive() [also new]) work correctly. The changes to
the other classes aren't very testable since they don't actually do
anything (other than pass things along).
BUG=12507
TEST=webkit/glue/webkit_unittest.cc
Patch by viettrungluu@gmail.com (see http://codereview.chromium.org/159048 ),
r=avi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=jorlow
Review URL: http://codereview.chromium.org/155898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155919
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
element (or even page)
The related webkit bug is
https://bugs.webkit.org/show_bug.cgi?id=24187
After webkit passes both the title string and its directionality to its client, Chrome will force the title to be displayed in correct directionality using Unicode Control characters.
BUG=http://crbug.com/5996
TEST=In both English Chrome and Hebrew Chrome
1. open the test case in http://crbug.com/5996 comment #1
2. hover over the red span, tooltip should be displayed as RTL in both English Chrome and Hebrew Chrome.
3. hover over the blue span, tooltip should be displayed as LTR in both English Chrome and Hebrew Chrome.
Review URL: http://codereview.chromium.org/147240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"skia/ext/platform_canvas.h"
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159057
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline must have changed with last merge.
BUG=17326
TBR=paul
Review URL: http://codereview.chromium.org/155903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds project dependencies to test_shell so that all (and only?)
the targets needed for the layout_tests to run cleanly are built. On most
platforms this is test_shell, npapi_test_plugin, and test_worker, and on
the Mac this adds the layout_test_helper binary as well
also, this moves image_diff from chrome/tools/test to tools/
R=mmentovai@google.com, darin@google.com
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be aggregated separately from standard Chrome on Linux
Review URL: http://codereview.chromium.org/155101
Patch from Chris Masone <cmasone@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17326
Review URL: http://codereview.chromium.org/159159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://bugs.webkit.org/show_bug.cgi?id=27388 .
BUG=http://crbug.com/474
TEST=After sheriff rolls DEPS, Linux buildbots should be greener.
Review URL: http://codereview.chromium.org/155877
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=27388
BUG=http://crbug.com/474
TEST=Windows webkit bots should be greener after sheriff rolls DEPS.
Review URL: http://codereview.chromium.org/155880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handled in original code are addressed, for example the input method in password
box case.
The most important change in this CL is the change to key event processing flow.
In old code, a key event will first be sent to webkit then dispatched to IME
for filtering. With this CL, a key event will first be dispatched to IME for
filtering, then how to send the event to webkit is decided by the filtering
result.
This CL tries to emulate the keyboard input behavior on Windows as much as
possible. For example, if a keydown event is filtered by IME, then its virtual
key code will be changed to VK_PROCESSKEY(0xE5) to prevent webkit from
processing it again. This behavior can workaround bug 16281.
To test this CL, you may cut and save following html code into a file and open
it in chrome.
------------------8<----cut here----->8---------------------
<html><head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<script>
function keyEventHandler(event) {
var props = [ "type", "charCode", "keyCode", "altKey",
"ctrlKey", "shiftKey", "metaKey" ];
var info = document.getElementById('info');
var s = '';
for (var i in props) {
s += props[i] + ':' + event[props[i]] + ' ';
}
info.value += s + '\n';
}
function textEventHandler(event) {
info.value += "type:" + event['type'] + " data:" + event['data'] + '\n';
}
function passwordChangeEventHandler(event) {
var input2 = document.getElementById('input2');
info.value += "password:" + input2.value + '\n';
}
function onLoad() {
var input = document.getElementById('input');
input.addEventListener('keydown', keyEventHandler, false);
input.addEventListener('keyup', keyEventHandler, false);
input.addEventListener('keypress', keyEventHandler, false);
input.addEventListener('textInput', textEventHandler, false);
var input2 = document.getElementById('input2');
input2.addEventListener('change', passwordChangeEventHandler, false);
}
</script>
</head><body onload="onLoad()">
<input id="input" size="20">
<input id="input2" type="password" size="20">
<p>
<textarea id="info" rows="40" cols="150"></textarea>
</p></body></html>
------------------8<----cut here----->8---------------------
This CL was confirmed to fix following issues:
BUG=16281 "arrow keys and backspace/delete keys move/delete two characters at a
time when xim immodule is used"
BUG=16282 "Disable IMEs in a password input"
BUG=16596 "fcitx (chinese input method) not working in ubuntu 9.04"
BUG=16659 "Crash near RenderWidgetHostViewGtk::IMEUpdateStatus"
BUG=16699 "Can't move cursor to omnibox and use input method if cursor is
currently in a text input box in web page."
BUG=16796 "Input method issue: When inputting text in a text box, if there is a
composition string then pressing Backspace or Delete will cause the composition
string be cleared and the text box refuses to accept any further input.
All tests assume above html code is used.
TEST=Start scim with "scim -d" and start chrome with GTK_IM_MODULE=xim and
XMODIFIERS=@im=SCIM. Type something in input box, eg. "hello", then press
backspace, to see if only one character is deleted.
TEST=Move cursor to password input box, press ctrl-space to see if input method
is not activated. Switch keyboard layout to Canadian-French then type a'[{' key
and an 'a' key, then press enter, to see if a Latin character "U+00E2" is
inputted in password box.
TEST=Install fcitx with "sudo apt-get install fcitx" (assume you are using
Ubuntu/Debian). Open a terminal, export XMODIFIERS=@im=fcitx and
GTK_IM_MODULE=xim then run fcitx, then start chrome. Move cursor into an input
box, press ctrl-space and input something, eg. "nihao" then press space. Check
if some Chinese characters are inputted.
TEST=Start chrome with GTK_IM_MODULE=scim. Move cursor into a text input box
then move into a password box, chrome should not crash.
TEST=Move cursor into a text input box, then click omnibox, and see if the text
input box has lost focus. Press ctrl-space to activate input method, then type
something, and see of the input goes into omnibox.
TEST=Move cursor into a text input box and enable a Chinese Pinyin input method,
then type something, eg. "dajiahao", make sure a composition string is displayed
in the text input box, then press backspace and see if there is still a
composition string and backspace is handled by input method.
patch by James Su <james.su [at] gmail>
original review URL: <http://codereview.chromium.org/149755>
Review URL: http://codereview.chromium.org/155869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is swapped out while a drag is happening.
Since the tab contents is swapped out, our RVH that the drag
started on is no longer valid. Simply null out the pointer
and no longer try to send feedback to the drag source. This
allows the user to continue the drag even though the source
RVH is gone.
BUG=16073
Review URL: http://codereview.chromium.org/159040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12956
Review URL: http://codereview.chromium.org/159132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- if profile is generated, and no profile is shown, show the new one;
- display processed ticks count during processing to show that we're alive.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the layout test runner script.
It complains if there are no baselines, even though this test is expected to fail.
(The upstream mac baseline was removed in <http://trac.webkit.org/changeset/46140>).
TEST=none
BUG=http://crbug.com/13907
TBR=paul
Review URL: http://codereview.chromium.org/155844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17332
TBR=rniwa
Review URL: http://codereview.chromium.org/155843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=NONE
BUG=http://crbug.com/17332
TBR=rniwa
Review URL: http://codereview.chromium.org/155837
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360TEST=none
Review URL: http://codereview.chromium.org/159059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21157 0039d316-1c4b-4281-b951-d872f2087c98
|