| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
webkit/glue/webpreferences.h:44: warning: 'WebPreferences::user_style_sheet_enabled' will be initialized after
webkit/glue/webpreferences.h:40: warning: 'bool WebPreferences::allow_scripts_to_close_windows'
webkit/glue/webpreferences.h:52: warning: when initialized here
Review URL: http://codereview.chromium.org/2947
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
With this switch, window.close() will always be enabled.
Currently the switch is only available in test_shell.
Review URL: http://codereview.chromium.org/2915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we can pull this prototype upstream.
Review URL: http://codereview.chromium.org/2930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Be more specific when using an overloaded operator since objective-c++ finds conflicts. Enable objective-C GC in our common config file for all projects.
Review URL: http://codereview.chromium.org/2912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
across this when tracking down previous fix. Allowing MAX_PATH + 1
causes a DCHECK to be hit when we read back from the clipboard.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
order to fix release Mac builds
Review URL: http://codereview.chromium.org/2908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2053
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2900
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementation for mac. Turn off buliding resource loader we're not using.
Review URL: http://codereview.chromium.org/2897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
So catch failure here and die.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2894
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
down the WebCore chain.
TBR
Review URL: http://codereview.chromium.org/2893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI language of the Windows.
BUG=1862
TEST=Switch the Chrome UI language to pt-PT, fr, ja, etc and try 1862test.html (attached to issue 1862). navigator.language should
be pt-PT, fr, ja.
Review URL: http://codereview.chromium.org/3073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
this is covered by issue 2303, 2304, 2306, 2307
Review URL: http://codereview.chromium.org/2868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Image & Option functions should have precendence than document elements.
Review URL: http://codereview.chromium.org/1968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
are subject to change as the rest of the rendering and event handling paths
come together.
Review URL: http://codereview.chromium.org/3062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2809
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to the 3.1 branch, r31616. The ones corresponding to the new WebCore are already in there, and when they land this copy will be deleted.
Review URL: http://codereview.chromium.org/2853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2814
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
last change to context menu encodings.
Review URL: http://codereview.chromium.org/2831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. check for http 0.9 responses (no status line)
2. allow up to 4 bytes of junk to precede the http version.
3. distinguish between the parsed vs normalized http version (a TODO needed this).
Review URL: http://codereview.chromium.org/1934
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes view source for some pages (for example Google Reader) not work
properly. I speculate that telling WebKit to change the encoding (which causes
a reload) right after starting the real load makes it confused.
Review URL: http://codereview.chromium.org/3022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is happening because the title's string implementation is null. If the
title's string implementation is null then
charactersWithNullTermination will return null and we'll crash as in
the stack trace.
BUG=1374632
TEST=none
Review URL: http://codereview.chromium.org/2812
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1910
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/1919 Patch Set 1)
and changed the test to be a real layout test and added expected output.
Review URL: http://codereview.chromium.org/2459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1958
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1949
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it now completely builds!
Review URL: http://codereview.chromium.org/2426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NavigationControllerBase, eliminating the temp directory. Cleaning up the Mac project to no longer have that reference.
Review URL: http://codereview.chromium.org/2427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when an object is specified with shape-rendering="crispEdges"
Review URL: http://codereview.chromium.org/1830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
staying put for now, because they're all trivial and identical.
Review URL: http://codereview.chromium.org/1925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=1669
Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0.
When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping.
To recap on how Find works (since I know it has been a while since you looked at this problem):
Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead.
BUG=1341577
Review URL: http://codereview.chromium.org/1847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I will pursue making this change upstream as well,
but as best I can tell, this function is dead code upstream
and should just be deleted.
Review URL: http://codereview.chromium.org/1880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2023 0039d316-1c4b-4281-b951-d872f2087c98
|