| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for all tests. Otherwise, depending on which tests ran and in which order,
EventNames::init() would not get called. I lost a couple hours last night
debugging to figure this out. :(
While I was at it, I rearranged the test functions for cleanliness and fixed
some minor style bits.
Review URL: http://codereview.chromium.org/10213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will investigate on the bot.
TBR=nsylvain
Review URL: http://codereview.chromium.org/9700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A test list was accidentally commited with a line commented out.
Aditionally, some of the animation tests are flaky. When running all
tests, one of the tests seems to consistently time out. When running
only the animation tests another test is timing out. Updating the
test list with the test that currently times out on the buildbot.
Review URL: http://codereview.chromium.org/10211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageChannel.
I create the MessagePort wrappers when a MessageChannel is constructed
and put references to them in internal fields in the MessageChannel.
This is a fix for
http://code.google.com/p/chromium/issues/detail?id=4195
Review URL: http://codereview.chromium.org/9508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
up to date anymore.
Review URL: http://codereview.chromium.org/9649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We work around all event names being null (!!!) by testing a enum instead. This code should be faster anyway, but I will also investigate the enum.
Review URL: http://codereview.chromium.org/9495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's not being kept up to date and is therefore not useful. We will
continue to maintain the JSC build, just not its layout test results.
BUG=4207
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
or two.
Review URL: http://codereview.chromium.org/10204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I have only compiled this on linux and tested it there but that shouldn't be a problem as the file does seem to be linux-specific.
Review URL: http://codereview.chromium.org/9685
Patch from Craig Schlenter.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Skia platforms. I do this by making the calling of PlatformCanvas.initialize() able to be the same by using an evil default parameter.
Review URL: http://codereview.chromium.org/9695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the canvas.
Review URL: http://codereview.chromium.org/9668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut.html
LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut.html
LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener.html
LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html
In WebKit r33979 all these layout tests had
alert("document.domain: " + window.document.domain);
changed to
try {
alert("document.domain: " + window.document.domain);
} catch(e) {
}
causing the document.domain access error to no longer be reported. Rebaselining the tests does not compromize what they are testing as if window.domain was accessible the output would change causing failures.
Review URL: http://codereview.chromium.org/9691
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
code.
Also, make sure that top, window, location, and location.href are not
deletable.
I had to fix a couple of layout tests that rely on top being shadowable.
Review URL: http://codereview.chromium.org/9506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
frame-busting code.
Review URL: http://codereview.chromium.org/9688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unrelated change. I think there is a real GC issue here and I will
look into it.
Review URL: http://codereview.chromium.org/9687
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.location.
This change disallows shadowing of window and location both when using
var declarations and when defining accessors. Using 'var location =
stuff' will cause a navigation. This is consistent with what Firefox
does.
Also, introduce an explicit valueOf function on location objects so
that implicit string conversions cannot be intercepted to fake the
current location reported by window.location.
Review URL: http://codereview.chromium.org/9636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is a valid file path separator.
Review URL: http://codereview.chromium.org/9489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was an issue with the site failing to detect Windows media player. The site would run a script which would enumerate the list of plugins from the navigator object and compare each plugin name for "Windows Media" and "Plug". This is under the assumption that the windows media player plugin is typically named as
Microsoft� Windows Media Player Firefox Plugin and it would find both the strings in the name.
I had changed the name of activex shim instance for media player previously to Windows Media to fix a similar issue with bloomberg.com. Should have changed it to the full name at that point.
The fix is to fully match the windows media player plugin name in the shim.
The other change is to perform a case insensitive comparison of the plugin file names while looking for matching plugins.
R=jam
Bug=4137
Review URL: http://codereview.chromium.org/9482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of some unnecessary addRepository() calls that mapped specific
webkit\port\ subdirectories to third_party\WebKit\WebCore subdirectories,
in ways that were already covered by the mapping in webkit\SConscript of
all of $WEBKIT_DIR\port to third_party\WebKit\WebCore.
This takes about 40 duplicate /I options out of a typical compilation
command line (and, more importantly, out of the .h file searches).
Add additional comments about future potential efficiency that we
can get from eliminating the quirky way we remap specific directories
into webkit\port, instead of just maintaining a completely parallel
directory structure and mapping the whole tree once.
Review URL: http://codereview.chromium.org/9466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
let it drop on the floor.
Review URL: http://codereview.chromium.org/9653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add password_autocomplete_listener.cc to the build
TBR=mark
Review URL: http://codereview.chromium.org/9648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"config.h" needs to be included first
TBR=mark
Review URL: http://codereview.chromium.org/9647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add autocomplete_input_listener.cc to the glue lib
TBR=mark
Review URL: http://codereview.chromium.org/9645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add dom_operations.cc to the mac build
TBR=mark
Review URL: http://codereview.chromium.org/9644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of these files that I don't added to the build would even compile
and link, but don't yet pass with current test_shell on Linux.
They just hang.
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> on
http://codereview.chromium.org/9417
Review URL: http://codereview.chromium.org/9641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
select boxes (but does not affect scroll bars). I created a helper class, ThemeHelperWin, which automatically wraps the logic necessary to do this. There are three modes: draw the form control normally, draw it at a different size (for scaling, just tell Windows it's a different size and don't transform the graphics coordinates), or arbitrary transforms (where it's drawn to an offscreen buffer and transformed by our graphics layer.
Review URL: http://codereview.chromium.org/9008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was already removed from Debug). Remove the trailing space on the
FEATURE_DEFINES setting in debug mode; it was causing a DOUBLE space in the
--defines string being passed to generate-bindings.pl, of which that script is
intolerant.
Review URL: http://codereview.chromium.org/9640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/9617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but no user name associated.
This was causing some wekbit layout tests to fail.
TEST=Run the webkit layout tests.
Review URL: http://codereview.chromium.org/9612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge.
The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner.
R=iyengar,eseidel
Review URL: http://codereview.chromium.org/9072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make everything use ARGB order in registers (B.G.R.A order in memory on
little-endian systems)
Review URL: http://codereview.chromium.org/8227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was a hang while loading certain PDF files. This was a regression caused by support for NPN_RequestRead (PDF Fast Webview). We had incorrectly assumed that the Content Type showing up for partial HTTP Responses would always end with the boundary. A content type can show up like multipart/byteranges; boundary=--bound--; charSet=utf8. As a result we would look for the wrong boundary in the actual data resulting in a hang.
The parsing code now accounts for this. Added a unit test to test this case.
Bug=4076
R=jam
Review URL: http://codereview.chromium.org/9198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functions in the upstream version of WebKit.
Review URL: http://codereview.chromium.org/9210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4818 0039d316-1c4b-4281-b951-d872f2087c98
|