summaryrefslogtreecommitdiffstats
path: root/webkit
Commit message (Collapse)AuthorAgeFilesLines
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-0830-50/+106
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-082-3/+6
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Make webkit/glue/plugins no longer depend on ppapi/proxy directly. This causesbrettw@chromium.org2010-12-085-169/+149
| | | | | | | | | | | | | things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68567 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix leak in PluginList by actually calling Shutdown().thestig@chromium.org2010-12-081-1/+2
| | | | | | | | | BUG=none TEST=Valgrind goes green this time. TBR=bauerb Review URL: http://codereview.chromium.org/5574005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68550 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code from headers to implementation.erg@google.com2010-12-072-0/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix leak in plugin group code.thestig@chromium.org2010-12-071-7/+20
| | | | | | | | BUG=none TEST=Memory tree goes green. Review URL: http://codereview.chromium.org/5529007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68513 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up downstream test expectations.victorw@chromium.org2010-12-071-7/+0
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68491 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68482 - Make webkit/glue/plugins no longer depend on ppapi/proxy ↵brettw@chromium.org2010-12-075-149/+169
| | | | | | | | | | | | | | | | | | | directly. This causes things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing Review URL: http://codereview.chromium.org/5592005 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/5616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68486 0039d316-1c4b-4281-b951-d872f2087c98
* Make webkit/glue/plugins no longer depend on ppapi/proxy directly. This causesbrettw@chromium.org2010-12-075-169/+149
| | | | | | | | | | | | | | things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing Review URL: http://codereview.chromium.org/5592005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68482 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up PluginGroup and related code.jkummerow@chromium.org2010-12-075-231/+321
| | | | | | | | | | | To avoid data races, do not pass pointers to PluginGroup around. Instead, create copies as plain objects. BUG=61210 TEST=existing unit tests still work; TSan no longer reports the race (see bug) Review URL: http://codereview.chromium.org/5516004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webkit URLRequestJob subtypes to handle Kill() correctly.willchan@chromium.org2010-12-077-29/+48
| | | | | | | | | | | Kill() should prevent calling back into the delegate. So we cancel pending callbacks. BUG=63692 TEST=existing Review URL: http://codereview.chromium.org/5545003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68445 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73372:73408victorw@chromium.org2010-12-071-0/+2
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68415 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete ↵kinuko@chromium.org2010-12-071-149/+0
| | | | | | | | | | | webkit/tools/layout_tests/webkitpy/layout_tests/test_output_xml_to_json.py BUG=41405 TEST=green bot Review URL: http://codereview.chromium.org/5598007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68412 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the "dangerous download" algorithm as follows. Original patch by ↵pkasting@chromium.org2010-12-063-3/+8
| | | | | | | | | | | | | | | | | | | | Pierre-Antoine LaFayette (see http://codereview.chromium.org/1403001/ ), r=me,brettw,aa. Downloads are considered dangerous if: a) The file is dangerous just by sitting on the drive, without needing to be clicked on e.g. dll, xbap b) The file is executable and the download was not user initiated. c) They are an extension that is not from the gallery We have defined a user initiated download as 3 possible cases: a) A user enters a URL into the address bar that is a file b) A user left clicks on a URL that is a file c) A user right clicks and does "Save As" on a URL that is a file. BUG=9044 TEST=Open a page with a download link to a dangerous file that is not an extension, e.g. an .exe file, and left click on the link. The download should proceed without a prompt. Review URL: http://codereview.chromium.org/5603008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68406 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-0617-463/+1003
| | | | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363). One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
* Use stopped_on_render_loop_ to prevent further work from executing in ↵scherkus@chromium.org2010-12-062-17/+5
| | | | | | | | | | | | | BufferedDataSource. Previously we were using it as a DCHECK but we would fail gracefully. Now that stopped_on_render_loop_ is set via Abort() (i.e., catastrophic failure), we need to use it as a singal to make sure all work on the render loop does indeed stop. BUG=16751 TEST=http/tests/media should stop crashing Review URL: http://codereview.chromium.org/5603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68363 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup downstream test expectations file.victorw@chromium.org2010-12-061-3/+0
| | | | | | | | | TBR=yutak TESt=none BUG=65404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68357 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number in test expectationsvictorw@chromium.org2010-12-041-2/+2
| | | | | | | | | TBR=yutak BUG=65404 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68281 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two failed layout tests while investigating.victorw@chromium.org2010-12-041-0/+3
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68276 0039d316-1c4b-4281-b951-d872f2087c98
* Allow data URLs to trigger downloads, as they do in Firefox.darin@chromium.org2010-12-031-1/+27
| | | | | | | | | | | | | | | | | | | | Unfortunately, many of our tests rely on being able to use WebURLLoader to load data: URLs when there is no ResourceLoaderBridge implementation. In those tests, we would crash if we try to use the ResourceLoaderBridge. To workaround that, and because it probably a good optimization anyways, I decided to check if the data URL has a supported MIME type, and if it does, then I let it load directly as before. Since data URLs may be very large, I modified DataURL::Parse to skip parsing the 'data' section of the URL if the corresponding out param is null. R=tony BUG=38546 TEST=none (I would like to add a download test, but they are all disabled or flaky.) Review URL: http://codereview.chromium.org/5542001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68212 0039d316-1c4b-4281-b951-d872f2087c98
* glue: use string16 in place of wstring for Unicode textevan@chromium.org2010-12-037-37/+39
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5591004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68208 0039d316-1c4b-4281-b951-d872f2087c98
* wstrings: convert CppVariant and CppBoundClass to not use wstringevan@chromium.org2010-12-039-34/+29
| | | | | | | | | | | | | | | Confusingly, we had a ToString() that returned a UTF-8 string and a ToStringVector() that returned wstrings. Since CppVariant is a small wrapper around NPVariant I made them both use UTF-8; it simplified most of the users anyway (which only dealt with ASCII anyway). BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5631002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68187 0039d316-1c4b-4281-b951-d872f2087c98
* Delete FileSystem API data when uninstalling extensions.kinuko@chromium.org2010-12-033-7/+31
| | | | | | | | | BUG=63700 TEST=load an extension that keeps writing to file system and unload it. See if the origin data under the profile is deleted. Review URL: http://codereview.chromium.org/5272010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68143 0039d316-1c4b-4281-b951-d872f2087c98
* Turn GPU accelerated features (WebGL, compositing, accelerated 2d canvas) ↵jamesr@chromium.org2010-12-031-1/+1
| | | | | | | | | | | | | off for background pages We don't support turning compositing on for a background page currently and it doesn't seem necessary. This disables all GPU-requiring features for background pages for now. When we have valid use cases we can re-enable features as needed. BUG=64512 TEST=load extension that uses 3d CSS in a background page and verify that there is no browser crash or GPU process created on startup Review URL: http://codereview.chromium.org/5369008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68130 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73207:73212victorw@chromium.org2010-12-031-4/+0
| | | | | | | | | | | | Also clean up downstream test expectations, they were added upstream http://trac.webkit.org/changeset/73212 TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader ↵scherkus@chromium.org2010-12-0317-1003/+463
| | | | | | | | | | | | | | | | | | | | instead of a MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/5619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73140:73207victorw@chromium.org2010-12-031-0/+5
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68116 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MediaFilter and MediaFilterCollection to Filter and FilterCollection, ↵scherkus@chromium.org2010-12-037-14/+16
| | | | | | | | | | | respectively. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DrawGlyphs call have the proper const arguments, and make the proxiedbrettw@chromium.org2010-12-023-9/+9
| | | | | | | | | | | version of this API synchronous. Otherwise, the caller may end up trying to draw over the text that isn't there yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/5555004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68108 0039d316-1c4b-4281-b951-d872f2087c98
* Have about:plugins point to the latest Flash and Reader versions.panayiotis@google.com2010-12-021-3/+3
| | | | | | | | | BUG=65170 TEST=unit_tests Review URL: http://codereview.chromium.org/5619001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68107 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-0217-463/+1003
| | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup downstream suppressions.antonm@chromium.org2010-12-021-4/+0
| | | | | | | | It's been moved upstream with http://trac.webkit.org/changeset/73050 Review URL: http://codereview.chromium.org/5539004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68070 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new command line flag (--enable-accelerated-layers) for turning vangelis@chromium.org2010-12-022-2/+20
| | | | | | | | | | | | | on the accelerated compositor for 3D CSS, Video, Plugins and Animations. Also the compositor will now always be enabled for WebGL and accelerated 2D canvas content. In addition, added an about:flags entry for the flag using the same name and description as our old "enable accelerated compositing" entry had, however triggering the new flag. This CL must be checked in after the patch for https://bugs.webkit.org/show_bug.cgi?id=50301 lands. BUG=64589 Review URL: http://codereview.chromium.org/5421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68064 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expectations for 2 tests that do now pass:thakis@chromium.org2010-12-021-4/+0
| | | | | | | | | | | | | | | http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2FW3C-SVG-1.1%2Fstruct-image-10-t.svg%20 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla%2Fbugs%2Fbug14929.html Fixed upstream here: http://trac.webkit.org/changeset/73089 BUG=64395,64394 TEST=webkit tests stay green Review URL: http://codereview.chromium.org/5539003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68048 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expectations from downstream test_expecations.jparent@chromium.org2010-12-021-3/+0
| | | | | | | | | | | It was moved upstream in r73093. TEST=none BUG=none Review URL: http://codereview.chromium.org/5557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68032 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in proxied audio.brettw@chromium.org2010-12-021-4/+7
| | | | | | | | TEST=proxied audio works (manual test) BUG=none Review URL: http://codereview.chromium.org/5522003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68027 0039d316-1c4b-4281-b951-d872f2087c98
* Implement audio proxy for Pepper.brettw@chromium.org2010-12-026-145/+85
| | | | | | | | | | | | | In addition to the basic proxying, this required some changes to the dispatcher and process infrastructure to get the handles of the processes available when I need them so I can duplicate the shared memory handles properly into the different processes. TEST=none BUG=none Review URL: http://codereview.chromium.org/4985001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68026 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress the layout test failure on macvictorw@chromium.org2010-12-021-0/+4
| | | | | | | | | | TBR=tony TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67980 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crasher with negative index set on select popups.jcivelli@chromium.org2010-12-021-5/+11
| | | | | | | | | | BUG=63774 TEST=Visit http://vescam.com/select_crasher.html and try all the selects in that page. Review URL: http://codereview.chromium.org/5302009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove upstreamed test expectation.levin@chromium.org2010-12-021-2/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/5503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67934 0039d316-1c4b-4281-b951-d872f2087c98
* TestShell windows: add --crash-dumps-fulldump optionmorrita@chromium.org2010-12-023-1/+16
| | | | | | | | | | | to allow the dump including the heap memory. TEST=none BUG=none Review URL: http://codereview.chromium.org/5262011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67925 0039d316-1c4b-4281-b951-d872f2087c98
* histogram API of WebKitClient implemented in chromium/webkit/gluescheib@chromium.org2010-12-022-0/+29
| | | | | | | | | BUG=62865 TEST=none Review URL: http://codereview.chromium.org/5406004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67920 0039d316-1c4b-4281-b951-d872f2087c98
* Update fast/ruby/nested-ruby.html for DRT.tony@chromium.org2010-12-021-1/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/5534001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67915 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ui test and test_shell_tests results since numberstony@chromium.org2010-12-022-4/+3
| | | | | | | | | | | are now doubles (to match Safari). This was done in http://trac.webkit.org/changeset/72974 BUG=64874 Review URL: http://codereview.chromium.org/5482002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67914 0039d316-1c4b-4281-b951-d872f2087c98
* Change trusted shared memory interface to match audio.nfullagar@google.com2010-12-024-15/+19
| | | | | | | | | | | | | - shm handle uint64_t -> int - more unification of shm size from int32_t -> uint32_t - GetNativeMemoryHandle() -> GetSharedMemory() BUG=none TEST=src/ppapi/examples/ Review URL: http://codereview.chromium.org/5410001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67910 0039d316-1c4b-4281-b951-d872f2087c98
* Stopgap fix for crash in issue 53867 comment 15thakis@chromium.org2010-12-014-21/+45
| | | | | | | | | | | | | gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer). The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case. BUG=53867,61293 TEST=Completing the first level in gwtquake shouldn't crash the renderer. Review URL: http://codereview.chromium.org/5362003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup from webkit merge.ojan@chromium.org2010-12-011-0/+2
| | | | | | | Disable failing NaClUITest.SrpcBasicTest and add back in test expectation that was erroneously removed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67811 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 72952:72986. Also cleaned up downstream test_expectations.txt file.ojan@google.com2010-12-011-21/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67807 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-3024-181/+189
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 72881:72952.vitalyr@chromium.org2010-11-301-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ojan Review URL: http://codereview.chromium.org/5364008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67759 0039d316-1c4b-4281-b951-d872f2087c98